@abaplint/core 2.119.57 → 2.119.58

package/build/abaplint.d.ts

@@ -618,6 +618,9 @@ export declare class BuiltIn {
     static readonly filename = "_builtin.prog.abap";
     private static counter;
     private static readonly getCache;
+    private static typesCache;
+    private static extrasCacheKey;
+    private static extrasCache;
     static readonly methods: {
         [name: string]: IBuiltinMethod;
     };

package/build/src/abap/5_syntax/_builtin.js

@@ -129,16 +129,20 @@ class BuiltIn {
         return def.predicate;
     }
     getTypes() {
-        const ret = this.buildSY();
-        {
-            const id = new tokens_1.Identifier(new position_1.Position(1, 1), "abap_bool");
-            ret.push(new _typed_identifier_1.TypedIdentifier(id, BuiltIn.filename, new basic_1.CharacterType(1, { qualifiedName: "ABAP_BOOL", ddicName: "ABAP_BOOL" })));
+        // the identifiers are identical for every object, share them to reduce memory usage
+        if (BuiltIn.typesCache === undefined) {
+            const ret = this.buildSY();
+            {
+                const id = new tokens_1.Identifier(new position_1.Position(1, 1), "abap_bool");
+                ret.push(new _typed_identifier_1.TypedIdentifier(id, BuiltIn.filename, new basic_1.CharacterType(1, { qualifiedName: "ABAP_BOOL", ddicName: "ABAP_BOOL" })));
+            }
+            {
+                const id = new tokens_1.Identifier(new position_1.Position(1, 1), "cursor");
+                ret.push(new _typed_identifier_1.TypedIdentifier(id, BuiltIn.filename, basic_1.IntegerType.get({ qualifiedName: "CURSOR", ddicName: "CURSOR" })));
+            }
+            BuiltIn.typesCache = ret;
         }
-        {
-            const id = new tokens_1.Identifier(new position_1.Position(1, 1), "cursor");
-            ret.push(new _typed_identifier_1.TypedIdentifier(id, BuiltIn.filename, basic_1.IntegerType.get({ qualifiedName: "CURSOR", ddicName: "CURSOR" })));
-        }
-        return ret;
+        return BuiltIn.typesCache;
     }
     get(extras) {
         const ret = [];
@@ -171,10 +175,17 @@ class BuiltIn {
             BuiltIn.getCache.push(this.buildConstant("space", new basic_1.CharacterType(1, { derivedFromConstant: true }), "' '"));
         }
         ret.push(...BuiltIn.getCache);
-        for (const e of extras) {
-            const id = new tokens_1.Identifier(new position_1.Position(this.row++, 1), e);
-            ret.push(new _typed_identifier_1.TypedIdentifier(id, BuiltIn.filename, basic_1.VoidType.get(e), ["read_only" /* IdentifierMeta.ReadOnly */, "built-in" /* IdentifierMeta.BuiltIn */], "'?'"));
+        // the extras are identical for every object, share them to reduce memory usage
+        const key = extras.join("|");
+        if (key !== BuiltIn.extrasCacheKey) {
+            BuiltIn.extrasCacheKey = key;
+            BuiltIn.extrasCache = [];
+            for (const e of extras) {
+                const id = new tokens_1.Identifier(new position_1.Position(this.row++, 1), e);
+                BuiltIn.extrasCache.push(new _typed_identifier_1.TypedIdentifier(id, BuiltIn.filename, basic_1.VoidType.get(e), ["read_only" /* IdentifierMeta.ReadOnly */, "built-in" /* IdentifierMeta.BuiltIn */], "'?'"));
+            }
         }
+        ret.push(...BuiltIn.extrasCache);
         return ret;
     }
     /////////////////////////////
@@ -383,6 +394,9 @@ exports.BuiltIn = BuiltIn;
 BuiltIn.filename = "_builtin.prog.abap";
 BuiltIn.counter = 1;
 BuiltIn.getCache = [];
+BuiltIn.typesCache = undefined;
+BuiltIn.extrasCacheKey = undefined;
+BuiltIn.extrasCache = [];
 // todo: "pcre" vs "regex", only one of these parameters are allowed
 // todo: "pcre", only possible from 755
 BuiltIn.methods = {

package/build/src/abap/nodes/_abstract_node.js

@@ -1,15 +1,21 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.AbstractNode = void 0;
+// shared constant, so nodes without children don't waste memory on empty arrays
+const EMPTY = Object.freeze([]);
 class AbstractNode {
     constructor() {
-        this.children = [];
+        this.children = EMPTY;
     }
     addChild(n) {
+        if (this.children === EMPTY) {
+            this.children = [];
+        }
         this.children.push(n);
     }
     setChildren(children) {
-        this.children = children;
+        // copy, input arrays are built via push() and carry over-allocated backing stores
+        this.children = children.slice();
     }
     getChildren() {
         return this.children;

package/build/src/abap/nodes/statement_node.js

@@ -11,17 +11,13 @@ const string_template_middle_1 = require("../1_lexer/tokens/string_template_midd
 const string_template_end_1 = require("../1_lexer/tokens/string_template_end");
 const string_template_begin_1 = require("../1_lexer/tokens/string_template_begin");
 const string_template_1 = require("../1_lexer/tokens/string_template");
+const EMPTY_PRAGMAS = Object.freeze([]);
 class StatementNode extends _abstract_node_1.AbstractNode {
     constructor(statement, colon, pragmas) {
         super();
         this.statement = statement;
         this.colon = colon;
-        if (pragmas) {
-            this.pragmas = pragmas;
-        }
-        else {
-            this.pragmas = [];
-        }
+        this.pragmas = pragmas !== null && pragmas !== void 0 ? pragmas : EMPTY_PRAGMAS;
     }
     get() {
         return this.statement;
@@ -36,7 +32,7 @@ class StatementNode extends _abstract_node_1.AbstractNode {
         if (children.length === 0) {
             throw new Error("statement: zero children");
         }
-        this.children = children;
+        super.setChildren(children);
         return this;
     }
     getStart() {

package/build/src/abap/nodes/token_node.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.TokenNode = void 0;
+const EMPTY_CHILDREN = Object.freeze([]);
 class TokenNode {
     constructor(token) {
         this.token = token;
@@ -12,7 +13,7 @@ class TokenNode {
         throw new Error("TokenNode, Method not implemented.");
     }
     getChildren() {
-        return [];
+        return EMPTY_CHILDREN;
     }
     concatTokens() {
         return this.token.getStr();

package/build/src/registry.js

@@ -75,7 +75,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.119.57";
+        return "2.119.58";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.119.57",
+    "version": "2.119.58",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",