@abaplint/core 2.119.51 → 2.119.52

package/build/abaplint.d.ts

@@ -28,7 +28,7 @@ export declare abstract class ABAPObject extends AbstractObject {
     abstract getDescription(): string | undefined;
     constructor(name: string);
     static is(x: any): x is ABAPObject;
-    parse(release: ABAPRelease, globalMacros?: readonly string[], reg?: IRegistry, languageVersion?: LanguageVersion, openABAP?: boolean): IParseResult;
+    parse(release: ABAPRelease, globalMacros?: readonly string[], reg?: IRegistry, languageVersion?: LanguageVersion): IParseResult;
     setDirty(): void;
     private getParsedXML;
     getABAPFiles(): readonly ABAPFile[];
@@ -122,7 +122,7 @@ declare abstract class AbstractObject implements IObject {
     abstract getDescription(): string | undefined;
     constructor(name: string);
     getParsingIssues(): readonly Issue[];
-    parse(_release?: ABAPRelease, _globalMacros?: readonly string[], _reg?: IRegistry, _languageVersion?: LanguageVersion, _openABAP?: boolean): IParseResult;
+    parse(_release?: ABAPRelease, _globalMacros?: readonly string[], _reg?: IRegistry, _languageVersion?: LanguageVersion): IParseResult;
     getName(): string;
     setDirty(): void;
     addFile(file: IFile): void;
@@ -1463,7 +1463,7 @@ declare class CondSub extends Expression {
 
 export declare class Config implements IConfiguration {
     private readonly config;
-    static getDefault(ver?: VersionOldOrNew, langVer?: LanguageVersion, openABAP?: boolean): Config;
+    static getDefault(ver?: VersionOldOrNew, langVer?: LanguageVersion): Config;
     getEnabledRules(): IRule[];
     constructor(json: string);
     get(): IConfig;
@@ -4076,7 +4076,7 @@ export declare interface IObject extends IArtifact {
     /** returns true if the object was parsed, false if no changes since last parse
      * registry for global cross object macros
      */
-    parse(release?: ABAPRelease, globalMacros?: readonly string[], reg?: IRegistry, languageVersion?: LanguageVersion, openABAP?: boolean): IParseResult;
+    parse(release?: ABAPRelease, globalMacros?: readonly string[], reg?: IRegistry, languageVersion?: LanguageVersion): IParseResult;
     getParsingIssues(): readonly Issue[];
     getFiles(): readonly IFile[];
     addFile(file: IFile): void;
@@ -4371,8 +4371,6 @@ declare interface ISyntaxSettings {
     /** ABAP language version */
     version?: VersionOldOrNew;
     languageVersion?: LanguageVersion;
-    /** Use the OpenABAP dialect (v702 base + a set of additional language features). */
-    openABAP?: boolean;
     /** Report error for objects in this regex namespace. Types not in namespace will be void. Case insensitive */
     errorNamespace: string;
     /** List of full named global constants (regex not possible)
@@ -5990,6 +5988,12 @@ declare const releaseDefsRaw: readonly [readonly ["v700", {
     readonly op: 702;
     readonly cloud: null;
     readonly ce: null;
+}], readonly ["open-abap", {
+    readonly abap: "open-abap";
+    readonly kernel: null;
+    readonly op: null;
+    readonly cloud: null;
+    readonly ce: null;
 }], readonly ["v710", {
     readonly abap: "710";
     readonly kernel: 710;

package/build/src/abap/2_statements/combi.js

@@ -860,14 +860,13 @@ class Combi {
         return res;
     }
     // assumption: no pragmas supplied in tokens input
-    static run(runnable, tokens, versionOrRelease, languageVersion = version_1.LanguageVersion.Normal, openABAP = false) {
-        this.openABAP = openABAP || versionOrRelease === version_1.Version.OpenABAP;
+    static run(runnable, tokens, versionOrRelease, languageVersion = version_1.LanguageVersion.Normal) {
         this.langVer = languageVersion;
         if (typeof versionOrRelease === "string") {
-            this.release = this.openABAP ? version_1.Release.v702 : (0, version_1.versionToABAPRelease)(versionOrRelease);
+            this.release = (0, version_1.versionToABAPRelease)(versionOrRelease);
         }
         else {
-            this.release = this.openABAP ? version_1.Release.v702 : versionOrRelease;
+            this.release = versionOrRelease;
         }
         const input = new result_1.Result(tokens, 0);
         try {
@@ -900,14 +899,13 @@ class Combi {
         return this.langVer;
     }
     static isOpenABAP() {
-        return this.openABAP;
+        return this.release === version_1.Release["open-abap"];
     }
 }
 exports.Combi = Combi;
 // todo, change this class to be instantiated, constructor(runnable) ?
 Combi.release = version_1.Release.v758;
 Combi.langVer = version_1.LanguageVersion.Normal;
-Combi.openABAP = false;
 // -----------------------------------------------------------------------------
 function str(s) {
     if (s.indexOf(" ") > 0 || s.indexOf("-") > 0) {

package/build/src/abap/2_statements/statement_parser.js

@@ -103,13 +103,12 @@ class WorkArea {
     }
 }
 class StatementParser {
-    constructor(release, reg, languageVersion = version_1.LanguageVersion.Normal, openABAP = false) {
+    constructor(release, reg, languageVersion = version_1.LanguageVersion.Normal) {
         if (!StatementParser.map) {
             StatementParser.map = new StatementMap();
         }
         this.release = release;
         this.languageVersion = languageVersion;
-        this.openABAP = openABAP;
         this.reg = reg;
     }
     /** input is one full object */
@@ -266,7 +265,7 @@ class StatementParser {
             return new nodes_1.StatementNode(new _statement_1.Empty()).setChildren(this.tokensToNodes(tokens));
         }
         for (const st of StatementParser.map.lookup(filtered[0].getStr())) {
-            const match = combi_1.Combi.run(st.matcher, filtered, this.release, this.languageVersion, this.openABAP);
+            const match = combi_1.Combi.run(st.matcher, filtered, this.release, this.languageVersion);
             if (match) {
                 const last = tokens[tokens.length - 1];
                 match.push(new nodes_1.TokenNode(last));
@@ -276,7 +275,7 @@ class StatementParser {
         }
         // next try the statements without specific keywords
         for (const st of StatementParser.map.lookup("")) {
-            const match = combi_1.Combi.run(st.matcher, filtered, this.release, this.languageVersion, this.openABAP);
+            const match = combi_1.Combi.run(st.matcher, filtered, this.release, this.languageVersion);
             if (match) {
                 const last = tokens[tokens.length - 1];
                 match.push(new nodes_1.TokenNode(last));

package/build/src/abap/5_syntax/expressions/select.js

@@ -116,10 +116,18 @@ class Select {
         for (const s of node.findDirectExpressions(Expressions.SQLSource)) {
             sql_source_1.SQLSource.runSyntax(s, input);
         }
+        const upToWhere = node.findDirectExpression(Expressions.SQLCond);
+        const isCloud = input.scope.getLanguageVersion() === version_1.LanguageVersion.Cloud;
         for (const up of node.findDirectExpressions(Expressions.SQLUpTo)) {
+            // in classic Open SQL (INTO before WHERE) "UP TO" is allowed before INTO,
+            // in strict Open SQL (INTO after WHERE) "UP TO" must be placed after INTO
+            const intoAfterWhere = upToWhere !== undefined
+                && intoExpression !== undefined
+                && intoExpression.getFirstToken().getStart().isAfter(upToWhere.getFirstToken().getStart());
             if (intoExpression
                 && this.isStrictMode(node, input)
-                && (selectLoop === false || input.scope.getLanguageVersion() === version_1.LanguageVersion.Cloud)
+                && (isCloud || (this.upToUsesHostVariable(up) && intoAfterWhere))
+                && (selectLoop === false || isCloud)
                 && from.getFirstToken().getStart().isBefore(up.getFirstToken().getStart())
                 && up.getFirstToken().getStart().isBefore(intoExpression.getFirstToken().getStart())) {
                 const message = `The addition "UP TO n ROWS" must only be placed after the INTO/APPENDING clause.`;
@@ -157,6 +165,10 @@ class Select {
             input.scope.pop(node.getLastToken().getEnd());
         }
     }
+    static upToUsesHostVariable(up) {
+        var _a;
+        return ((_a = up.findFirstExpression(Expressions.SQLSource)) === null || _a === void 0 ? void 0 : _a.getFirstToken().getStr()) === "@";
+    }
     static buildUpToRowsFix(node, input, up, intoExpression) {
         const tokens = node.getTokens();
         const upLast = up.getLastToken();

package/build/src/abap/abap_parser.js

@@ -10,19 +10,17 @@ const structure_parser_1 = require("./3_structures/structure_parser");
 const version_1 = require("../version");
 class ABAPParser {
     constructor(optionsOrRelease, globalMacros, reg) {
-        var _a, _b, _c, _d;
+        var _a, _b, _c;
         if (optionsOrRelease === undefined || ABAPParser.isRelease(optionsOrRelease)) {
             this.release = optionsOrRelease !== null && optionsOrRelease !== void 0 ? optionsOrRelease : version_1.defaultRelease;
             this.languageVersion = version_1.LanguageVersion.Normal;
-            this.openABAP = false;
             this.globalMacros = globalMacros !== null && globalMacros !== void 0 ? globalMacros : [];
             this.reg = reg;
         }
         else {
             this.release = (_a = optionsOrRelease.release) !== null && _a !== void 0 ? _a : version_1.defaultRelease;
             this.languageVersion = (_b = optionsOrRelease.languageVersion) !== null && _b !== void 0 ? _b : version_1.LanguageVersion.Normal;
-            this.openABAP = (_c = optionsOrRelease.openABAP) !== null && _c !== void 0 ? _c : false;
-            this.globalMacros = (_d = optionsOrRelease.globalMacros) !== null && _d !== void 0 ? _d : [];
+            this.globalMacros = (_c = optionsOrRelease.globalMacros) !== null && _c !== void 0 ? _c : [];
             this.reg = optionsOrRelease.reg;
         }
     }
@@ -40,7 +38,7 @@ class ABAPParser {
         const lexingRuntime = Date.now() - b1;
         // 2: statements
         const b2 = Date.now();
-        const statementResult = new statement_parser_1.StatementParser(this.release, this.reg, this.languageVersion, this.openABAP)
+        const statementResult = new statement_parser_1.StatementParser(this.release, this.reg, this.languageVersion)
             .run(lexerResult, this.globalMacros);
         const statementsRuntime = Date.now() - b2;
         // 3: structures

package/build/src/config.js

@@ -39,7 +39,7 @@ const artifacts_rules_1 = require("./artifacts_rules");
 const JSON5 = __importStar(require("json5"));
 // assumption: this class is immutable
 class Config {
-    static getDefault(ver, langVer, openABAP) {
+    static getDefault(ver, langVer) {
         const rules = {};
         const sorted = artifacts_rules_1.ArtifactsRules.getRules().sort((a, b) => {
             return a.getMetadata().key.localeCompare(b.getMetadata().key);
@@ -73,7 +73,6 @@ class Config {
             syntax: {
                 version,
                 languageVersion: langVer,
-                openABAP,
                 errorNamespace: "^(Z|Y|LCL\_|TY\_|LIF\_)",
                 globalConstants: [],
                 globalMacros: [],
@@ -165,7 +164,7 @@ class Config {
         return (0, version_1.versionToABAPRelease)(v);
     }
     getOpenABAP() {
-        return this.config.syntax.openABAP === true;
+        return this.getRelease() === version_1.Release["open-abap"];
     }
     getVersion() {
         const v = this.config.syntax.version;
@@ -202,10 +201,8 @@ class Config {
         if (version === version_1.Version.Cloud) {
             this.config.syntax.languageVersion = version_1.LanguageVersion.Cloud;
         }
-        else if (version === version_1.Version.OpenABAP) {
-            this.config.syntax.version = version_1.Version.v702;
-            this.config.syntax.openABAP = true;
-        }
+        // OpenABAP keeps its own version identity; open-abap-ness is derived from the
+        // release in getOpenABAP() rather than a separate stored flag.
     }
 }
 exports.Config = Config;

package/build/src/objects/_abap_object.js

@@ -18,12 +18,12 @@ class ABAPObject extends _abstract_object_1.AbstractObject {
     static is(x) {
         return !!x && x instanceof ABAPObject;
     }
-    parse(release, globalMacros, reg, languageVersion = version_1.LanguageVersion.Normal, openABAP = false) {
+    parse(release, globalMacros, reg, languageVersion = version_1.LanguageVersion.Normal) {
         if (this.isDirty() === false) {
             return { updated: false, runtime: 0 };
         }
         const abapFiles = this.getFiles().filter(f => f.getFilename().endsWith(".abap"));
-        const result = new abap_parser_1.ABAPParser({ release, globalMacros, reg, languageVersion, openABAP }).parse(abapFiles);
+        const result = new abap_parser_1.ABAPParser({ release, globalMacros, reg, languageVersion }).parse(abapFiles);
         this.parsed = result.output;
         this.old = result.issues;
         this.dirty = false;

package/build/src/objects/_abstract_object.js

@@ -15,7 +15,7 @@ class AbstractObject {
     getParsingIssues() {
         return this.old;
     }
-    parse(_release, _globalMacros, _reg, _languageVersion, _openABAP) {
+    parse(_release, _globalMacros, _reg, _languageVersion) {
         return { updated: false, runtime: 0 };
     }
     getName() {

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.119.51";
+        return "2.119.52";
     }
     getDDICReferences() {
         return this.ddicReferences;
@@ -322,7 +322,7 @@ class Registry {
     // todo, refactor, this is a mess, see where-used, a lot of the code should be in this method instead
     parsePrivate(input) {
         const config = this.getConfig();
-        const result = input.parse(config.getRelease(), config.getSyntaxSetttings().globalMacros, this, config.getLanguageVersion(), config.getOpenABAP());
+        const result = input.parse(config.getRelease(), config.getSyntaxSetttings().globalMacros, this, config.getLanguageVersion());
         ParsingPerformance.push(input, result);
     }
     isDirty() {

package/build/src/version.js

@@ -51,6 +51,12 @@ const releaseDefsRaw = [
     ["v700", { abap: "700", kernel: 700, op: 700, cloud: null, ce: null }],
     ["v701", { abap: "701", kernel: 701, op: 701, cloud: null, ce: null }],
     ["v702", { abap: "702", kernel: 702, op: 702, cloud: null, ce: null }],
+    // OpenABAP: not a real SAP release. A dialect that is "702 baseline + a curated set
+    // of newer features" (opted in per-statement via AlsoIn.OpenABAP). Placed right after
+    // v702 on purpose: its ordinal must behave exactly like v702 for releaseAtLeast() gates
+    // (nothing else gates between v702 and v710), while staying a distinct identity so
+    // open-abap can be detected without a separate boolean flag.
+    ["open-abap", { abap: "open-abap", kernel: null, op: null, cloud: null, ce: null }],
     ["v710", { abap: "710", kernel: 710, op: 710, cloud: null, ce: null }],
     ["v711", { abap: "711", kernel: 711, op: 711, cloud: null, ce: null }],
     ["v720", { abap: "720", kernel: 720, op: 720, cloud: null, ce: null }],
@@ -125,10 +131,13 @@ const releaseDefsRaw = [
 ];
 /** All known releases in chronological order. Declaration order IS the ordering. */
 exports.ReleaseList = releaseDefsRaw.map(([name, r], i) => Object.freeze(Object.assign(Object.assign({}, r), { name, ordinal: i })));
+/** Base lookup, keyed by the raw release name (e.g. `"v762"`, `"Newest"`). */
+const byName = Object.fromEntries(releaseDefsRaw.map(([name], i) => [name, exports.ReleaseList[i]]));
 /** Lookup table keyed by release name (e.g. `Release.v740sp05`, `Release.Newest`). */
-exports.Release = Object.freeze(Object.assign(Object.assign({}, Object.fromEntries(releaseDefsRaw.map(([name], i) => [name, exports.ReleaseList[i]]))), { 
-    // Deprecated aliases: on-prem v750–v758 map to last cloud row at that op
-    v750: exports.ReleaseList[14], v751: exports.ReleaseList[17], v752: exports.ReleaseList[21], v753: exports.ReleaseList[25], v754: exports.ReleaseList[29], v755: exports.ReleaseList[33], v756: exports.ReleaseList[37], v757: exports.ReleaseList[41], v758: exports.ReleaseList[45], v816: exports.ReleaseList[53] }));
+exports.Release = Object.freeze(Object.assign(Object.assign({}, byName), { 
+    // Deprecated aliases: on-prem v750–v758 map to last cloud row at that op.
+    // Referenced by cloud name (not array index) so inserting rows can't silently repoint them.
+    v750: byName["v762"], v751: byName["v765"], v752: byName["v769"], v753: byName["v773"], v754: byName["v777"], v755: byName["v781"], v756: byName["v785"], v757: byName["v789"], v758: byName["v793"], v816: byName["v916"] }));
 /**
  * Is `running` at least as new as `required`?
  * Comparison is purely by ordinal (declaration order in ReleaseList).
@@ -157,7 +166,7 @@ const byDeprecated = Object.freeze({
     [Version.v758]: exports.Release["v758"],
     [Version.v816]: exports.Release["v816"],
     [Version.Cloud]: exports.Release["Newest"], // Cloud → Newest sentinel
-    [Version.OpenABAP]: exports.Release["v702"], // OpenABAP shares v702 release identity
+    [Version.OpenABAP]: exports.Release["open-abap"], // OpenABAP is its own release identity (702 baseline + curated features)
 });
 function versionToABAPRelease(v) {
     const found = byDeprecated[v];

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.119.51",
+    "version": "2.119.52",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",