@abaplint/core 2.119.48 → 2.119.50

package/build/src/abap/2_statements/expand_macros.js

@@ -134,7 +134,7 @@ class ExpandMacros {
             }
         }
     }
-    handleMacros(statements, file) {
+    handleMacros(statements, file, seen = new Set()) {
         var _a;
         const result = [];
         let containsUnknown = false;
@@ -152,13 +152,20 @@ class ExpandMacros {
                         });
                     }
                     result.push(new statement_node_1.StatementNode(new _statement_1.MacroCall(), statement.getColon()).setChildren(this.tokensToNodes(statement.getTokens())));
-                    const expanded = this.expandContents(macroName, statement);
-                    const handled = this.handleMacros(expanded, file);
-                    for (const e of handled.statements) {
-                        result.push(e);
+                    if (!seen.has(macroName.toUpperCase())) {
+                        const expanded = this.expandContents(macroName, statement);
+                        const nextSeen = new Set(seen).add(macroName.toUpperCase());
+                        const handled = this.handleMacros(expanded, file, nextSeen);
+                        for (const e of handled.statements) {
+                            result.push(e);
+                        }
+                        if (handled.containsUnknown === true) {
+                            containsUnknown = true;
+                        }
                     }
-                    if (handled.containsUnknown === true) {
-                        containsUnknown = true;
+                    else {
+                        const node = new statement_node_1.StatementNode(new _statement_1.MacroRecursion(), statement.getColon());
+                        result.push(node.setChildren(this.tokensToNodes(statement.getTokens())));
                     }
                     continue;
                 }

package/build/src/abap/2_statements/expressions/_derived_types.js

@@ -0,0 +1,53 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.commonDerivedTypes = commonDerivedTypes;
+exports.derivedTypesAlt = derivedTypesAlt;
+const combi_1 = require("../combi");
+const _1 = require(".");
+const version_1 = require("../../../version");
+function commonDerivedTypes() {
+    const entity = (0, combi_1.alt)(_1.TypeName, _1.EntityAssociation);
+    // more-specific keyword phrases (e.g. "FAILED LATE") must precede less-specific ones ("FAILED")
+    return [
+        (0, combi_1.ver)(version_1.Release.v774, (0, combi_1.seq)("FAILED LATE", entity)),
+        (0, combi_1.ver)(version_1.Release.v774, (0, combi_1.seq)("MAPPED LATE", entity)),
+        (0, combi_1.ver)(version_1.Release.v774, (0, combi_1.seq)("REPORTED LATE", entity)),
+        (0, combi_1.ver)(version_1.Release.v777, (0, combi_1.seq)("FAILED EARLY", entity)),
+        (0, combi_1.ver)(version_1.Release.v777, (0, combi_1.seq)("MAPPED EARLY", entity)),
+        (0, combi_1.ver)(version_1.Release.v777, (0, combi_1.seq)("REPORTED EARLY", entity)),
+        (0, combi_1.ver)(version_1.Release.v776, (0, combi_1.seq)("FAILED", entity)),
+        (0, combi_1.ver)(version_1.Release.v776, (0, combi_1.seq)("MAPPED", entity)),
+        (0, combi_1.ver)(version_1.Release.v776, (0, combi_1.seq)("REPORTED", entity)),
+        (0, combi_1.ver)(version_1.Release.v773, (0, combi_1.seq)("FUNCTION IMPORT", entity)),
+        (0, combi_1.ver)(version_1.Release.v773, (0, combi_1.seq)("FUNCTION RESULT", entity)),
+        (0, combi_1.ver)(version_1.Release.v773, (0, combi_1.seq)("ACTION RESULT", entity)),
+        (0, combi_1.ver)(version_1.Release.v781, (0, combi_1.seq)("INSTANCE AUTHORIZATION KEY", entity)),
+        (0, combi_1.ver)(version_1.Release.v781, (0, combi_1.seq)("INSTANCE AUTHORIZATION REQUEST", entity)),
+        (0, combi_1.ver)(version_1.Release.v781, (0, combi_1.seq)("INSTANCE AUTHORIZATION RESULT", entity)),
+        (0, combi_1.ver)(version_1.Release.v781, (0, combi_1.seq)("INSTANCE FEATURES KEY", entity)),
+        (0, combi_1.ver)(version_1.Release.v781, (0, combi_1.seq)("INSTANCE FEATURES REQUEST", entity)),
+        (0, combi_1.ver)(version_1.Release.v781, (0, combi_1.seq)("INSTANCE FEATURES RESULT", entity)),
+        (0, combi_1.ver)(version_1.Release.v780, (0, combi_1.seq)("AUTHORIZATION RESULT", entity)),
+        (0, combi_1.ver)(version_1.Release.v781, (0, combi_1.seq)("AUTHORIZATION KEY", entity)),
+        (0, combi_1.ver)(version_1.Release.v776, (0, combi_1.seq)("FEATURES RESULT", entity)),
+        (0, combi_1.ver)(version_1.Release.v776, (0, combi_1.seq)("FEATURES KEY", entity)),
+        (0, combi_1.ver)(version_1.Release.v780, (0, combi_1.seq)("PERMISSIONS KEY", entity)),
+        (0, combi_1.seq)("READ IMPORT", entity),
+        (0, combi_1.seq)("READ RESULT", entity),
+        (0, combi_1.ver)(version_1.Release.v915, (0, combi_1.seq)("READ CHANGES", entity)),
+        (0, combi_1.seq)("CREATE", entity),
+        (0, combi_1.seq)("DELETE", entity),
+        (0, combi_1.seq)("UPDATE", entity),
+        (0, combi_1.ver)(version_1.Release.v777, (0, combi_1.seq)("LOCK", entity)),
+        (0, combi_1.ver)(version_1.Release.v775, (0, combi_1.seq)("KEY OF", entity)),
+        (0, combi_1.ver)(version_1.Release.v776, (0, combi_1.seq)("DETERMINATION", entity)),
+        (0, combi_1.ver)(version_1.Release.v776, (0, combi_1.seq)("VALIDATION", entity)),
+        (0, combi_1.ver)(version_1.Release.v778, (0, combi_1.seq)("CHANGE", entity)),
+    ];
+}
+function derivedTypesAlt(...extra) {
+    const all = [...extra, ...commonDerivedTypes()];
+    const [first, second, ...rest] = all;
+    return (0, combi_1.altPrio)(first, second, ...rest);
+}
+//# sourceMappingURL=_derived_types.js.map

package/build/src/abap/2_statements/expressions/type_structure.js

@@ -3,24 +3,16 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.TypeStructure = void 0;
 const combi_1 = require("../combi");
 const _1 = require(".");
+const version_1 = require("../../../version");
+const _derived_types_1 = require("./_derived_types");
 class TypeStructure extends combi_1.Expression {
     getRunnable() {
-        // todo, add version,
-        const hier = (0, combi_1.seq)("HIERARCHY", _1.NamespaceSimpleName);
-        const create = (0, combi_1.seq)("CREATE", (0, combi_1.alt)(_1.NamespaceSimpleName, _1.EntityAssociation));
-        const update = (0, combi_1.seq)("UPDATE", (0, combi_1.alt)(_1.NamespaceSimpleName, _1.EntityAssociation));
-        const readResult = (0, combi_1.seq)("READ RESULT", (0, combi_1.alt)(_1.NamespaceSimpleName, _1.EntityAssociation));
-        const readLink = (0, combi_1.seq)("READ LINK", _1.EntityAssociation);
-        const action = (0, combi_1.seq)("ACTION IMPORT", _1.Source);
-        const permissionsRequest = (0, combi_1.seq)("PERMISSIONS REQUEST", _1.NamespaceSimpleName);
-        const evt = (0, combi_1.seq)("EVENT", _1.EventName);
-        const failedEarly = (0, combi_1.seq)("FAILED EARLY", _1.NamespaceSimpleName);
-        const mappedEarly = (0, combi_1.seq)("MAPPED EARLY", _1.NamespaceSimpleName);
-        const reportedEarly = (0, combi_1.seq)("REPORTED EARLY", _1.NamespaceSimpleName);
-        const structure = (0, combi_1.seq)("STRUCTURE FOR", (0, combi_1.altPrio)(hier, evt, create, update, action, permissionsRequest, readLink, readResult));
-        const response = (0, combi_1.seq)("RESPONSE FOR", (0, combi_1.altPrio)(failedEarly, mappedEarly, reportedEarly));
-        const request = (0, combi_1.seq)("REQUEST FOR CHANGE", _1.NamespaceSimpleName);
-        return (0, combi_1.seq)("TYPE", (0, combi_1.altPrio)(structure, response, request));
+        const entity = (0, combi_1.alt)(_1.TypeName, _1.EntityAssociation);
+        const derivedTypes = (0, _derived_types_1.derivedTypesAlt)((0, combi_1.ver)(version_1.Release.v779, (0, combi_1.seq)("FUNCTION REQUEST", entity)), (0, combi_1.ver)(version_1.Release.v779, (0, combi_1.seq)("ACTION REQUEST", entity)), (0, combi_1.seq)("ACTION IMPORT", _1.Source), (0, combi_1.ver)(version_1.Release.v781, (0, combi_1.seq)("GLOBAL AUTHORIZATION REQUEST", entity)), (0, combi_1.ver)(version_1.Release.v781, (0, combi_1.seq)("GLOBAL AUTHORIZATION RESULT", entity)), (0, combi_1.ver)(version_1.Release.v781, (0, combi_1.seq)("GLOBAL FEATURES REQUEST", entity)), (0, combi_1.ver)(version_1.Release.v781, (0, combi_1.seq)("GLOBAL FEATURES RESULT", entity)), (0, combi_1.ver)(version_1.Release.v780, (0, combi_1.seq)("AUTHORIZATION REQUEST", entity)), (0, combi_1.ver)(version_1.Release.v776, (0, combi_1.seq)("FEATURES REQUEST", entity)), (0, combi_1.seq)("PERMISSIONS REQUEST", _1.NamespaceSimpleName), (0, combi_1.ver)(version_1.Release.v780, (0, combi_1.seq)("PERMISSIONS RESULT", entity)), (0, combi_1.seq)("READ LINK", _1.EntityAssociation), (0, combi_1.seq)("HIERARCHY", _1.NamespaceSimpleName), (0, combi_1.seq)("EVENT", _1.EventName));
+        const structure = (0, combi_1.ver)(version_1.Release.v774, (0, combi_1.seq)("STRUCTURE FOR", derivedTypes));
+        const response = (0, combi_1.ver)(version_1.Release.v776, (0, combi_1.seq)("RESPONSE FOR", (0, combi_1.altPrio)((0, combi_1.seq)("FAILED EARLY", _1.NamespaceSimpleName), (0, combi_1.seq)("FAILED LATE", _1.NamespaceSimpleName), (0, combi_1.seq)("FAILED", _1.NamespaceSimpleName), (0, combi_1.seq)("MAPPED EARLY", _1.NamespaceSimpleName), (0, combi_1.seq)("MAPPED LATE", _1.NamespaceSimpleName), (0, combi_1.seq)("MAPPED", _1.NamespaceSimpleName), (0, combi_1.seq)("REPORTED EARLY", _1.NamespaceSimpleName), (0, combi_1.seq)("REPORTED LATE", _1.NamespaceSimpleName), (0, combi_1.seq)("REPORTED", _1.NamespaceSimpleName))));
+        const request = (0, combi_1.ver)(version_1.Release.v778, (0, combi_1.seq)("REQUEST FOR", (0, combi_1.alt)("CHANGE", "DELETE"), _1.NamespaceSimpleName));
+        return (0, combi_1.seq)("TYPE", (0, combi_1.altPrio)(structure, response, request), (0, combi_1.optPrio)("VALUE IS INITIAL"));
     }
 }
 exports.TypeStructure = TypeStructure;

package/build/src/abap/2_statements/expressions/type_table.js

@@ -6,6 +6,7 @@ const _1 = require(".");
 const field_chain_1 = require("./field_chain");
 const type_table_key_1 = require("./type_table_key");
 const version_1 = require("../../../version");
+const _derived_types_1 = require("./_derived_types");
 class TypeTable extends combi_1.Expression {
     getRunnable() {
         const header = "WITH HEADER LINE";
@@ -19,7 +20,9 @@ class TypeTable extends combi_1.Expression {
         // "WITH" is not allowed as a field name in keys
         const typetable = (0, combi_1.alt)(generic, (0, combi_1.seq)(normal1, (0, combi_1.alt)((0, combi_1.opt)((0, combi_1.per)(header, initial, (0, combi_1.plusPrio)(type_table_key_1.TypeTableKey))), (0, combi_1.seq)((0, combi_1.plus)(type_table_key_1.TypeTableKey), (0, combi_1.optPrio)(initial))), (0, combi_1.optPrio)("VALUE IS INITIAL")));
         const occurs = (0, combi_1.seq)("OCCURS", (0, combi_1.altPrio)(_1.Integer, field_chain_1.FieldChain));
-        const derived = (0, combi_1.ver)(version_1.Release.v754, (0, combi_1.seq)("TABLE FOR", (0, combi_1.altPrio)("ACTION IMPORT", "ACTION RESULT", "CREATE", "EVENT", "REPORTED EARLY", "READ IMPORT", "FAILED EARLY", "FAILED", "LOCK", "DETERMINATION", "READ RESULT", "UPDATE", "DELETE"), (0, combi_1.alt)(_1.TypeName, _1.EntityAssociation)), { also: combi_1.AlsoIn.OpenABAP });
+        const entity = (0, combi_1.alt)(_1.TypeName, _1.EntityAssociation);
+        const derivedTypes = (0, _derived_types_1.derivedTypesAlt)((0, combi_1.ver)(version_1.Release.v773, (0, combi_1.seq)("ACTION IMPORT", entity)), (0, combi_1.seq)("READ LINK", entity), (0, combi_1.seq)("EVENT", entity));
+        const derived = (0, combi_1.ver)(version_1.Release.v770, (0, combi_1.seq)("TABLE FOR", derivedTypes, (0, combi_1.optPrio)("VALUE IS INITIAL")), { also: combi_1.AlsoIn.OpenABAP });
         const oldType = (0, combi_1.seq)((0, combi_1.opt)("REF TO"), _1.TypeName, (0, combi_1.alt)((0, combi_1.seq)(occurs, (0, combi_1.opt)(header)), header));
         const oldLike = (0, combi_1.seq)((0, combi_1.opt)("REF TO"), field_chain_1.FieldChain, (0, combi_1.alt)((0, combi_1.seq)(occurs, (0, combi_1.opt)(header)), header));
         const typeLine = (0, combi_1.seq)("LINE OF", _1.TypeName, occurs, header);

package/build/src/abap/2_statements/statements/_statement.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.NativeSQL = exports.MacroContent = exports.MacroCall = exports.Empty = exports.Comment = exports.Unknown = void 0;
+exports.NativeSQL = exports.MacroRecursion = exports.MacroContent = exports.MacroCall = exports.Empty = exports.Comment = exports.Unknown = void 0;
 class Unknown {
     getMatcher() {
         throw new Error("Unknown Statement, get_matcher");
@@ -31,6 +31,12 @@ class MacroContent {
     }
 }
 exports.MacroContent = MacroContent;
+class MacroRecursion {
+    getMatcher() {
+        throw new Error("MacroRecursion Statement, get_matcher");
+    }
+}
+exports.MacroRecursion = MacroRecursion;
 class NativeSQL {
     getMatcher() {
         throw new Error("NativeSQL Statement, get_matcher");

package/build/src/abap/3_structures/structures/_combi.js

@@ -266,7 +266,7 @@ class SubStatement {
     }
     first() {
         const o = new this.obj();
-        if (o instanceof _statement_1.MacroCall || o instanceof _statement_1.NativeSQL) {
+        if (o instanceof _statement_1.MacroCall || o instanceof _statement_1.MacroRecursion || o instanceof _statement_1.NativeSQL) {
             return [""];
         }
         return o.getMatcher().first();

package/build/src/abap/3_structures/structures/normal.js

@@ -41,7 +41,7 @@ const _statement_1 = require("../../2_statements/statements/_statement");
 class Normal {
     getMatcher() {
         // note that the sequence of alternatives here influences performance
-        return (0, _combi_1.alt)((0, _combi_1.sta)(Statements.Move), (0, _combi_1.sta)(Statements.Call), (0, _combi_1.sta)(Statements.Data), (0, _combi_1.sub)(Structures.If), (0, _combi_1.sta)(Statements.Clear), (0, _combi_1.sta)(Statements.FieldSymbol), (0, _combi_1.sta)(Statements.CreateObject), (0, _combi_1.sta)(Statements.CallFunction), (0, _combi_1.sta)(_statement_1.MacroCall), (0, _combi_1.sub)(Structures.LoopAtScreen), (0, _combi_1.sub)(Structures.Loop), (0, _combi_1.sub)(Structures.LoopExtract), (0, _combi_1.sta)(Statements.Append), (0, _combi_1.sub)(Structures.Try), (0, _combi_1.sub)(Structures.OnChange), (0, _combi_1.sta)(Statements.ReadTable), (0, _combi_1.sta)(Statements.Assert), (0, _combi_1.sta)(Statements.Return), (0, _combi_1.sta)(Statements.Select), (0, _combi_1.sta)(Statements.Assign), (0, _combi_1.sta)(Statements.InsertInternal), (0, _combi_1.sta)(Statements.DeleteInternal), (0, _combi_1.sta)(Statements.Concatenate), (0, _combi_1.sub)(Structures.Case), (0, _combi_1.sub)(Structures.CaseType), (0, _combi_1.sub)(Structures.Enhancement), (0, _combi_1.sub)(Structures.EnhancementSection), (0, _combi_1.sta)(Statements.AddCorresponding), (0, _combi_1.sta)(Statements.Add), (0, _combi_1.sta)(Statements.AssignLocalCopy), (0, _combi_1.sta)(Statements.AuthorityCheck), (0, _combi_1.sta)(Statements.Back), (0, _combi_1.sta)(Statements.Break), (0, _combi_1.sta)(Statements.BreakId), (0, _combi_1.sta)(Statements.CallDatabase), (0, _combi_1.sta)(Statements.CallDialog), (0, _combi_1.sta)(Statements.CallKernel), (0, _combi_1.sta)(Statements.CallOLE), (0, _combi_1.sta)(Statements.CallScreen), (0, _combi_1.sta)(Statements.ModifyScreen), (0, _combi_1.sta)(Statements.CallSelectionScreen), (0, _combi_1.sta)(Statements.CallTransaction), (0, _combi_1.sta)(Statements.CallTransformation), (0, _combi_1.sta)(Statements.Check), (0, _combi_1.sta)(Statements.ClassDefinitionLoad), (0, _combi_1.sta)(Statements.CloseCursor), (0, _combi_1.sta)(Statements.CloseDataset), (0, _combi_1.sta)(Statements.Collect), (0, _combi_1.sta)(Statements.Commit), (0, _combi_1.sta)(Statements.Communication), (0, _combi_1.sta)(Statements.Compute), (0, _combi_1.sta)(Statements.CallBadi), (0, _combi_1.sta)(Statements.Condense), (0, _combi_1.sta)(Statements.Constant), (0, _combi_1.sta)(Statements.Contexts), (0, _combi_1.sta)(Statements.Continue), (0, _combi_1.sta)(Statements.ConvertText), (0, _combi_1.sta)(Statements.Convert), (0, _combi_1.sta)(Statements.CreateData), (0, _combi_1.sta)(Statements.CreateOLE), (0, _combi_1.sta)(Statements.DeleteCluster), (0, _combi_1.sta)(Statements.DeleteDatabase), (0, _combi_1.sta)(Statements.DeleteDataset), (0, _combi_1.sta)(Statements.DeleteDynpro), (0, _combi_1.sta)(Statements.DeleteMemory), (0, _combi_1.sta)(Statements.DeleteReport), (0, _combi_1.sta)(Statements.DeleteTextpool), (0, _combi_1.sta)(Statements.Demand), (0, _combi_1.sta)(Statements.Describe), (0, _combi_1.sta)(Statements.Detail), (0, _combi_1.sta)(Statements.Divide), (0, _combi_1.sta)(Statements.EditorCall), (0, _combi_1.sta)(Statements.EnhancementPoint), (0, _combi_1.sta)(Statements.Exit), (0, _combi_1.sta)(Statements.ExportDynpro), (0, _combi_1.sta)(Statements.Export), (0, _combi_1.sta)(Statements.Extract), (0, _combi_1.sta)(Statements.FetchNextCursor), (0, _combi_1.sta)(Statements.FieldGroup), (0, _combi_1.sta)(Statements.Fields), (0, _combi_1.sta)(Statements.Find), (0, _combi_1.sta)(Statements.Format), (0, _combi_1.sta)(Statements.FreeMemory), (0, _combi_1.sta)(Statements.FreeObject), (0, _combi_1.sta)(Statements.Free), (0, _combi_1.sta)(Statements.GenerateDynpro), (0, _combi_1.sta)(Statements.GenerateReport), (0, _combi_1.sta)(Statements.GenerateSubroutine), (0, _combi_1.sta)(Statements.GetBadi), (0, _combi_1.sta)(Statements.GetBit), (0, _combi_1.sta)(Statements.GetCursor), (0, _combi_1.sta)(Statements.GetDataset), (0, _combi_1.sta)(Statements.GetLocale), (0, _combi_1.sta)(Statements.GetParameter), (0, _combi_1.sta)(Statements.GetPFStatus), (0, _combi_1.sta)(Statements.GetProperty), (0, _combi_1.sta)(Statements.GetReference), (0, _combi_1.sta)(Statements.GetRunTime), (0, _combi_1.sta)(Statements.GetTime), (0, _combi_1.sta)(Statements.Hide), (0, _combi_1.sta)(Statements.Nodes), (0, _combi_1.sta)(Statements.ImportDynpro), (0, _combi_1.sta)(Statements.ImportNametab), (0, _combi_1.sta)(Statements.MoveCorresponding), (0, _combi_1.sta)(Statements.Import), (0, _combi_1.sta)(Statements.Infotypes), (0, _combi_1.sta)(Statements.Include), // include does not have to be at top level
+        return (0, _combi_1.alt)((0, _combi_1.sta)(Statements.Move), (0, _combi_1.sta)(Statements.Call), (0, _combi_1.sta)(Statements.Data), (0, _combi_1.sub)(Structures.If), (0, _combi_1.sta)(Statements.Clear), (0, _combi_1.sta)(Statements.FieldSymbol), (0, _combi_1.sta)(Statements.CreateObject), (0, _combi_1.sta)(Statements.CallFunction), (0, _combi_1.sta)(_statement_1.MacroCall), (0, _combi_1.sta)(_statement_1.MacroRecursion), (0, _combi_1.sub)(Structures.LoopAtScreen), (0, _combi_1.sub)(Structures.Loop), (0, _combi_1.sub)(Structures.LoopExtract), (0, _combi_1.sta)(Statements.Append), (0, _combi_1.sub)(Structures.Try), (0, _combi_1.sub)(Structures.OnChange), (0, _combi_1.sta)(Statements.ReadTable), (0, _combi_1.sta)(Statements.Assert), (0, _combi_1.sta)(Statements.Return), (0, _combi_1.sta)(Statements.Select), (0, _combi_1.sta)(Statements.Assign), (0, _combi_1.sta)(Statements.InsertInternal), (0, _combi_1.sta)(Statements.DeleteInternal), (0, _combi_1.sta)(Statements.Concatenate), (0, _combi_1.sub)(Structures.Case), (0, _combi_1.sub)(Structures.CaseType), (0, _combi_1.sub)(Structures.Enhancement), (0, _combi_1.sub)(Structures.EnhancementSection), (0, _combi_1.sta)(Statements.AddCorresponding), (0, _combi_1.sta)(Statements.Add), (0, _combi_1.sta)(Statements.AssignLocalCopy), (0, _combi_1.sta)(Statements.AuthorityCheck), (0, _combi_1.sta)(Statements.Back), (0, _combi_1.sta)(Statements.Break), (0, _combi_1.sta)(Statements.BreakId), (0, _combi_1.sta)(Statements.CallDatabase), (0, _combi_1.sta)(Statements.CallDialog), (0, _combi_1.sta)(Statements.CallKernel), (0, _combi_1.sta)(Statements.CallOLE), (0, _combi_1.sta)(Statements.CallScreen), (0, _combi_1.sta)(Statements.ModifyScreen), (0, _combi_1.sta)(Statements.CallSelectionScreen), (0, _combi_1.sta)(Statements.CallTransaction), (0, _combi_1.sta)(Statements.CallTransformation), (0, _combi_1.sta)(Statements.Check), (0, _combi_1.sta)(Statements.ClassDefinitionLoad), (0, _combi_1.sta)(Statements.CloseCursor), (0, _combi_1.sta)(Statements.CloseDataset), (0, _combi_1.sta)(Statements.Collect), (0, _combi_1.sta)(Statements.Commit), (0, _combi_1.sta)(Statements.Communication), (0, _combi_1.sta)(Statements.Compute), (0, _combi_1.sta)(Statements.CallBadi), (0, _combi_1.sta)(Statements.Condense), (0, _combi_1.sta)(Statements.Constant), (0, _combi_1.sta)(Statements.Contexts), (0, _combi_1.sta)(Statements.Continue), (0, _combi_1.sta)(Statements.ConvertText), (0, _combi_1.sta)(Statements.Convert), (0, _combi_1.sta)(Statements.CreateData), (0, _combi_1.sta)(Statements.CreateOLE), (0, _combi_1.sta)(Statements.DeleteCluster), (0, _combi_1.sta)(Statements.DeleteDatabase), (0, _combi_1.sta)(Statements.DeleteDataset), (0, _combi_1.sta)(Statements.DeleteDynpro), (0, _combi_1.sta)(Statements.DeleteMemory), (0, _combi_1.sta)(Statements.DeleteReport), (0, _combi_1.sta)(Statements.DeleteTextpool), (0, _combi_1.sta)(Statements.Demand), (0, _combi_1.sta)(Statements.Describe), (0, _combi_1.sta)(Statements.Detail), (0, _combi_1.sta)(Statements.Divide), (0, _combi_1.sta)(Statements.EditorCall), (0, _combi_1.sta)(Statements.EnhancementPoint), (0, _combi_1.sta)(Statements.Exit), (0, _combi_1.sta)(Statements.ExportDynpro), (0, _combi_1.sta)(Statements.Export), (0, _combi_1.sta)(Statements.Extract), (0, _combi_1.sta)(Statements.FetchNextCursor), (0, _combi_1.sta)(Statements.FieldGroup), (0, _combi_1.sta)(Statements.Fields), (0, _combi_1.sta)(Statements.Find), (0, _combi_1.sta)(Statements.Format), (0, _combi_1.sta)(Statements.FreeMemory), (0, _combi_1.sta)(Statements.FreeObject), (0, _combi_1.sta)(Statements.Free), (0, _combi_1.sta)(Statements.GenerateDynpro), (0, _combi_1.sta)(Statements.GenerateReport), (0, _combi_1.sta)(Statements.GenerateSubroutine), (0, _combi_1.sta)(Statements.GetBadi), (0, _combi_1.sta)(Statements.GetBit), (0, _combi_1.sta)(Statements.GetCursor), (0, _combi_1.sta)(Statements.GetDataset), (0, _combi_1.sta)(Statements.GetLocale), (0, _combi_1.sta)(Statements.GetParameter), (0, _combi_1.sta)(Statements.GetPFStatus), (0, _combi_1.sta)(Statements.GetProperty), (0, _combi_1.sta)(Statements.GetReference), (0, _combi_1.sta)(Statements.GetRunTime), (0, _combi_1.sta)(Statements.GetTime), (0, _combi_1.sta)(Statements.Hide), (0, _combi_1.sta)(Statements.Nodes), (0, _combi_1.sta)(Statements.ImportDynpro), (0, _combi_1.sta)(Statements.ImportNametab), (0, _combi_1.sta)(Statements.MoveCorresponding), (0, _combi_1.sta)(Statements.Import), (0, _combi_1.sta)(Statements.Infotypes), (0, _combi_1.sta)(Statements.Include), // include does not have to be at top level
         (0, _combi_1.sta)(Statements.InsertDatabase), (0, _combi_1.sta)(Statements.InsertReport), (0, _combi_1.sta)(Statements.InsertTextpool), (0, _combi_1.sta)(Statements.InsertFieldGroup), (0, _combi_1.sta)(Statements.InterfaceLoad), (0, _combi_1.sta)(Statements.Leave), (0, _combi_1.sta)(Statements.LoadReport), (0, _combi_1.sta)(Statements.Local), (0, _combi_1.sta)(Statements.With), (0, _combi_1.sta)(Statements.LogPoint), (0, _combi_1.sta)(Statements.Message), (0, _combi_1.sta)(Statements.MergeDatabase), (0, _combi_1.sta)(Statements.ModifyLine), (0, _combi_1.sta)(Statements.ModifyDatabase), (0, _combi_1.sta)(Statements.ModifyInternal), (0, _combi_1.sta)(Statements.Multiply), (0, _combi_1.sta)(Statements.NewLine), (0, _combi_1.sta)(Statements.NewPage), (0, _combi_1.sta)(Statements.OpenCursor), (0, _combi_1.sta)(Statements.OpenDataset), (0, _combi_1.sta)(Statements.Overlay), (0, _combi_1.sta)(Statements.Pack), (0, _combi_1.sta)(Statements.Perform), (0, _combi_1.sta)(Statements.FormDefinition), (0, _combi_1.sta)(Statements.Position), (0, _combi_1.sta)(Statements.Put), (0, _combi_1.sta)(Statements.PrintControl), (0, _combi_1.sta)(Statements.RaiseEvent), (0, _combi_1.sta)(Statements.RaiseEntityEvent), (0, _combi_1.sta)(Statements.Raise), (0, _combi_1.sta)(Statements.Ranges), (0, _combi_1.sta)(Statements.ReadDataset), (0, _combi_1.sta)(Statements.ReadLine), (0, _combi_1.sta)(Statements.ReadReport), (0, _combi_1.sta)(Statements.ReadTextpool), (0, _combi_1.sta)(Statements.Receive), (0, _combi_1.sta)(Statements.RefreshControl), (0, _combi_1.sta)(Statements.Refresh), (0, _combi_1.sta)(Statements.Reject), (0, _combi_1.sta)(Statements.Replace), (0, _combi_1.sta)(Statements.Reserve), (0, _combi_1.sta)(Statements.Resume), (0, _combi_1.sta)(Statements.Retry), (0, _combi_1.sta)(Statements.Rollback), (0, _combi_1.sta)(Statements.Scan), (0, _combi_1.sta)(Statements.ScrollList), (0, _combi_1.sta)(Statements.Search), (0, _combi_1.sta)(Statements.SetBit), (0, _combi_1.sta)(Statements.SetBlank), (0, _combi_1.sta)(Statements.SetCountry), (0, _combi_1.sta)(Statements.SetCursor), (0, _combi_1.sta)(Statements.SetDataset), (0, _combi_1.sta)(Statements.SetExtendedCheck), (0, _combi_1.sta)(Statements.SetHandler), (0, _combi_1.sta)(Statements.SetLanguage), (0, _combi_1.sta)(Statements.SetLeft), (0, _combi_1.sta)(Statements.SetLocale), (0, _combi_1.sta)(Statements.SetMargin), (0, _combi_1.sta)(Statements.SetParameter), (0, _combi_1.sta)(Statements.SetPFStatus), (0, _combi_1.sta)(Statements.SetProperty), (0, _combi_1.sta)(Statements.SetRunTime), (0, _combi_1.sta)(Statements.SetScreen), (0, _combi_1.sta)(Statements.SetTitlebar), (0, _combi_1.sta)(Statements.SetUserCommand), (0, _combi_1.sta)(Statements.SetUpdateTask), (0, _combi_1.sta)(Statements.Shift), (0, _combi_1.sta)(Statements.Skip), (0, _combi_1.sta)(Statements.SortDataset), (0, _combi_1.sta)(Statements.Sort), (0, _combi_1.sta)(Statements.Static), (0, _combi_1.sta)(Statements.Split), (0, _combi_1.sta)(Statements.Stop), (0, _combi_1.sta)(Statements.Submit), (0, _combi_1.sta)(Statements.Summary), (0, _combi_1.sta)(Statements.SubtractCorresponding), (0, _combi_1.sta)(Statements.Subtract), (0, _combi_1.sta)(Statements.SuppressDialog), (0, _combi_1.sta)(Statements.Supply), (0, _combi_1.sta)(Statements.Sum), (0, _combi_1.sta)(Statements.SyntaxCheck), (0, _combi_1.sta)(Statements.SystemCall), (0, _combi_1.sta)(Statements.Tables), (0, _combi_1.sta)(Statements.Transfer), (0, _combi_1.sta)(Statements.Translate), (0, _combi_1.sta)(Statements.Type), (0, _combi_1.sta)(Statements.TypePools), (0, _combi_1.sta)(Statements.Uline), (0, _combi_1.sta)(Statements.Unassign), (0, _combi_1.sta)(Statements.Unpack), (0, _combi_1.sta)(Statements.UpdateDatabase), (0, _combi_1.sta)(Statements.Wait), (0, _combi_1.sta)(Statements.Window), (0, _combi_1.sta)(Statements.Write), (0, _combi_1.sta)(Statements.CommitEntities), (0, _combi_1.sta)(Statements.GetPermissions), (0, _combi_1.sta)(Statements.SetLocks), (0, _combi_1.sta)(Statements.ModifyEntities), (0, _combi_1.sta)(Statements.ReadEntities), (0, _combi_1.sta)(Statements.RollbackEntities), (0, _combi_1.sta)(Statements.Module), // todo, should be dynpro specific
         (0, _combi_1.sta)(Statements.Field), // todo, should be dynpro specific
         (0, _combi_1.sub)(Structures.Chain), // todo, should be dynpro specific

package/build/src/abap/5_syntax/basic_types.js

@@ -684,25 +684,12 @@ class BasicTypes {
         return name.includes("\\") || name.includes("~");
     }
     isRAPTableFor(text) {
-        return text.startsWith("TYPE TABLE FOR ACTION IMPORT ")
-            || text.startsWith("TYPE TABLE FOR ACTION RESULT ")
-            || text.startsWith("TYPE TABLE FOR CREATE ")
-            || text.startsWith("TYPE TABLE FOR DELETE ")
-            || text.startsWith("TYPE TABLE FOR DETERMINATION ")
-            || text.startsWith("TYPE TABLE FOR EVENT ")
-            || text.startsWith("TYPE TABLE FOR FAILED ")
-            || text.startsWith("TYPE TABLE FOR FAILED EARLY ")
-            || text.startsWith("TYPE TABLE FOR LOCK ")
-            || text.startsWith("TYPE TABLE FOR READ ")
-            || text.startsWith("TYPE TABLE FOR READ IMPORT ")
-            || text.startsWith("TYPE TABLE FOR READ RESULT ")
-            || text.startsWith("TYPE TABLE FOR REPORTED EARLY ")
-            || text.startsWith("TYPE TABLE FOR UPDATE ");
+        return text.startsWith("TYPE TABLE FOR ");
     }
     isRAPTypeStructure(text) {
         return text.startsWith("TYPE STRUCTURE FOR ")
             || text.startsWith("TYPE RESPONSE FOR ")
-            || text.startsWith("TYPE REQUEST FOR CHANGE ");
+            || text.startsWith("TYPE REQUEST FOR ");
     }
     // todo, rewrite this method
     resolveTypeChain(expr) {

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.119.48";
+        return "2.119.50";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/avoid_use.js

@@ -89,6 +89,8 @@ TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md
 
 BREAK points`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
+            badExample: `DESCRIBE TABLE items LINES count.`,
+            goodExample: `count = lines( items ).`,
         };
     }
     getDescription(statement) {

package/build/src/rules/class_attribute_names.js

@@ -37,6 +37,14 @@ class ClassAttributeNames extends _abap_rule_1.ABAPRule {
             title: "Class attributes naming",
             shortDescription: `Allows you to enforce a pattern, such as a prefix, for class variable names.`,
             tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.SingleFile],
+            badExample: `CLASS zcl_foo DEFINITION PUBLIC.
+  PUBLIC SECTION.
+    DATA counter TYPE i.
+ENDCLASS.`,
+            goodExample: `CLASS zcl_foo DEFINITION PUBLIC.
+  PUBLIC SECTION.
+    DATA mv_counter TYPE i.
+ENDCLASS.`,
         };
     }
     getDescription(actual, expected) {

package/build/src/rules/constructor_visibility_public.js

@@ -24,6 +24,14 @@ This only applies to global classes.
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
 https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abeninstance_constructor_guidl.htm`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
+            badExample: `CLASS zcl_foo DEFINITION PUBLIC CREATE PRIVATE.
+  PRIVATE SECTION.
+    METHODS constructor.
+ENDCLASS.`,
+            goodExample: `CLASS zcl_foo DEFINITION PUBLIC CREATE PRIVATE.
+  PUBLIC SECTION.
+    METHODS constructor.
+ENDCLASS.`,
         };
     }
     getMessage() {

package/build/src/rules/dangerous_statement.js

@@ -79,6 +79,8 @@ class DangerousStatement extends _abap_rule_1.ABAPRule {
             extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
 dynamic SQL can potentially create SQL injection problems`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
+            badExample: `SELECT * FROM (lv_table_name) INTO TABLE @DATA(lt_rows).`,
+            goodExample: `SELECT * FROM zknown_table INTO TABLE @DATA(lt_rows).`,
         };
     }
     getDescription(statement) {

package/build/src/rules/db_operation_in_loop.js

@@ -54,6 +54,17 @@ class DbOperationInLoop extends _abap_rule_1.ABAPRule {
             title: "Database operation in loop",
             shortDescription: `Database operation in LOOP/DO/WHILE`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Performance],
+            badExample: `LOOP AT lt_items INTO DATA(ls_item).
+  SELECT SINGLE name FROM zcustomer INTO @DATA(lv_name) WHERE id = @ls_item-customer_id.
+ENDLOOP.`,
+            goodExample: `ASSERT lines( lt_items ) > 0.
+SELECT id, name FROM zcustomer INTO TABLE @DATA(lt_customers)
+  FOR ALL ENTRIES IN @lt_items
+  WHERE id = @lt_items-customer_id.
+
+LOOP AT lt_items INTO DATA(ls_item).
+  READ TABLE lt_customers INTO DATA(ls_customer) WITH KEY id = ls_item-customer_id.
+ENDLOOP.`,
         };
     }
     getConfig() {

package/build/src/rules/exit_or_check.js

@@ -63,6 +63,12 @@ Use RETURN to leave procesing blocks instead.`,
 https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-return`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
+            badExample: `CHECK is_valid = abap_true.
+do_something( ).`,
+            goodExample: `IF is_valid = abap_false.
+  RETURN.
+ENDIF.
+do_something( ).`,
         };
     }
     getConfig() {

package/build/src/rules/form_tables_obsolete.js

@@ -55,6 +55,10 @@ class FormTablesObsolete extends _abap_rule_1.ABAPRule {
             shortDescription: `Checks for TABLES parameters in forms.`,
             extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abapform_tables.htm`,
             tags: [_irule_1.RuleTag.SingleFile],
+            badExample: `FORM update_items TABLES items.
+ENDFORM.`,
+            goodExample: `FORM update_items CHANGING items TYPE ty_items.
+ENDFORM.`,
         };
     }
     getMessage() {

package/build/src/rules/function_module_recommendations.js

@@ -110,6 +110,10 @@ class FunctionModuleRecommendations extends _abap_rule_1.ABAPRule {
             shortDescription: `Suggests replacements for various function modules`,
             extendedInformation: `https://docs.abapopenchecks.org/checks/53/`,
             tags: [_irule_1.RuleTag.SingleFile],
+            badExample: `CALL FUNCTION 'GUID_CREATE'
+  IMPORTING
+    ev_guid_32 = guid.`,
+            goodExample: `guid = cl_system_uuid=>create_uuid_c32_static( ).`,
         };
     }
     getConfig() {

package/build/src/rules/index.js

@@ -124,6 +124,7 @@ __exportStar(require("./no_chained_assignment"), exports);
 __exportStar(require("./no_comments_between_methods"), exports);
 __exportStar(require("./no_external_form_calls"), exports);
 __exportStar(require("./no_inline_in_optional_branches"), exports);
+__exportStar(require("./no_macros"), exports);
 __exportStar(require("./no_prefixes"), exports);
 __exportStar(require("./no_public_attributes"), exports);
 __exportStar(require("./no_yoda_conditions"), exports);

package/build/src/rules/line_length.js

@@ -27,6 +27,9 @@ class LineLength extends _abap_rule_1.ABAPRule {
             extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#stick-to-a-reasonable-line-length
 https://docs.abapopenchecks.org/checks/04/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
+            badExample: "DATA long_text TYPE string VALUE 'this line keeps going until it is longer than the configured maximum'.",
+            goodExample: `DATA long_text TYPE string.
+long_text = 'split long expressions across multiple lines'.`,
         };
     }
     getConfig() {

package/build/src/rules/local_class_naming.js

@@ -30,6 +30,10 @@ class LocalClassNaming extends _abap_rule_1.ABAPRule {
             title: "Local class naming conventions",
             shortDescription: `Allows you to enforce a pattern, such as a prefix, for local class names.`,
             tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.SingleFile],
+            badExample: `CLASS helper DEFINITION.
+ENDCLASS.`,
+            goodExample: `CLASS lcl_helper DEFINITION.
+ENDCLASS.`,
         };
     }
     getDescription(expected, actual) {

package/build/src/rules/method_parameter_names.js

@@ -34,6 +34,12 @@ class MethodParameterNames {
             title: "Method parameter naming conventions",
             shortDescription: `Allows you to enforce a pattern, such as a prefix, for method parameter names`,
             tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.SingleFile],
+            badExample: `METHODS get_name
+  IMPORTING customer TYPE string
+  RETURNING VALUE(name) TYPE string.`,
+            goodExample: `METHODS get_name
+  IMPORTING iv_customer TYPE string
+  RETURNING VALUE(rv_name) TYPE string.`,
         };
     }
     getDescription(expected, actual) {

package/build/src/rules/no_aliases.js

@@ -25,6 +25,13 @@ class NoAliases extends _abap_rule_1.ABAPRule {
             title: "No ALIASES",
             shortDescription: `Detects use of the ALIAS statement`,
             tags: [_irule_1.RuleTag.SingleFile],
+            badExample: `INTERFACE lif_foo.
+  METHODS long_method_name.
+  ALIASES short FOR long_method_name.
+ENDINTERFACE.`,
+            goodExample: `INTERFACE lif_foo.
+  METHODS long_method_name.
+ENDINTERFACE.`,
         };
     }
     getConfig() {

package/build/src/rules/no_comments_between_methods.js

@@ -53,8 +53,22 @@ class NoCommentsBetweenMethods extends _abap_rule_1.ABAPRule {
         return {
             key: "no_comments_between_methods",
             title: "No comments between methods in global classes",
-            shortDescription: `Its not possible to have comments between methods in global classes.`,
+            shortDescription: `It's not possible to have comments between methods in global classes.`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Syntax],
+            badExample: `CLASS zcl_foo IMPLEMENTATION.
+  METHOD first.
+  ENDMETHOD.
+  " comment
+  METHOD second.
+  ENDMETHOD.
+ENDCLASS.`,
+            goodExample: `CLASS zcl_foo IMPLEMENTATION.
+  METHOD first.
+  ENDMETHOD.
+
+  METHOD second.
+  ENDMETHOD.
+ENDCLASS.`,
         };
     }
     getConfig() {

package/build/src/rules/no_macros.js

@@ -0,0 +1,82 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.NoMacros = exports.NoMacrosConf = void 0;
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const Statements = __importStar(require("../abap/2_statements/statements"));
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+class NoMacrosConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.NoMacrosConf = NoMacrosConf;
+class NoMacros extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new NoMacrosConf();
+    }
+    getMetadata() {
+        return {
+            key: "no_macros",
+            title: "No macros",
+            shortDescription: `Checks that macros are not used`,
+            extendedInformation: `Macros reduce readability and are difficult to debug, use methods or form routines instead.
+
+https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/abenmacros_guidl.htm`,
+            tags: [_irule_1.RuleTag.SingleFile],
+            badExample: `DEFINE _macro.
+  WRITE 'hello'.
+END-OF-DEFINITION.`,
+            goodExample: `WRITE 'hello'.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        for (const stat of file.getStatements()) {
+            if (stat.get() instanceof Statements.Define) {
+                issues.push(issue_1.Issue.atStatement(file, stat, "Do not define macros", this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
+}
+exports.NoMacros = NoMacros;
+//# sourceMappingURL=no_macros.js.map

package/build/src/rules/no_public_attributes.js

@@ -31,6 +31,14 @@ class NoPublicAttributes extends _abap_rule_1.ABAPRule {
 Exceptions are excluded from this rule.`,
             extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#members-private-by-default-protected-only-if-needed`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
+            badExample: `CLASS zcl_foo DEFINITION PUBLIC.
+  PUBLIC SECTION.
+    DATA counter TYPE i.
+ENDCLASS.`,
+            goodExample: `CLASS zcl_foo DEFINITION PUBLIC.
+  PRIVATE SECTION.
+    DATA counter TYPE i.
+ENDCLASS.`,
         };
     }
     getDescription(name) {

package/build/src/rules/parser_error.js

@@ -41,19 +41,23 @@ See recognized syntax at https://syntax.abaplint.org`,
         if (obj instanceof _abap_object_1.ABAPObject) {
             for (const file of obj.getABAPFiles()) {
                 for (const statement of file.getStatements()) {
-                    if (!(statement.get() instanceof _statement_1.Unknown)) {
-                        continue;
-                    }
-                    if (statement.getTokens().length > statement_parser_1.STATEMENT_MAX_TOKENS) {
-                        const message = "Statement too long, refactor statement";
-                        const issue = issue_1.Issue.atToken(file, statement.getTokens()[0], message, this.getMetadata().key, this.conf.severity);
-                        issues.push(issue);
+                    if (statement.get() instanceof _statement_1.Unknown) {
+                        if (statement.getTokens().length > statement_parser_1.STATEMENT_MAX_TOKENS) {
+                            const message = "Statement too long, refactor statement";
+                            const issue = issue_1.Issue.atToken(file, statement.getTokens()[0], message, this.getMetadata().key, this.conf.severity);
+                            issues.push(issue);
+                        }
+                        else {
+                            const tok = statement.getFirstToken();
+                            const message = "Statement does not exist in ABAP " + this.reg.getConfig().getRelease().name + " (or a parser error), \"" + tok.getStr() + "\"";
+                            const issue = issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity);
+                            issues.push(issue);
+                        }
                     }
-                    else {
+                    else if (statement.get() instanceof _statement_1.MacroRecursion) {
                         const tok = statement.getFirstToken();
-                        const message = "Statement does not exist in ABAP" + this.reg.getConfig().getRelease().name + "(or a parser error), \"" + tok.getStr() + "\"";
-                        const issue = issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity);
-                        issues.push(issue);
+                        const message = "Macro recursion detected involving \"" + tok.getStr() + "\"";
+                        issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity));
                     }
                 }
                 if (this.reg.getConfig().getRelease() === version_1.Release.v700) {

package/build/src/rules/prefix_is_current_class.js

@@ -67,6 +67,14 @@ class PrefixIsCurrentClass extends _abap_rule_1.ABAPRule {
             // eslint-disable-next-line max-len
             extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-attribute-or-method`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
+            badExample: `METHOD run.
+  zcl_current=>helper( ).
+  me->do_work( ).
+ENDMETHOD.`,
+            goodExample: `METHOD run.
+  helper( ).
+  do_work( ).
+ENDMETHOD.`,
         };
     }
     getConfig() {

package/build/src/rules/static_call_via_instance.js

@@ -29,6 +29,12 @@ class StaticCallViaInstance extends _abap_rule_1.ABAPRule {
             shortDescription: `Static method call via instance variable`,
             extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-call-static-methods-through-instance-variables`,
             tags: [_irule_1.RuleTag.Styleguide],
+            badExample: `METHOD run.
+  NEW lcl_helper( )->static_method( ).
+ENDMETHOD.`,
+            goodExample: `METHOD run.
+  lcl_helper=>static_method( ).
+ENDMETHOD.`,
         };
     }
     getConfig() {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.119.48",
+    "version": "2.119.50",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",