@abaplint/core 2.119.45 → 2.119.46

package/build/src/abap/5_syntax/expressions/select.js

@@ -50,7 +50,7 @@ const _syntax_input_1 = require("../_syntax_input");
 const version_1 = require("../../../version");
 const isSimple = /^\w+$/;
 class Select {
-    static runSyntax(node, input, skipImplicitInto = false) {
+    static runSyntax(node, input, skipImplicitInto = false, selectLoop = false) {
         var _a;
         const token = node.getFirstToken();
         let from = node.findDirectExpression(Expressions.SQLFrom);
@@ -109,6 +109,14 @@ class Select {
             sql_source_1.SQLSource.runSyntax(s, input);
         }
         for (const up of node.findDirectExpressions(Expressions.SQLUpTo)) {
+            if (intoExpression
+                && this.isStrictMode(node, input)
+                && (selectLoop === false || input.scope.getLanguageVersion() === version_1.LanguageVersion.Cloud)
+                && from.getFirstToken().getStart().isBefore(up.getFirstToken().getStart())
+                && up.getFirstToken().getStart().isBefore(intoExpression.getFirstToken().getStart())) {
+                const message = `The addition "UP TO n ROWS" must only be placed after the INTO/APPENDING clause.`;
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, up.getFirstToken(), message));
+            }
             for (const s of up.findDirectExpressions(Expressions.SQLSource)) {
                 sql_source_1.SQLSource.runSyntax(s, input);
             }
@@ -134,7 +142,7 @@ class Select {
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, orderBy.getFirstToken(), message));
             }
         }
-        if (this.isStrictMode(node)) {
+        if (this.isStrictMode(node, input)) {
             this.strictModeChecks(node, input);
         }
         if (input.scope.getType() === _scope_type_1.ScopeType.OpenSQL) {
@@ -142,7 +150,11 @@ class Select {
         }
     }
     // there are multiple rules, but gotta start somewhere
-    static isStrictMode(node) {
+    static isStrictMode(node, input) {
+        // strict OpenSQL is always required in the cloud language version
+        if (input.scope.getLanguageVersion() === version_1.LanguageVersion.Cloud) {
+            return true;
+        }
         const into = node.findDirectExpressionsMulti([Expressions.SQLIntoList, Expressions.SQLIntoStructure, Expressions.SQLIntoTable])[0];
         const where = node.findDirectExpression(Expressions.SQLCond);
         // INTO is after WHERE

package/build/src/abap/5_syntax/statements/delete_internal.js

@@ -54,8 +54,9 @@ class DeleteInternal {
             const localVariable = input.scope.findVariable(target.concatTokens());
             if (localVariable === undefined && node.getChildren().length === 5 && node.getChildren()[2].concatTokens().toUpperCase() === "FROM") {
                 // it might be a database table
-                tabl = (_a = input.scope.getDDIC()) === null || _a === void 0 ? void 0 : _a.lookupTableOrView(target.concatTokens());
-                if (tabl) {
+                const found = (_a = input.scope.getDDIC()) === null || _a === void 0 ? void 0 : _a.lookupTableOrView(target.concatTokens());
+                if ((found === null || found === void 0 ? void 0 : found.object) !== undefined) {
+                    tabl = found;
                     input.scope.getDDICReferences().addUsing(input.scope.getParentObj(), { object: tabl.object });
                 }
             }
@@ -63,7 +64,7 @@ class DeleteInternal {
                 targetType = target_1.Target.runSyntax(target, input);
                 if (node.findDirectTokenByText("TABLE") === undefined
                     && node.findDirectTokenByText("ADJACENT") === undefined
-                    && node.findDirectTokenByText("FROM")
+                    && (node.findDirectTokenByText("FROM") || node.findDirectTokenByText("INDEX"))
                     && targetType instanceof basic_1.TableType
                     && targetType.getAccessType() === basic_1.TableAccessType.hashed) {
                     const message = "Implicit or explicit index operation on hashed table is not possible";

package/build/src/abap/5_syntax/statements/loop.js

@@ -99,6 +99,14 @@ class Loop {
         }
         const targetConcat = loopTarget === null || loopTarget === void 0 ? void 0 : loopTarget.concatTokens().toUpperCase();
         const topType = sourceType; // todo: refactor topType vs sourceType vs rowType
+        if (topType instanceof basic_1.TableType
+            && topType.getAccessType() === basic_1.TableAccessType.hashed
+            && node.findDirectTokenByText("USING") === undefined
+            && (node.findDirectTokenByText("FROM") || node.findDirectTokenByText("TO"))) {
+            const message = "Implicit or explicit index operation on hashed table is not possible";
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+            return;
+        }
         if (sourceType instanceof basic_1.TableType) {
             rowType = sourceType.getRowType();
             sourceType = rowType;

package/build/src/abap/5_syntax/statements/modify_internal.js

@@ -58,6 +58,13 @@ class ModifyInternal {
                 // ok
             }
             else if (targetType instanceof basic_1.TableType) {
+                if (node.findDirectTokenByText("TABLE") === undefined
+                    && node.findDirectTokenByText("INDEX")
+                    && targetType.getAccessType() === basic_1.TableAccessType.hashed) {
+                    const message = "Implicit or explicit index operation on hashed table is not possible";
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                    return;
+                }
                 if (node.findDirectTokenByText("TABLE")
                     && node.findDirectTokenByText("INDEX")
                     && targetType.isWithHeader() === false) {

package/build/src/abap/5_syntax/statements/select_loop.js

@@ -40,7 +40,7 @@ class SelectLoop {
     runSyntax(node, input) {
         const s = node.findDirectExpression(Expressions.Select);
         if (s) {
-            select_1.Select.runSyntax(s, input);
+            select_1.Select.runSyntax(s, input, false, true);
         }
     }
 }

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.js"
-        return "2.119.45";
+        return "2.119.46";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.119.45",
+    "version": "2.119.46",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",