@abaplint/core 2.119.23 → 2.119.25

package/build/src/rules/easy_to_find_messages.js

@@ -19,12 +19,12 @@ class EasyToFindMessages {
             key: "easy_to_find_messages",
             title: "Easy to find messages",
             shortDescription: `Make messages easy to find`,
-            extendedInformation: `All messages must be statically referenced exactly once
-
-Only MESSAGE and RAISE statments are counted as static references
-
-Also see rule "message_exists"
-
+            extendedInformation: `All messages must be statically referenced exactly once
+
+Only MESSAGE and RAISE statments are counted as static references
+
+Also see rule "message_exists"
+
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#make-messages-easy-to-find`,
             tags: [_irule_1.RuleTag.Styleguide],
         };

package/build/src/rules/empty_event.js

@@ -23,13 +23,13 @@ class EmptyEvent extends _abap_rule_1.ABAPRule {
             shortDescription: `Empty selection screen or list processing event block`,
             extendedInformation: ``,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `
-INITIALIZATION.
-  WRITE 'hello'.
+            badExample: `
+INITIALIZATION.
+  WRITE 'hello'.
 END-OF-SELECTION.`,
-            goodExample: `
-START-OF-SELECTION.
-  PERFORM sdf.
+            goodExample: `
+START-OF-SELECTION.
+  PERFORM sdf.
   COMMIT WORK.`,
         };
     }

package/build/src/rules/empty_line_in_statement.js

@@ -27,8 +27,8 @@ class EmptyLineinStatement extends _abap_rule_1.ABAPRule {
             key: "empty_line_in_statement",
             title: "Find empty lines in statements",
             shortDescription: `Checks that statements do not contain empty lines.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-obsess-with-separating-blank-lines
-
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-obsess-with-separating-blank-lines
+
 https://docs.abapopenchecks.org/checks/41/`,
             tags: [_irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
             badExample: `WRITE\n\nhello.`,

package/build/src/rules/empty_structure.js

@@ -46,13 +46,13 @@ class EmptyStructure extends _abap_rule_1.ABAPRule {
             shortDescription: `Checks that the code does not contain empty blocks.`,
             extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#no-empty-if-branches`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
-            badExample: `IF foo = bar.
-ENDIF.
-
-DO 2 TIMES.
+            badExample: `IF foo = bar.
+ENDIF.
+
+DO 2 TIMES.
 ENDDO.`,
-            goodExample: `LOOP AT itab WHERE qty = 0 OR date > sy-datum.
-ENDLOOP.
+            goodExample: `LOOP AT itab WHERE qty = 0 OR date > sy-datum.
+ENDLOOP.
 result = xsdbool( sy-subrc = 0 ).`,
         };
     }

package/build/src/rules/exit_or_check.js

@@ -24,10 +24,10 @@ class ExitOrCheck extends _abap_rule_1.ABAPRule {
         return {
             key: "exit_or_check",
             title: "Find EXIT or CHECK outside loops",
-            shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
+            shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
 Use RETURN to leave procesing blocks instead.`,
-            extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
-https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
+            extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
+https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-return`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
         };

package/build/src/rules/expand_macros.js

@@ -21,12 +21,12 @@ class ExpandMacros extends _abap_rule_1.ABAPRule {
             key: "expand_macros",
             title: "Expand Macros",
             shortDescription: `Allows expanding macro calls with quick fixes`,
-            extendedInformation: `Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
-
+            extendedInformation: `Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
+
 Note that macros/DEFINE cannot be used in the ABAP Cloud programming model`,
-            badExample: `DEFINE _hello.
-  WRITE 'hello'.
-END-OF-DEFINITION.
+            badExample: `DEFINE _hello.
+  WRITE 'hello'.
+END-OF-DEFINITION.
 _hello.`,
             goodExample: `WRITE 'hello'.`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Upport],

package/build/src/rules/exporting.js

@@ -22,7 +22,7 @@ class Exporting extends _abap_rule_1.ABAPRule {
             shortDescription: `Detects EXPORTING statements which can be omitted.`,
             badExample: `call_method( EXPORTING foo = bar ).`,
             goodExample: `call_method( foo = bar ).`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting
 https://docs.abapopenchecks.org/checks/30/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/forbidden_identifier.js

@@ -26,7 +26,7 @@ class ForbiddenIdentifier extends _abap_rule_1.ABAPRule {
             key: "forbidden_identifier",
             title: "Forbidden Identifier",
             shortDescription: `Forbid use of specified identifiers, list of regex.`,
-            extendedInformation: `Used in the transpiler to find javascript keywords in ABAP identifiers,
+            extendedInformation: `Used in the transpiler to find javascript keywords in ABAP identifiers,
 https://github.com/abaplint/transpiler/blob/bda94b8b56e2b7f2f87be2168f12361aa530220e/packages/transpiler/src/validation.ts#L44`,
             tags: [_irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/forbidden_void_type.js

@@ -28,8 +28,8 @@ class ForbiddenVoidType {
             key: "forbidden_void_type",
             title: "Forbidden Void Types",
             shortDescription: `Avoid usage of specified void types.`,
-            extendedInformation: `Inspiration:
-BOOLEAN, BOOLE_D, CHAR01, CHAR1, CHAR10, CHAR12, CHAR128, CHAR2, CHAR20, CHAR4, CHAR70,
+            extendedInformation: `Inspiration:
+BOOLEAN, BOOLE_D, CHAR01, CHAR1, CHAR10, CHAR12, CHAR128, CHAR2, CHAR20, CHAR4, CHAR70,
 DATS, TIMS, DATUM, FLAG, INT4, NUMC3, NUMC4, SAP_BOOL, TEXT25, TEXT80, X255, XFELD`,
         };
     }

package/build/src/rules/fully_type_itabs.js

@@ -20,9 +20,9 @@ class FullyTypeITabs extends _abap_rule_1.ABAPRule {
             key: "fully_type_itabs",
             title: "Fully type internal tables",
             shortDescription: `No implict table types or table keys`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-the-right-table-type
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-the-right-table-type
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key`,
-            badExample: `DATA lt_foo TYPE TABLE OF ty.
+            badExample: `DATA lt_foo TYPE TABLE OF ty.
 DATA lt_bar TYPE STANDARD TABLE OF ty.`,
             goodExample: `DATA lt_foo TYPE STANDARD TABLE OF ty WITH EMPTY KEY.`,
             tags: [_irule_1.RuleTag.SingleFile],

package/build/src/rules/function_module_recommendations.js

@@ -14,25 +14,54 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
          * @uniqueItems true
          */
         this.recommendations = [
+            { name: "CALCULATE_HASH_FOR_CHAR", replace: "use CL_ABAP_MESSAGE_DIGEST" },
             { name: "CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_HMAC or CL_ABAP_MESSAGE_DIGEST" },
             { name: "CCU_TIMESTAMP_DIFFERENCE", replace: "use CL_ABAP_TSTMP" },
+            { name: "CLPB_EXPORT", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "CLPB_IMPORT", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "CONVERT_DATE_TO_EXTERNAL", replace: "use CL_ABAP_DATFM" },
             { name: "CONVERT_TIME_INPUT", replace: "use CL_ABAP_TIMEFM" },
+            { name: "DOWNLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "ECATT_CONV_XSTRING_TO_STRING", replace: "use CL_BINARY_CONVERT" },
             { name: "F4_FILENAME", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "FUNCTION_EXISTS", replace: "surround with try-catch CX_SY_DYN_CALL_ILLEGAL_METHOD instead" },
+            { name: "GUI_CREATE_DIRECTORY", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_DELETE_FILE", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "GUI_DOWNLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_EXEC", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_FB_USAGE", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_FILE_LOAD_DIALOG", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_FILE_SAVE_DIALOG", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_GET_DESKTOP_INFO", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_GET_FILE_INFO", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_GET_REGVALUE", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_MULTIPLE_FILE_LOAD_DIALOG", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_REMOVE_DIRECTORY", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_RUN", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_SET_REGVALUE", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "GUI_UPLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_VSS_DOWNLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "GUI_VSS_UPLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "GUID_CREATE", replace: "use CL_SYSTEM_UUID" },
             { name: "IGN_TIMESTAMP_DIFFERENCE", replace: "use CL_ABAP_TSTMP" },
             { name: "IGN_TIMESTAMP_PLUSMINUS", replace: "use CL_ABAP_TSTMP" },
             { name: "ISM_SD_GET_PRICING_CONDITIONS", replace: "use CL_PRC_RESULT_FACTORY as per note 2220005" },
             { name: "JOB_CREATE", replace: "use CL_BP_ABAP_JOB" },
             { name: "JOB_SUBMIT", replace: "use CL_BP_ABAP_JOB" },
+            { name: "MD5_CALCULATE_HASH_FOR_CHAR", replace: "use CL_ABAP_MESSAGE_DIGEST" },
+            { name: "MD5_CALCULATE_HASH_FOR_RAW", replace: "use CL_ABAP_MESSAGE_DIGEST" },
+            { name: "POPUP_TO_CONFIRM_LOSS_OF_DATA", replace: "use POPUP_TO_CONFIRM" },
             { name: "POPUP_TO_CONFIRM_STEP", replace: "use POPUP_TO_CONFIRM" },
+            { name: "POPUP_TO_CONFIRM_WITH_MESSAGE", replace: "use POPUP_TO_CONFIRM" },
+            { name: "POPUP_TO_CONFIRM_WITH_VALUE", replace: "use POPUP_TO_CONFIRM" },
+            { name: "POPUP_TO_CONFIRM_WITH_VALUE_2", replace: "use POPUP_TO_CONFIRM" },
             { name: "POPUP_TO_DECIDE", replace: "use POPUP_TO_CONFIRM" },
+            { name: "POPUP_TO_DECIDE_INFO", replace: "use POPUP_TO_CONFIRM" },
+            { name: "POPUP_TO_DECIDE_WITH_MESSAGE", replace: "use POPUP_TO_CONFIRM" },
             { name: "POPUP_TO_GET_VALUE", replace: "use POPUP_GET_VALUES" },
             { name: "QF05_RANDOM_INTEGER", replace: "use CL_ABAP_RANDOM_INT" },
+            { name: "REGISTRY_GET", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "REGISTRY_SET", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "REUSE_ALV_GRID_DISPLAY", replace: "use CL_SALV_TABLE=>FACTORY or CL_GUI_ALV_GRID" },
             { name: "ROUND", replace: "use built in function: round()" },
             { name: "SAPGUI_PROGRESS_INDICATOR", replace: "use CL_PROGRESS_INDICATOR" },
@@ -42,7 +71,17 @@ class FunctionModuleRecommendationsConf extends _basic_rule_config_1.BasicRuleCo
             { name: "SSFC_BASE64_DECODE", replace: "use class CL_HTTP_UTILITY methods" },
             { name: "SSFC_BASE64_ENCODE", replace: "use class CL_HTTP_UTILITY methods" },
             { name: "SUBST_GET_FILE_LIST", replace: "see note 1686357" },
+            { name: "SYSTEM_GET_UNIQUE_ID", replace: "use CL_SYSTEM_UUID" },
+            { name: "SYSTEM_UUID_C_CREATE", replace: "use CL_SYSTEM_UUID" },
+            { name: "UPLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "WS_DOWNLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "WS_EXECUTE", replace: "use CL_GUI_FRONTEND_SERVICES" },
             { name: "WS_FILENAME_GET", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "WS_FILE_ATTRIB", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "WS_FILE_COPY", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "WS_FILE_DELETE", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "WS_QUERY", replace: "use CL_GUI_FRONTEND_SERVICES" },
+            { name: "WS_UPLOAD", replace: "use CL_GUI_FRONTEND_SERVICES" },
         ];
     }
 }

package/build/src/rules/functional_writing.js

@@ -28,26 +28,26 @@ class FunctionalWriting extends _abap_rule_1.ABAPRule {
             key: "functional_writing",
             title: "Use functional writing",
             shortDescription: `Detects usage of call method when functional style calls can be used.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
 https://docs.abapopenchecks.org/checks/07/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
-            badExample: `CALL METHOD zcl_class=>method( ).
-CALL METHOD cl_abap_typedescr=>describe_by_name
-  EXPORTING
-    p_name         = 'NAME'
-  RECEIVING
-    p_descr_ref    = lr_typedescr
-  EXCEPTIONS
-    type_not_found = 1
+            badExample: `CALL METHOD zcl_class=>method( ).
+CALL METHOD cl_abap_typedescr=>describe_by_name
+  EXPORTING
+    p_name         = 'NAME'
+  RECEIVING
+    p_descr_ref    = lr_typedescr
+  EXCEPTIONS
+    type_not_found = 1
     OTHERS         = 2.`,
-            goodExample: `zcl_class=>method( ).
-cl_abap_typedescr=>describe_by_name(
-  EXPORTING
-    p_name         = 'NAME'
-  RECEIVING
-    p_descr_ref    = lr_typedescr
-  EXCEPTIONS
-    type_not_found = 1
+            goodExample: `zcl_class=>method( ).
+cl_abap_typedescr=>describe_by_name(
+  EXPORTING
+    p_name         = 'NAME'
+  RECEIVING
+    p_descr_ref    = lr_typedescr
+  EXCEPTIONS
+    type_not_found = 1
     OTHERS         = 2 ).`,
         };
     }

package/build/src/rules/global_class.js

@@ -20,16 +20,16 @@ class GlobalClass extends _abap_rule_1.ABAPRule {
             key: "global_class",
             title: "Global class checks",
             shortDescription: `Checks related to global classes`,
-            extendedInformation: `* global classes must be in own files
-
-* file names must match class name
-
-* file names must match interface name
-
-* global classes must be global definitions
-
-* global interfaces must be global definitions
-
+            extendedInformation: `* global classes must be in own files
+
+* file names must match class name
+
+* file names must match interface name
+
+* global classes must be global definitions
+
+* global interfaces must be global definitions
+
 * global FOR TESTING, must have CATEGORY = 05 in the XML`,
             tags: [_irule_1.RuleTag.Syntax],
         };

package/build/src/rules/identical_conditions.js

@@ -33,21 +33,21 @@ class IdenticalConditions extends _abap_rule_1.ABAPRule {
         return {
             key: "identical_conditions",
             title: "Identical conditions",
-            shortDescription: `Find identical conditions in IF + CASE + WHILE etc
-
+            shortDescription: `Find identical conditions in IF + CASE + WHILE etc
+
 Prerequsites: code is pretty printed with identical cAsE`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `IF foo = bar OR 1 = a OR foo = bar.
-ENDIF.
-CASE bar.
-  WHEN '1'.
-  WHEN 'A' OR '1'.
+            badExample: `IF foo = bar OR 1 = a OR foo = bar.
+ENDIF.
+CASE bar.
+  WHEN '1'.
+  WHEN 'A' OR '1'.
 ENDCASE.`,
-            goodExample: `IF foo = bar OR 1 = a.
-ENDIF.
-CASE bar.
-  WHEN '1'.
-  WHEN 'A'.
+            goodExample: `IF foo = bar OR 1 = a.
+ENDIF.
+CASE bar.
+  WHEN '1'.
+  WHEN 'A'.
 ENDCASE.`,
         };
     }

package/build/src/rules/identical_contents.js

@@ -21,23 +21,23 @@ class IdenticalContents extends _abap_rule_1.ABAPRule {
             key: "identical_contents",
             title: "Identical contents",
             shortDescription: `Find identical contents in blocks inside IFs, both in the beginning and in the end.`,
-            extendedInformation: `
-Prerequsites: code is pretty printed with identical cAsE
-
+            extendedInformation: `
+Prerequsites: code is pretty printed with identical cAsE
+
 Chained statments are ignored`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `IF foo = bar.
-  WRITE 'bar'.
-  WRITE 'world'.
-ELSE.
-  WRITE 'foo'.
-  WRITE 'world'.
+            badExample: `IF foo = bar.
+  WRITE 'bar'.
+  WRITE 'world'.
+ELSE.
+  WRITE 'foo'.
+  WRITE 'world'.
 ENDIF.`,
-            goodExample: `IF foo = bar.
-  WRITE 'bar'.
-ELSE.
-  WRITE 'foo'.
-ENDIF.
+            goodExample: `IF foo = bar.
+  WRITE 'bar'.
+ELSE.
+  WRITE 'foo'.
+ENDIF.
 WRITE 'world'.`,
         };
     }

package/build/src/rules/identical_descriptions.js

@@ -16,12 +16,12 @@ class IdenticalDescriptions {
             key: "identical_descriptions",
             title: "Identical descriptions",
             shortDescription: `Searches for objects with the same type and same description`,
-            extendedInformation: `Case insensitive
-
-Only checks the master language descriptions
-
-Dependencies are skipped
-
+            extendedInformation: `Case insensitive
+
+Only checks the master language descriptions
+
+Dependencies are skipped
+
 Works for: INTF, CLAS, DOMA, DTEL, FUNC in same FUGR`,
             tags: [],
         };

package/build/src/rules/identical_move.js

@@ -21,9 +21,9 @@ class IdenticalMove extends _abap_rule_1.ABAPRule {
             title: "Identical move",
             shortDescription: `Moving the same value from left to right or right to left is redundant.`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `DATA lv_value TYPE i.
+            badExample: `DATA lv_value TYPE i.
 lv_value = lv_value.`,
-            goodExample: `DATA lv_value TYPE i.
+            goodExample: `DATA lv_value TYPE i.
 lv_value = 5.`,
         };
     }

package/build/src/rules/if_in_if.js

@@ -21,43 +21,43 @@ class IfInIf extends _abap_rule_1.ABAPRule {
             key: "if_in_if",
             title: "IF in IF",
             shortDescription: `Detects nested ifs which can be refactored.`,
-            extendedInformation: `
-Directly nested IFs without ELSE can be refactored to a single condition using AND.
-
-ELSE condtions with directly nested IF refactored to ELSEIF, quickfixes are suggested for this case.
-
-https://docs.abapopenchecks.org/checks/01/
+            extendedInformation: `
+Directly nested IFs without ELSE can be refactored to a single condition using AND.
+
+ELSE condtions with directly nested IF refactored to ELSEIF, quickfixes are suggested for this case.
+
+https://docs.abapopenchecks.org/checks/01/
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#keep-the-nesting-depth-low`,
-            badExample: `IF condition1.
-  IF condition2.
-    ...
-  ENDIF.
-ENDIF.
-
-IF condition1.
-  ...
-ELSE.
-  IF condition2.
-    ...
-  ENDIF.
+            badExample: `IF condition1.
+  IF condition2.
+    ...
+  ENDIF.
+ENDIF.
+
+IF condition1.
+  ...
+ELSE.
+  IF condition2.
+    ...
+  ENDIF.
 ENDIF.`,
-            goodExample: `IF ( condition1 ) AND ( condition2 ).
-  ...
-ENDIF.
-
-IF condition1.
-  ...
-ELSEIF condition2.
-  ...
-ENDIF.
-
-CASE variable.
-  WHEN value1.
-  ...
-  WHEN value2.
-    IF condition2.
-      ...
-    ENDIF.
+            goodExample: `IF ( condition1 ) AND ( condition2 ).
+  ...
+ENDIF.
+
+IF condition1.
+  ...
+ELSEIF condition2.
+  ...
+ENDIF.
+
+CASE variable.
+  WHEN value1.
+  ...
+  WHEN value2.
+    IF condition2.
+      ...
+    ENDIF.
 ENDCASE.`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
         };

package/build/src/rules/implement_methods.js

@@ -110,9 +110,9 @@ class ImplementMethods extends _abap_rule_1.ABAPRule {
         for (const i of ((_a = file.getStructure()) === null || _a === void 0 ? void 0 : _a.findAllStatements(Statements.ClassImplementation)) || []) {
             const name = (_b = i.findFirstExpression(Expressions.ClassName)) === null || _b === void 0 ? void 0 : _b.getFirstToken().getStr().toUpperCase();
             if (name === impl.identifier.getName().toUpperCase()) {
-                return edit_helper_1.EditHelper.insertAt(file, i.getLastToken().getEnd(), `
-  METHOD ${methodName.toLowerCase()}.
-    RETURN. " todo, implement method
+                return edit_helper_1.EditHelper.insertAt(file, i.getLastToken().getEnd(), `
+  METHOD ${methodName.toLowerCase()}.
+    RETURN. " todo, implement method
   ENDMETHOD.`);
             }
         }

package/build/src/rules/implicit_start_of_selection.js

@@ -22,13 +22,13 @@ class ImplicitStartOfSelection extends _abap_rule_1.ABAPRule {
             key: "implicit_start_of_selection",
             title: "Implicit START-OF-SELECTION",
             shortDescription: `Add explicit selection screen event handling`,
-            extendedInformation: `Only runs for executable programs
-
+            extendedInformation: `Only runs for executable programs
+
 https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapstart-of-selection.htm`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `REPORT zfoo.
+            badExample: `REPORT zfoo.
 WRITE 'hello'.`,
-            goodExample: `START-OF-SELECTION.
+            goodExample: `START-OF-SELECTION.
   WRITE 'hello'.`,
         };
     }

package/build/src/rules/in_statement_indentation.js

@@ -31,19 +31,19 @@ class InStatementIndentation extends _abap_rule_1.ABAPRule {
             key: "in_statement_indentation",
             title: "In-statement indentation",
             shortDescription: "Checks alignment within statements which span multiple lines.",
-            extendedInformation: `Lines following the first line should be indented once (2 spaces).
-
-For block declaration statements, lines after the first should be indented an additional time (default: +2 spaces)
+            extendedInformation: `Lines following the first line should be indented once (2 spaces).
+
+For block declaration statements, lines after the first should be indented an additional time (default: +2 spaces)
 to distinguish them better from code within the block.`,
-            badExample: `IF 1 = 1
-  AND 2 = 2.
-  WRITE 'hello' &&
-  'world'.
+            badExample: `IF 1 = 1
+  AND 2 = 2.
+  WRITE 'hello' &&
+  'world'.
 ENDIF.`,
-            goodExample: `IF 1 = 1
-    AND 2 = 2.
-  WRITE 'hello' &&
-    'world'.
+            goodExample: `IF 1 = 1
+    AND 2 = 2.
+  WRITE 'hello' &&
+    'world'.
 ENDIF.`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/indentation.js

@@ -41,23 +41,23 @@ class Indentation extends _abap_rule_1.ABAPRule {
             title: "Indentation",
             shortDescription: `Checks indentation`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
-            badExample: `CLASS lcl DEFINITION.
-PRIVATE SECTION.
-METHODS constructor.
-ENDCLASS.
-
-CLASS lcl IMPLEMENTATION.
-METHOD constructor.
-ENDMETHOD.
+            badExample: `CLASS lcl DEFINITION.
+PRIVATE SECTION.
+METHODS constructor.
+ENDCLASS.
+
+CLASS lcl IMPLEMENTATION.
+METHOD constructor.
+ENDMETHOD.
 ENDCLASS.`,
-            goodExample: `CLASS lcl DEFINITION.
-  PRIVATE SECTION.
-    METHODS constructor.
-ENDCLASS.
-
-CLASS lcl IMPLEMENTATION.
-  METHOD constructor.
-  ENDMETHOD.
+            goodExample: `CLASS lcl DEFINITION.
+  PRIVATE SECTION.
+    METHODS constructor.
+ENDCLASS.
+
+CLASS lcl IMPLEMENTATION.
+  METHOD constructor.
+  ENDMETHOD.
 ENDCLASS.`,
         };
     }

package/build/src/rules/intf_referencing_clas.js

@@ -26,9 +26,9 @@ class IntfReferencingClas {
             key: "intf_referencing_clas",
             title: "INTF referencing CLAS",
             shortDescription: `Interface contains references to class`,
-            extendedInformation: `Only global interfaces are checked.
-      Only first level references are checked.
-      Exception class references are ignored.
+            extendedInformation: `Only global interfaces are checked.
+      Only first level references are checked.
+      Exception class references are ignored.
       Void references are ignored.`,
         };
     }

package/build/src/rules/invalid_table_index.js

@@ -22,9 +22,9 @@ class InvalidTableIndex extends _abap_rule_1.ABAPRule {
             title: "Invalid Table Index",
             shortDescription: `Issues error for constant table index zero, as ABAP starts from 1`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
-            badExample: `DATA(first) = table[ 0 ].
+            badExample: `DATA(first) = table[ 0 ].
 READ TABLE gt_stack ASSIGNING <ls_stack> INDEX 0.`,
-            goodExample: `DATA(first) = table[ 1 ].
+            goodExample: `DATA(first) = table[ 1 ].
 READ TABLE gt_stack ASSIGNING <ls_stack> INDEX 1.`,
         };
     }

package/build/src/rules/line_break_style.js

@@ -15,8 +15,8 @@ class LineBreakStyle {
         return {
             key: "line_break_style",
             title: "Makes sure line breaks are consistent in the ABAP code",
-            shortDescription: `Enforces LF as newlines in ABAP files
-
+            shortDescription: `Enforces LF as newlines in ABAP files
+
 abapGit does not work with CRLF`,
             tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/line_length.js

@@ -24,7 +24,7 @@ class LineLength extends _abap_rule_1.ABAPRule {
             key: "line_length",
             title: "Line length",
             shortDescription: `Detects lines exceeding the provided maximum length.`,
-            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#stick-to-a-reasonable-line-length
+            extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#stick-to-a-reasonable-line-length
 https://docs.abapopenchecks.org/checks/04/`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };