@abaplint/core 2.119.21 → 2.119.23

package/build/src/objects/_abap_object.js

@@ -119,16 +119,16 @@ class ABAPObject extends _abstract_object_1.AbstractObject {
         }
     }
     findTextsTranslations(parsed) {
-        var _a, _b, _c, _d, _e, _f;
+        var _a, _b, _c, _d, _e, _f, _g;
         this.textsTranslations = [];
-        const values = (_c = (_b = (_a = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _a === void 0 ? void 0 : _a["asx:abap"]) === null || _b === void 0 ? void 0 : _b["asx:values"].I18N_TPOOL) === null || _c === void 0 ? void 0 : _c.item;
+        const values = (_d = (_c = (_b = (_a = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _a === void 0 ? void 0 : _a["asx:abap"]) === null || _b === void 0 ? void 0 : _b["asx:values"]) === null || _c === void 0 ? void 0 : _c.I18N_TPOOL) === null || _d === void 0 ? void 0 : _d.item;
         if (values === undefined) {
             return;
         }
         for (const langItem of (0, xml_utils_1.xmlToArray)(values)) {
             const textElements = {};
-            for (const item of (0, xml_utils_1.xmlToArray)((_d = langItem.TEXTPOOL) === null || _d === void 0 ? void 0 : _d.item)) {
-                const key = (_f = ((_e = item.KEY) !== null && _e !== void 0 ? _e : item.ID)) === null || _f === void 0 ? void 0 : _f.toUpperCase();
+            for (const item of (0, xml_utils_1.xmlToArray)((_e = langItem.TEXTPOOL) === null || _e === void 0 ? void 0 : _e.item)) {
+                const key = (_g = ((_f = item.KEY) !== null && _f !== void 0 ? _f : item.ID)) === null || _g === void 0 ? void 0 : _g.toUpperCase();
                 if (key !== undefined) {
                     textElements[key] = { entry: (0, xml_utils_1.unescape)(item.ENTRY), maxLength: parseInt(item.LENGTH, 10) };
                 }

package/build/src/objects/transaction.js

@@ -38,23 +38,22 @@ class Transaction extends _abstract_object_1.AbstractObject {
         return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.textsTranslations;
     }
     parse() {
-        var _a, _b, _c, _d;
+        var _a, _b, _c, _d, _e, _f;
         if (this.parsedXML) {
             return { updated: false, runtime: 0 };
         }
         const start = Date.now();
         this.parsedXML = {};
         const parsed = super.parseRaw2();
-        if (parsed === undefined
-            || parsed.abapGit === undefined
-            || parsed.abapGit["asx:abap"]["asx:values"] === undefined) {
+        const values = (_b = (_a = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _a === void 0 ? void 0 : _a["asx:abap"]) === null || _b === void 0 ? void 0 : _b["asx:values"];
+        if (values === undefined) {
             return { updated: false, runtime: 0 };
         }
-        this.parsedXML.description = (_a = parsed.abapGit["asx:abap"]["asx:values"].TSTCT) === null || _a === void 0 ? void 0 : _a.TTEXT;
-        this.parsedXML.programName = (_b = parsed.abapGit["asx:abap"]["asx:values"].TSTC) === null || _b === void 0 ? void 0 : _b.PGMNA;
-        this.parsedXML.cinfo = (_c = parsed.abapGit["asx:abap"]["asx:values"].TSTC) === null || _c === void 0 ? void 0 : _c.CINFO;
+        this.parsedXML.description = (_c = values.TSTCT) === null || _c === void 0 ? void 0 : _c.TTEXT;
+        this.parsedXML.programName = (_d = values.TSTC) === null || _d === void 0 ? void 0 : _d.PGMNA;
+        this.parsedXML.cinfo = (_e = values.TSTC) === null || _e === void 0 ? void 0 : _e.CINFO;
         this.parsedXML.textsTranslations = [];
-        for (const item of (0, xml_utils_1.xmlToArray)((_d = parsed.abapGit["asx:abap"]["asx:values"].I18N_TPOOL) === null || _d === void 0 ? void 0 : _d.TSTCT)) {
+        for (const item of (0, xml_utils_1.xmlToArray)((_f = values.I18N_TPOOL) === null || _f === void 0 ? void 0 : _f.TSTCT)) {
             this.parsedXML.textsTranslations.push({ language: item.SPRSL, description: item.TTEXT });
         }
         const end = Date.now();

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.119.21";
+        return "2.119.23";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/check_text_elements.js

@@ -59,11 +59,12 @@ class CheckTextElements {
                 }
             }
             for (const e of expressions) {
+                const mainNameSuffix = mainName !== undefined && mainName.toLowerCase() !== file.getFilename().toLowerCase() ? ", " + mainName : "";
                 if (e.get() instanceof Expressions.TextElement) {
                     const token = e.findFirstExpression(Expressions.TextElementKey).getFirstToken();
                     const key = token.getStr().toUpperCase();
                     if (texts[key] === undefined) {
-                        const message = `Text element "${key}" not found` + (mainName ? ", " + mainName : "");
+                        const message = `Text element "${key}" not found` + mainNameSuffix;
                         output.push(issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.conf.severity));
                     }
                 }
@@ -77,7 +78,7 @@ class CheckTextElements {
                         found = found.replace(/'/g, "''");
                     }
                     if (found === undefined) {
-                        const message = `Text element "${key}" not found` + (mainName ? ", " + mainName : "");
+                        const message = `Text element "${key}" not found` + mainNameSuffix;
                         output.push(issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.conf.severity));
                     }
                     else if (code !== "'" + found + "'"

package/build/src/rules/uncaught_exception.js

@@ -159,7 +159,29 @@ class UncaughtException extends _abap_rule_1.ABAPRule {
                     this.check(name, n, file);
                 }
             }
+            else if (r.referenceType === _reference_1.ReferenceType.ConstructorReference
+                && r.position.getStart().isAfter(start)
+                && r.position.getEnd().isBefore(end)
+                && r.resolved instanceof types_1.ClassDefinition) {
+                const method = this.findConstructor(r.resolved, scope);
+                for (const name of (method === null || method === void 0 ? void 0 : method.getRaising()) || []) {
+                    this.check(name, n, file);
+                }
+            }
+        }
+    }
+    findConstructor(def, scope) {
+        for (const method of def.getMethodDefinitions().getAll()) {
+            if (method instanceof types_1.MethodDefinition && method.getName().toUpperCase() === "CONSTRUCTOR") {
+                return method;
+            }
+        }
+        const sup = def.getSuperClass();
+        if (sup === undefined) {
+            return undefined;
         }
+        const superDefinition = scope === null || scope === void 0 ? void 0 : scope.findClassDefinition(sup);
+        return superDefinition ? this.findConstructor(superDefinition, scope) : undefined;
     }
     addFromTryStructure(s) {
         if (this.sinked === undefined) {

package/build/src/rules/xml_consistency.js

@@ -7,7 +7,13 @@ const Objects = require("../objects");
 const _abap_object_1 = require("../objects/_abap_object");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const fast_xml_parser_1 = require("fast-xml-parser");
+const severity_1 = require("../severity");
 class XMLConsistencyConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        /** Problem severity for text and translation length checks */
+        this.textAndTranslationLengthSeverity = severity_1.Severity.Error;
+    }
 }
 exports.XMLConsistencyConf = XMLConsistencyConf;
 class XMLConsistency {
@@ -130,7 +136,7 @@ class XMLConsistency {
         const max = typeof maxLength === "number" ? maxLength : parseInt(maxLength, 10);
         if (text.length > max) {
             const prefix = lang ? `[${lang}] ` : "";
-            return issue_1.Issue.atRow(file, 1, `${prefix}${fieldName} "${text}" exceeds maximum length of ${max} characters (actual: ${text.length})`, this.getMetadata().key, this.conf.severity);
+            return issue_1.Issue.atRow(file, 1, `${prefix}${fieldName} "${text}" exceeds maximum length of ${max} characters (actual: ${text.length})`, this.getMetadata().key, this.conf.textAndTranslationLengthSeverity);
         }
         return undefined;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.119.21",
+    "version": "2.119.23",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",