@abaplint/core 2.119.2 → 2.119.3

package/build/abaplint.d.ts

@@ -5942,6 +5942,7 @@ declare abstract class ScopeData {
 export declare enum ScopeType {
     BuiltIn = "_builtin",
     Dummy = "_dummy",
+    SelectionEvent = "selection_event",
     Global = "_global",
     Program = "_program",
     TypePool = "_type_pool",
@@ -7071,6 +7072,10 @@ export declare class SyntaxLogic {
      */
     private updateScopeStructure;
     private updateScopeStatement;
+    private updateSelectionEventScope;
+    private opensSelectionEventScope;
+    private isSelectionEventBoundary;
+    private isSelectionEventBoundaryStructure;
 }
 
 declare class SystemCall implements IStatement {

package/build/src/abap/5_syntax/_scope_type.js

@@ -5,6 +5,8 @@ var ScopeType;
 (function (ScopeType) {
     ScopeType["BuiltIn"] = "_builtin";
     ScopeType["Dummy"] = "_dummy";
+    // definitions inside this one are local
+    ScopeType["SelectionEvent"] = "selection_event";
     ScopeType["Global"] = "_global";
     ScopeType["Program"] = "_program";
     ScopeType["TypePool"] = "_type_pool";

package/build/src/abap/5_syntax/syntax.js

@@ -152,6 +152,7 @@ const commit_entities_1 = require("./statements/commit_entities");
 const _syntax_input_1 = require("./_syntax_input");
 const assert_error_1 = require("./assert_error");
 const field_group_1 = require("./statements/field_group");
+const stuff_1 = require("../../stuff");
 // -----------------------------------
 const map = {};
 function addToMap(handler) {
@@ -405,6 +406,9 @@ class SyntaxLogic {
     updateScopeStructure(node) {
         const filename = this.currentFile.getFilename();
         const stru = node.get();
+        if (this.scope.getType() === _scope_type_1.ScopeType.SelectionEvent && this.isSelectionEventBoundaryStructure(stru)) {
+            this.scope.pop(node.getFirstToken().getStart());
+        }
         const input = {
             scope: this.scope,
             filename,
@@ -444,6 +448,7 @@ class SyntaxLogic {
     updateScopeStatement(node) {
         const filename = this.currentFile.getFilename();
         const s = node.get();
+        this.updateSelectionEventScope(node);
         const input = {
             scope: this.scope,
             filename,
@@ -489,6 +494,27 @@ class SyntaxLogic {
             }
         }
     }
+    updateSelectionEventScope(node) {
+        const statement = node.get();
+        if (this.scope.getType() === _scope_type_1.ScopeType.SelectionEvent && this.isSelectionEventBoundary(statement)) {
+            this.scope.pop(node.getFirstToken().getStart());
+        }
+        if (this.opensSelectionEventScope(statement)) {
+            this.scope.push(_scope_type_1.ScopeType.SelectionEvent, statement.constructor.name, node.getFirstToken().getStart(), this.currentFile.getFilename());
+        }
+    }
+    opensSelectionEventScope(statement) {
+        return statement instanceof Statements.AtSelectionScreen;
+    }
+    isSelectionEventBoundary(statement) {
+        return stuff_1.SELECTION_EVENTS.some(event => statement instanceof event)
+            || statement instanceof Statements.Form
+            || statement instanceof Statements.FunctionModule;
+    }
+    isSelectionEventBoundaryStructure(structure) {
+        return structure instanceof Structures.ClassDefinition
+            || structure instanceof Structures.Interface;
+    }
 }
 exports.SyntaxLogic = SyntaxLogic;
 //# sourceMappingURL=syntax.js.map

package/build/src/abap/types/class_definition.js

@@ -173,7 +173,7 @@ class ClassDefinition extends _identifier_1.Identifier {
                 input.scope.addReference(token, undefined, _reference_1.ReferenceType.ObjectOrientedVoidReference, input.filename);
             }
             else {
-                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, token, name.toUpperCase() + " does not exist"));
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, token, "Friend class " + name.toUpperCase() + " does not exist"));
             }
             result.push(name);
         }

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.119.2";
+        return "2.119.3";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/keep_single_parameter_on_one_line.js

@@ -6,6 +6,7 @@ const _basic_rule_config_1 = require("./_basic_rule_config");
 const _abap_rule_1 = require("./_abap_rule");
 const Expressions = require("../abap/2_statements/expressions");
 const _irule_1 = require("./_irule");
+const edit_helper_1 = require("../edit_helper");
 class KeepSingleParameterCallsOnOneLineConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
@@ -25,7 +26,7 @@ class KeepSingleParameterCallsOnOneLine extends _abap_rule_1.ABAPRule {
             title: "Keep single parameters on one line",
             shortDescription: `Keep single parameter calls on one line`,
             extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#keep-single-parameter-calls-on-one-line`,
-            tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
+            tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
             badExample: `call_method(\n  2 ).`,
             goodExample: `call_method( 2 ).`,
         };
@@ -101,7 +102,8 @@ class KeepSingleParameterCallsOnOneLine extends _abap_rule_1.ABAPRule {
                 }
             }
             const message = "Keep single parameter on one line";
-            return [issue_1.Issue.atToken(file, c.getFirstToken(), message, this.getMetadata().key, this.conf.severity)];
+            const fix = edit_helper_1.EditHelper.replaceRange(file, c.getFirstToken().getStart(), c.getLastToken().getEnd(), c.concatTokens());
+            return [issue_1.Issue.atToken(file, c.getFirstToken(), message, this.getMetadata().key, this.conf.severity, fix)];
         }
         return [];
     }

package/build/src/rules/main_file_contents.js

@@ -5,6 +5,7 @@ const issue_1 = require("../issue");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const Objects = require("../objects");
 const _abap_object_1 = require("../objects/_abap_object");
+const _irule_1 = require("./_irule");
 const Statements = require("../abap/2_statements/statements");
 const Expressions = require("../abap/2_statements/expressions");
 const position_1 = require("../position");
@@ -22,6 +23,7 @@ class MainFileContents {
             key: "main_file_contents",
             title: "Main file contents",
             shortDescription: `Checks related to report declarations.`,
+            tags: [_irule_1.RuleTag.Syntax],
             extendedInformation: `Does not run if the target version is Cloud
 
 * PROGs must begin with "REPORT <name>." or "PROGRAM <name>.

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.119.2",
+    "version": "2.119.3",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",