@abaplint/core 2.119.19 → 2.119.21

package/build/abaplint.d.ts

@@ -18,7 +18,11 @@ export declare class ABAPFile extends AbstractFile implements IABAPFile {
 
 export declare abstract class ABAPObject extends AbstractObject {
     private parsed;
-    protected texts: ITextElements | undefined;
+    protected texts: {
+        [id: string]: ITextElements;
+    } | undefined;
+    private textsTranslations;
+    private rawXMLCache;
     syntaxResult: ISyntaxResult | undefined;
     abstract getSequencedFiles(): readonly ABAPFile[];
     abstract getDescription(): string | undefined;
@@ -26,11 +30,15 @@ export declare abstract class ABAPObject extends AbstractObject {
     static is(x: any): x is ABAPObject;
     parse(version: Version, globalMacros?: readonly string[], reg?: IRegistry): IParseResult;
     setDirty(): void;
+    private getParsedXML;
     getABAPFiles(): readonly ABAPFile[];
     getABAPFileByName(filename: string): ABAPFile | undefined;
     getMainABAPFile(): ABAPFile | undefined;
-    getTexts(): ITextElements;
+    getTextSymbols(): ITextElements;
+    getTextElements(): ITextElements;
+    getTextElementsTranslations(): ITranslationTextElements[];
     protected findTexts(parsed: any): void;
+    private findTextsTranslations;
 }
 
 declare class ABAPQueryFunctionalArea extends AbstractObject {
@@ -1731,6 +1739,20 @@ declare class DataElement extends AbstractObject {
         long?: string;
         heading?: string;
     } | undefined;
+    getTextMaxLengths(): {
+        short?: string;
+        medium?: string;
+        long?: string;
+        heading?: string;
+    } | undefined;
+    getTextsTranslations(): {
+        language: string;
+        description?: string;
+        short?: string;
+        medium?: string;
+        long?: string;
+        heading?: string;
+    }[] | undefined;
     parseType(reg: IRegistry): AbstractType;
     parse(): {
         updated: boolean;
@@ -1978,6 +2000,7 @@ declare class Domain extends AbstractObject {
         runtime: number;
     };
     getFixedValues(): DomainValue[];
+    getFixedValuesTranslations(): DomainValueTranslation[];
 }
 
 declare interface DomainValue {
@@ -1987,6 +2010,11 @@ declare interface DomainValue {
     description: string;
 }
 
+declare interface DomainValueTranslation {
+    language: string;
+    description: string;
+}
+
 declare enum Duration {
     short = "SHORT",
     medium = "MEDIUM",
@@ -2912,7 +2940,7 @@ declare class FunctionGroup extends ABAPObject {
     getMainABAPFile(): ABAPFile | undefined;
     getIncludes(): string[];
     getModule(name: string): FunctionModuleDefinition | undefined;
-    getTexts(): ITextElements;
+    getTextSymbols(): ITextElements;
     private parseXML;
     private findTextFile;
 }
@@ -4289,7 +4317,15 @@ declare interface ITextEdit {
 }
 
 declare interface ITextElements {
-    [key: string]: string;
+    [key: string]: {
+        entry: string;
+        maxLength: number;
+    };
+}
+
+declare interface ITranslationTextElements {
+    language: string;
+    textElements: ITextElements;
 }
 
 declare interface ITypeDefinitions {
@@ -4513,6 +4549,11 @@ declare class MessageClass extends AbstractObject {
         allowNamespace: boolean;
     };
     getParsed(): parsedMessageClass | undefined;
+    getTextsTranslations(): {
+        language: string;
+        number: string;
+        text?: string;
+    }[] | undefined;
     setDirty(): void;
     getMessages(): readonly Message[];
     getByNumber(num: string): Message | undefined;
@@ -5142,6 +5183,7 @@ declare namespace Objects {
         DialogModule,
         Documentation,
         DomainValue,
+        DomainValueTranslation,
         Domain,
         EcattTestConfiguration,
         EcattTestDataContainer,
@@ -5431,6 +5473,11 @@ declare type parsedMessageClass = {
     topName: string | undefined;
     description: string | undefined;
     parsedMessages: Message[] | undefined;
+    textsTranslations: {
+        language: string;
+        number: string;
+        text?: string;
+    }[] | undefined;
 };
 
 declare type ParsedMetadataExtension = {
@@ -7330,6 +7377,10 @@ declare class Transaction extends AbstractObject {
     getCInfo(): string | undefined;
     getProgramName(): string | undefined;
     getDescription(): string | undefined;
+    getTextsTranslations(): {
+        language: string;
+        description?: string;
+    }[] | undefined;
     parse(): {
         updated: boolean;
         runtime: number;

package/build/src/abap/2_statements/expressions/sql_function.js

@@ -6,6 +6,7 @@ const tokens_1 = require("../../1_lexer/tokens");
 const combi_1 = require("../combi");
 const integer_1 = require("./integer");
 const sql_function_input_1 = require("./sql_function_input");
+const sql_case_1 = require("./sql_case");
 class SQLFunction extends combi_1.Expression {
     getRunnable() {
         const castTypes = (0, combi_1.altPrio)((0, combi_1.seq)("CHAR", (0, combi_1.optPrio)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.ParenLeftW), integer_1.Integer, (0, combi_1.tok)(tokens_1.WParenRightW)))), (0, combi_1.seq)("DEC", (0, combi_1.tok)(tokens_1.ParenLeftW), integer_1.Integer, ",", integer_1.Integer, (0, combi_1.tok)(tokens_1.WParenRightW)), (0, combi_1.seq)("NUMC", (0, combi_1.optPrio)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.ParenLeftW), integer_1.Integer, (0, combi_1.tok)(tokens_1.WParenRightW)))), "DATS", "FLTP", "INT2", "INT4", "INT8");
@@ -13,7 +14,8 @@ class SQLFunction extends combi_1.Expression {
         // note: the function names are not keywords, they are usually in lower case
         const abs = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)((0, combi_1.regex)(/^abs$/i), (0, combi_1.tok)(tokens_1.ParenLeftW), sql_function_input_1.SQLFunctionInput, (0, combi_1.tok)(tokens_1.WParenRightW)));
         // yea, 750 is correct, but it also works technically in version v740sp05
-        const cast = (0, combi_1.ver)(version_1.Version.v750, (0, combi_1.seq)((0, combi_1.regex)(/^cast$/i), (0, combi_1.tok)(tokens_1.ParenLeftW), sql_function_input_1.SQLFunctionInput, "AS", castTypes, (0, combi_1.tok)(tokens_1.WParenRightW)));
+        const castInput = (0, combi_1.altPrio)(sql_case_1.SQLCase, sql_function_input_1.SQLFunctionInput);
+        const cast = (0, combi_1.ver)(version_1.Version.v750, (0, combi_1.seq)((0, combi_1.regex)(/^cast$/i), (0, combi_1.tok)(tokens_1.ParenLeftW), castInput, "AS", castTypes, (0, combi_1.tok)(tokens_1.WParenRightW)));
         const ceil = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)((0, combi_1.regex)(/^ceil$/i), (0, combi_1.tok)(tokens_1.ParenLeftW), sql_function_input_1.SQLFunctionInput, (0, combi_1.tok)(tokens_1.WParenRightW)));
         const coalesce = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)((0, combi_1.regex)(/^coalesce$/i), (0, combi_1.tok)(tokens_1.ParenLeftW), sql_function_input_1.SQLFunctionInput, commaParam, (0, combi_1.optPrio)(commaParam), (0, combi_1.tok)(tokens_1.WParenRightW)));
         const concat = (0, combi_1.ver)(version_1.Version.v750, (0, combi_1.seq)((0, combi_1.regex)(/^concat$/i), (0, combi_1.tok)(tokens_1.ParenLeftW), sql_function_input_1.SQLFunctionInput, commaParam, (0, combi_1.tok)(tokens_1.WParenRightW)));

package/build/src/abap/5_syntax/statements/constant.js

@@ -5,7 +5,9 @@ const Expressions = require("../../2_statements/expressions");
 const basic_types_1 = require("../basic_types");
 const _typed_identifier_1 = require("../../types/_typed_identifier");
 const basic_1 = require("../../types/basic");
+const _syntax_input_1 = require("../_syntax_input");
 const assert_error_1 = require("../assert_error");
+const basic_2 = require("../../types/basic");
 class Constant {
     runSyntax(node, input) {
         const basic = new basic_types_1.BasicTypes(input);
@@ -13,14 +15,29 @@ class Constant {
         if (found) {
             const val = basic.findValue(node);
             const meta = ["read_only" /* IdentifierMeta.ReadOnly */, "static" /* IdentifierMeta.Static */];
+            if (this.isOnlyDigits(found.getName()) && this.allowOnlyDigitsName(node, input) === false) {
+                const message = "not possible to have a name with only digits";
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, found.getToken(), message));
+                return new _typed_identifier_1.TypedIdentifier(found.getToken(), input.filename, basic_2.VoidType.get(_syntax_input_1.CheckSyntaxKey), meta, val);
+            }
             return new _typed_identifier_1.TypedIdentifier(found.getToken(), input.filename, found.getType(), meta, val);
         }
         const fallback = node.findFirstExpression(Expressions.DefinitionName);
         if (fallback) {
+            if (this.isOnlyDigits(fallback.concatTokens()) && this.allowOnlyDigitsName(node, input) === false) {
+                const message = "not possible to have a name with only digits";
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, fallback.getFirstToken(), message));
+            }
             return new _typed_identifier_1.TypedIdentifier(fallback.getFirstToken(), input.filename, new basic_1.UnknownType("constant, fallback"));
         }
         throw new assert_error_1.AssertError("Statement Constant: unexpected structure");
     }
+    isOnlyDigits(name) {
+        return /^[0-9]+$/.test(name);
+    }
+    allowOnlyDigitsName(node, input) {
+        return input.scope.isAnyOO() === false && node.getColon() !== undefined;
+    }
 }
 exports.Constant = Constant;
 //# sourceMappingURL=constant.js.map

package/build/src/abap/5_syntax/statements/data.js

@@ -13,6 +13,11 @@ class Data {
         const dd = node.findFirstExpression(Expressions.DataDefinition);
         if (dd) {
             const id = data_definition_1.DataDefinition.runSyntax(dd, input);
+            if (id && this.isOnlyDigits(id.getName())) {
+                const message = "not possible to have a name with only digits";
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, id.getToken(), message));
+                return new _typed_identifier_1.TypedIdentifier(id.getToken(), input.filename, basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey));
+            }
             if ((id === null || id === void 0 ? void 0 : id.getType().isGeneric()) === true
                 && (id === null || id === void 0 ? void 0 : id.getType().containsVoid()) === false) {
                 const message = "DATA definition cannot be generic, " + (name === null || name === void 0 ? void 0 : name.concatTokens());
@@ -22,10 +27,17 @@ class Data {
             return id;
         }
         if (name) {
+            if (this.isOnlyDigits(name.concatTokens())) {
+                const message = "not possible to have a name with only digits";
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, name.getFirstToken(), message));
+            }
             return new _typed_identifier_1.TypedIdentifier(name.getFirstToken(), input.filename, new unknown_type_1.UnknownType("data, fallback"));
         }
         return undefined;
     }
+    isOnlyDigits(name) {
+        return /^[0-9]+$/.test(name);
+    }
 }
 exports.Data = Data;
 //# sourceMappingURL=data.js.map

package/build/src/objects/_abap_object.js

@@ -12,6 +12,7 @@ class ABAPObject extends _abstract_object_1.AbstractObject {
         super(name);
         this.parsed = [];
         this.texts = undefined;
+        this.rawXMLCache = undefined;
     }
     static is(x) {
         return !!x && x instanceof ABAPObject;
@@ -30,9 +31,18 @@ class ABAPObject extends _abstract_object_1.AbstractObject {
     setDirty() {
         this.syntaxResult = undefined;
         this.texts = undefined;
+        this.textsTranslations = undefined;
+        this.rawXMLCache = undefined;
         this.parsed = [];
         super.setDirty();
     }
+    getParsedXML() {
+        var _a, _b;
+        if (this.rawXMLCache === undefined) {
+            this.rawXMLCache = (_a = this.parseRaw2()) !== null && _a !== void 0 ? _a : null;
+        }
+        return (_b = this.rawXMLCache) !== null && _b !== void 0 ? _b : undefined;
+    }
     getABAPFiles() {
         return this.parsed;
     }
@@ -63,29 +73,67 @@ class ABAPObject extends _abstract_object_1.AbstractObject {
         }
         return undefined;
     }
-    getTexts() {
+    getTextSymbols() {
+        var _a;
         if (this.texts === undefined) {
-            this.findTexts(this.parseRaw2());
+            this.findTexts(this.getParsedXML());
         }
-        return this.texts;
+        return (_a = this.texts["I"]) !== null && _a !== void 0 ? _a : {};
+    }
+    getTextElements() {
+        if (this.texts === undefined) {
+            this.findTexts(this.getParsedXML());
+        }
+        const result = {};
+        for (const elements of Object.values(this.texts)) {
+            Object.assign(result, elements);
+        }
+        return result;
+    }
+    getTextElementsTranslations() {
+        if (this.textsTranslations === undefined) {
+            this.findTextsTranslations(this.getParsedXML());
+        }
+        return this.textsTranslations;
     }
     findTexts(parsed) {
-        var _a, _b, _c, _d;
+        var _a, _b, _c, _d, _e, _f, _g;
         this.texts = {};
         if (((_d = (_c = (_b = (_a = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _a === void 0 ? void 0 : _a["asx:abap"]) === null || _b === void 0 ? void 0 : _b["asx:values"]) === null || _c === void 0 ? void 0 : _c.TPOOL) === null || _d === void 0 ? void 0 : _d.item) === undefined) {
             return;
         }
         for (const t of (0, xml_utils_1.xmlToArray)(parsed.abapGit["asx:abap"]["asx:values"].TPOOL.item)) {
-            if ((t === null || t === void 0 ? void 0 : t.ID) === "I") {
-                if (t.KEY === undefined) {
-                    throw new Error("findTexts, undefined");
-                }
-                const key = t.KEY;
-                if (key === undefined) {
-                    continue;
+            const id = (_e = t.ID) === null || _e === void 0 ? void 0 : _e.toUpperCase();
+            if (id === undefined
+                || (id !== "R" && t.KEY === undefined)) {
+                throw new Error("findTexts, undefined");
+            }
+            const key = (_g = ((_f = t.KEY) !== null && _f !== void 0 ? _f : t.ID)) === null || _g === void 0 ? void 0 : _g.toUpperCase();
+            if (key === undefined) {
+                continue;
+            }
+            if (this.texts[id] === undefined) {
+                this.texts[id] = {};
+            }
+            this.texts[id][key] = { entry: t.ENTRY ? (0, xml_utils_1.unescape)(t.ENTRY) : "", maxLength: parseInt(t.LENGTH, 10) };
+        }
+    }
+    findTextsTranslations(parsed) {
+        var _a, _b, _c, _d, _e, _f;
+        this.textsTranslations = [];
+        const values = (_c = (_b = (_a = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _a === void 0 ? void 0 : _a["asx:abap"]) === null || _b === void 0 ? void 0 : _b["asx:values"].I18N_TPOOL) === null || _c === void 0 ? void 0 : _c.item;
+        if (values === undefined) {
+            return;
+        }
+        for (const langItem of (0, xml_utils_1.xmlToArray)(values)) {
+            const textElements = {};
+            for (const item of (0, xml_utils_1.xmlToArray)((_d = langItem.TEXTPOOL) === null || _d === void 0 ? void 0 : _d.item)) {
+                const key = (_f = ((_e = item.KEY) !== null && _e !== void 0 ? _e : item.ID)) === null || _f === void 0 ? void 0 : _f.toUpperCase();
+                if (key !== undefined) {
+                    textElements[key] = { entry: (0, xml_utils_1.unescape)(item.ENTRY), maxLength: parseInt(item.LENGTH, 10) };
                 }
-                this.texts[key.toUpperCase()] = t.ENTRY ? (0, xml_utils_1.unescape)(t.ENTRY) : "";
             }
+            this.textsTranslations.push({ language: langItem.LANGUAGE, textElements });
         }
     }
 }

package/build/src/objects/data_element.js

@@ -4,6 +4,7 @@ exports.DataElement = void 0;
 const _abstract_object_1 = require("./_abstract_object");
 const ddic_1 = require("../ddic");
 const Types = require("../abap/types/basic");
+const xml_utils_1 = require("../xml_utils");
 class DataElement extends _abstract_object_1.AbstractObject {
     constructor() {
         super(...arguments);
@@ -39,6 +40,16 @@ class DataElement extends _abstract_object_1.AbstractObject {
         this.parse();
         return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.texts;
     }
+    getTextMaxLengths() {
+        var _a;
+        this.parse();
+        return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.textMaxLengths;
+    }
+    getTextsTranslations() {
+        var _a;
+        this.parse();
+        return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.textsTranslations;
+    }
     parseType(reg) {
         var _a;
         const references = [];
@@ -98,7 +109,7 @@ class DataElement extends _abstract_object_1.AbstractObject {
         return lookup.type;
     }
     parse() {
-        var _a, _b, _c;
+        var _a, _b, _c, _d, _e, _f, _g;
         if (this.parsedXML !== undefined) {
             return { updated: false, runtime: 0 };
         }
@@ -122,7 +133,24 @@ class DataElement extends _abstract_object_1.AbstractObject {
                 long: dd04v === null || dd04v === void 0 ? void 0 : dd04v.SCRTEXT_L,
                 heading: dd04v === null || dd04v === void 0 ? void 0 : dd04v.REPTEXT,
             },
+            textMaxLengths: {
+                short: dd04v === null || dd04v === void 0 ? void 0 : dd04v.SCRLEN1,
+                medium: dd04v === null || dd04v === void 0 ? void 0 : dd04v.SCRLEN2,
+                long: dd04v === null || dd04v === void 0 ? void 0 : dd04v.SCRLEN3,
+                heading: dd04v === null || dd04v === void 0 ? void 0 : dd04v.HEADLEN,
+            },
         };
+        this.parsedXML.textsTranslations = [];
+        for (const item of (0, xml_utils_1.xmlToArray)((_g = (_f = (_e = (_d = parsed.abapGit) === null || _d === void 0 ? void 0 : _d["asx:abap"]) === null || _e === void 0 ? void 0 : _e["asx:values"]) === null || _f === void 0 ? void 0 : _f.DD04_TEXTS) === null || _g === void 0 ? void 0 : _g.item)) {
+            this.parsedXML.textsTranslations.push({
+                language: item.DDLANGUAGE,
+                description: item.DDTEXT,
+                short: item.SCRTEXT_S,
+                medium: item.SCRTEXT_M,
+                long: item.SCRTEXT_L,
+                heading: item.REPTEXT,
+            });
+        }
         const end = Date.now();
         return { updated: true, runtime: end - start };
     }

package/build/src/objects/domain.js

@@ -49,7 +49,7 @@ class Domain extends _abstract_object_1.AbstractObject {
         });
     }
     parse() {
-        var _a, _b, _c, _d, _e, _f, _g;
+        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l;
         if (this.parsedXML) {
             return { updated: false, runtime: 0 };
         }
@@ -71,6 +71,15 @@ class Domain extends _abstract_object_1.AbstractObject {
             };
             values.push(value);
         }
+        const dd07v_texts = (0, xml_utils_1.xmlToArray)((_l = (_k = (_j = (_h = parsed.abapGit) === null || _h === void 0 ? void 0 : _h["asx:abap"]) === null || _j === void 0 ? void 0 : _j["asx:values"]) === null || _k === void 0 ? void 0 : _k.DD07_TEXTS) === null || _l === void 0 ? void 0 : _l.item);
+        const translationValues = [];
+        for (const dd07v of dd07v_texts) {
+            const value = {
+                language: dd07v === null || dd07v === void 0 ? void 0 : dd07v.DDLANGUAGE,
+                description: dd07v === null || dd07v === void 0 ? void 0 : dd07v.DDTEXT,
+            };
+            translationValues.push(value);
+        }
         this.parsedXML = {
             description: dd01v === null || dd01v === void 0 ? void 0 : dd01v.DDTEXT,
             datatype: dd01v === null || dd01v === void 0 ? void 0 : dd01v.DATATYPE,
@@ -78,6 +87,7 @@ class Domain extends _abstract_object_1.AbstractObject {
             conversionExit: dd01v === null || dd01v === void 0 ? void 0 : dd01v.CONVEXIT,
             decimals: dd01v === null || dd01v === void 0 ? void 0 : dd01v.DECIMALS,
             values: values,
+            valuesTranslations: translationValues,
         };
         const end = Date.now();
         return { updated: true, runtime: end - start };
@@ -86,6 +96,10 @@ class Domain extends _abstract_object_1.AbstractObject {
         var _a, _b;
         return (_b = (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.values) !== null && _b !== void 0 ? _b : [];
     }
+    getFixedValuesTranslations() {
+        var _a, _b;
+        return (_b = (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.valuesTranslations) !== null && _b !== void 0 ? _b : [];
+    }
 }
 exports.Domain = Domain;
 //# sourceMappingURL=domain.js.map

package/build/src/objects/function_group.js

@@ -132,7 +132,8 @@ class FunctionGroup extends _abap_object_1.ABAPObject {
         }
         return undefined;
     }
-    getTexts() {
+    getTextSymbols() {
+        var _a;
         if (this.texts === undefined) {
             const found = this.findTextFile();
             if (found === undefined) {
@@ -141,7 +142,7 @@ class FunctionGroup extends _abap_object_1.ABAPObject {
             const parsed = new fast_xml_parser_1.XMLParser({ parseTagValue: false, ignoreAttributes: true, trimValues: false }).parse(found.getRaw());
             this.findTexts(parsed);
         }
-        return this.texts;
+        return (_a = this.texts["I"]) !== null && _a !== void 0 ? _a : {};
     }
     /////////////////////////////////
     parseXML() {

package/build/src/objects/message_class.js

@@ -27,6 +27,11 @@ class MessageClass extends _abstract_object_1.AbstractObject {
         this.parseXML();
         return this.xml;
     }
+    getTextsTranslations() {
+        var _a;
+        this.parseXML();
+        return (_a = this.xml) === null || _a === void 0 ? void 0 : _a.textsTranslations;
+    }
     setDirty() {
         this.xml = undefined;
         super.setDirty();
@@ -49,7 +54,7 @@ class MessageClass extends _abstract_object_1.AbstractObject {
     }
     /////////////////////////////////
     parseXML() {
-        var _a, _b, _c, _d, _e, _f, _g, _h;
+        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k;
         if (this.xml !== undefined) {
             return;
         }
@@ -57,6 +62,7 @@ class MessageClass extends _abstract_object_1.AbstractObject {
             topName: undefined,
             description: undefined,
             parsedMessages: [],
+            textsTranslations: [],
         };
         const parsed = super.parseRaw2();
         if (parsed === undefined) {
@@ -71,6 +77,13 @@ class MessageClass extends _abstract_object_1.AbstractObject {
         for (const msg of (0, xml_utils_1.xmlToArray)(t100.T100)) {
             this.xml.parsedMessages.push(new message_1.Message(msg.MSGNR, (0, xml_utils_1.unescape)(msg.TEXT), msg.ARBGB));
         }
+        const t100_texts = (_k = (_j = parsed === null || parsed === void 0 ? void 0 : parsed.abapGit) === null || _j === void 0 ? void 0 : _j["asx:abap"]["asx:values"]) === null || _k === void 0 ? void 0 : _k.T100_TEXTS;
+        if (t100_texts === undefined) {
+            return;
+        }
+        for (const item of (0, xml_utils_1.xmlToArray)(t100_texts === null || t100_texts === void 0 ? void 0 : t100_texts.item)) {
+            this.xml.textsTranslations.push({ language: item.SPRSL, number: item.MSGNR, text: (0, xml_utils_1.unescape)(item.TEXT) });
+        }
     }
 }
 exports.MessageClass = MessageClass;

package/build/src/objects/program.js

@@ -71,7 +71,7 @@ class Program extends _abap_object_1.ABAPObject {
                 description = t.ENTRY ? (0, xml_utils_1.unescape)(t.ENTRY) : "";
             }
             else if ((t === null || t === void 0 ? void 0 : t.ID) === "S" && t.KEY !== undefined) {
-                selectionTexts[t.KEY.toUpperCase()] = t.ENTRY ? (0, xml_utils_1.unescape)(t.ENTRY) : "";
+                selectionTexts[t.KEY.toUpperCase()] = { entry: t.ENTRY ? (0, xml_utils_1.unescape)(t.ENTRY) : "", maxLength: parseInt(t.LENGTH, 10) };
             }
         }
         const dynpros = (0, _dynpros_1.parseDynpros)(parsed);

package/build/src/objects/transaction.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.Transaction = void 0;
 const _abstract_object_1 = require("./_abstract_object");
+const xml_utils_1 = require("../xml_utils");
 class Transaction extends _abstract_object_1.AbstractObject {
     getType() {
         return "TRAN";
@@ -31,8 +32,13 @@ class Transaction extends _abstract_object_1.AbstractObject {
         this.parse();
         return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.description;
     }
+    getTextsTranslations() {
+        var _a;
+        this.parse();
+        return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.textsTranslations;
+    }
     parse() {
-        var _a, _b, _c;
+        var _a, _b, _c, _d;
         if (this.parsedXML) {
             return { updated: false, runtime: 0 };
         }
@@ -47,6 +53,10 @@ class Transaction extends _abstract_object_1.AbstractObject {
         this.parsedXML.description = (_a = parsed.abapGit["asx:abap"]["asx:values"].TSTCT) === null || _a === void 0 ? void 0 : _a.TTEXT;
         this.parsedXML.programName = (_b = parsed.abapGit["asx:abap"]["asx:values"].TSTC) === null || _b === void 0 ? void 0 : _b.PGMNA;
         this.parsedXML.cinfo = (_c = parsed.abapGit["asx:abap"]["asx:values"].TSTC) === null || _c === void 0 ? void 0 : _c.CINFO;
+        this.parsedXML.textsTranslations = [];
+        for (const item of (0, xml_utils_1.xmlToArray)((_d = parsed.abapGit["asx:abap"]["asx:values"].I18N_TPOOL) === null || _d === void 0 ? void 0 : _d.TSTCT)) {
+            this.parsedXML.textsTranslations.push({ language: item.SPRSL, description: item.TTEXT });
+        }
         const end = Date.now();
         return { updated: true, runtime: end - start };
     }

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.119.19";
+        return "2.119.21";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/check_text_elements.js

@@ -32,6 +32,7 @@ class CheckTextElements {
         return this;
     }
     run(obj) {
+        var _a;
         if (!(obj instanceof _abap_object_1.ABAPObject)) {
             return [];
         }
@@ -51,10 +52,10 @@ class CheckTextElements {
                     // todo, this only checks the first main
                     mainName = mains[0];
                     const main1 = this.reg.findObjectForFile(this.reg.getFileByName(mains[0]));
-                    texts = main1.getTexts();
+                    texts = main1.getTextSymbols();
                 }
                 else {
-                    texts = obj.getTexts();
+                    texts = obj.getTextSymbols();
                 }
             }
             for (const e of expressions) {
@@ -71,8 +72,8 @@ class CheckTextElements {
                     const token = e.findFirstExpression(Expressions.TextElementKey).getFirstToken();
                     const code = e.getFirstToken().getStr();
                     const key = token.getStr().toUpperCase();
-                    let found = texts[key];
-                    if (found && code.startsWith("'")) {
+                    let found = (_a = texts[key]) === null || _a === void 0 ? void 0 : _a.entry;
+                    if (found !== undefined && code.startsWith("'")) {
                         found = found.replace(/'/g, "''");
                     }
                     if (found === undefined) {

package/build/src/rules/xml_consistency.js

@@ -4,6 +4,7 @@ exports.XMLConsistency = exports.XMLConsistencyConf = void 0;
 const issue_1 = require("../issue");
 const _irule_1 = require("./_irule");
 const Objects = require("../objects");
+const _abap_object_1 = require("../objects/_abap_object");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const fast_xml_parser_1 = require("fast-xml-parser");
 class XMLConsistencyConf extends _basic_rule_config_1.BasicRuleConfig {
@@ -17,7 +18,11 @@ class XMLConsistency {
         return {
             key: "xml_consistency",
             title: "XML consistency",
-            shortDescription: `Checks the consistency of main XML files, eg. naming for CLAS and INTF objects`,
+            shortDescription: `Checks the consistency of main XML files`,
+            extendedInformation: `Checks:
+* XML is well-formed and parseable
+* Naming for CLAS and INTF objects
+* Texts and translations do not exceed maximum allowed length.`,
             tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.Syntax],
         };
     }
@@ -31,7 +36,6 @@ class XMLConsistency {
         return this;
     }
     run(obj) {
-        var _a, _b;
         const issues = [];
         const file = obj.getXMLFile();
         if (file === undefined) {
@@ -46,37 +50,166 @@ class XMLConsistency {
         }
         // todo, have some XML validation in each object?
         if (obj instanceof Objects.Class) {
-            const name = obj.getNameFromXML();
-            if (name === undefined) {
-                issues.push(issue_1.Issue.atRow(file, 1, "Name undefined in XML", this.getMetadata().key, this.conf.severity));
-            }
-            else if (obj.getDescription() && obj.getDescription().length > 60) {
-                issues.push(issue_1.Issue.atRow(file, 1, "Description too long", this.getMetadata().key, this.conf.severity));
-            }
-            else if (name !== obj.getName().toUpperCase()) {
-                issues.push(issue_1.Issue.atRow(file, 1, "Name in XML does not match object", this.getMetadata().key, this.conf.severity));
-            }
-            else if (((_a = obj.getMainABAPFile()) === null || _a === void 0 ? void 0 : _a.getStructure()) !== undefined && obj.getClassDefinition() === undefined) {
-                issues.push(issue_1.Issue.atRow(file, 1, "Class matching XML name not found in ABAP file", this.getMetadata().key, this.conf.severity));
-            }
+            issues.push(...this.runClass(obj, file));
         }
         else if (obj instanceof Objects.Interface) {
-            const name = obj.getNameFromXML();
-            if (name === undefined) {
-                issues.push(issue_1.Issue.atRow(file, 1, "Name undefined in XML", this.getMetadata().key, this.conf.severity));
-            }
-            else if (obj.getDescription() && obj.getDescription().length > 60) {
-                issues.push(issue_1.Issue.atRow(file, 1, "Description too long", this.getMetadata().key, this.conf.severity));
+            issues.push(...this.runInterface(obj, file));
+        }
+        else if (obj instanceof Objects.DataElement) {
+            issues.push(...this.runDataElement(obj, file));
+        }
+        else if (obj instanceof Objects.Domain) {
+            issues.push(...this.runDomain(obj, file));
+        }
+        else if (obj instanceof Objects.Transaction) {
+            issues.push(...this.runTransaction(obj, file));
+        }
+        else if (obj instanceof Objects.MessageClass) {
+            issues.push(...this.runMessageClass(obj, file));
+        }
+        if (obj instanceof _abap_object_1.ABAPObject) {
+            issues.push(...this.runTextPool(obj, file));
+        }
+        return issues;
+    }
+    runClass(obj, file) {
+        var _a;
+        const issues = [];
+        const name = obj.getNameFromXML();
+        if (name === undefined) {
+            issues.push(issue_1.Issue.atRow(file, 1, "Name undefined in XML", this.getMetadata().key, this.conf.severity));
+        }
+        else if (obj.getDescription() && obj.getDescription().length > 60) {
+            issues.push(issue_1.Issue.atRow(file, 1, "Description too long", this.getMetadata().key, this.conf.severity));
+        }
+        else if (name !== obj.getName().toUpperCase()) {
+            issues.push(issue_1.Issue.atRow(file, 1, "Name in XML does not match object", this.getMetadata().key, this.conf.severity));
+        }
+        else if (((_a = obj.getMainABAPFile()) === null || _a === void 0 ? void 0 : _a.getStructure()) !== undefined && obj.getClassDefinition() === undefined) {
+            issues.push(issue_1.Issue.atRow(file, 1, "Class matching XML name not found in ABAP file", this.getMetadata().key, this.conf.severity));
+        }
+        return issues;
+    }
+    runTextPool(obj, file) {
+        const issues = [];
+        const push = (issue) => { if (issue) {
+            issues.push(issue);
+        } };
+        for (const [key, el] of Object.entries(obj.getTextElements())) {
+            push(this.checkTextLength(file, `ENTRY[${key}]`, el.entry, el.maxLength));
+        }
+        for (const translation of obj.getTextElementsTranslations()) {
+            for (const [key, el] of Object.entries(translation.textElements)) {
+                push(this.checkTextLength(file, `ENTRY[${key}]`, el.entry, el.maxLength, translation.language));
             }
-            else if (name !== obj.getName().toUpperCase()) {
-                issues.push(issue_1.Issue.atRow(file, 1, "Name in XML does not match object", this.getMetadata().key, this.conf.severity));
+        }
+        return issues;
+    }
+    runInterface(obj, file) {
+        var _a;
+        const issues = [];
+        const name = obj.getNameFromXML();
+        if (name === undefined) {
+            issues.push(issue_1.Issue.atRow(file, 1, "Name undefined in XML", this.getMetadata().key, this.conf.severity));
+        }
+        else if (obj.getDescription() && obj.getDescription().length > 60) {
+            issues.push(issue_1.Issue.atRow(file, 1, "Description too long", this.getMetadata().key, this.conf.severity));
+        }
+        else if (name !== obj.getName().toUpperCase()) {
+            issues.push(issue_1.Issue.atRow(file, 1, "Name in XML does not match object", this.getMetadata().key, this.conf.severity));
+        }
+        else if (obj.getDefinition() !== undefined && ((_a = obj.getDefinition()) === null || _a === void 0 ? void 0 : _a.getName().toUpperCase()) !== name.toUpperCase()) {
+            issues.push(issue_1.Issue.atRow(file, 1, "Interface matching XML name not found in ABAP file", this.getMetadata().key, this.conf.severity));
+        }
+        return issues;
+    }
+    checkTextLength(file, fieldName, text, maxLength, lang) {
+        if (text === undefined || maxLength === undefined) {
+            return undefined;
+        }
+        const max = typeof maxLength === "number" ? maxLength : parseInt(maxLength, 10);
+        if (text.length > max) {
+            const prefix = lang ? `[${lang}] ` : "";
+            return issue_1.Issue.atRow(file, 1, `${prefix}${fieldName} "${text}" exceeds maximum length of ${max} characters (actual: ${text.length})`, this.getMetadata().key, this.conf.severity);
+        }
+        return undefined;
+    }
+    runDataElement(obj, file) {
+        var _a;
+        const issues = [];
+        const texts = obj.getTexts();
+        const maxLengths = obj.getTextMaxLengths();
+        for (const issue of [
+            this.checkTextLength(file, "DDTEXT", obj.getDescription(), 60),
+            this.checkTextLength(file, "SCRTEXT_S", texts === null || texts === void 0 ? void 0 : texts.short, maxLengths === null || maxLengths === void 0 ? void 0 : maxLengths.short),
+            this.checkTextLength(file, "SCRTEXT_M", texts === null || texts === void 0 ? void 0 : texts.medium, maxLengths === null || maxLengths === void 0 ? void 0 : maxLengths.medium),
+            this.checkTextLength(file, "SCRTEXT_L", texts === null || texts === void 0 ? void 0 : texts.long, maxLengths === null || maxLengths === void 0 ? void 0 : maxLengths.long),
+            this.checkTextLength(file, "REPTEXT", texts === null || texts === void 0 ? void 0 : texts.heading, maxLengths === null || maxLengths === void 0 ? void 0 : maxLengths.heading),
+        ]) {
+            if (issue) {
+                issues.push(issue);
             }
-            else if (obj.getDefinition() !== undefined && ((_b = obj.getDefinition()) === null || _b === void 0 ? void 0 : _b.getName().toUpperCase()) !== name.toUpperCase()) {
-                issues.push(issue_1.Issue.atRow(file, 1, "Interface matching XML name not found in ABAP file", this.getMetadata().key, this.conf.severity));
+        }
+        for (const translation of (_a = obj.getTextsTranslations()) !== null && _a !== void 0 ? _a : []) {
+            const lang = translation.language;
+            for (const issue of [
+                this.checkTextLength(file, "DDTEXT", translation.description, 60, lang),
+                this.checkTextLength(file, "SCRTEXT_S", translation.short, maxLengths === null || maxLengths === void 0 ? void 0 : maxLengths.short, lang),
+                this.checkTextLength(file, "SCRTEXT_M", translation.medium, maxLengths === null || maxLengths === void 0 ? void 0 : maxLengths.medium, lang),
+                this.checkTextLength(file, "SCRTEXT_L", translation.long, maxLengths === null || maxLengths === void 0 ? void 0 : maxLengths.long, lang),
+                this.checkTextLength(file, "REPTEXT", translation.heading, maxLengths === null || maxLengths === void 0 ? void 0 : maxLengths.heading, lang),
+            ]) {
+                if (issue) {
+                    issues.push(issue);
+                }
             }
         }
         return issues;
     }
+    runDomain(obj, file) {
+        var _a, _b;
+        const maxTextLength = 60;
+        const issues = [];
+        const push = (issue) => { if (issue) {
+            issues.push(issue);
+        } };
+        push(this.checkTextLength(file, "DDTEXT", obj.getDescription(), maxTextLength));
+        for (const fixedValue of (_a = obj.getFixedValues()) !== null && _a !== void 0 ? _a : []) {
+            push(this.checkTextLength(file, "DDTEXT", fixedValue.description, maxTextLength, fixedValue.language));
+        }
+        for (const translationFixedValue of (_b = obj.getFixedValuesTranslations()) !== null && _b !== void 0 ? _b : []) {
+            push(this.checkTextLength(file, "DDTEXT", translationFixedValue.description, maxTextLength, translationFixedValue.language));
+        }
+        return issues;
+    }
+    runTransaction(obj, file) {
+        var _a;
+        const maxTextLength = 36;
+        const issues = [];
+        const push = (issue) => { if (issue) {
+            issues.push(issue);
+        } };
+        push(this.checkTextLength(file, "TTEXT", obj.getDescription(), maxTextLength));
+        for (const translation of (_a = obj.getTextsTranslations()) !== null && _a !== void 0 ? _a : []) {
+            push(this.checkTextLength(file, "TTEXT", translation.description, maxTextLength, translation.language));
+        }
+        return issues;
+    }
+    runMessageClass(obj, file) {
+        var _a;
+        const maxTextLength = 73;
+        const issues = [];
+        const push = (issue) => { if (issue) {
+            issues.push(issue);
+        } };
+        for (const msg of obj.getMessages()) {
+            push(this.checkTextLength(file, `TEXT[${msg.getNumber()}]`, msg.getMessage(), maxTextLength));
+        }
+        for (const translation of (_a = obj.getTextsTranslations()) !== null && _a !== void 0 ? _a : []) {
+            push(this.checkTextLength(file, `TEXT[${translation.number}]`, translation.text, maxTextLength, translation.language));
+        }
+        return issues;
+    }
 }
 exports.XMLConsistency = XMLConsistency;
 //# sourceMappingURL=xml_consistency.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.119.19",
+    "version": "2.119.21",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",