@abaplint/core 2.119.14 → 2.119.16

package/build/abaplint.d.ts

@@ -4619,6 +4619,7 @@ declare class MethodDefinitions implements IMethodDefinitions {
     getByName(name: string | undefined): IMethodDefinition | undefined;
     private parseInterface;
     private parse;
+    private add;
 }
 
 declare class MethodDefRaising extends Expression {
@@ -4684,6 +4685,7 @@ declare class MethodParameters_2 implements IMethodParameters {
     getExceptions(): string[];
     getParameterDefault(parameter: string): ExpressionNode;
     private parse;
+    private checkDuplicateNames;
     private workaroundRAP;
     private add;
 }

package/build/src/abap/types/class_definition.js

@@ -41,7 +41,8 @@ class ClassDefinition extends _identifier_1.Identifier {
         for (const e of events) {
             const eventName = (_a = e.findDirectExpression(Expressions.EventName)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
             if (this.events.find(ev => ev.getName().toUpperCase() === eventName) !== undefined) {
-                throw new Error("Event " + eventName + " already defined");
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, e.getFirstToken(), "Event " + eventName + " already defined"));
+                continue;
             }
             this.events.push(new event_definition_1.EventDefinition(e, visibility_1.Visibility.Public, input)); // todo, all these are not Public
         }
@@ -61,8 +62,8 @@ class ClassDefinition extends _identifier_1.Identifier {
             this.createVisibilityValue = visibility_1.Visibility.Public;
         }
         // perform checks after everything has been initialized
-        this.checkMethodsFromSuperClasses(input.scope);
-        this.checkMethodNameLength();
+        this.checkMethodsFromSuperClasses(input);
+        this.checkMethodNameLength(input);
     }
     getFriends() {
         return this.friends;
@@ -118,18 +119,20 @@ class ClassDefinition extends _identifier_1.Identifier {
         const name = token === null || token === void 0 ? void 0 : token.getStr();
         return name;
     }
-    checkMethodNameLength() {
+    checkMethodNameLength(input) {
         for (const m of this.methodDefs.getAll()) {
             if (m.getName().length > 30 && m.getName().includes("~") === false) {
                 const message = `Method name "${m.getName()}" is too long, maximum length is 30 characters`;
-                throw new Error(message);
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, m.getToken(), message));
             }
         }
     }
-    checkMethodsFromSuperClasses(scope) {
+    checkMethodsFromSuperClasses(input) {
         var _a;
+        const scope = input.scope;
         let sup = this.getSuperClass();
         const names = new Set();
+        const methods = new Map();
         while (sup !== undefined) {
             const cdef = scope.findClassDefinition(sup);
             for (const m of ((_a = cdef === null || cdef === void 0 ? void 0 : cdef.getMethodDefinitions()) === null || _a === void 0 ? void 0 : _a.getAll()) || []) {
@@ -143,6 +146,9 @@ class ClassDefinition extends _identifier_1.Identifier {
                     continue;
                 }
                 names.add(name);
+                if (methods.has(name) === false) {
+                    methods.set(name, m.getVisibility());
+                }
             }
             for (const a of (cdef === null || cdef === void 0 ? void 0 : cdef.getAliases()) || []) {
                 names.add(a.getName().toUpperCase());
@@ -152,7 +158,13 @@ class ClassDefinition extends _identifier_1.Identifier {
         for (const m of this.getMethodDefinitions().getAll()) {
             if (names.has(m.getName().toUpperCase())
                 && m.isRedefinition() === false) {
-                throw new Error(`${m.getName().toUpperCase()} already declared in superclass`);
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, m.getToken(), `${m.getName().toUpperCase()} already declared in superclass`));
+            }
+            const superVisibility = methods.get(m.getName().toUpperCase());
+            if (m.isRedefinition() === true
+                && superVisibility !== undefined
+                && m.getVisibility() !== superVisibility) {
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, m.getToken(), `${m.getName().toUpperCase()} redefinition visibility cannot be changed`));
             }
         }
     }

package/build/src/abap/types/interface_definition.js

@@ -11,6 +11,7 @@ const _scope_type_1 = require("../5_syntax/_scope_type");
 const event_definition_1 = require("./event_definition");
 const method_definitions_1 = require("./method_definitions");
 const _reference_1 = require("../5_syntax/_reference");
+const _syntax_input_1 = require("../5_syntax/_syntax_input");
 const _object_oriented_1 = require("../5_syntax/_object_oriented");
 class InterfaceDefinition extends _identifier_1.Identifier {
     constructor(node, input) {
@@ -27,7 +28,7 @@ class InterfaceDefinition extends _identifier_1.Identifier {
         this.parse(input, node);
         input.scope.pop(node.getLastToken().getEnd());
         // perform checks after everything has been initialized
-        this.checkMethodNameLength();
+        this.checkMethodNameLength(input);
     }
     getSuperClass() {
         return undefined;
@@ -57,11 +58,11 @@ class InterfaceDefinition extends _identifier_1.Identifier {
         return this.methodDefinitions;
     }
     /////////////////
-    checkMethodNameLength() {
+    checkMethodNameLength(input) {
         for (const m of this.methodDefinitions.getAll()) {
             if (m.getName().length > 30) {
                 const message = `Method name "${m.getName()}" is too long, maximum length is 30 characters`;
-                throw new Error(message);
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, m.getToken(), message));
             }
         }
     }
@@ -86,6 +87,7 @@ class InterfaceDefinition extends _identifier_1.Identifier {
         }
     }
     parse(input, node) {
+        var _a;
         this.checkInterfacesExists(input, node);
         const helper = new _object_oriented_1.ObjectOriented(input.scope);
         helper.fromInterfaces(this);
@@ -95,11 +97,17 @@ class InterfaceDefinition extends _identifier_1.Identifier {
         this.aliases = this.attributes.getAliases();
         const events = node.findAllStatements(Statements.Events);
         for (const e of events) {
+            const eventName = (_a = e.findDirectExpression(Expressions.EventName)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
+            if (this.events.find(ev => ev.getName().toUpperCase() === eventName) !== undefined) {
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, e.getFirstToken(), "Event " + eventName + " already defined"));
+                continue;
+            }
             this.events.push(new event_definition_1.EventDefinition(e, visibility_1.Visibility.Public, input));
         }
         this.methodDefinitions = new method_definitions_1.MethodDefinitions(node, input);
         if (this.methodDefinitions.getByName("CONSTRUCTOR") !== undefined) {
-            throw new Error("Interfaces cannot have constructor methods");
+            const constructor = this.methodDefinitions.getByName("CONSTRUCTOR");
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, constructor.getToken(), "Interfaces cannot have constructor methods"));
         }
     }
 }

package/build/src/abap/types/method_definitions.js

@@ -5,6 +5,7 @@ const method_definition_1 = require("./method_definition");
 const Structures = require("../3_structures/structures");
 const statements_1 = require("../2_statements/statements");
 const visibility_1 = require("../4_file_information/visibility");
+const _syntax_input_1 = require("../5_syntax/_syntax_input");
 class MethodDefinitions {
     constructor(node, input) {
         this.all = {};
@@ -26,8 +27,7 @@ class MethodDefinitions {
     parseInterface(node, input) {
         const defs = node.findAllStatements(statements_1.MethodDef);
         for (const def of defs) {
-            const m = new method_definition_1.MethodDefinition(def, visibility_1.Visibility.Public, input);
-            this.all[m.getName().toUpperCase()] = m;
+            this.add(def, visibility_1.Visibility.Public, input);
         }
     }
     parse(node, input) {
@@ -41,19 +41,25 @@ class MethodDefinitions {
         }
         const pri = cdef.findDirectStructure(Structures.PrivateSection);
         for (const def of (pri === null || pri === void 0 ? void 0 : pri.findAllStatements(statements_1.MethodDef)) || []) {
-            const m = new method_definition_1.MethodDefinition(def, visibility_1.Visibility.Private, input);
-            this.all[m.getName().toUpperCase()] = m;
+            this.add(def, visibility_1.Visibility.Private, input);
         }
         const pro = node.findDirectStructure(Structures.ProtectedSection);
         for (const def of (pro === null || pro === void 0 ? void 0 : pro.findAllStatements(statements_1.MethodDef)) || []) {
-            const m = new method_definition_1.MethodDefinition(def, visibility_1.Visibility.Protected, input);
-            this.all[m.getName().toUpperCase()] = m;
+            this.add(def, visibility_1.Visibility.Protected, input);
         }
         const pub = node.findDirectStructure(Structures.PublicSection);
         for (const def of (pub === null || pub === void 0 ? void 0 : pub.findAllStatements(statements_1.MethodDef)) || []) {
-            const m = new method_definition_1.MethodDefinition(def, visibility_1.Visibility.Public, input);
+            this.add(def, visibility_1.Visibility.Public, input);
+        }
+    }
+    add(def, visibility, input) {
+        try {
+            const m = new method_definition_1.MethodDefinition(def, visibility, input);
             this.all[m.getName().toUpperCase()] = m;
         }
+        catch (e) {
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, def.getFirstToken(), e.message));
+        }
     }
 }
 exports.MethodDefinitions = MethodDefinitions;

package/build/src/abap/types/method_parameters.js

@@ -32,8 +32,13 @@ class MethodParameters {
         // need the scope for LIKE typing inside method parameters
         const parentName = input.scope.getName();
         input.scope.push(_scope_type_1.ScopeType.MethodDefinition, "method definition", node.getStart(), input.filename);
-        this.parse(node, input, parentName, abstractMethod);
-        input.scope.pop(node.getEnd());
+        try {
+            this.parse(node, input, parentName, abstractMethod);
+            this.checkDuplicateNames();
+        }
+        finally {
+            input.scope.pop(node.getEnd());
+        }
     }
     getFilename() {
         return this.filename;
@@ -170,6 +175,16 @@ class MethodParameters {
         }
         this.workaroundRAP(node, input, parentName);
     }
+    checkDuplicateNames() {
+        const names = new Set();
+        for (const parameter of this.getAll()) {
+            const name = parameter.getName().toUpperCase();
+            if (names.has(name)) {
+                throw new Error(`Method parameter "${name}" already defined`);
+            }
+            names.add(name);
+        }
+    }
     workaroundRAP(node, input, parentName) {
         const resultName = node.findExpressionAfterToken("RESULT");
         const isRap = node.findExpressionAfterToken("IMPORTING");

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.119.14";
+        return "2.119.16";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/unreachable_code.js

@@ -44,10 +44,6 @@ class UnreachableCode extends _abap_rule_1.ABAPRule {
                 || node.get() instanceof _statement_1.Empty) {
                 continue;
             }
-            else if (this.isExit(node)) {
-                exit = true;
-                continue;
-            }
             else if (this.isStructure(node.get())) {
                 exit = false;
                 continue;
@@ -56,6 +52,11 @@ class UnreachableCode extends _abap_rule_1.ABAPRule {
                 const issue = issue_1.Issue.atStatement(file, node, this.getMessage(), this.getMetadata().key, this.conf.severity);
                 output.push(issue);
                 exit = false;
+                continue;
+            }
+            else if (this.isExit(node)) {
+                exit = true;
+                continue;
             }
         }
         return output;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.119.14",
+    "version": "2.119.16",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,7 +50,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.58.5",
+        "@microsoft/api-extractor": "^7.58.7",
         "@types/chai": "^4.3.20",
         "@types/mocha": "^10.0.10",
         "@types/node": "^24.12.2",
@@ -63,7 +63,7 @@
         "typescript": "^5.9.3"
     },
     "dependencies": {
-        "fast-xml-parser": "^5.7.1",
+        "fast-xml-parser": "^5.8.0",
         "json5": "^2.2.3",
         "vscode-languageserver-types": "^3.17.5"
     }