@abaplint/core 2.119.13 → 2.119.15

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.119.13";
+        return "2.119.15";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/no_aliases.js

@@ -4,9 +4,14 @@ exports.NoAliases = exports.NoAliasesConf = void 0;
 const issue_1 = require("../issue");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _abap_rule_1 = require("./_abap_rule");
-const Statements = require("../abap/2_statements/statements");
 const _irule_1 = require("./_irule");
+const visibility_1 = require("../abap/4_file_information/visibility");
 class NoAliasesConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        /** Skip reporting aliases in private sections. */
+        this.ignorePrivate = false;
+    }
 }
 exports.NoAliasesConf = NoAliasesConf;
 class NoAliases extends _abap_rule_1.ABAPRule {
@@ -19,7 +24,6 @@ class NoAliases extends _abap_rule_1.ABAPRule {
             key: "no_aliases",
             title: "No ALIASES",
             shortDescription: `Detects use of the ALIAS statement`,
-            extendedInformation: `Only one issue is reported for chained statements`,
             tags: [_irule_1.RuleTag.SingleFile],
         };
     }
@@ -32,18 +36,24 @@ class NoAliases extends _abap_rule_1.ABAPRule {
     runParsed(file) {
         const issues = [];
         const message = "Do not use ALIASES";
-        let prev = undefined;
-        for (const stat of file.getStatements()) {
-            if (stat.get() instanceof Statements.Aliases) {
-                if (prev && prev.getColon() === stat.getColon()) {
+        for (const classDef of file.getInfo().listClassDefinitions()) {
+            for (const alias of classDef.aliases) {
+                if (this.skipAlias(alias)) {
                     continue;
                 }
-                issues.push(issue_1.Issue.atStatement(file, stat, message, this.getMetadata().key, this.conf.severity));
-                prev = stat;
+                issues.push(issue_1.Issue.atIdentifier(alias.identifier, message, this.getMetadata().key, this.conf.severity));
+            }
+        }
+        for (const interfaceDef of file.getInfo().listInterfaceDefinitions()) {
+            for (const alias of interfaceDef.aliases) {
+                issues.push(issue_1.Issue.atIdentifier(alias.identifier, message, this.getMetadata().key, this.conf.severity));
             }
         }
         return issues;
     }
+    skipAlias(alias) {
+        return this.conf.ignorePrivate === true && alias.visibility === visibility_1.Visibility.Private;
+    }
 }
 exports.NoAliases = NoAliases;
 //# sourceMappingURL=no_aliases.js.map

package/build/src/rules/unreachable_code.js

@@ -44,10 +44,6 @@ class UnreachableCode extends _abap_rule_1.ABAPRule {
                 || node.get() instanceof _statement_1.Empty) {
                 continue;
             }
-            else if (this.isExit(node)) {
-                exit = true;
-                continue;
-            }
             else if (this.isStructure(node.get())) {
                 exit = false;
                 continue;
@@ -56,6 +52,11 @@ class UnreachableCode extends _abap_rule_1.ABAPRule {
                 const issue = issue_1.Issue.atStatement(file, node, this.getMessage(), this.getMetadata().key, this.conf.severity);
                 output.push(issue);
                 exit = false;
+                continue;
+            }
+            else if (this.isExit(node)) {
+                exit = true;
+                continue;
             }
         }
         return output;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.119.13",
+    "version": "2.119.15",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",