@abaplint/core 2.119.12 → 2.119.14

package/build/src/abap/2_statements/statements/return.js

@@ -6,7 +6,7 @@ const version_1 = require("../../../version");
 const expressions_1 = require("../expressions");
 class Return {
     getMatcher() {
-        return (0, combi_1.seq)((0, combi_1.str)("RETURN"), (0, combi_1.optPrio)((0, combi_1.ver)(version_1.Version.v758, expressions_1.Source)));
+        return (0, combi_1.seq)((0, combi_1.str)("RETURN"), (0, combi_1.optPrio)((0, combi_1.ver)(version_1.Version.v758, expressions_1.Source, version_1.Version.OpenABAP)));
     }
 }
 exports.Return = Return;

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.119.12";
+        return "2.119.14";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/no_aliases.js

@@ -4,9 +4,14 @@ exports.NoAliases = exports.NoAliasesConf = void 0;
 const issue_1 = require("../issue");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _abap_rule_1 = require("./_abap_rule");
-const Statements = require("../abap/2_statements/statements");
 const _irule_1 = require("./_irule");
+const visibility_1 = require("../abap/4_file_information/visibility");
 class NoAliasesConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        /** Skip reporting aliases in private sections. */
+        this.ignorePrivate = false;
+    }
 }
 exports.NoAliasesConf = NoAliasesConf;
 class NoAliases extends _abap_rule_1.ABAPRule {
@@ -19,7 +24,6 @@ class NoAliases extends _abap_rule_1.ABAPRule {
             key: "no_aliases",
             title: "No ALIASES",
             shortDescription: `Detects use of the ALIAS statement`,
-            extendedInformation: `Only one issue is reported for chained statements`,
             tags: [_irule_1.RuleTag.SingleFile],
         };
     }
@@ -32,18 +36,24 @@ class NoAliases extends _abap_rule_1.ABAPRule {
     runParsed(file) {
         const issues = [];
         const message = "Do not use ALIASES";
-        let prev = undefined;
-        for (const stat of file.getStatements()) {
-            if (stat.get() instanceof Statements.Aliases) {
-                if (prev && prev.getColon() === stat.getColon()) {
+        for (const classDef of file.getInfo().listClassDefinitions()) {
+            for (const alias of classDef.aliases) {
+                if (this.skipAlias(alias)) {
                     continue;
                 }
-                issues.push(issue_1.Issue.atStatement(file, stat, message, this.getMetadata().key, this.conf.severity));
-                prev = stat;
+                issues.push(issue_1.Issue.atIdentifier(alias.identifier, message, this.getMetadata().key, this.conf.severity));
+            }
+        }
+        for (const interfaceDef of file.getInfo().listInterfaceDefinitions()) {
+            for (const alias of interfaceDef.aliases) {
+                issues.push(issue_1.Issue.atIdentifier(alias.identifier, message, this.getMetadata().key, this.conf.severity));
             }
         }
         return issues;
     }
+    skipAlias(alias) {
+        return this.conf.ignorePrivate === true && alias.visibility === visibility_1.Visibility.Private;
+    }
 }
 exports.NoAliases = NoAliases;
 //# sourceMappingURL=no_aliases.js.map

package/build/src/rules/unnecessary_chaining.js

@@ -7,10 +7,14 @@ const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
 const edit_helper_1 = require("../edit_helper");
 const _statement_1 = require("../abap/2_statements/statements/_statement");
+const objects_1 = require("../objects");
+const ddic_1 = require("../ddic");
 class UnnecessaryChainingConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
         this.maxIssuesPerFile = 10;
+        /** Ignore global exception classes */
+        this.ignoreExceptions = true;
     }
 }
 exports.UnnecessaryChainingConf = UnnecessaryChainingConf;
@@ -36,8 +40,15 @@ class UnnecessaryChaining extends _abap_rule_1.ABAPRule {
     setConfig(conf) {
         this.conf = conf;
     }
-    runParsed(file) {
+    runParsed(file, obj) {
         const issues = [];
+        if (obj instanceof objects_1.Class) {
+            const definition = obj.getClassDefinition();
+            const ddic = new ddic_1.DDIC(this.reg);
+            if (this.conf.ignoreExceptions === true && ddic.isException(definition, obj)) {
+                return issues;
+            }
+        }
         let max = this.getConfig().maxIssuesPerFile;
         if (max === undefined || max < 1) {
             max = 10;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.119.12",
+    "version": "2.119.14",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",