@abaplint/core 2.118.4 → 2.118.6

package/build/abaplint.d.ts

@@ -383,6 +383,7 @@ declare class Attributes implements IAttributes {
     private readonly tlist;
     private readonly filename;
     private readonly aliases;
+    private readonly declaredInterfaces;
     constructor(node: StructureNode, input: SyntaxInput);
     getTypes(): TypeDefinitions;
     getStatic(): ClassAttribute[];
@@ -1189,6 +1190,7 @@ declare class ClassDefinition_3 extends Identifier implements IClassDefinition {
     private readonly globalValue;
     private readonly sharedMemory;
     private readonly aliases;
+    private readonly createVisibilityValue;
     constructor(node: StructureNode, input: SyntaxInput);
     getFriends(): string[];
     getEvents(): IEventDefinition[];
@@ -1203,6 +1205,7 @@ declare class ClassDefinition_3 extends Identifier implements IClassDefinition {
     isForTesting(): boolean;
     isAbstract(): boolean;
     isSharedMemory(): boolean;
+    getCreateVisibility(): Visibility;
     private findSuper;
     private checkMethodNameLength;
     private checkMethodsFromSuperClasses;
@@ -1533,6 +1536,7 @@ export declare class CurrentScope {
     protected current: SpaghettiScopeNode | undefined;
     protected allowHeaderUse: string | undefined;
     protected parentObj: IObject;
+    private readonly localFriends;
     static buildDefault(reg: IRegistry, obj: IObject): CurrentScope;
     private static addBuiltIn;
     private constructor();
@@ -1581,6 +1585,9 @@ export declare class CurrentScope {
     push(stype: ScopeType, sname: string, start: Position, filename: string): void;
     isOO(): boolean;
     isAnyOO(): boolean;
+    addLocalFriend(className: string, friendName: string): void;
+    isLocalFriend(className: string, friendName: string): boolean;
+    getEnclosingClassName(): string | undefined;
     isGlobalOO(): boolean;
     isTypePool(): boolean;
     setAllowHeaderUse(name: string): void;
@@ -3277,6 +3284,7 @@ export declare interface IClassDefinition extends IInterfaceDefinition {
     isAbstract(): boolean;
     isSharedMemory(): boolean;
     getFriends(): string[];
+    getCreateVisibility(): Visibility;
 }
 
 declare interface IClassImplementation extends Identifier {

package/build/src/abap/2_statements/statements/read_table.js

@@ -13,7 +13,9 @@ class ReadTable {
         const key = (0, combi_1.seq)((0, combi_1.altPrio)("WITH KEY", "WITH TABLE KEY"), (0, combi_1.alt)(expressions_1.ComponentCompareSimple, components, (0, combi_1.seq)((0, combi_1.optPrio)("="), expressions_1.Source)));
         const using = (0, combi_1.seq)("USING KEY", (0, combi_1.alt)(expressions_1.Field, expressions_1.Dynamic));
         const from = (0, combi_1.seq)("FROM", expressions_1.Source);
-        const perm = (0, combi_1.per)((0, combi_1.alt)(index, key, from), expressions_1.ReadTableTarget, using, comparing, "CASTING", (0, combi_1.seq)("TRANSPORTING", (0, combi_1.altPrio)("ALL FIELDS", "NO FIELDS", transporting_fields_1.TransportingFields)), "BINARY SEARCH");
+        const transporting = (0, combi_1.seq)("TRANSPORTING", (0, combi_1.altPrio)("ALL FIELDS", "NO FIELDS", transporting_fields_1.TransportingFields));
+        const common = [expressions_1.ReadTableTarget, comparing, "CASTING", transporting, "BINARY SEARCH"];
+        const perm = (0, combi_1.alt)((0, combi_1.per)((0, combi_1.alt)(index, from), using, ...common), (0, combi_1.per)(key, ...common), (0, combi_1.per)(...common));
         return (0, combi_1.seq)("READ TABLE", (0, combi_1.alt)(expressions_1.SimpleSource2, (0, combi_1.ver)(version_1.Version.v740sp02, expressions_1.Source, version_1.Version.OpenABAP)), (0, combi_1.opt)(perm));
     }
 }

package/build/src/abap/5_syntax/_builtin.js

@@ -504,7 +504,7 @@ BuiltIn.methods = {
     "CONCAT_LINES_OF": {
         counter: BuiltIn.counter++,
         mandatory: {
-            "table": new basic_1.TableType(basic_1.AnyType.get(), { withHeader: false, keyType: basic_1.TableKeyType.default }),
+            "table": new basic_1.TableType(basic_1.AnyType.get(), { withHeader: false, keyType: basic_1.TableKeyType.user }),
         },
         optional: {
             "sep": basic_1.CLikeType.get(),
@@ -802,7 +802,7 @@ BuiltIn.methods = {
     "LINES": {
         counter: BuiltIn.counter++,
         mandatory: {
-            "val": new basic_1.TableType(basic_1.AnyType.get(), { withHeader: false, keyType: basic_1.TableKeyType.default }),
+            "val": new basic_1.TableType(basic_1.AnyType.get(), { withHeader: false, keyType: basic_1.TableKeyType.user }),
         },
         return: basic_1.IntegerType.get(),
     },

package/build/src/abap/5_syntax/_current_scope.js

@@ -29,6 +29,7 @@ class CurrentScope {
         }
     }
     constructor(reg, obj) {
+        this.localFriends = new Map();
         this.current = undefined;
         this.parentObj = obj;
         this.reg = reg;
@@ -452,6 +453,27 @@ class CurrentScope {
         }
         return false;
     }
+    addLocalFriend(className, friendName) {
+        var _a;
+        const key = className.toUpperCase();
+        const list = (_a = this.localFriends.get(key)) !== null && _a !== void 0 ? _a : [];
+        list.push(friendName.toUpperCase());
+        this.localFriends.set(key, list);
+    }
+    isLocalFriend(className, friendName) {
+        var _a;
+        return ((_a = this.localFriends.get(className.toUpperCase())) === null || _a === void 0 ? void 0 : _a.includes(friendName.toUpperCase())) === true;
+    }
+    getEnclosingClassName() {
+        let curr = this.current;
+        while (curr !== undefined) {
+            if (curr.getIdentifier().stype === _scope_type_1.ScopeType.ClassImplementation) {
+                return curr.getIdentifier().sname;
+            }
+            curr = curr.getParent();
+        }
+        return undefined;
+    }
     isGlobalOO() {
         return this.parentObj.getType() === "INTF" || this.parentObj.getType() === "CLAS";
     }

package/build/src/abap/5_syntax/_type_utils.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.TypeUtils = void 0;
 const types_1 = require("../types");
 const basic_1 = require("../types/basic");
+const table_type_1 = require("../types/basic/table_type");
 const enum_type_1 = require("../types/basic/enum_type");
 const cgeneric_type_1 = require("../types/basic/cgeneric_type");
 const Expressions = require("../2_statements/expressions");
@@ -431,6 +432,17 @@ class TypeUtils {
         }
         else if (source instanceof basic_1.TableType) {
             if (target instanceof basic_1.TableType) {
+                const sourceKeyType = source.getOptions().keyType;
+                const targetKeyType = target.getOptions().keyType;
+                if (sourceKeyType !== targetKeyType
+                    && sourceKeyType !== table_type_1.TableKeyType.user
+                    && targetKeyType !== table_type_1.TableKeyType.user) {
+                    return false;
+                }
+                if (sourceKeyType === table_type_1.TableKeyType.empty && targetKeyType !== table_type_1.TableKeyType.empty
+                    && !(target.getRowType() instanceof basic_1.AnyType)) {
+                    return false;
+                }
                 return this.isAssignableStrict(source.getRowType(), target.getRowType());
             }
             else if (target instanceof basic_1.UnknownType

package/build/src/abap/5_syntax/basic_types.js

@@ -527,7 +527,7 @@ class BasicTypes {
             || text === "TYPE HASHED TABLE"
             || text === "TYPE INDEX TABLE"
             || text === "TYPE ANY TABLE") {
-            return new Types.TableType(Types.AnyType.get(), { withHeader: node.concatTokens().toUpperCase().includes("WITH HEADER LINE"), keyType: Types.TableKeyType.default });
+            return new Types.TableType(Types.AnyType.get(), { withHeader: node.concatTokens().toUpperCase().includes("WITH HEADER LINE"), keyType: Types.TableKeyType.user });
         }
         else if (text.startsWith("LIKE ")) {
             let sub = node.findFirstExpression(Expressions.Type);

package/build/src/abap/5_syntax/expressions/method_parameters.js

@@ -111,7 +111,7 @@ class MethodParameters {
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                 return;
             }
-            else if (item.targetType && new _type_utils_1.TypeUtils(input.scope).isAssignable(parameterType, item.targetType) === false) {
+            else if (item.targetType && new _type_utils_1.TypeUtils(input.scope).isAssignableStrict(parameterType, item.targetType) === false) {
                 const message = "Method parameter type not compatible, " + item.name;
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                 return;
@@ -139,7 +139,7 @@ class MethodParameters {
                 }
                 parameterType = parameter.getType();
             }
-            if (item.targetType && new _type_utils_1.TypeUtils(input.scope).isAssignable(parameterType, item.targetType) === false) {
+            if (item.targetType && new _type_utils_1.TypeUtils(input.scope).isAssignableStrict(parameterType, item.targetType) === false) {
                 const message = "Method parameter type not compatible, " + item.name;
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                 return;

package/build/src/abap/5_syntax/expressions/new_object.js

@@ -12,6 +12,7 @@ const _type_utils_1 = require("../_type_utils");
 const _syntax_input_1 = require("../_syntax_input");
 const assert_error_1 = require("../assert_error");
 const _typed_identifier_1 = require("../../types/_typed_identifier");
+const create_object_1 = require("../statements/create_object");
 class NewObject {
     static runSyntax(node, input, targetType) {
         let ret = undefined;
@@ -45,6 +46,13 @@ class NewObject {
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                 return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
             }
+            if (clas) {
+                const err = create_object_1.CreateObject.checkInstantiationAllowed(clas, input);
+                if (err) {
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), err));
+                    return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                }
+            }
         }
         else if (typeName === "#" && targetType) {
             ret = targetType;
@@ -66,6 +74,13 @@ class NewObject {
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                     return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                 }
+                if (clas) {
+                    const err = create_object_1.CreateObject.checkInstantiationAllowed(clas, input);
+                    if (err) {
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), err));
+                        return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                    }
+                }
                 ret = objref;
             }
         }

package/build/src/abap/5_syntax/expressions/select.js

@@ -322,16 +322,17 @@ class Select {
         if (dbSources.length !== 1) {
             return basic_1.VoidType.get("SELECT_todo3");
         }
+        const tableOptions = { withHeader: false, keyType: basic_1.TableKeyType.empty };
         if (dbSources[0] === undefined) {
             // then its a voided table
-            return basic_1.VoidType.get("SELECT_todo4");
+            return new basic_1.TableType(basic_1.VoidType.get("SELECT_todo4"), tableOptions, undefined);
         }
         const dbType = dbSources[0].parseType(scope.getRegistry());
         if (!(dbType instanceof basic_1.StructureType)) {
             return basic_1.VoidType.get("SELECT_todo5");
         }
         if (fields.length === 1 && fields[0].code === "*") {
-            return new basic_1.TableType(dbType, { withHeader: false, keyType: basic_1.TableKeyType.default }, undefined);
+            return new basic_1.TableType(dbType, tableOptions, undefined);
         }
         const allFieldsSimple = fields.every(f => isSimple.test(f.code));
         if (allFieldsSimple === true) {
@@ -343,7 +344,7 @@ class Select {
                 }
                 components.push({ name: field.code, type });
             }
-            return new basic_1.TableType(new basic_1.StructureType(components), { withHeader: false, keyType: basic_1.TableKeyType.default }, undefined);
+            return new basic_1.TableType(new basic_1.StructureType(components), tableOptions, undefined);
         }
         return basic_1.VoidType.get("SELECT_todo7");
     }

package/build/src/abap/5_syntax/expressions/source.js

@@ -121,6 +121,11 @@ class Source {
                             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                             return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                         }
+                        else if (foundType === null || foundType === void 0 ? void 0 : foundType.isGeneric()) {
+                            const message = "Cannot CONV to generic type";
+                            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                            return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                        }
                         this.addIfInferred(node, input, foundType);
                         return foundType;
                     }

package/build/src/abap/5_syntax/statements/class_local_friends.js

@@ -6,6 +6,7 @@ const _reference_1 = require("../_reference");
 const _syntax_input_1 = require("../_syntax_input");
 class ClassLocalFriends {
     runSyntax(node, input) {
+        var _a;
         const classNames = node.findAllExpressions(Expressions.ClassName);
         const found = classNames[0];
         if (found) {
@@ -36,6 +37,12 @@ class ClassLocalFriends {
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                 return;
             }
+            else {
+                const befriendedName = (_a = classNames[0]) === null || _a === void 0 ? void 0 : _a.getFirstToken().getStr();
+                if (befriendedName) {
+                    input.scope.addLocalFriend(befriendedName, className);
+                }
+            }
         }
     }
 }

package/build/src/abap/5_syntax/statements/create_object.js

@@ -11,6 +11,7 @@ const types_1 = require("../../types");
 const _object_oriented_1 = require("../_object_oriented");
 const _type_utils_1 = require("../_type_utils");
 const _syntax_input_1 = require("../_syntax_input");
+const visibility_1 = require("../../4_file_information/visibility");
 class CreateObject {
     runSyntax(node, input) {
         var _a;
@@ -107,8 +108,46 @@ class CreateObject {
             ooName = found.getVoided();
         }
         input.scope.addReference(t === null || t === void 0 ? void 0 : t.getFirstToken(), cdef, _reference_1.ReferenceType.ConstructorReference, input.filename, { ooName: ooName });
+        if (cdef !== undefined) {
+            const err = CreateObject.checkInstantiationAllowed(cdef, input);
+            if (err) {
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), err));
+                return;
+            }
+        }
         this.validateParameters(cdef, node, input);
     }
+    static checkInstantiationAllowed(cdef, input) {
+        var _a, _b;
+        const createVis = cdef.getCreateVisibility();
+        if (createVis === visibility_1.Visibility.Public) {
+            return undefined;
+        }
+        const enclosingClass = input.scope.getEnclosingClassName();
+        if (enclosingClass === undefined) {
+            return cdef.getName() + " cannot be instantiated, class is defined as " +
+                (createVis === visibility_1.Visibility.Private ? "private" : "protected");
+        }
+        if (enclosingClass.toUpperCase() === cdef.getName().toUpperCase()) {
+            return undefined;
+        }
+        if (cdef.getFriends().some(f => f.toUpperCase() === enclosingClass.toUpperCase()) ||
+            input.scope.isLocalFriend(cdef.getName(), enclosingClass)) {
+            return undefined;
+        }
+        if (createVis === visibility_1.Visibility.Protected) {
+            // subclasses are also allowed
+            let sup = (_a = input.scope.findClassDefinition(enclosingClass)) === null || _a === void 0 ? void 0 : _a.getSuperClass();
+            while (sup !== undefined) {
+                if (sup.toUpperCase() === cdef.getName().toUpperCase()) {
+                    return undefined;
+                }
+                sup = (_b = input.scope.findClassDefinition(sup)) === null || _b === void 0 ? void 0 : _b.getSuperClass();
+            }
+        }
+        return cdef.getName() + " cannot be instantiated, class is defined as " +
+            (createVis === visibility_1.Visibility.Private ? "private" : "protected");
+    }
     validateParameters(cdef, node, input) {
         var _a, _b, _c, _d;
         if (cdef === undefined) {

package/build/src/abap/types/class_attributes.js

@@ -26,6 +26,7 @@ class Attributes {
         this.instance = [];
         this.constants = [];
         this.aliases = [];
+        this.declaredInterfaces = [];
         this.tlist = [];
         this.filename = input.filename;
         this.parse(node, input);
@@ -101,8 +102,15 @@ class Attributes {
     }
     /////////////////////////////
     parse(node, input) {
+        var _a, _b;
         const cdef = node.findDirectStructure(Structures.ClassDefinition);
         if (cdef) {
+            for (const i of cdef.findAllStatements(Statements.InterfaceDef)) {
+                const name = (_a = i.findFirstExpression(Expressions.InterfaceName)) === null || _a === void 0 ? void 0 : _a.getFirstToken().getStr();
+                if (name) {
+                    this.declaredInterfaces.push(name.toUpperCase());
+                }
+            }
             this.parseSection(cdef.findDirectStructure(Structures.PublicSection), visibility_1.Visibility.Public, input);
             this.parseSection(cdef.findDirectStructure(Structures.ProtectedSection), visibility_1.Visibility.Protected, input);
             this.parseSection(cdef.findDirectStructure(Structures.PrivateSection), visibility_1.Visibility.Private, input);
@@ -110,6 +118,12 @@ class Attributes {
         }
         const idef = node.findDirectStructure(Structures.Interface);
         if (idef) {
+            for (const i of idef.findAllStatements(Statements.InterfaceDef)) {
+                const name = (_b = i.findFirstExpression(Expressions.InterfaceName)) === null || _b === void 0 ? void 0 : _b.getFirstToken().getStr();
+                if (name) {
+                    this.declaredInterfaces.push(name.toUpperCase());
+                }
+            }
             this.parseSection(idef.findDirectStructure(Structures.SectionContents), visibility_1.Visibility.Public, input);
             return;
         }
@@ -218,6 +232,12 @@ class Attributes {
                     input.scope.addNamedIdentifier(aliasName.getStr(), foundAttribute);
                 }
             }
+            else if (this.declaredInterfaces.includes(name.toUpperCase()) || input.scope.getDDIC().inErrorNamespace(name) === false) {
+                input.scope.addReference(compToken, undefined, _reference_1.ReferenceType.ObjectOrientedVoidReference, input.filename);
+            }
+            else {
+                throw new Error("Interface " + name + " not found");
+            }
         }
     }
     parseAttribute(node, visibility, input) {

package/build/src/abap/types/class_definition.js

@@ -13,6 +13,7 @@ const event_definition_1 = require("./event_definition");
 const visibility_1 = require("../4_file_information/visibility");
 const _object_oriented_1 = require("../5_syntax/_object_oriented");
 const _reference_1 = require("../5_syntax/_reference");
+const _syntax_input_1 = require("../5_syntax/_syntax_input");
 class ClassDefinition extends _identifier_1.Identifier {
     constructor(node, input) {
         var _a;
@@ -50,6 +51,15 @@ class ClassDefinition extends _identifier_1.Identifier {
         this.testing = concat.includes(" FOR TESTING");
         this.sharedMemory = concat.includes(" SHARED MEMORY ENABLED");
         this.abstract = (def === null || def === void 0 ? void 0 : def.findDirectTokenByText("ABSTRACT")) !== undefined;
+        if (concat.includes(" CREATE PRIVATE")) {
+            this.createVisibilityValue = visibility_1.Visibility.Private;
+        }
+        else if (concat.includes(" CREATE PROTECTED")) {
+            this.createVisibilityValue = visibility_1.Visibility.Protected;
+        }
+        else {
+            this.createVisibilityValue = visibility_1.Visibility.Public;
+        }
         // perform checks after everything has been initialized
         this.checkMethodsFromSuperClasses(input.scope);
         this.checkMethodNameLength();
@@ -93,6 +103,9 @@ class ClassDefinition extends _identifier_1.Identifier {
     isSharedMemory() {
         return this.sharedMemory;
     }
+    getCreateVisibility() {
+        return this.createVisibilityValue;
+    }
     /*
       public getEvents() {
       }
@@ -148,8 +161,20 @@ class ClassDefinition extends _identifier_1.Identifier {
         const result = [];
         for (const n of ((_a = def === null || def === void 0 ? void 0 : def.findDirectExpression(Expressions.ClassFriends)) === null || _a === void 0 ? void 0 : _a.findDirectExpressions(Expressions.ClassName)) || []) {
             const token = n.getFirstToken();
-            this.addReference(token, input);
             const name = token.getStr();
+            const s = input.scope.findClassDefinition(name);
+            if (s) {
+                input.scope.addReference(token, s, _reference_1.ReferenceType.ObjectOrientedReference, input.filename, { ooName: name.toUpperCase(), ooType: "CLAS" });
+            }
+            else if (input.scope.existsObject(name) !== undefined) {
+                // DEFINITION DEFERRED friend
+            }
+            else if (input.scope.getDDIC().inErrorNamespace(name) === false) {
+                input.scope.addReference(token, undefined, _reference_1.ReferenceType.ObjectOrientedVoidReference, input.filename);
+            }
+            else {
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, token, name.toUpperCase() + " does not exist"));
+            }
             result.push(name);
         }
         return result;

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.118.4";
+        return "2.118.6";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/catch_and_raise.js

@@ -0,0 +1,82 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.CatchAndRaise = exports.CatchAndRaiseConf = void 0;
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+const Structures = require("../abap/3_structures/structures");
+const Statements = require("../abap/2_statements/statements");
+const Expressions = require("../abap/2_statements/expressions");
+class CatchAndRaiseConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.CatchAndRaiseConf = CatchAndRaiseConf;
+class CatchAndRaise extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new CatchAndRaiseConf();
+    }
+    getMetadata() {
+        return {
+            key: "catch_and_raise",
+            title: "Catch and re-raise same exception",
+            shortDescription: `Reports CATCH blocks that only re-raise the caught exception without any handling`,
+            badExample: `TRY.\n  something( ).\nCATCH zcx_something INTO DATA(lv_exc).\n  RAISE EXCEPTION lv_exc.\nENDTRY.`,
+            goodExample: `TRY.\n  something( ).\nCATCH zcx_something.\n  " handle exception\nENDTRY.`,
+            tags: [_irule_1.RuleTag.SingleFile],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        const stru = file.getStructure();
+        if (stru === undefined) {
+            return [];
+        }
+        for (const catchStruct of stru.findAllStructures(Structures.Catch)) {
+            const catchStatement = catchStruct.findDirectStatement(Statements.Catch);
+            if (catchStatement === undefined) {
+                continue;
+            }
+            const target = catchStatement.findFirstExpression(Expressions.Target);
+            if (target === undefined) {
+                continue;
+            }
+            const targetField = target.findFirstExpression(Expressions.TargetField);
+            if (targetField === undefined) {
+                continue;
+            }
+            const caughtVar = targetField.getFirstToken().getStr().toUpperCase();
+            const allStatements = catchStruct.findAllStatementNodes();
+            if (allStatements.length !== 2) {
+                continue;
+            }
+            if (!(allStatements[1].get() instanceof Statements.Raise)) {
+                continue;
+            }
+            const raiseStatement = allStatements[1];
+            const raiseConcat = raiseStatement.concatTokens().toUpperCase().replace(/\.$/, "").trim();
+            if (!raiseConcat.startsWith("RAISE EXCEPTION ")) {
+                continue;
+            }
+            const parts = raiseConcat.split(/\s+/);
+            if (parts.length !== 3) {
+                continue;
+            }
+            if (parts[2] === caughtVar) {
+                issues.push(issue_1.Issue.atStatement(file, catchStatement, this.getMessage(), this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
+    getMessage() {
+        return "Caught exception is immediately re-raised, CATCH block has no effect";
+    }
+}
+exports.CatchAndRaise = CatchAndRaise;
+//# sourceMappingURL=catch_and_raise.js.map

package/build/src/rules/index.js

@@ -28,6 +28,7 @@ __exportStar(require("./avoid_use"), exports);
 __exportStar(require("./begin_end_names"), exports);
 __exportStar(require("./begin_single_include"), exports);
 __exportStar(require("./call_transaction_authority_check"), exports);
+__exportStar(require("./catch_and_raise"), exports);
 __exportStar(require("./cds_association_name"), exports);
 __exportStar(require("./cds_comment_style"), exports);
 __exportStar(require("./cds_field_order"), exports);

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.118.4",
+    "version": "2.118.6",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -63,7 +63,7 @@
         "typescript": "^5.9.3"
     },
     "dependencies": {
-        "fast-xml-parser": "^5.5.8",
+        "fast-xml-parser": "^5.5.9",
         "json5": "^2.2.3",
         "vscode-languageserver-types": "^3.17.5"
     }