@abaplint/core 2.118.11 → 2.119.0

package/build/src/abap/2_statements/expressions/class_name.js

@@ -4,7 +4,7 @@ exports.ClassName = void 0;
 const combi_1 = require("../combi");
 class ClassName extends combi_1.Expression {
     getRunnable() {
-        return (0, combi_1.regex)(/^\w*(\/\w{3,}\/)?\w+$/);
+        return (0, combi_1.regex)(/^!?\w*(\/\w{3,}\/)?\w+$/);
     }
 }
 exports.ClassName = ClassName;

package/build/src/abap/2_statements/expressions/default.js

@@ -6,7 +6,7 @@ const _1 = require(".");
 class Default extends combi_1.Expression {
     getRunnable() {
         // todo, DEFAULT is only valid for definitions in relation to method parameters
-        const def = (0, combi_1.seq)("DEFAULT", (0, combi_1.altPrio)(_1.Constant, _1.FieldChain));
+        const def = (0, combi_1.seq)("DEFAULT", (0, combi_1.altPrio)(_1.TextElement, _1.Constant, _1.FieldChain));
         return def;
     }
 }

package/build/src/abap/2_statements/expressions/function_parameters.js

@@ -9,7 +9,7 @@ class FunctionParameters extends combi_1.Expression {
         const importing = (0, combi_1.seq)("IMPORTING", _1.ParameterListT);
         const changing = (0, combi_1.seq)("CHANGING", _1.ParameterListT);
         const tables = (0, combi_1.seq)("TABLES", _1.ParameterListT);
-        const exceptions = (0, combi_1.seq)("EXCEPTIONS", (0, combi_1.altPrio)(_1.ParameterListExceptions, (0, combi_1.plus)(_1.Field)));
+        const exceptions = (0, combi_1.seq)("EXCEPTIONS", _1.ParameterListExceptions);
         const long = (0, combi_1.seq)((0, combi_1.optPrio)(exporting), (0, combi_1.optPrio)(importing), (0, combi_1.optPrio)(tables), (0, combi_1.optPrio)(changing), (0, combi_1.optPrio)(exceptions));
         return long;
     }

package/build/src/abap/2_statements/expressions/parameter_exception.js

@@ -6,7 +6,7 @@ const _1 = require(".");
 class ParameterException extends combi_1.Expression {
     getRunnable() {
         const name = (0, combi_1.altPrio)("OTHERS", _1.ParameterName);
-        return (0, combi_1.seq)(name, "=", (0, combi_1.altPrio)(_1.Integer, _1.SimpleFieldChain), (0, combi_1.optPrio)((0, combi_1.seq)("MESSAGE", _1.Target)));
+        return (0, combi_1.seq)(name, (0, combi_1.optPrio)((0, combi_1.seq)("=", (0, combi_1.altPrio)(_1.Integer, _1.SimpleFieldChain), (0, combi_1.optPrio)((0, combi_1.seq)("MESSAGE", _1.Target)))));
     }
 }
 exports.ParameterException = ParameterException;

package/build/src/abap/2_statements/expressions/report_name.js

@@ -5,7 +5,7 @@ const combi_1 = require("../combi");
 const tokens_1 = require("../../1_lexer/tokens");
 class ReportName extends combi_1.Expression {
     getRunnable() {
-        return (0, combi_1.seq)((0, combi_1.regex)(/^[\w/$%&]+$/), (0, combi_1.star)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.Dash), (0, combi_1.regex)(/^\w+$/))));
+        return (0, combi_1.seq)((0, combi_1.regex)(/^[\w/$%&=]+$/), (0, combi_1.star)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.Dash), (0, combi_1.regex)(/^\w+$/))));
     }
 }
 exports.ReportName = ReportName;

package/build/src/abap/2_statements/expressions/select_loop.js

@@ -20,7 +20,7 @@ class SelectLoop extends combi_1.Expression {
         const tab = (0, combi_1.seq)(_1.SQLIntoTable, (0, combi_1.alt)(pack, (0, combi_1.seq)(_1.SQLFrom, pack), (0, combi_1.seq)(pack, _1.SQLFrom)));
         const packTab = (0, combi_1.seq)(pack, _1.SQLIntoTable);
         const into = (0, combi_1.altPrio)(sql_into_structure_1.SQLIntoStructure, _1.SQLIntoList);
-        const perm = (0, combi_1.per)(_1.SQLFrom, where, sql_up_to_1.SQLUpTo, sql_order_by_1.SQLOrderBy, sql_having_1.SQLHaving, _1.SQLClient, bypass, _1.SQLGroupBy, _1.SQLForAllEntries, (0, combi_1.alt)(tab, sql_into_structure_1.SQLIntoStructure, _1.SQLIntoList, packTab));
+        const perm = (0, combi_1.per)(_1.SQLFrom, where, sql_up_to_1.SQLUpTo, sql_order_by_1.SQLOrderBy, sql_having_1.SQLHaving, _1.SQLClient, bypass, _1.SQLGroupBy, _1.SQLForAllEntries, _1.DatabaseConnection, (0, combi_1.alt)(tab, sql_into_structure_1.SQLIntoStructure, _1.SQLIntoList, packTab));
         const strict = (0, combi_1.seq)(_1.SQLFrom, (0, combi_1.ver)(version_1.Version.v750, sql_fields_loop_1.SQLFieldsLoop), (0, combi_1.optPrio)(_1.SQLForAllEntries), (0, combi_1.optPrio)((0, combi_1.seq)(where, (0, combi_1.optPrio)(sql_order_by_1.SQLOrderBy), into, (0, combi_1.optPrio)(sql_up_to_1.SQLUpTo))));
         const aggr = (0, combi_1.seq)((0, combi_1.plusPrio)(_1.SQLAggregation), into, (0, combi_1.optPrio)(sql_up_to_1.SQLUpTo), _1.SQLFrom, (0, combi_1.optPrio)(_1.SQLClient), (0, combi_1.optPrio)(where), _1.SQLGroupBy);
         const ret = (0, combi_1.seq)("SELECT", (0, combi_1.altPrio)((0, combi_1.seq)((0, combi_1.optPrio)("DISTINCT"), sql_field_list_loop_1.SQLFieldListLoop, perm), strict, aggr), (0, combi_1.optPrio)(sql_hints_1.SQLHints));

package/build/src/abap/2_statements/statements/move_corresponding.js

@@ -6,8 +6,8 @@ const expressions_1 = require("../expressions");
 const version_1 = require("../../../version");
 class MoveCorresponding {
     getMatcher() {
-        const keeping = (0, combi_1.ver)(version_1.Version.v740sp05, "KEEPING TARGET LINES");
-        const expanding = (0, combi_1.ver)(version_1.Version.v740sp05, "EXPANDING NESTED TABLES");
+        const keeping = (0, combi_1.ver)(version_1.Version.v740sp05, "KEEPING TARGET LINES", version_1.Version.OpenABAP);
+        const expanding = (0, combi_1.ver)(version_1.Version.v740sp05, "EXPANDING NESTED TABLES", version_1.Version.OpenABAP);
         const move = (0, combi_1.seq)("MOVE-CORRESPONDING", (0, combi_1.optPrio)("EXACT"), expressions_1.Source, "TO", 
         // inline defintions not possible in this position,
         expressions_1.SimpleTarget, (0, combi_1.optPrio)(expanding), (0, combi_1.optPrio)(keeping));

package/build/src/abap/2_statements/statements/report.js

@@ -7,7 +7,7 @@ const version_1 = require("../../../version");
 const tokens_1 = require("../../1_lexer/tokens");
 class Report {
     getMatcher() {
-        const more = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.ParenLeft), expressions_1.Integer, (0, combi_1.tok)(tokens_1.ParenRightW));
+        const more = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.ParenLeft), expressions_1.Integer, (0, combi_1.alt)((0, combi_1.tok)(tokens_1.ParenRightW), (0, combi_1.tok)(tokens_1.ParenRight)));
         const heading = (0, combi_1.str)("NO STANDARD PAGE HEADING");
         const size = (0, combi_1.seq)("LINE-SIZE", expressions_1.Integer);
         const count = (0, combi_1.seq)("LINE-COUNT", expressions_1.Integer, (0, combi_1.opt)(more));

package/build/src/abap/2_statements/statements/submit.js

@@ -37,7 +37,7 @@ class Submit {
         const imm = (0, combi_1.seq)("IMMEDIATELY", expressions_1.Source);
         const dest = (0, combi_1.seq)("DESTINATION", expressions_1.Source);
         const language = (0, combi_1.seq)("LANGUAGE", expressions_1.Source);
-        const perm = (0, combi_1.per)((0, combi_1.plus)(awith), selectionTable, (0, combi_1.plus)(awith), (0, combi_1.plus)(awith), spool, lineSize, lineCount, archive, archiveMode, receiver, user, sset, ssetp, keep, cover, imm, layout, dest, coverText, listName, language, free, newList, uss, copies, datasetExpiration, "TO SAP-SPOOL", "WITHOUT SPOOL DYNPRO", "VIA SELECTION-SCREEN", exporting, expressions_1.AndReturn, job);
+        const perm = (0, combi_1.per)((0, combi_1.plusPrio)(awith), selectionTable, (0, combi_1.plusPrio)(awith), (0, combi_1.plusPrio)(awith), spool, lineSize, lineCount, archive, archiveMode, receiver, user, sset, ssetp, keep, cover, imm, layout, dest, coverText, listName, language, free, newList, uss, copies, datasetExpiration, "TO SAP-SPOOL", "WITHOUT SPOOL DYNPRO", "VIA SELECTION-SCREEN", exporting, expressions_1.AndReturn, job);
         const ret = (0, combi_1.seq)("SUBMIT", prog, (0, combi_1.opt)(perm));
         return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
     }

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.118.11";
+        return "2.119.0";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/index.js

@@ -196,4 +196,6 @@ __exportStar(require("./use_new"), exports);
 __exportStar(require("./when_others_last"), exports);
 __exportStar(require("./whitespace_end"), exports);
 __exportStar(require("./xml_consistency"), exports);
+__exportStar(require("./no_exclamation_escape"), exports);
+__exportStar(require("./no_exclamation_escape"), exports);
 //# sourceMappingURL=index.js.map

package/build/src/rules/no_exclamation_escape.js

@@ -0,0 +1,52 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.NoExclamationEscape = exports.NoExclamationEscapeConf = void 0;
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+const edit_helper_1 = require("../edit_helper");
+const tokens_1 = require("../abap/1_lexer/tokens");
+class NoExclamationEscapeConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.NoExclamationEscapeConf = NoExclamationEscapeConf;
+class NoExclamationEscape extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new NoExclamationEscapeConf();
+    }
+    getMetadata() {
+        return {
+            key: "no_exclamation_escape",
+            title: "No exclamation escape",
+            shortDescription: `Detects and removes exclamation marks (!) used to escape identifiers`,
+            // eslint-disable-next-line max-len
+            extendedInformation: `Exclamation marks are not needed when the identifier is not a reserved keyword, or could be avoided by renaming.`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
+            badExample: "methods CONVERT changing !CO_sdf type ref to ZCL_sdf optional.",
+            goodExample: "methods CONVERT changing CO_sdf type ref to ZCL_sdf optional.",
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        for (const token of file.getTokens()) {
+            if (token instanceof tokens_1.Identifier) {
+                const str = token.getStr();
+                if (str.startsWith("!")) {
+                    const replacement = str.substring(1);
+                    const fix = edit_helper_1.EditHelper.replaceToken(file, token, replacement);
+                    issues.push(issue_1.Issue.atToken(file, token, "Do not use exclamation mark to escape identifiers", this.getMetadata().key, this.conf.severity, fix));
+                }
+            }
+        }
+        return issues;
+    }
+}
+exports.NoExclamationEscape = NoExclamationEscape;
+//# sourceMappingURL=no_exclamation_escape.js.map

package/build/src/rules/parser_bad_exceptions.js

@@ -35,18 +35,17 @@ class ParserBadExceptions extends _abap_rule_1.ABAPRule {
         this.conf = conf;
     }
     runParsed(file) {
-        var _a;
         const issues = [];
         for (const statement of file.getStatements()) {
             if (!(statement.get() instanceof Statements.CallFunction)) {
                 continue;
             }
-            const found = (_a = statement.findDirectExpression(Expressions.FunctionParameters)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.Field);
-            if (found === undefined) {
-                continue;
+            for (const e of statement.findAllExpressions(Expressions.ParameterException)) {
+                if (e.findDirectTokenByText("=") === undefined) {
+                    const message = "Bad EXCEPTIONS syntax in CALL FUNCTION";
+                    issues.push(issue_1.Issue.atToken(file, e.getFirstToken(), message, this.getMetadata().key, this.conf.severity));
+                }
             }
-            const message = "Bad EXCEPTIONS syntax in CALL FUNCTION";
-            issues.push(issue_1.Issue.atToken(file, found.getFirstToken(), message, this.getMetadata().key, this.conf.severity));
         }
         return issues;
     }

package/build/src/rules/slow_parameter_passing.js

@@ -8,6 +8,7 @@ const _abap_object_1 = require("../objects/_abap_object");
 const syntax_1 = require("../abap/5_syntax/syntax");
 const _scope_type_1 = require("../abap/5_syntax/_scope_type");
 const _reference_1 = require("../abap/5_syntax/_reference");
+const edit_helper_1 = require("../edit_helper");
 class SlowParameterPassingConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.SlowParameterPassingConf = SlowParameterPassingConf;
@@ -21,7 +22,7 @@ class SlowParameterPassing {
             title: "Slow Parameter Passing",
             shortDescription: `Detects slow pass by value passing for methods where parameter is not changed`,
             extendedInformation: `Method parameters defined in interfaces is not checked`,
-            tags: [_irule_1.RuleTag.Performance],
+            tags: [_irule_1.RuleTag.Performance, _irule_1.RuleTag.Quickfix],
             badExample: `CLASS lcl DEFINITION.
   PUBLIC SECTION.
     METHODS bar IMPORTING VALUE(sdf) TYPE string.
@@ -77,7 +78,25 @@ ENDCLASS.`,
                 const writes = this.listWritePositions(m, id);
                 if (writes.length === 0) {
                     const message = "Parameter " + id.getName() + " passed by VALUE but not changed";
-                    issues.push(issue_1.Issue.atIdentifier(id, message, this.getMetadata().key, this.getConfig().severity));
+                    let fix = undefined;
+                    const file = obj.getABAPFiles().find(f => f.getFilename() === id.getFilename());
+                    if (file) {
+                        const tokens = file.getTokens();
+                        for (let i = 0; i < tokens.length; i++) {
+                            if (tokens[i].getStart().equals(id.getToken().getStart())) {
+                                const prev1 = tokens[i - 1];
+                                const prev2 = tokens[i - 2];
+                                const next1 = tokens[i + 1];
+                                if ((prev1 === null || prev1 === void 0 ? void 0 : prev1.getStr()) === "("
+                                    && (prev2 === null || prev2 === void 0 ? void 0 : prev2.getStr().toUpperCase()) === "VALUE"
+                                    && (next1 === null || next1 === void 0 ? void 0 : next1.getStr()) === ")") {
+                                    fix = edit_helper_1.EditHelper.replaceRange(file, prev2.getStart(), next1.getEnd(), id.getToken().getStr());
+                                }
+                                break;
+                            }
+                        }
+                    }
+                    issues.push(issue_1.Issue.atIdentifier(id, message, this.getMetadata().key, this.getConfig().severity, fix));
                 }
             }
         }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.118.11",
+    "version": "2.119.0",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,10 +50,10 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.57.7",
+        "@microsoft/api-extractor": "^7.58.5",
         "@types/chai": "^4.3.20",
         "@types/mocha": "^10.0.10",
-        "@types/node": "^24.12.0",
+        "@types/node": "^24.12.2",
         "chai": "^4.5.0",
         "eslint": "^9.39.2",
         "mocha": "^11.7.5",
@@ -63,7 +63,7 @@
         "typescript": "^5.9.3"
     },
     "dependencies": {
-        "fast-xml-parser": "^5.5.9",
+        "fast-xml-parser": "^5.7.1",
         "json5": "^2.2.3",
         "vscode-languageserver-types": "^3.17.5"
     }