@abaplint/core 2.118.0 → 2.118.2

package/build/src/abap/5_syntax/expressions/database_table.js

@@ -6,7 +6,9 @@ const _syntax_input_1 = require("../_syntax_input");
 class DatabaseTable {
     static runSyntax(node, input) {
         const token = node.getFirstToken();
-        const name = token.getStr();
+        const rawName = token.getStr();
+        const starPrefixed = rawName.startsWith("*");
+        const name = starPrefixed ? rawName.substring(1) : rawName;
         if (name === "(") {
             // dynamic
             return undefined;

package/build/src/abap/5_syntax/expressions/field_chain.js

@@ -38,6 +38,7 @@ class FieldChain {
         let context = undefined;
         const children = node.getChildren();
         context = this.findTop(children[0], input, refType);
+        let prev = children[0].concatTokens();
         for (let i = 1; i < children.length; i++) {
             const current = children[i];
             if (current === undefined) {
@@ -78,7 +79,7 @@ class FieldChain {
                         }
                     }
                     else {
-                        const message = "Not a structure, FieldChain, " + (context === null || context === void 0 ? void 0 : context.constructor.name) + ", " + current.concatTokens();
+                        const message = prev.toUpperCase() + " is not structured (" + (context === null || context === void 0 ? void 0 : context.constructor.name) + ")";
                         input.issues.push((0, _syntax_input_1.syntaxIssue)(input, current.getFirstToken(), message));
                         return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
                     }
@@ -145,6 +146,7 @@ class FieldChain {
                     }
                 }
             }
+            prev = current.concatTokens();
         }
         return context;
     }

package/build/src/abap/5_syntax/expressions/function_parameters.js

@@ -0,0 +1,54 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.FunctionParameters = void 0;
+const Expressions = require("../../2_statements/expressions");
+const source_1 = require("./source");
+const target_1 = require("./target");
+const field_chain_1 = require("./field_chain");
+const _reference_1 = require("../_reference");
+const _syntax_input_1 = require("../_syntax_input");
+class FunctionParameters {
+    static runSyntax(node, input) {
+        // EXPORTING: process sources in each FunctionExportingParameter
+        for (const param of node.findAllExpressions(Expressions.FunctionExportingParameter)) {
+            const s = param.findDirectExpression(Expressions.Source);
+            if (s) {
+                source_1.Source.runSyntax(s, input);
+            }
+            const s3 = param.findDirectExpression(Expressions.SimpleSource3);
+            if (s3) {
+                source_1.Source.runSyntax(s3, input);
+            }
+        }
+        // IMPORTING / CHANGING / TABLES: process targets in each ParameterT
+        const changingList = node.findExpressionAfterToken("CHANGING");
+        for (const paramList of node.findDirectExpressions(Expressions.ParameterListT)) {
+            for (const param of paramList.findDirectExpressions(Expressions.ParameterT)) {
+                const t = param.findDirectExpression(Expressions.Target);
+                if (t) {
+                    target_1.Target.runSyntax(t, input);
+                }
+                if (paramList === changingList && t !== undefined) {
+                    // hmm, does this do the scoping correctly? handle constants etc? todo
+                    const found = input.scope.findVariable(t.concatTokens());
+                    if (found && found.getMeta().includes("read_only" /* IdentifierMeta.ReadOnly */)) {
+                        const message = `"${t.concatTokens()}" cannot be modified, it is readonly`;
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, t.getFirstToken(), message));
+                    }
+                }
+            }
+        }
+        // EXCEPTIONS: process field chains and optional MESSAGE targets
+        for (const exc of node.findAllExpressions(Expressions.ParameterException)) {
+            for (const s of exc.findDirectExpressions(Expressions.SimpleFieldChain)) {
+                field_chain_1.FieldChain.runSyntax(s, input, _reference_1.ReferenceType.DataReadReference);
+            }
+            const t = exc.findDirectExpression(Expressions.Target);
+            if (t) {
+                target_1.Target.runSyntax(t, input);
+            }
+        }
+    }
+}
+exports.FunctionParameters = FunctionParameters;
+//# sourceMappingURL=function_parameters.js.map

package/build/src/abap/5_syntax/statements/call_function.js

@@ -3,11 +3,11 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.CallFunction = void 0;
 const Expressions = require("../../2_statements/expressions");
 const source_1 = require("../expressions/source");
-const target_1 = require("../expressions/target");
 const field_chain_1 = require("../expressions/field_chain");
 const _reference_1 = require("../_reference");
 const version_1 = require("../../../version");
 const _syntax_input_1 = require("../_syntax_input");
+const function_parameters_1 = require("../expressions/function_parameters");
 class CallFunction {
     runSyntax(node, input) {
         // todo, lots of work here, similar to receive.ts
@@ -25,22 +25,15 @@ class CallFunction {
                 return;
             }
         }
-        // just recurse
-        for (const s of node.findAllExpressions(Expressions.Source)) {
-            source_1.Source.runSyntax(s, input);
-        }
-        for (const s of node.findAllExpressions(Expressions.SimpleSource3)) {
+        for (const s of node.findDirectExpressions(Expressions.SimpleSource2)) {
             source_1.Source.runSyntax(s, input);
         }
-        for (const t of node.findAllExpressions(Expressions.Target)) {
-            target_1.Target.runSyntax(t, input);
-        }
-        for (const s of node.findDirectExpressions(Expressions.SimpleSource2)) {
+        for (const s of node.findDirectExpressions(Expressions.Source)) {
             source_1.Source.runSyntax(s, input);
         }
-        const exceptions = node.findFirstExpression(Expressions.ParameterException);
-        for (const s of (exceptions === null || exceptions === void 0 ? void 0 : exceptions.findAllExpressions(Expressions.SimpleFieldChain)) || []) {
-            field_chain_1.FieldChain.runSyntax(s, input, _reference_1.ReferenceType.DataReadReference);
+        const fp = node.findDirectExpression(Expressions.FunctionParameters);
+        if (fp) {
+            function_parameters_1.FunctionParameters.runSyntax(fp, input);
         }
     }
 }

package/build/src/abap/5_syntax/statements/move.js

@@ -23,6 +23,15 @@ class Move {
                 target_1.Target.runSyntax(t, input);
             }
         }
+        if (inline === undefined && firstTarget !== undefined) {
+            // hmm, does this do the scoping correctly? handle constants etc? todo
+            const found = input.scope.findVariable(firstTarget.concatTokens());
+            if (found && found.getMeta().includes("read_only" /* IdentifierMeta.ReadOnly */)) {
+                const message = `"${firstTarget.concatTokens()}" cannot be modified, it is readonly`;
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, firstTarget.getFirstToken(), message));
+                return;
+            }
+        }
         const source = node.findDirectExpression(Expressions.Source);
         let sourceType = source ? source_1.Source.runSyntax(source, input, targetType) : undefined;
         if (sourceType === undefined) {

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.118.0";
+        return "2.118.2";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/abapdoc.js

@@ -96,12 +96,12 @@ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#abap-doc-on
                     issues.push(issue);
                 }
                 if (rowText.trim().match(regexEmptyAbapdoc) === null && previousRowsTexts.indexOf(rowText) === previousRowsTexts.length - 1) {
-                    const message = "Missing ABAP Doc for method " + method.identifier.getToken().getStr() + " (" + rowText + ")";
+                    const message = "Missing ABAP Doc for method " + method.identifier.getToken().getStr();
                     const issue = issue_1.Issue.atIdentifier(method.identifier, message, this.getMetadata().key, this.conf.severity);
                     issues.push(issue);
                 }
                 if (rowText.trim().match(regexEmptyParameterName) !== null) {
-                    const message = "Missing ABAP Doc parameter name for method " + method.identifier.getToken().getStr() + " (" + rowText + ")";
+                    const message = "Missing ABAP Doc parameter name for method " + method.identifier.getToken().getStr();
                     const issue = issue_1.Issue.atIdentifier(method.identifier, message, this.getMetadata().key, this.conf.severity);
                     issues.push(issue);
                 }

package/build/src/rules/cds_association_name.js

@@ -18,15 +18,15 @@ class CDSAssociationName {
             key: "cds_association_name",
             title: "CDS Association Name",
             shortDescription: `CDS association names should start with an underscore`,
-            extendedInformation: `By convention, CDS association names must start with an underscore character.
-
+            extendedInformation: `By convention, CDS association names must start with an underscore character.
+
 https://help.sap.com/docs/abap-cloud/abap-data-models/cds-associations`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Naming],
-            badExample: `define view entity test as select from source
-  association [1..1] to target as Assoc on Assoc.id = source.id
+            badExample: `define view entity test as select from source
+  association [1..1] to target as Assoc on Assoc.id = source.id
 { key id }`,
-            goodExample: `define view entity test as select from source
-  association [1..1] to target as _Assoc on _Assoc.id = source.id
+            goodExample: `define view entity test as select from source
+  association [1..1] to target as _Assoc on _Assoc.id = source.id
 { key id }`,
         };
     }

package/build/src/rules/cds_field_order.js

@@ -19,19 +19,19 @@ class CDSFieldOrder {
             title: "CDS Field Order",
             shortDescription: `Checks that CDS key fields are listed first and associations last in the field list`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `define view entity test as select from source
-  association [1..1] to target as _Assoc on _Assoc.id = source.id
-{
-  field1,
-  key id,
-  _Assoc
+            badExample: `define view entity test as select from source
+  association [1..1] to target as _Assoc on _Assoc.id = source.id
+{
+  field1,
+  key id,
+  _Assoc
 }`,
-            goodExample: `define view entity test as select from source
-  association [1..1] to target as _Assoc on _Assoc.id = source.id
-{
-  key id,
-  field1,
-  _Assoc
+            goodExample: `define view entity test as select from source
+  association [1..1] to target as _Assoc on _Assoc.id = source.id
+{
+  key id,
+  field1,
+  _Assoc
 }`,
         };
     }

package/build/src/rules/cds_naming.js

@@ -44,13 +44,13 @@ class CDSNaming {
             key: "cds_naming",
             title: "CDS Naming",
             shortDescription: `Checks CDS naming conventions based on the VDM prefix rules`,
-            extendedInformation: `Validates that CDS entity names follow the expected prefix conventions:
-I_ for interface views, C_ for consumption views, R_ for restricted reuse views,
-P_ for private views, A_ for remote API views, X_ for view extends,
-E_ for extension include views, F_ for derivation functions, D_ for abstract entities.
-
-Names must also start with Z after the prefix (custom namespace).
-
+            extendedInformation: `Validates that CDS entity names follow the expected prefix conventions:
+I_ for interface views, C_ for consumption views, R_ for restricted reuse views,
+P_ for private views, A_ for remote API views, X_ for view extends,
+E_ for extension include views, F_ for derivation functions, D_ for abstract entities.
+
+Names must also start with Z after the prefix (custom namespace).
+
 https://help.sap.com/docs/SAP_S4HANA_ON-PREMISE/ee6ff9b281d8448f96b4fe6c89f2bdc8/8a8cee943ef944fe8936f4cc60ba9bc1.html`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Naming],
             badExample: `define view entity ZMY_VIEW as select from source { key id }`,

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.118.0",
+    "version": "2.118.2",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -63,7 +63,7 @@
         "typescript": "^5.9.3"
     },
     "dependencies": {
-        "fast-xml-parser": "^5.5.7",
+        "fast-xml-parser": "^5.5.8",
         "json5": "^2.2.3",
         "vscode-languageserver-types": "^3.17.5"
     }