@abaplint/core 2.117.1 → 2.117.3

package/build/abaplint.d.ts

@@ -1993,6 +1993,7 @@ declare type DynproField = {
     name: string;
     type: string;
     length: number;
+    vislength: number;
     line: number;
     column: number;
     height: number;

package/build/src/objects/_dynpros.js

@@ -20,6 +20,7 @@ function parseDynpros(parsed) {
                     name: f.NAME,
                     type: f.TYPE,
                     length: parseNumber(f.LENGTH),
+                    vislength: parseNumber(f.VISLENGTH),
                     line: parseNumber(f.LINE),
                     column: parseNumber(f.COLUMN),
                     height: parseNumber(f.HEIGHT),

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.117.1";
+        return "2.117.3";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/dynpro_checks.js

@@ -55,15 +55,15 @@ class DynproChecks {
         const ret = [];
         for (let index = 0; index < dynpro.fields.length; index++) {
             const current = dynpro.fields[index];
-            if (current.name === undefined) {
+            if (current.name === undefined || current.type === "FRAME") {
                 continue;
             }
             for (let compare = index + 1; compare < dynpro.fields.length; compare++) {
                 const other = dynpro.fields[compare];
-                if (other.name === undefined || this.overlaps(current, other) === false) {
+                if (other.name === undefined || other.type === "FRAME" || this.overlaps(current, other) === false) {
                     continue;
                 }
-                const message = `Screen ${dynpro.number}, fields ${current.name} and ${other.name} are overlapping`;
+                const message = `Screen ${dynpro.number}, ${current.type} ${current.name} and ${other.type} ${other.name} are overlapping`;
                 ret.push(issue_1.Issue.atPosition(file, new position_1.Position(1, 1), message, this.getMetadata().key, this.getConfig().severity));
             }
         }
@@ -80,8 +80,8 @@ class DynproChecks {
         if (firstLastLine < second.line || secondLastLine < first.line) {
             return false;
         }
-        const firstLastColumn = first.column + Math.max(first.length, 1) - 1;
-        const secondLastColumn = second.column + Math.max(second.length, 1) - 1;
+        const firstLastColumn = first.column + Math.max(first.vislength || first.length, 1) - 1;
+        const secondLastColumn = second.column + Math.max(second.vislength || second.length, 1) - 1;
         return first.column <= secondLastColumn && second.column <= firstLastColumn;
     }
 }

package/build/src/rules/msag_consistency.js

@@ -22,7 +22,8 @@ class MSAGConsistency {
             key: "msag_consistency",
             title: "MSAG consistency check",
             shortDescription: `Checks the validity of messages in message classes`,
-            extendedInformation: `Message numbers must be 3 digits, message text must not be empty, no message number duplicates`,
+            extendedInformation: `Message numbers must be 3 digits, message text must not be empty,\n` +
+                `message text must not exceed 73 characters, no message number duplicates`,
         };
     }
     getDescription(reason) {
@@ -58,6 +59,12 @@ class MSAGConsistency {
                 const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, text, this.getMetadata().key, this.conf.severity);
                 issues.push(issue);
             }
+            if (message.getMessage().length > 73) {
+                const text = `Message text too long (max 73 characters): message ${message.getNumber()}`;
+                const position = new position_1.Position(1, 1);
+                const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, text, this.getMetadata().key, this.conf.severity);
+                issues.push(issue);
+            }
             const num = message.getNumber();
             if (numbers.has(num)) {
                 const text = "Duplicate message number " + num;
@@ -71,7 +78,7 @@ class MSAGConsistency {
             if (this.getConfig().numericParameters === true) {
                 const placeholderCount = message.getPlaceholderCount();
                 if (placeholderCount > 4) {
-                    const text = `More than 4 placeholders in mesasge ${message.getNumber()}`;
+                    const text = `More than 4 placeholders in message ${message.getNumber()}`;
                     const position = new position_1.Position(1, 1);
                     const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, text, this.getMetadata().key, this.conf.severity);
                     issues.push(issue);

package/build/src/rules/smim_consistency.js

@@ -17,7 +17,7 @@ class SMIMConsistency {
             key: "smim_consistency",
             title: "SMIM consistency check",
             shortDescription: `SMIM consistency check`,
-            extendedInformation: "Check folders exists",
+            extendedInformation: "Checks that the parent folder of each MIME object exists in the registry. The SAP system folder /SAP/PUBLIC is always allowed as a parent even if not present in the repository.",
         };
     }
     getConfig() {
@@ -36,7 +36,7 @@ class SMIMConsistency {
             return [];
         }
         const base = this.base(obj.getURL() || "");
-        if (base !== "" && this.findFolder(base) === false) {
+        if (base !== "" && base !== "/SAP/PUBLIC" && this.findFolder(base) === false) {
             const message = `Parent folder "${base}" not found`;
             const position = new position_1.Position(1, 1);
             const issue = issue_1.Issue.atPosition(obj.getFiles()[0], position, message, this.getMetadata().key, this.conf.severity);

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.117.1",
+    "version": "2.117.3",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",