@abaplint/core 2.116.1 → 2.117.0

package/build/abaplint.d.ts

@@ -5534,6 +5534,7 @@ declare class Program extends ABAPObject {
     isInclude(): boolean;
     isModulePool(): boolean;
     getDynpros(): DynproList;
+    getSelectionTexts(): ITextElements;
     private parseXML;
 }
 

package/build/src/objects/program.js

@@ -42,6 +42,10 @@ class Program extends _abap_object_1.ABAPObject {
         this.parseXML();
         return this.parsedXML.dynpros || [];
     }
+    getSelectionTexts() {
+        this.parseXML();
+        return this.parsedXML.selectionTexts;
+    }
     ////////////////////////////
     parseXML() {
         var _a, _b, _c;
@@ -56,14 +60,19 @@ class Program extends _abap_object_1.ABAPObject {
                 isModulePool: false,
                 description: undefined,
                 dynpros: [],
+                selectionTexts: {},
             };
             return;
         }
         let description = "";
+        const selectionTexts = {};
         for (const t of (0, xml_utils_1.xmlToArray)((_c = (_b = (_a = parsed.abapGit) === null || _a === void 0 ? void 0 : _a["asx:abap"]["asx:values"]) === null || _b === void 0 ? void 0 : _b.TPOOL) === null || _c === void 0 ? void 0 : _c.item)) {
             if ((t === null || t === void 0 ? void 0 : t.ID) === "R") {
                 description = t.ENTRY ? (0, xml_utils_1.unescape)(t.ENTRY) : "";
             }
+            else if ((t === null || t === void 0 ? void 0 : t.ID) === "S" && t.KEY !== undefined) {
+                selectionTexts[t.KEY.toUpperCase()] = t.ENTRY ? (0, xml_utils_1.unescape)(t.ENTRY) : "";
+            }
         }
         const dynpros = (0, _dynpros_1.parseDynpros)(parsed);
         this.parsedXML = {
@@ -71,6 +80,7 @@ class Program extends _abap_object_1.ABAPObject {
             isModulePool: file ? file.getRaw().includes("<SUBC>M</SUBC>") : false,
             dynpros: dynpros,
             description: description,
+            selectionTexts: selectionTexts,
         };
     }
 }

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.116.1";
+        return "2.117.0";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/index.js

@@ -152,6 +152,7 @@ __exportStar(require("./select_add_order_by"), exports);
 __exportStar(require("./select_performance"), exports);
 __exportStar(require("./select_single_full_key"), exports);
 __exportStar(require("./selection_screen_naming"), exports);
+__exportStar(require("./selection_screen_texts_missing"), exports);
 __exportStar(require("./sequential_blank"), exports);
 __exportStar(require("./short_case"), exports);
 __exportStar(require("./sicf_consistency"), exports);

package/build/src/rules/selection_screen_texts_missing.js

@@ -0,0 +1,79 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.SelectionScreenTextsMissing = exports.SelectionScreenTextsMissingConf = void 0;
+const issue_1 = require("../issue");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const statements_1 = require("../abap/2_statements/statements");
+const expressions_1 = require("../abap/2_statements/expressions");
+const objects_1 = require("../objects");
+class SelectionScreenTextsMissingConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.SelectionScreenTextsMissingConf = SelectionScreenTextsMissingConf;
+class SelectionScreenTextsMissing {
+    constructor() {
+        this.conf = new SelectionScreenTextsMissingConf();
+    }
+    getMetadata() {
+        return {
+            key: "selection_screen_texts_missing",
+            title: "Selection screen texts missing",
+            shortDescription: `Checks that selection screen parameters and select-options have selection texts`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    initialize(reg) {
+        this.reg = reg;
+        return this;
+    }
+    run(obj) {
+        if (!(obj instanceof objects_1.Program)) {
+            return [];
+        }
+        if (obj.isInclude()) {
+            return [];
+        }
+        const selTexts = obj.getSelectionTexts();
+        const output = [];
+        const checked = new Set();
+        this.checkFile(obj.getMainABAPFile(), selTexts, output, checked);
+        return output;
+    }
+    checkFile(file, selTexts, output, checked) {
+        if (file === undefined) {
+            return;
+        }
+        if (checked.has(file.getFilename())) {
+            return;
+        }
+        checked.add(file.getFilename());
+        for (const stat of file.getStatements()) {
+            const s = stat.get();
+            if (s instanceof statements_1.Parameter || s instanceof statements_1.SelectOption) {
+                const fieldNode = stat.findFirstExpression(expressions_1.FieldSub);
+                if (fieldNode) {
+                    const fieldName = fieldNode.getFirstToken().getStr().toUpperCase();
+                    if (selTexts[fieldName] === undefined) {
+                        output.push(issue_1.Issue.atToken(file, fieldNode.getFirstToken(), `Selection text missing for "${fieldName}"`, this.getMetadata().key, this.conf.severity));
+                    }
+                }
+            }
+            else if (s instanceof statements_1.Include) {
+                const nameNode = stat.findFirstExpression(expressions_1.IncludeName);
+                if (nameNode) {
+                    const inclName = nameNode.getFirstToken().getStr().toUpperCase();
+                    const inclObj = this.reg.getObject("PROG", inclName);
+                    if (inclObj) {
+                        this.checkFile(inclObj.getMainABAPFile(), selTexts, output, checked);
+                    }
+                }
+            }
+        }
+    }
+}
+exports.SelectionScreenTextsMissing = SelectionScreenTextsMissing;
+//# sourceMappingURL=selection_screen_texts_missing.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.116.1",
+    "version": "2.117.0",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",