@abaplint/core 2.115.21 → 2.115.23

package/build/src/abap/2_statements/expressions/cast.js

@@ -9,7 +9,7 @@ const let_1 = require("./let");
 class Cast extends combi_1.Expression {
     getRunnable() {
         const rparen = (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WParenRightW), (0, combi_1.tok)(tokens_1.WParenRight));
-        const cast = (0, combi_1.seq)("CAST", _1.TypeNameOrInfer, (0, combi_1.tok)(tokens_1.ParenLeftW), (0, combi_1.optPrio)(let_1.Let), _1.Source, rparen);
+        const cast = (0, combi_1.seq)("CAST", _1.TypeNameOrInfer, (0, combi_1.tok)(tokens_1.ParenLeftW), (0, combi_1.optPrio)(let_1.Let), _1.Source, rparen, (0, combi_1.opt)(_1.Dereference));
         return (0, combi_1.ver)(version_1.Version.v740sp02, cast, version_1.Version.OpenABAP);
     }
 }

package/build/src/abap/2_statements/statements/move.js

@@ -14,7 +14,7 @@ class Move {
         const equals = (0, combi_1.altPrio)((0, combi_1.altPrio)(chained, "?="), calcAssign);
         // todo, move "?=" to CAST?
         const eq = (0, combi_1.seq)(expressions_1.Target, equals, expressions_1.Source);
-        return (0, combi_1.altPrio)(move, eq);
+        return (0, combi_1.alt)(move, eq);
     }
 }
 exports.Move = Move;

package/build/src/abap/5_syntax/statements/create_object.js

@@ -72,8 +72,9 @@ class CreateObject {
                 return;
             }
             else if (found instanceof basic_1.ObjectReferenceType) {
-                const id = found.getIdentifier();
-                if (id instanceof types_1.InterfaceDefinition && type === undefined) {
+                const identifier = found.getIdentifier();
+                const idFound = input.scope.findObjectDefinition(identifier.getName());
+                if (idFound instanceof types_1.InterfaceDefinition && type === undefined) {
                     const message = "Interface reference, cannot be instantiated";
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                     return;
@@ -85,11 +86,11 @@ class CreateObject {
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                     return;
                 }
-                else if (id instanceof types_1.ClassDefinition && cdef === undefined) {
-                    cdef = id;
+                else if (idFound instanceof types_1.ClassDefinition && cdef === undefined) {
+                    cdef = idFound;
                 }
-                if (type === undefined && id instanceof types_1.ClassDefinition && id.isAbstract() === true) {
-                    const message = id.getName() + " is abstract, cannot be instantiated";
+                if (type === undefined && idFound instanceof types_1.ClassDefinition && idFound.isAbstract() === true) {
+                    const message = identifier.getName() + " is abstract, cannot be instantiated";
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                     return;
                 }

package/build/src/abap/5_syntax/statements/move.js

@@ -7,6 +7,7 @@ const target_1 = require("../expressions/target");
 const inline_data_1 = require("../expressions/inline_data");
 const _type_utils_1 = require("../_type_utils");
 const _syntax_input_1 = require("../_syntax_input");
+const dereference_1 = require("../expressions/dereference");
 class Move {
     runSyntax(node, input) {
         const targets = node.findDirectExpressions(Expressions.Target);
@@ -23,12 +24,15 @@ class Move {
             }
         }
         const source = node.findDirectExpression(Expressions.Source);
-        const sourceType = source ? source_1.Source.runSyntax(source, input, targetType) : undefined;
+        let sourceType = source ? source_1.Source.runSyntax(source, input, targetType) : undefined;
         if (sourceType === undefined) {
             const message = "No source type determined";
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return;
         }
+        if (node.findDirectExpression(Expressions.Dereference)) {
+            sourceType = dereference_1.Dereference.runSyntax(node, sourceType, input);
+        }
         if (inline) {
             inline_data_1.InlineData.runSyntax(inline, input, sourceType);
             targetType = sourceType;

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.115.21";
+        return "2.115.23";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/global_class.js

@@ -6,6 +6,7 @@ const _abap_rule_1 = require("./_abap_rule");
 const Objects = require("../objects");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
+const objects_1 = require("../objects");
 class GlobalClassConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.GlobalClassConf = GlobalClassConf;
@@ -27,7 +28,9 @@ class GlobalClass extends _abap_rule_1.ABAPRule {
 
 * global classes must be global definitions
 
-* global interfaces must be global definitions`,
+* global interfaces must be global definitions
+
+* global FOR TESTING, must have CATEGORY = 05 in the XML`,
             tags: [_irule_1.RuleTag.Syntax],
         };
     }
@@ -52,6 +55,18 @@ class GlobalClass extends _abap_rule_1.ABAPRule {
                 const issue = issue_1.Issue.atIdentifier(definition.identifier, "Class must be local", this.getMetadata().key, this.conf.severity);
                 output.push(issue);
             }
+            if (definition.isGlobal && obj instanceof Objects.Class) {
+                if (definition.isForTesting === true && obj instanceof Objects.Class && obj.getCategory() !== objects_1.ClassCategory.Test) {
+                    const message = "Class is marked as FOR TESTING, but CATEGORY is not 05 in the XML";
+                    const issue = issue_1.Issue.atIdentifier(definition.identifier, message, this.getMetadata().key, this.conf.severity);
+                    output.push(issue);
+                }
+                else if (definition.isForTesting === false && obj instanceof Objects.Class && obj.getCategory() === objects_1.ClassCategory.Test) {
+                    const message = "Class has CATEGORY 05 in the XML, but is not marked as FOR TESTING";
+                    const issue = issue_1.Issue.atIdentifier(definition.identifier, message, this.getMetadata().key, this.conf.severity);
+                    output.push(issue);
+                }
+            }
         }
         for (const impl of file.getInfo().listClassImplementations()) {
             if (file.getFilename().match(/\.clas\.abap$/)

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.115.21",
+    "version": "2.115.23",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",