@abaplint/core 2.115.18 → 2.115.20

package/build/src/abap/2_statements/expressions/function_parameters.js

@@ -9,7 +9,7 @@ class FunctionParameters extends combi_1.Expression {
         const importing = (0, combi_1.seq)("IMPORTING", _1.ParameterListT);
         const changing = (0, combi_1.seq)("CHANGING", _1.ParameterListT);
         const tables = (0, combi_1.seq)("TABLES", _1.ParameterListT);
-        const exceptions = (0, combi_1.seq)("EXCEPTIONS", (0, combi_1.optPrio)((0, combi_1.altPrio)(_1.ParameterListExceptions, _1.Field)));
+        const exceptions = (0, combi_1.seq)("EXCEPTIONS", (0, combi_1.altPrio)(_1.ParameterListExceptions, (0, combi_1.plus)(_1.Field)));
         const long = (0, combi_1.seq)((0, combi_1.optPrio)(exporting), (0, combi_1.optPrio)(importing), (0, combi_1.optPrio)(tables), (0, combi_1.optPrio)(changing), (0, combi_1.optPrio)(exceptions));
         return long;
     }

package/build/src/abap/2_statements/expressions/sql_field.js

@@ -9,7 +9,8 @@ const sql_function_1 = require("./sql_function");
 const sql_path_1 = require("./sql_path");
 class SQLField extends combi_1.Expression {
     getRunnable() {
-        const abap = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WAt), _1.SimpleFieldChain2), version_1.Version.OpenABAP);
+        const atParen = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.ParenLeftW), _1.SimpleFieldChain2, (0, combi_1.tok)(tokens_1.WParenRightW));
+        const abap = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WAt), (0, combi_1.altPrio)(_1.SimpleFieldChain2, atParen)), version_1.Version.OpenABAP);
         const as = (0, combi_1.seq)("AS", _1.SQLAsName);
         const parenFieldName = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WParenLeftW), _1.SQLFieldName, (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WParenRightW), (0, combi_1.tok)(tokens_1.WParenRight)));
         const field = (0, combi_1.altPrio)(_1.SQLAggregation, _1.SQLCase, sql_function_1.SQLFunction, sql_path_1.SQLPath, _1.SQLFieldName, abap, _1.Constant, parenFieldName);

package/build/src/lsp/_lookup.js

@@ -15,6 +15,7 @@ const objects_1 = require("../objects");
 const types_1 = require("../abap/types");
 const _statement_1 = require("../abap/2_statements/statements/_statement");
 const include_graph_1 = require("../utils/include_graph");
+const visibility_1 = require("../abap/4_file_information/visibility");
 class LSPLookup {
     static lookup(cursor, reg, obj) {
         var _a, _b;
@@ -72,7 +73,11 @@ class LSPLookup {
         const method = this.findMethodDefinition(cursor, bottomScope.getParent());
         if (method !== undefined && method.getStart().equals(cursor.token.getStart())) {
             const found = _lsp_utils_1.LSPUtils.identiferToLocation(method);
-            const hover = "Method Definition \"" + method.getName() + "\"";
+            let hover = "Method Definition \"" + method.getName() + "\"";
+            // Method definitions have getVisibility()
+            const methodDef = method;
+            const visibilityStr = this.visibilityToString(methodDef.getVisibility());
+            hover += "\n\n" + visibilityStr;
             return { hover, definition: found, definitionId: method, scope: bottomScope };
         }
         let hoverValue = "";
@@ -238,8 +243,25 @@ class LSPLookup {
         }
         return this.methodParameters(methodDef);
     }
+    static visibilityToString(visibility) {
+        switch (visibility) {
+            case visibility_1.Visibility.Public:
+                return "PUBLIC";
+            case visibility_1.Visibility.Protected:
+                return "PROTECTED";
+            case visibility_1.Visibility.Private:
+                return "PRIVATE";
+            default:
+                return "";
+        }
+    }
     static methodParameters(methodDef) {
         let ret = "";
+        // Add visibility information
+        const visibilityStr = this.visibilityToString(methodDef.getVisibility());
+        if (visibilityStr) {
+            ret += visibilityStr + "\n\n";
+        }
         const parameters = methodDef.getParameters();
         const importing = parameters.getImporting();
         if (importing.length > 0) {

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.115.18";
+        return "2.115.20";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/index.js

@@ -129,6 +129,7 @@ __exportStar(require("./omit_parameter_name"), exports);
 __exportStar(require("./omit_preceding_zeros"), exports);
 __exportStar(require("./omit_receiving"), exports);
 __exportStar(require("./parser_702_chaining"), exports);
+__exportStar(require("./parser_bad_exceptions"), exports);
 __exportStar(require("./parser_error"), exports);
 __exportStar(require("./parser_missing_space"), exports);
 __exportStar(require("./pragma_style"), exports);

package/build/src/rules/parser_bad_exceptions.js

@@ -0,0 +1,55 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ParserBadExceptions = exports.ParserBadExceptionsConf = void 0;
+const Statements = require("../abap/2_statements/statements");
+const Expressions = require("../abap/2_statements/expressions");
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+// todo: this rule needs refactoring
+class ParserBadExceptionsConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.ParserBadExceptionsConf = ParserBadExceptionsConf;
+class ParserBadExceptions extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new ParserBadExceptionsConf();
+    }
+    getMetadata() {
+        return {
+            key: "parser_bad_exceptions",
+            title: "Parser Error, bad EXCEPTIONS in CALL FUNCTION",
+            shortDescription: `Checks for syntax not recognized by abaplint, related to EXCEPTIONS in CALL FUNCTION.`,
+            tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.SingleFile],
+            /*
+            badExample: `IF ( foo = 'bar').`,
+            goodExample: `IF ( foo = 'bar' ).`,
+            */
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        var _a;
+        const issues = [];
+        for (const statement of file.getStatements()) {
+            if (!(statement.get() instanceof Statements.CallFunction)) {
+                continue;
+            }
+            const found = (_a = statement.findDirectExpression(Expressions.FunctionParameters)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.Field);
+            if (found === undefined) {
+                continue;
+            }
+            const message = "Bad EXCEPTIONS syntax in CALL FUNCTION";
+            issues.push(issue_1.Issue.atToken(file, found.getFirstToken(), message, this.getMetadata().key, this.conf.severity));
+        }
+        return issues;
+    }
+}
+exports.ParserBadExceptions = ParserBadExceptions;
+//# sourceMappingURL=parser_bad_exceptions.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.115.18",
+    "version": "2.115.20",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,20 +50,20 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.55.2",
+        "@microsoft/api-extractor": "^7.56.2",
         "@types/chai": "^4.3.20",
         "@types/mocha": "^10.0.10",
-        "@types/node": "^24.10.9",
+        "@types/node": "^24.10.10",
         "chai": "^4.5.0",
         "eslint": "^9.39.2",
         "mocha": "^11.7.5",
         "c8": "^10.1.3",
         "source-map-support": "^0.5.21",
-        "ts-json-schema-generator": "^2.4.0",
+        "ts-json-schema-generator": "=2.4.0",
         "typescript": "^5.9.3"
     },
     "dependencies": {
-        "fast-xml-parser": "^5.3.3",
+        "fast-xml-parser": "^5.3.4",
         "json5": "^2.2.3",
         "vscode-languageserver-types": "^3.17.5"
     }