@abaplint/core 2.114.9 → 2.115.0

package/build/abaplint.d.ts

@@ -7642,6 +7642,10 @@ declare class WebMIME extends AbstractObject {
     getType(): string;
     getAllowedNaming(): IAllowedNaming;
     getDescription(): string | undefined;
+    getParameter(name: string): string | undefined;
+    getParameters(): {
+        [key: string]: string;
+    };
     setDirty(): void;
     getDataFile(): IFile | undefined;
     parse(): {

package/build/src/abap/5_syntax/statements/concatenate.js

@@ -39,6 +39,11 @@ class Concatenate {
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                     return;
                 }
+                if (linesMode === true && byteMode === true && type instanceof basic_1.TableType && type.getRowType() instanceof basic_1.StructureType) {
+                    const message = "Source row type must not be a structure in BYTE mode";
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                    return;
+                }
             }
         }
         for (const s of node.findDirectExpressions(Expressions.SimpleSource3)) {

package/build/src/objects/table.js

@@ -99,6 +99,10 @@ class Table extends _abstract_object_1.AbstractObject {
             && this.parsedData.dataClass === "USER3") {
             return new Types.UnknownType("Data class = USER3 not allowed in cloud");
         }
+        if (this.getTableCategory() === TableCategory.Transparent
+            && this.listKeys(reg).length === 0) {
+            return new Types.UnknownType("Table " + this.getName() + " has no key fields");
+        }
         if (this.parsedType) {
             return this.parsedType;
         }

package/build/src/objects/web_mime.js

@@ -1,6 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.WebMIME = void 0;
+const xml_utils_1 = require("../xml_utils");
 const _abstract_object_1 = require("./_abstract_object");
 class WebMIME extends _abstract_object_1.AbstractObject {
     getType() {
@@ -18,6 +19,16 @@ class WebMIME extends _abstract_object_1.AbstractObject {
         this.parse();
         return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.description;
     }
+    getParameter(name) {
+        var _a;
+        this.parse();
+        return (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.params[name.toLowerCase()];
+    }
+    getParameters() {
+        var _a, _b;
+        this.parse();
+        return (_b = (_a = this.parsedXML) === null || _a === void 0 ? void 0 : _a.params) !== null && _b !== void 0 ? _b : {};
+    }
     setDirty() {
         this.parsedXML = undefined;
         super.setDirty();
@@ -31,11 +42,12 @@ class WebMIME extends _abstract_object_1.AbstractObject {
         return undefined;
     }
     parse() {
+        var _a;
         if (this.parsedXML) {
             return { updated: false, runtime: 0 };
         }
         const start = Date.now();
-        this.parsedXML = {};
+        this.parsedXML = { params: {} };
         const parsed = super.parseRaw2();
         if (parsed === undefined
             || parsed.abapGit === undefined
@@ -43,6 +55,9 @@ class WebMIME extends _abstract_object_1.AbstractObject {
             return { updated: false, runtime: 0 };
         }
         this.parsedXML.description = parsed.abapGit["asx:abap"]["asx:values"].TEXT;
+        for (const param of (0, xml_utils_1.xmlToArray)((_a = parsed.abapGit["asx:abap"]["asx:values"].PARAMS) === null || _a === void 0 ? void 0 : _a.WWWPARAMS)) {
+            this.parsedXML.params[param.NAME.toLowerCase()] = param.VALUE;
+        }
         const end = Date.now();
         return { updated: true, runtime: end - start };
     }

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.114.9";
+        return "2.115.0";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/identical_move.js

@@ -0,0 +1,60 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.IdenticalMove = exports.IdenticalMoveConf = void 0;
+const Statements = require("../abap/2_statements/statements");
+const Expressions = require("../abap/2_statements/expressions");
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+const objects_1 = require("../objects");
+class IdenticalMoveConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.IdenticalMoveConf = IdenticalMoveConf;
+class IdenticalMove extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new IdenticalMoveConf();
+    }
+    getMetadata() {
+        return {
+            key: "identical_move",
+            title: "Identical move",
+            shortDescription: `Moving the same value from left to right or right to left is redundant.`,
+            tags: [_irule_1.RuleTag.SingleFile],
+            badExample: `DATA lv_value TYPE i.
+lv_value = lv_value.`,
+            goodExample: `DATA lv_value TYPE i.
+lv_value = 5.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file, obj) {
+        var _a, _b;
+        const issues = [];
+        if (!(obj instanceof objects_1.Class)) {
+            return [];
+        }
+        else if (file !== obj.getMainABAPFile()) {
+            return [];
+        }
+        for (const statement of file.getStatements()) {
+            const statementType = statement.get();
+            if (statementType instanceof Statements.Move) {
+                const source = (_a = statement.findDirectExpression(Expressions.Source)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
+                const target = (_b = statement.findDirectExpression(Expressions.Target)) === null || _b === void 0 ? void 0 : _b.concatTokens().toUpperCase();
+                if (source === target && source !== undefined) {
+                    issues.push(issue_1.Issue.atStatement(file, statement, "Comment between methods in global class implementation", this.getMetadata().key, this.conf.severity));
+                }
+            }
+        }
+        return issues;
+    }
+}
+exports.IdenticalMove = IdenticalMove;
+//# sourceMappingURL=identical_move.js.map

package/build/src/rules/index.js

@@ -89,6 +89,7 @@ __exportStar(require("./intf_referencing_clas"), exports);
 __exportStar(require("./invalid_table_index"), exports);
 __exportStar(require("./keep_single_parameter_on_one_line"), exports);
 __exportStar(require("./keyword_case"), exports);
+__exportStar(require("./identical_move"), exports);
 __exportStar(require("./line_break_multiple_parameters"), exports);
 __exportStar(require("./line_break_style"), exports);
 __exportStar(require("./line_length"), exports);
@@ -114,6 +115,7 @@ __exportStar(require("./nesting"), exports);
 __exportStar(require("./newline_between_methods"), exports);
 __exportStar(require("./no_aliases"), exports);
 __exportStar(require("./no_chained_assignment"), exports);
+__exportStar(require("./no_comments_between_methods"), exports);
 __exportStar(require("./no_external_form_calls"), exports);
 __exportStar(require("./no_inline_in_optional_branches"), exports);
 __exportStar(require("./no_prefixes"), exports);

package/build/src/rules/no_comments_between_methods.js

@@ -0,0 +1,65 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.NoCommentsBetweenMethods = exports.NoCommentsBetweenMethodsConf = void 0;
+const Statements = require("../abap/2_statements/statements");
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+const objects_1 = require("../objects");
+const _statement_1 = require("../abap/2_statements/statements/_statement");
+class NoCommentsBetweenMethodsConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.NoCommentsBetweenMethodsConf = NoCommentsBetweenMethodsConf;
+class NoCommentsBetweenMethods extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new NoCommentsBetweenMethodsConf();
+    }
+    getMetadata() {
+        return {
+            key: "no_comments_between_methods",
+            title: "No comments between methods in global classes",
+            shortDescription: `Its not possible to have comments between methods in global classes.`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Syntax],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file, obj) {
+        const issues = [];
+        if (!(obj instanceof objects_1.Class)) {
+            return [];
+        }
+        else if (file !== obj.getMainABAPFile()) {
+            return [];
+        }
+        let inMethod = false;
+        let inClassImpl = false;
+        for (const statement of file.getStatements()) {
+            const statementType = statement.get();
+            if (statementType instanceof Statements.ClassImplementation) {
+                inClassImpl = true;
+            }
+            else if (statementType instanceof Statements.EndClass) {
+                inClassImpl = false;
+            }
+            else if (statementType instanceof Statements.MethodImplementation) {
+                inMethod = true;
+            }
+            else if (statementType instanceof Statements.EndMethod) {
+                inMethod = false;
+            }
+            else if (inClassImpl === true && inMethod === false && statementType instanceof _statement_1.Comment) {
+                issues.push(issue_1.Issue.atStatement(file, statement, "Comment between methods in global class implementation", this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
+}
+exports.NoCommentsBetweenMethods = NoCommentsBetweenMethods;
+//# sourceMappingURL=no_comments_between_methods.js.map

package/build/src/rules/uncaught_exception.js

@@ -72,7 +72,7 @@ class UncaughtException extends _abap_rule_1.ABAPRule {
         return this.issues;
     }
     traverse(n, file) {
-        var _a, _b, _c, _d, _e, _f;
+        var _a, _b, _c, _d, _e;
         const get = n.get();
         if (get instanceof Structures.ClassDefinition
             || get instanceof Structures.Interface) {
@@ -87,13 +87,14 @@ class UncaughtException extends _abap_rule_1.ABAPRule {
                     this.traverse(c, file);
                 }
                 this.sinked = previous;
-                for (const c of ((_b = n.findDirectStructure(Structures.Catch)) === null || _b === void 0 ? void 0 : _b.getChildren()) || []) {
-                    this.traverse(c, file);
+                for (const catchStructure of n.findDirectStructures(Structures.Catch)) {
+                    for (const c of catchStructure.getChildren()) {
+                        this.traverse(c, file);
+                    }
                 }
-                for (const c of ((_c = n.findDirectStructure(Structures.Cleanup)) === null || _c === void 0 ? void 0 : _c.getChildren()) || []) {
+                for (const c of ((_b = n.findDirectStructure(Structures.Cleanup)) === null || _b === void 0 ? void 0 : _b.getChildren()) || []) {
                     this.traverse(c, file);
                 }
-                return;
             }
             else {
                 for (const c of n.getChildren()) {
@@ -122,10 +123,10 @@ class UncaughtException extends _abap_rule_1.ABAPRule {
                 let name = undefined;
                 const concat = n.concatTokens().toUpperCase();
                 if (concat.startsWith("RAISE EXCEPTION TYPE ")) {
-                    name = (_d = n.findFirstExpression(Expressions.ClassName)) === null || _d === void 0 ? void 0 : _d.getFirstToken().getStr().toUpperCase();
+                    name = (_c = n.findFirstExpression(Expressions.ClassName)) === null || _c === void 0 ? void 0 : _c.getFirstToken().getStr().toUpperCase();
                 }
                 else if (concat.startsWith("RAISE EXCEPTION NEW ")) {
-                    name = (_f = (_e = n.findFirstExpression(Expressions.NewObject)) === null || _e === void 0 ? void 0 : _e.findFirstExpression(Expressions.TypeNameOrInfer)) === null || _f === void 0 ? void 0 : _f.getFirstToken().getStr().toUpperCase();
+                    name = (_e = (_d = n.findFirstExpression(Expressions.NewObject)) === null || _d === void 0 ? void 0 : _d.findFirstExpression(Expressions.TypeNameOrInfer)) === null || _e === void 0 ? void 0 : _e.getFirstToken().getStr().toUpperCase();
                     // todo: else its a normal Source, infer the type from it
                 }
                 this.check(name, n, file);

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.114.9",
+    "version": "2.115.0",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",