@abaplint/core 2.114.10 → 2.115.1

package/build/src/abap/5_syntax/statements/concatenate.js

@@ -39,6 +39,11 @@ class Concatenate {
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                     return;
                 }
+                if (linesMode === true && byteMode === true && type instanceof basic_1.TableType && type.getRowType() instanceof basic_1.StructureType) {
+                    const message = "Source row type must not be a structure in BYTE mode";
+                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                    return;
+                }
             }
         }
         for (const s of node.findDirectExpressions(Expressions.SimpleSource3)) {

package/build/src/objects/table.js

@@ -99,6 +99,10 @@ class Table extends _abstract_object_1.AbstractObject {
             && this.parsedData.dataClass === "USER3") {
             return new Types.UnknownType("Data class = USER3 not allowed in cloud");
         }
+        if (this.getTableCategory() === TableCategory.Transparent
+            && this.listKeys(reg).length === 0) {
+            return new Types.UnknownType("Table " + this.getName() + " has no key fields");
+        }
         if (this.parsedType) {
             return this.parsedType;
         }

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.114.10";
+        return "2.115.1";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/identical_move.js

@@ -0,0 +1,53 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.IdenticalMove = exports.IdenticalMoveConf = void 0;
+const Statements = require("../abap/2_statements/statements");
+const Expressions = require("../abap/2_statements/expressions");
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+class IdenticalMoveConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.IdenticalMoveConf = IdenticalMoveConf;
+class IdenticalMove extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new IdenticalMoveConf();
+    }
+    getMetadata() {
+        return {
+            key: "identical_move",
+            title: "Identical move",
+            shortDescription: `Moving the same value from left to right or right to left is redundant.`,
+            tags: [_irule_1.RuleTag.SingleFile],
+            badExample: `DATA lv_value TYPE i.
+lv_value = lv_value.`,
+            goodExample: `DATA lv_value TYPE i.
+lv_value = 5.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file, _obj) {
+        var _a, _b;
+        const issues = [];
+        for (const statement of file.getStatements()) {
+            const statementType = statement.get();
+            if (statementType instanceof Statements.Move) {
+                const source = (_a = statement.findDirectExpression(Expressions.Source)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
+                const target = (_b = statement.findDirectExpression(Expressions.Target)) === null || _b === void 0 ? void 0 : _b.concatTokens().toUpperCase();
+                if (source === target && source !== undefined) {
+                    issues.push(issue_1.Issue.atStatement(file, statement, "Comment between methods in global class implementation", this.getMetadata().key, this.conf.severity));
+                }
+            }
+        }
+        return issues;
+    }
+}
+exports.IdenticalMove = IdenticalMove;
+//# sourceMappingURL=identical_move.js.map

package/build/src/rules/index.js

@@ -89,6 +89,7 @@ __exportStar(require("./intf_referencing_clas"), exports);
 __exportStar(require("./invalid_table_index"), exports);
 __exportStar(require("./keep_single_parameter_on_one_line"), exports);
 __exportStar(require("./keyword_case"), exports);
+__exportStar(require("./identical_move"), exports);
 __exportStar(require("./line_break_multiple_parameters"), exports);
 __exportStar(require("./line_break_style"), exports);
 __exportStar(require("./line_length"), exports);
@@ -114,6 +115,7 @@ __exportStar(require("./nesting"), exports);
 __exportStar(require("./newline_between_methods"), exports);
 __exportStar(require("./no_aliases"), exports);
 __exportStar(require("./no_chained_assignment"), exports);
+__exportStar(require("./no_comments_between_methods"), exports);
 __exportStar(require("./no_external_form_calls"), exports);
 __exportStar(require("./no_inline_in_optional_branches"), exports);
 __exportStar(require("./no_prefixes"), exports);

package/build/src/rules/no_comments_between_methods.js

@@ -0,0 +1,65 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.NoCommentsBetweenMethods = exports.NoCommentsBetweenMethodsConf = void 0;
+const Statements = require("../abap/2_statements/statements");
+const issue_1 = require("../issue");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+const objects_1 = require("../objects");
+const _statement_1 = require("../abap/2_statements/statements/_statement");
+class NoCommentsBetweenMethodsConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.NoCommentsBetweenMethodsConf = NoCommentsBetweenMethodsConf;
+class NoCommentsBetweenMethods extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new NoCommentsBetweenMethodsConf();
+    }
+    getMetadata() {
+        return {
+            key: "no_comments_between_methods",
+            title: "No comments between methods in global classes",
+            shortDescription: `Its not possible to have comments between methods in global classes.`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Syntax],
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file, obj) {
+        const issues = [];
+        if (!(obj instanceof objects_1.Class)) {
+            return [];
+        }
+        else if (file !== obj.getMainABAPFile()) {
+            return [];
+        }
+        let inMethod = false;
+        let inClassImpl = false;
+        for (const statement of file.getStatements()) {
+            const statementType = statement.get();
+            if (statementType instanceof Statements.ClassImplementation) {
+                inClassImpl = true;
+            }
+            else if (statementType instanceof Statements.EndClass) {
+                inClassImpl = false;
+            }
+            else if (statementType instanceof Statements.MethodImplementation) {
+                inMethod = true;
+            }
+            else if (statementType instanceof Statements.EndMethod) {
+                inMethod = false;
+            }
+            else if (inClassImpl === true && inMethod === false && statementType instanceof _statement_1.Comment) {
+                issues.push(issue_1.Issue.atStatement(file, statement, "Comment between methods in global class implementation", this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
+}
+exports.NoCommentsBetweenMethods = NoCommentsBetweenMethods;
+//# sourceMappingURL=no_comments_between_methods.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.114.10",
+    "version": "2.115.1",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",