@abaplint/core 2.113.85 → 2.113.87

package/README.md

@@ -1,7 +1,7 @@
-# @abaplint/core
-
-[abaplint](https://abaplint.org) core library
-
-Exposes functionality like the parser and rules, which can be used in other projects.
-
+# @abaplint/core
+
+[abaplint](https://abaplint.org) core library
+
+Exposes functionality like the parser and rules, which can be used in other projects.
+
 For more information see https://github.com/abaplint/abaplint

package/build/src/abap/2_statements/statements/assign.js

@@ -13,7 +13,7 @@ class Assign {
         const decimals = (0, combi_1.seq)("DECIMALS", expressions_1.Source);
         const casting = (0, combi_1.seq)("CASTING", (0, combi_1.opt)((0, combi_1.alt)(like, handle, (0, combi_1.per)(type, decimals))));
         const obsoleteType = (0, combi_1.seq)("TYPE", expressions_1.Source, (0, combi_1.optPrio)(decimals));
-        const ret = (0, combi_1.seq)("ASSIGN", (0, combi_1.opt)((0, combi_1.seq)(expressions_1.Target, "INCREMENT")), expressions_1.AssignSource, "TO", expressions_1.FSTarget, (0, combi_1.opt)((0, combi_1.altPrio)(casting, obsoleteType)), (0, combi_1.opt)(range), (0, combi_1.opt)((0, combi_1.ver)(version_1.Version.v757, "ELSE UNASSIGN")));
+        const ret = (0, combi_1.seq)("ASSIGN", (0, combi_1.opt)((0, combi_1.seq)(expressions_1.Target, "INCREMENT")), expressions_1.AssignSource, "TO", expressions_1.FSTarget, (0, combi_1.opt)((0, combi_1.altPrio)(casting, obsoleteType, decimals)), (0, combi_1.opt)(range), (0, combi_1.opt)((0, combi_1.ver)(version_1.Version.v757, "ELSE UNASSIGN")));
         return ret;
     }
 }

package/build/src/abap/2_statements/statements/call_ole.js

@@ -7,7 +7,7 @@ const version_1 = require("../../../version");
 class CallOLE {
     getMatcher() {
         const rc = (0, combi_1.seq)("=", expressions_1.Target);
-        const ret = (0, combi_1.seq)("CALL METHOD OF", expressions_1.Source, expressions_1.Source, (0, combi_1.opt)(rc), (0, combi_1.opt)("NO FLUSH"), (0, combi_1.opt)("QUEUEONLY"), (0, combi_1.opt)(expressions_1.OLEExporting));
+        const ret = (0, combi_1.seq)("CALL METHOD OF", expressions_1.Source, expressions_1.Source, (0, combi_1.opt)(rc), (0, combi_1.opt)("NO FLUSH"), (0, combi_1.opt)("QUEUE-ONLY"), (0, combi_1.opt)(expressions_1.OLEExporting));
         return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
     }
 }

package/build/src/abap/2_statements/statements/communication.js

@@ -7,10 +7,12 @@ const version_1 = require("../../../version");
 class Communication {
     getMatcher() {
         const length = (0, combi_1.seq)("LENGTH", expressions_1.Target);
+        const returncode = (0, combi_1.seq)("RETURNCODE", expressions_1.Source);
+        const buffer = (0, combi_1.seq)("BUFFER", expressions_1.Target);
         const init = (0, combi_1.seq)("INIT ID", expressions_1.Source, "DESTINATION", expressions_1.Target);
-        const allocate = (0, combi_1.seq)("ALLOCATE ID", expressions_1.Source);
-        const send = (0, combi_1.seq)("SEND ID", expressions_1.Source, "BUFFER", expressions_1.Target, (0, combi_1.opt)(length));
-        const deallocate = (0, combi_1.seq)("DEALLOCATE ID", expressions_1.Source);
+        const allocate = (0, combi_1.seq)("ALLOCATE ID", expressions_1.Source, (0, combi_1.opt)(returncode));
+        const send = (0, combi_1.seq)("SEND ID", expressions_1.Source, (0, combi_1.opt)((0, combi_1.per)(buffer, length)), (0, combi_1.opt)(returncode));
+        const deallocate = (0, combi_1.seq)("DEALLOCATE ID", expressions_1.Source, (0, combi_1.opt)(returncode));
         const accept = (0, combi_1.seq)("ACCEPT ID", expressions_1.Source);
         const receive = (0, combi_1.seq)("RECEIVE ID", expressions_1.Source, "BUFFER", expressions_1.Source, (0, combi_1.opt)(length), "DATAINFO", expressions_1.Target, "STATUSINFO", expressions_1.Target, "RECEIVED", expressions_1.Target);
         const ret = (0, combi_1.seq)("COMMUNICATION", (0, combi_1.alt)(init, allocate, send, deallocate, receive, accept));

package/build/src/abap/2_statements/statements/delete_memory.js

@@ -9,7 +9,7 @@ class DeleteMemory {
         const memory = (0, combi_1.seq)("MEMORY ID", expressions_1.Source);
         const id = (0, combi_1.seq)("ID", expressions_1.Source);
         const client = (0, combi_1.seq)("CLIENT", expressions_1.Source);
-        const shared = (0, combi_1.seq)("SHARED", (0, combi_1.altPrio)("MEMORY", "BUFFER"), expressions_1.Field, "(", expressions_1.Field, ")", (0, combi_1.optPrio)(client), id);
+        const shared = (0, combi_1.seq)("SHARED", (0, combi_1.altPrio)("MEMORY", "BUFFER"), expressions_1.Field, "(", (0, combi_1.regex)(/^\w+$/), ")", (0, combi_1.optPrio)(client), id);
         const ret = (0, combi_1.seq)("DELETE FROM", (0, combi_1.alt)(memory, shared));
         return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
     }

package/build/src/abap/2_statements/statements/get_property.js

@@ -6,7 +6,7 @@ const expressions_1 = require("../expressions");
 const version_1 = require("../../../version");
 class GetProperty {
     getMatcher() {
-        const ret = (0, combi_1.seq)("GET PROPERTY OF", expressions_1.FieldSub, expressions_1.Source, "=", expressions_1.Source, (0, combi_1.opt)("NO FLUSH"), (0, combi_1.opt)("QUEUEONLY"), (0, combi_1.opt)(expressions_1.OLEExporting));
+        const ret = (0, combi_1.seq)("GET PROPERTY OF", expressions_1.FieldSub, expressions_1.Source, "=", expressions_1.Source, (0, combi_1.opt)("NO FLUSH"), (0, combi_1.opt)("QUEUE-ONLY"), (0, combi_1.opt)(expressions_1.OLEExporting));
         return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
     }
 }

package/build/src/abap/2_statements/statements/modify_internal.js

@@ -13,9 +13,9 @@ class ModifyInternal {
         const using = (0, combi_1.seq)("USING KEY", expressions_1.SimpleName);
         const additions = (0, combi_1.per)(where, assigning, using);
         const target = (0, combi_1.alt)(expressions_1.Target, expressions_1.Dynamic);
-        const options = (0, combi_1.alt)((0, combi_1.per)(index, transporting), (0, combi_1.seq)(from, (0, combi_1.opt)((0, combi_1.per)(index, transporting))), (0, combi_1.seq)((0, combi_1.per)(index, transporting), from, (0, combi_1.opt)((0, combi_1.per)(index, transporting))));
+        const options = (0, combi_1.alt)((0, combi_1.per)(index, transporting), (0, combi_1.seq)(from, (0, combi_1.opt)((0, combi_1.per)(index, transporting, using))), (0, combi_1.seq)((0, combi_1.per)(index, transporting), from, (0, combi_1.opt)((0, combi_1.per)(index, transporting))));
         const long = (0, combi_1.seq)("MODIFY", (0, combi_1.opt)("TABLE"), target, (0, combi_1.opt)(options), (0, combi_1.opt)(additions));
-        const simple = (0, combi_1.seq)("MODIFY TABLE", target, from, (0, combi_1.opt)(using));
+        const simple = (0, combi_1.seq)("MODIFY TABLE", target, (0, combi_1.per)(from, using));
         return (0, combi_1.alt)(long, simple);
     }
 }

package/build/src/abap/2_statements/statements/modify_line.js

@@ -8,7 +8,7 @@ class ModifyLine {
     getMatcher() {
         const onOff = (0, combi_1.alt)("ON", "OFF");
         const eq = (0, combi_1.seq)("=", expressions_1.Source);
-        const form = (0, combi_1.seq)((0, combi_1.alt)("INVERSE", "INPUT", "COLOR"), (0, combi_1.alt)(eq, onOff));
+        const form = (0, combi_1.seq)((0, combi_1.alt)("INVERSE", "INPUT", "COLOR", "HOTSPOT"), (0, combi_1.alt)(eq, onOff));
         const from = (0, combi_1.seq)("FROM", expressions_1.Source);
         const value = (0, combi_1.seq)("FIELD VALUE", (0, combi_1.plus)((0, combi_1.seq)(expressions_1.Source, (0, combi_1.optPrio)(from))));
         const format = (0, combi_1.seq)("FIELD FORMAT", expressions_1.Source, (0, combi_1.opt)(form));

package/build/src/abap/2_statements/statements/parameter.js

@@ -12,7 +12,7 @@ class Parameter {
         const type = (0, combi_1.seq)((0, combi_1.altPrio)("TYPE", "LIKE"), (0, combi_1.altPrio)(expressions_1.TypeName, expressions_1.Dynamic));
         const memory = (0, combi_1.seq)("MEMORY ID", expressions_1.SimpleSource1);
         const listbox = (0, combi_1.str)("AS LISTBOX");
-        const cmd = (0, combi_1.seq)("USER-COMMAND", (0, combi_1.regex)(/^\w+$/));
+        const cmd = (0, combi_1.seq)("USER-COMMAND", (0, combi_1.regex)(/^[\w\?\/]+$/));
         const modif = (0, combi_1.seq)("MODIF ID", expressions_1.Modif);
         const visible = (0, combi_1.seq)("VISIBLE LENGTH", expressions_1.Constant);
         const length = (0, combi_1.seq)("LENGTH", expressions_1.Constant);

package/build/src/abap/2_statements/statements/scroll_list.js

@@ -10,7 +10,8 @@ class ScrollList {
         const line = (0, combi_1.seq)("LINE", expressions_1.Source);
         const column = (0, combi_1.seq)("TO COLUMN", expressions_1.Source);
         const to = (0, combi_1.seq)("TO", (0, combi_1.alt)("FIRST PAGE", "LAST PAGE", (0, combi_1.seq)("PAGE", expressions_1.Source)));
-        const ret = (0, combi_1.seq)("SCROLL LIST", (0, combi_1.per)(index, (0, combi_1.alt)(to, "BACKWARD", "FORWARD"), (0, combi_1.seq)((0, combi_1.alt)("LEFT", "RIGHT"), (0, combi_1.opt)((0, combi_1.seq)("BY", expressions_1.Source, "PLACES"))), column, line));
+        const pages = (0, combi_1.seq)(expressions_1.Source, "PAGES");
+        const ret = (0, combi_1.seq)("SCROLL LIST", (0, combi_1.per)(index, (0, combi_1.seq)((0, combi_1.alt)(to, "BACKWARD", "FORWARD"), (0, combi_1.opt)(pages)), (0, combi_1.seq)((0, combi_1.alt)("LEFT", "RIGHT"), (0, combi_1.opt)((0, combi_1.seq)("BY", expressions_1.Source, "PLACES"))), column, line));
         return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
     }
 }

package/build/src/abap/2_statements/statements/selectionscreen.js

@@ -41,7 +41,7 @@ class SelectionScreen {
         const exclude = (0, combi_1.seq)("EXCLUDE", (0, combi_1.alt)("IDS", "PARAMETERS"), (0, combi_1.regex)(/^\w+$/));
         const beginVersion = (0, combi_1.seq)("BEGIN OF VERSION", (0, combi_1.regex)(/^\w+$/), expressions_1.TextElement);
         const endVersion = (0, combi_1.seq)("END OF VERSION", (0, combi_1.regex)(/^\w+$/));
-        const ret = (0, combi_1.seq)("SELECTION-SCREEN", (0, combi_1.altPrio)(comment, func, skip, pos, incl, iso, push, tab, uline, beginBlock, tabbed, endBlock, beginLine, endLine, param, beginScreen, endScreen, exclude, beginVersion, endVersion));
+        const ret = (0, combi_1.seq)("SELECTION-SCREEN", (0, combi_1.altPrio)(comment, func, skip, pos, incl, iso, push, tab, uline, beginBlock, tabbed, endBlock, beginLine, endLine, param, beginScreen, endScreen, exclude, beginVersion, endVersion, def));
         return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
     }
 }

package/build/src/abap/2_statements/statements/selectoption.js

@@ -12,7 +12,7 @@ class SelectOption {
         const option = (0, combi_1.seq)("OPTION", (0, combi_1.alt)("CP", expressions_1.Field));
         const sign = (0, combi_1.seq)("SIGN", expressions_1.Field);
         const memory = (0, combi_1.seq)("MEMORY ID", expressions_1.SimpleSource1);
-        const match = (0, combi_1.seq)("MATCHCODE OBJECT", expressions_1.Field);
+        const match = (0, combi_1.seq)("MATCHCODE OBJECT", expressions_1.SimpleFieldChain);
         const modif = (0, combi_1.seq)("MODIF ID", expressions_1.Modif);
         const visible = (0, combi_1.seq)("VISIBLE LENGTH", expressions_1.Source);
         const options = (0, combi_1.per)(def, option, sign, memory, match, visible, modif, "NO DATABASE SELECTION", "LOWER CASE", "NO-EXTENSION", "NO INTERVALS", "NO-DISPLAY", "OBLIGATORY");

package/build/src/abap/2_statements/statements/submit.js

@@ -7,7 +7,7 @@ const version_1 = require("../../../version");
 class Submit {
     getMatcher() {
         const sign = (0, combi_1.seq)("SIGN", expressions_1.Source);
-        const eq = (0, combi_1.alt)("=", "EQ", "IN", "NE", "CP", "GE", "LE", "INCL");
+        const eq = (0, combi_1.alt)("=", "EQ", "IN", "NE", "CP", "GE", "LE", "INCL", "GT", "LT");
         const compare = (0, combi_1.seq)(eq, expressions_1.Source);
         const between = (0, combi_1.seq)("BETWEEN", expressions_1.Source, "AND", expressions_1.Source);
         const selectionTable = (0, combi_1.seq)("WITH SELECTION-TABLE", expressions_1.Source);

package/build/src/abap/5_syntax/_type_utils.js

@@ -308,6 +308,9 @@ class TypeUtils {
                 }
                 return true;
             }
+            else if (target instanceof basic_1.SimpleType) {
+                return this.isCharLikeStrict(source);
+            }
             else if (target instanceof basic_1.CLikeType) {
                 return this.isCharLikeStrict(source);
             }

package/build/src/abap/5_syntax/expressions/source.js

@@ -126,9 +126,10 @@ class Source {
                         if (foundType === undefined && s) {
                             return new basic_1.DataReference(s);
                         }
-                        else {
-                            return foundType;
+                        else if (foundType) {
+                            return new basic_1.DataReference(foundType);
                         }
+                        return undefined;
                     }
                 case "FILTER":
                     {

package/build/src/abap/5_syntax/statements/loop.js

@@ -35,12 +35,11 @@ class Loop {
                 const message = "No source type determined";
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             }
-            return;
         }
         else if (sourceType instanceof basic_1.UnknownType) {
             const message = "Loop, not a table type, " + sourceType.getError();
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
-            return;
+            sourceType = new basic_1.VoidType("Loop, not a table type");
         }
         else if (sourceType instanceof basic_1.TableType
             && target === undefined
@@ -48,7 +47,6 @@ class Loop {
             && node.getChildren().length === 4) {
             const message = "Loop, no header line";
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
-            return;
         }
         else if (!(sourceType instanceof basic_1.TableType)
             && !(sourceType instanceof basic_1.AnyType)
@@ -57,14 +55,12 @@ class Loop {
             && concat.startsWith("LOOP AT GROUP ") === false) {
             const message = "Loop, not a table type";
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
-            return;
         }
         else if (loopTarget === undefined
             && sourceType instanceof basic_1.TableType
             && sourceType.isWithHeader() === false) {
             const message = "Loop, no header";
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
-            return;
         }
         const targetConcat = loopTarget === null || loopTarget === void 0 ? void 0 : loopTarget.concatTokens().toUpperCase();
         if (sourceType instanceof basic_1.TableType) {

package/build/src/abap/flow/flow_graph.js

@@ -94,13 +94,13 @@ class FlowGraph {
         this.label = label;
     }
     toDigraph() {
-        return `digraph G {
-labelloc="t";
-label="${this.label}";
-graph [fontname = "helvetica"];
-node [fontname = "helvetica", shape="box"];
-edge [fontname = "helvetica"];
-${this.toTextEdges()}
+        return `digraph G {
+labelloc="t";
+label="${this.label}";
+graph [fontname = "helvetica"];
+node [fontname = "helvetica", shape="box"];
+edge [fontname = "helvetica"];
+${this.toTextEdges()}
 }`;
     }
     listSources(node) {

package/build/src/lsp/help.js

@@ -20,13 +20,13 @@ class Help {
     /////////////////////////////////////////////////
     static dumpABAP(file, reg, textDocument, position) {
         let content = "";
-        content = `
-    <a href="#_tokens" rel="no-refresh">Tokens</a> |
-    <a href="#_statements" rel="no-refresh">Statements</a> |
-    <a href="#_structure" rel="no-refresh">Structure</a> |
-    <a href="#_files" rel="no-refresh">Files</a> |
-    <a href="#_info" rel="no-refresh">Info Dump</a>
-    <hr>
+        content = `
+    <a href="#_tokens" rel="no-refresh">Tokens</a> |
+    <a href="#_statements" rel="no-refresh">Statements</a> |
+    <a href="#_structure" rel="no-refresh">Structure</a> |
+    <a href="#_files" rel="no-refresh">Files</a> |
+    <a href="#_info" rel="no-refresh">Info Dump</a>
+    <hr>
     ` +
             "<tt>" + textDocument.uri + " (" +
             (position.line + 1) + ", " +
@@ -181,9 +181,9 @@ class Help {
         return ret + "</ul>";
     }
     static tokens(file) {
-        let inner = `<table><tr><td><b>String</b></td><td><b>Type</b></td>
-    <td><b>Row</b></td><td><b>Column</b></td>
-    <td><b>vRow</b></td><td><b>vColumn</b></td>
+        let inner = `<table><tr><td><b>String</b></td><td><b>Type</b></td>
+    <td><b>Row</b></td><td><b>Column</b></td>
+    <td><b>vRow</b></td><td><b>vColumn</b></td>
     </tr>`;
         for (const token of file.getTokens()) {
             const tStart = token.getStart();

package/build/src/objects/_abap_object.js

@@ -53,7 +53,10 @@ class ABAPObject extends _abstract_object_1.AbstractObject {
         }
         // uri fallback,
         for (const file of this.getABAPFiles()) {
-            if (file.getFilename().endsWith(".abap")) {
+            if (file.getFilename().includes(".prog.screen_")) {
+                continue;
+            }
+            else if (file.getFilename().endsWith(".abap")) {
                 return file;
             }
         }

package/build/src/registry.js

@@ -67,7 +67,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.85";
+        return "2.113.87";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/7bit_ascii.js

@@ -17,10 +17,10 @@ class SevenBitAscii {
             key: "7bit_ascii",
             title: "Check for 7bit ascii",
             shortDescription: `Only allow characters from the 7bit ASCII set.`,
-            extendedInformation: `https://docs.abapopenchecks.org/checks/05/
-
-https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abencharacter_set_guidl.htm
-
+            extendedInformation: `https://docs.abapopenchecks.org/checks/05/
+
+https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abencharacter_set_guidl.htm
+
 Checkes files with extensions ".abap" and ".asddls"`,
             tags: [_irule_1.RuleTag.SingleFile],
             badExample: `WRITE '뽑'.`,

package/build/src/rules/abapdoc.js

@@ -28,10 +28,10 @@ class Abapdoc extends _abap_rule_1.ABAPRule {
             key: "abapdoc",
             title: "Check abapdoc",
             shortDescription: `Various checks regarding abapdoc.`,
-            extendedInformation: `Base rule checks for existence of abapdoc for public class methods and all interface methods.
-
-Plus class and interface definitions.
-
+            extendedInformation: `Base rule checks for existence of abapdoc for public class methods and all interface methods.
+
+Plus class and interface definitions.
+
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#abap-doc-only-for-public-apis`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
         };

package/build/src/rules/add_test_attributes.js

@@ -21,27 +21,27 @@ class AddTestAttributes extends _abap_rule_1.ABAPRule {
             title: "Add test attributes for tests classes with test methods",
             shortDescription: `Add test attributes DURATION and RISK LEVEL for tests classes with test methods`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `CLASS ltcl_test1 DEFINITION FINAL FOR TESTING.
-  PUBLIC SECTION.
-  PROTECTED SECTION.
-  PRIVATE SECTION.
-    METHODS test FOR TESTING RAISING cx_static_check.
-ENDCLASS.
-
-CLASS ltcl_test1 IMPLEMENTATION.
-  METHOD test.
-  ENDMETHOD.
+            badExample: `CLASS ltcl_test1 DEFINITION FINAL FOR TESTING.
+  PUBLIC SECTION.
+  PROTECTED SECTION.
+  PRIVATE SECTION.
+    METHODS test FOR TESTING RAISING cx_static_check.
+ENDCLASS.
+
+CLASS ltcl_test1 IMPLEMENTATION.
+  METHOD test.
+  ENDMETHOD.
 ENDCLASS.`,
-            goodExample: `CLASS ltcl_test2 DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
-  PUBLIC SECTION.
-  PROTECTED SECTION.
-  PRIVATE SECTION.
-    METHODS test FOR TESTING RAISING cx_static_check.
-ENDCLASS.
-
-CLASS ltcl_test2 IMPLEMENTATION.
-  METHOD test.
-  ENDMETHOD.
+            goodExample: `CLASS ltcl_test2 DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
+  PUBLIC SECTION.
+  PROTECTED SECTION.
+  PRIVATE SECTION.
+    METHODS test FOR TESTING RAISING cx_static_check.
+ENDCLASS.
+
+CLASS ltcl_test2 IMPLEMENTATION.
+  METHOD test.
+  ENDMETHOD.
 ENDCLASS.`,
         };
     }

package/build/src/rules/align_parameters.js

@@ -22,49 +22,49 @@ class AlignParameters extends _abap_rule_1.ABAPRule {
             key: "align_parameters",
             title: "Align Parameters",
             shortDescription: `Checks for vertially aligned parameters`,
-            extendedInformation: `Checks:
-* function module calls
-* method calls
-* VALUE constructors
-* NEW constructors
-* RAISE EXCEPTION statements
-* CREATE OBJECT statements
-* RAISE EVENT statements
-
-https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
-
-Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
-
-If parameters are on the same row, no issues are reported, see
+            extendedInformation: `Checks:
+* function module calls
+* method calls
+* VALUE constructors
+* NEW constructors
+* RAISE EXCEPTION statements
+* CREATE OBJECT statements
+* RAISE EVENT statements
+
+https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
+
+Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
+
+If parameters are on the same row, no issues are reported, see
 https://rules.abaplint.org/max_one_method_parameter_per_line/ for splitting parameters to lines`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix],
-            badExample: `CALL FUNCTION 'FOOBAR'
-  EXPORTING
-    foo = 2
-    parameter = 3.
-
-foobar( moo = 1
-  param = 1 ).
-
-foo = VALUE #(
-    foo = bar
+            badExample: `CALL FUNCTION 'FOOBAR'
+  EXPORTING
+    foo = 2
+    parameter = 3.
+
+foobar( moo = 1
+  param = 1 ).
+
+foo = VALUE #(
+    foo = bar
         moo = 2 ).`,
-            goodExample: `CALL FUNCTION 'FOOBAR'
-  EXPORTING
-    foo       = 2
-    parameter = 3.
-
-foobar( moo   = 1
-        param = 1 ).
-
-foo = VALUE #(
-    foo = bar
-    moo = 2 ).
-
-DATA(sdf) = VALUE type(
-  common_val     = 2
-  another_common = 5
-  ( row_value = 4
+            goodExample: `CALL FUNCTION 'FOOBAR'
+  EXPORTING
+    foo       = 2
+    parameter = 3.
+
+foobar( moo   = 1
+        param = 1 ).
+
+foo = VALUE #(
+    foo = bar
+    moo = 2 ).
+
+DATA(sdf) = VALUE type(
+  common_val     = 2
+  another_common = 5
+  ( row_value = 4
     value_foo = 5 ) ).`,
         };
     }

package/build/src/rules/align_type_expressions.js

@@ -30,37 +30,37 @@ class AlignTypeExpressions extends _abap_rule_1.ABAPRule {
             key: "align_type_expressions",
             title: "Align TYPE expressions",
             shortDescription: `Align TYPE expressions in statements`,
-            extendedInformation: `
-Currently works for METHODS + BEGIN OF
-
-If BEGIN OF has an INCLUDE TYPE its ignored
-
-Also note that clean ABAP does not recommend aligning TYPE clauses:
+            extendedInformation: `
+Currently works for METHODS + BEGIN OF
+
+If BEGIN OF has an INCLUDE TYPE its ignored
+
+Also note that clean ABAP does not recommend aligning TYPE clauses:
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-align-type-clauses`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix],
-            badExample: `
-TYPES: BEGIN OF foo,
-         bar TYPE i,
-         foobar TYPE i,
-       END OF foo.
-
-INTERFACE lif.
-  METHODS bar
-    IMPORTING
-      foo TYPE i
-      foobar TYPE i.
+            badExample: `
+TYPES: BEGIN OF foo,
+         bar TYPE i,
+         foobar TYPE i,
+       END OF foo.
+
+INTERFACE lif.
+  METHODS bar
+    IMPORTING
+      foo TYPE i
+      foobar TYPE i.
 ENDINTERFACE.`,
-            goodExample: `
-TYPES: BEGIN OF foo,
-         bar    TYPE i,
-         foobar TYPE i,
-       END OF foo.
-
-INTERFACE lif.
-  METHODS bar
-    IMPORTING
-      foo    TYPE i
-      foobar TYPE i.
+            goodExample: `
+TYPES: BEGIN OF foo,
+         bar    TYPE i,
+         foobar TYPE i,
+       END OF foo.
+
+INTERFACE lif.
+  METHODS bar
+    IMPORTING
+      foo    TYPE i
+      foobar TYPE i.
 ENDINTERFACE.`,
         };
     }

package/build/src/rules/ambiguous_statement.js

@@ -20,16 +20,16 @@ class AmbiguousStatement extends _abap_rule_1.ABAPRule {
         return {
             key: "ambiguous_statement",
             title: "Check for ambigious statements",
-            shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
-Add "TABLE" keyword or "@" for escaping SQL variables
-
+            shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
+Add "TABLE" keyword or "@" for escaping SQL variables
+
 Only works if the target version is 740sp05 or above`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `DELETE foo FROM bar.
+            badExample: `DELETE foo FROM bar.
 MODIFY foo FROM bar.`,
-            goodExample: `DELETE foo FROM @bar.
-DELETE TABLE itab FROM 2.
-MODIFY zfoo FROM @wa.
+            goodExample: `DELETE foo FROM @bar.
+DELETE TABLE itab FROM 2.
+MODIFY zfoo FROM @wa.
 MODIFY TABLE foo FROM bar.`,
         };
     }

package/build/src/rules/avoid_use.js

@@ -44,16 +44,16 @@ class AvoidUse extends _abap_rule_1.ABAPRule {
             key: "avoid_use",
             title: "Avoid use of certain statements",
             shortDescription: `Detects usage of certain statements.`,
-            extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
-
-Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
-
-STATICS: use CLASS-DATA instead
-
-DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
-
-TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround
-
+            extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
+
+Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
+
+STATICS: use CLASS-DATA instead
+
+DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
+
+TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround
+
 BREAK points`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/begin_end_names.js

@@ -24,11 +24,11 @@ class BeginEndNames extends _abap_rule_1.ABAPRule {
             title: "Check BEGIN END names",
             shortDescription: `Check BEGIN OF and END OF names match, plus there must be statements between BEGIN and END`,
             tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
-            badExample: `DATA: BEGIN OF stru,
-        field TYPE i,
+            badExample: `DATA: BEGIN OF stru,
+        field TYPE i,
       END OF structure_not_the_same.`,
-            goodExample: `DATA: BEGIN OF stru,
-        field TYPE i,
+            goodExample: `DATA: BEGIN OF stru,
+        field TYPE i,
       END OF stru.`,
         };
     }

package/build/src/rules/begin_single_include.js

@@ -21,20 +21,20 @@ class BeginSingleInclude extends _abap_rule_1.ABAPRule {
             title: "BEGIN contains single INCLUDE",
             shortDescription: `Finds TYPE BEGIN with just one INCLUDE TYPE, and DATA with single INCLUDE STRUCTURE`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `TYPES: BEGIN OF dummy1.
-  INCLUDE TYPE dselc.
-TYPES: END OF dummy1.
-
-DATA BEGIN OF foo.
-INCLUDE STRUCTURE syst.
-DATA END OF foo.
-
-STATICS BEGIN OF bar.
-INCLUDE STRUCTURE syst.
+            badExample: `TYPES: BEGIN OF dummy1.
+  INCLUDE TYPE dselc.
+TYPES: END OF dummy1.
+
+DATA BEGIN OF foo.
+INCLUDE STRUCTURE syst.
+DATA END OF foo.
+
+STATICS BEGIN OF bar.
+INCLUDE STRUCTURE syst.
 STATICS END OF bar.`,
-            goodExample: `DATA BEGIN OF foo.
-  DATA field TYPE i.
-  INCLUDE STRUCTURE dselc.
+            goodExample: `DATA BEGIN OF foo.
+  DATA field TYPE i.
+  INCLUDE STRUCTURE dselc.
 DATA END OF foo.`,
         };
     }