@abaplint/core 2.113.80 → 2.113.82

package/build/src/abap/5_syntax/expressions/source.js

@@ -155,7 +155,12 @@ class Source {
                         return foundType;
                     }
                 case "EXACT":
-                    return this.determineType(node, input, targetType);
+                    {
+                        const foundType = this.determineType(node, input, targetType);
+                        new Source().runSyntax(node.findDirectExpression(Expressions.Source), input, foundType);
+                        this.addIfInferred(node, input, foundType);
+                        return foundType;
+                    }
                 case "VALUE":
                     {
                         const foundType = this.determineType(node, input, targetType);

package/build/src/cds/expressions/cds_case.js

@@ -7,8 +7,8 @@ class CDSCase extends combi_1.Expression {
     getRunnable() {
         const name = (0, combi_1.seq)(_1.CDSName, (0, combi_1.optPrio)((0, combi_1.seq)(".", _1.CDSName)));
         const value = (0, combi_1.alt)(name, _1.CDSString, _1.CDSFunction, CDSCase, _1.CDSCast, _1.CDSArithmetics);
-        const simple = (0, combi_1.seq)("CASE", (0, combi_1.alt)(name, _1.CDSFunction), (0, combi_1.plus)((0, combi_1.seq)("WHEN", value, "THEN", value)), "ELSE", value, "END");
-        const complex = (0, combi_1.seq)("CASE", (0, combi_1.plus)((0, combi_1.seq)("WHEN", _1.CDSCondition, "THEN", value)), (0, combi_1.opt)((0, combi_1.seq)("ELSE", value)), "END");
+        const simple = (0, combi_1.seq)("CASE", (0, combi_1.alt)(name, _1.CDSFunction), (0, combi_1.plusPrio)((0, combi_1.seq)("WHEN", value, "THEN", value)), "ELSE", value, "END");
+        const complex = (0, combi_1.seq)("CASE", (0, combi_1.plusPrio)((0, combi_1.seq)("WHEN", _1.CDSCondition, "THEN", value)), (0, combi_1.opt)((0, combi_1.seq)("ELSE", value)), "END");
         return (0, combi_1.altPrio)(simple, complex);
     }
 }

package/build/src/registry.js

@@ -67,7 +67,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.80";
+        return "2.113.82";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/downport.js

@@ -2,32 +2,32 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.Downport = exports.DownportConf = void 0;
 /* eslint-disable max-len */
-const Statements = require("../abap/2_statements/statements");
+const crypto = require("crypto");
+const tokens_1 = require("../abap/1_lexer/tokens");
 const Expressions = require("../abap/2_statements/expressions");
-const Structures = require("../abap/3_structures/structures");
-const _basic_rule_config_1 = require("./_basic_rule_config");
-const issue_1 = require("../issue");
-const _irule_1 = require("./_irule");
+const Statements = require("../abap/2_statements/statements");
+const statements_1 = require("../abap/2_statements/statements");
 const _statement_1 = require("../abap/2_statements/statements/_statement");
-const nodes_1 = require("../abap/nodes");
-const edit_helper_1 = require("../edit_helper");
-const position_1 = require("../position");
-const virtual_position_1 = require("../virtual_position");
-const _abap_object_1 = require("../objects/_abap_object");
-const version_1 = require("../version");
-const registry_1 = require("../registry");
-const syntax_1 = require("../abap/5_syntax/syntax");
+const Structures = require("../abap/3_structures/structures");
+const _builtin_1 = require("../abap/5_syntax/_builtin");
 const _reference_1 = require("../abap/5_syntax/_reference");
+const _scope_type_1 = require("../abap/5_syntax/_scope_type");
+const syntax_1 = require("../abap/5_syntax/syntax");
+const nodes_1 = require("../abap/nodes");
 const _typed_identifier_1 = require("../abap/types/_typed_identifier");
 const basic_1 = require("../abap/types/basic");
 const config_1 = require("../config");
-const tokens_1 = require("../abap/1_lexer/tokens");
-const include_graph_1 = require("../utils/include_graph");
+const edit_helper_1 = require("../edit_helper");
+const issue_1 = require("../issue");
 const objects_1 = require("../objects");
-const _builtin_1 = require("../abap/5_syntax/_builtin");
-const _scope_type_1 = require("../abap/5_syntax/_scope_type");
-const statements_1 = require("../abap/2_statements/statements");
-const crypto = require("crypto");
+const _abap_object_1 = require("../objects/_abap_object");
+const position_1 = require("../position");
+const registry_1 = require("../registry");
+const include_graph_1 = require("../utils/include_graph");
+const version_1 = require("../version");
+const virtual_position_1 = require("../virtual_position");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
 // todo: refactor each sub-rule to new classes?
 // todo: add configuration
 class DownportConf extends _basic_rule_config_1.BasicRuleConfig {
@@ -1780,24 +1780,33 @@ ${indentation}    output = ${uniqueName}.\n`;
         return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Outline LOOP input", this.getMetadata().key, this.conf.severity, fix);
     }
     outlineLoopTarget(node, lowFile, highSyntax) {
-        var _a, _b, _c, _d, _e, _f, _g;
+        var _a, _b, _c, _d, _e, _f;
         // also allows outlining of voided types
         if (!(node.get() instanceof Statements.Loop)) {
             return undefined;
         }
-        const sourceName = (_a = node.findDirectExpression(Expressions.SimpleSource2)) === null || _a === void 0 ? void 0 : _a.concatTokens();
+        const source = node.findDirectExpression(Expressions.SimpleSource2);
+        if (source === undefined) {
+            return undefined;
+        }
+        const sourceName = source === null || source === void 0 ? void 0 : source.concatTokens();
         if (sourceName === undefined) {
             return undefined;
         }
+        let foundType = undefined;
+        const spag = highSyntax.spaghetti.lookupPosition(source.getFirstToken().getStart(), lowFile.getFilename());
+        if (spag) {
+            foundType = spag.findVariable(source.concatTokens());
+        }
         const concat = node.concatTokens().toUpperCase();
         if (concat.includes(" GROUP BY ") || concat.startsWith("LOOP AT GROUP ")) {
             return undefined;
         }
         const isReference = concat.includes(" REFERENCE INTO ");
         const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
-        const dataTarget = (_c = (_b = node.findDirectExpression(Expressions.LoopTarget)) === null || _b === void 0 ? void 0 : _b.findDirectExpression(Expressions.Target)) === null || _c === void 0 ? void 0 : _c.findDirectExpression(Expressions.InlineData);
+        const dataTarget = (_b = (_a = node.findDirectExpression(Expressions.LoopTarget)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.Target)) === null || _b === void 0 ? void 0 : _b.findDirectExpression(Expressions.InlineData);
         if (dataTarget) {
-            const targetName = ((_d = dataTarget.findDirectExpression(Expressions.TargetField)) === null || _d === void 0 ? void 0 : _d.concatTokens()) || "DOWNPORT_ERROR";
+            const targetName = ((_c = dataTarget.findDirectExpression(Expressions.TargetField)) === null || _c === void 0 ? void 0 : _c.concatTokens()) || "DOWNPORT_ERROR";
             let code = `DATA ${targetName} LIKE LINE OF ${sourceName}.\n${indentation}`;
             if (isReference) {
                 const likeName = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
@@ -1808,10 +1817,15 @@ ${indentation}    output = ${uniqueName}.\n`;
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
             return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Outline LOOP data target", this.getMetadata().key, this.conf.severity, fix);
         }
-        const fsTarget = (_f = (_e = node.findDirectExpression(Expressions.LoopTarget)) === null || _e === void 0 ? void 0 : _e.findDirectExpression(Expressions.FSTarget)) === null || _f === void 0 ? void 0 : _f.findDirectExpression(Expressions.InlineFS);
+        const fsTarget = (_e = (_d = node.findDirectExpression(Expressions.LoopTarget)) === null || _d === void 0 ? void 0 : _d.findDirectExpression(Expressions.FSTarget)) === null || _e === void 0 ? void 0 : _e.findDirectExpression(Expressions.InlineFS);
         if (fsTarget) {
-            const targetName = ((_g = fsTarget.findDirectExpression(Expressions.TargetFieldSymbol)) === null || _g === void 0 ? void 0 : _g.concatTokens()) || "DOWNPORT_ERROR";
-            const code = `FIELD-SYMBOLS ${targetName} LIKE LINE OF ${sourceName}.\n${indentation}`;
+            const targetName = ((_f = fsTarget.findDirectExpression(Expressions.TargetFieldSymbol)) === null || _f === void 0 ? void 0 : _f.concatTokens()) || "DOWNPORT_ERROR";
+            let type = `LIKE LINE OF ${sourceName}`;
+            const f = foundType === null || foundType === void 0 ? void 0 : foundType.getType();
+            if (f instanceof basic_1.TableType && f.getRowType() instanceof basic_1.AnyType) {
+                type = "TYPE ANY";
+            }
+            const code = `FIELD-SYMBOLS ${targetName} ${type}.\n${indentation}`;
             const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, node.getFirstToken().getStart(), code);
             const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, fsTarget.getFirstToken().getStart(), fsTarget.getLastToken().getEnd(), targetName);
             const fix = edit_helper_1.EditHelper.merge(fix2, fix1);

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.113.80",
+    "version": "2.113.82",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,12 +50,12 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.48.0",
+        "@microsoft/api-extractor": "^7.48.1",
         "@types/chai": "^4.3.20",
         "@types/mocha": "^10.0.10",
-        "@types/node": "^22.10.1",
+        "@types/node": "^22.10.2",
         "chai": "^4.5.0",
-        "eslint": "^9.16.0",
+        "eslint": "^9.17.0",
         "mocha": "^11.0.1",
         "c8": "^10.1.3",
         "source-map-support": "^0.5.21",
@@ -63,7 +63,7 @@
         "typescript": "^5.7.2"
     },
     "dependencies": {
-        "fast-xml-parser": "^4.5.0",
+        "fast-xml-parser": "^4.5.1",
         "json5": "^2.2.3",
         "vscode-languageserver-types": "^3.17.5"
     }