@abaplint/core 2.113.8 → 2.113.9

package/build/src/abap/5_syntax/statements/parameter.js

@@ -6,6 +6,7 @@ const _typed_identifier_1 = require("../../types/_typed_identifier");
 const basic_1 = require("../../types/basic");
 const basic_types_1 = require("../basic_types");
 const _syntax_input_1 = require("../_syntax_input");
+const tokens_1 = require("../../1_lexer/tokens");
 class Parameter {
     runSyntax(node, input) {
         var _a;
@@ -15,19 +16,24 @@ class Parameter {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return;
         }
+        else if (nameToken === undefined) {
+            return;
+        }
         if (node.findDirectTokenByText("RADIOBUTTON") && node.findDirectTokenByText("LENGTH")) {
             const message = "RADIOBUTTON and LENGTH not possible together";
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return;
         }
         const bfound = new basic_types_1.BasicTypes(input).parseType(node);
-        if (nameToken && bfound) {
+        if (bfound) {
             input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, bfound));
-            return;
         }
-        if (nameToken) {
+        else {
             input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, new basic_1.UnknownType("Parameter, fallback")));
         }
+        const magicName = "%_" + nameToken.getStr() + "_%_app_%";
+        const magicToken = new tokens_1.Identifier(nameToken.getStart(), magicName);
+        input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(magicToken, input.filename, new basic_1.VoidType("PARAMETER magic")));
     }
 }
 exports.Parameter = Parameter;

package/build/src/abap/5_syntax/statements/selection_screen.js

@@ -4,12 +4,18 @@ exports.SelectionScreen = void 0;
 const Expressions = require("../../2_statements/expressions");
 const _typed_identifier_1 = require("../../types/_typed_identifier");
 const basic_1 = require("../../types/basic");
+const _syntax_input_1 = require("../_syntax_input");
 class SelectionScreen {
     runSyntax(node, input) {
         const field = node.findFirstExpression(Expressions.InlineField);
         if (field === undefined) {
             return;
         }
+        if (field.getFirstToken().getStr().length > 8) {
+            const message = "SELECTION-SCREEN name too long, " + field.getFirstToken().getStr();
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, field.getFirstToken(), message));
+            return;
+        }
         const name = field.getFirstToken();
         const concat = node.concatTokens().toUpperCase();
         if (concat.includes("BEGIN OF TABBED BLOCK")) {

package/build/src/abap/5_syntax/statements/selectoption.js

@@ -7,6 +7,7 @@ const basic_1 = require("../../types/basic");
 const basic_types_1 = require("../basic_types");
 const dynamic_1 = require("../expressions/dynamic");
 const _syntax_input_1 = require("../_syntax_input");
+const tokens_1 = require("../../1_lexer/tokens");
 class SelectOption {
     runSyntax(node, input) {
         var _a;
@@ -16,12 +17,15 @@ class SelectOption {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, nameToken, message));
             return;
         }
+        else if (nameToken === undefined) {
+            return;
+        }
         for (const d of node.findDirectExpressions(Expressions.Dynamic)) {
             new dynamic_1.Dynamic().runSyntax(d, input);
         }
         const nameExpression = node.findFirstExpression(Expressions.FieldChain);
         let found = new basic_types_1.BasicTypes(input).resolveLikeName(nameExpression);
-        if (found && nameToken) {
+        if (found) {
             if (found instanceof basic_1.StructureType) {
                 let length = 0;
                 for (const c of found.getComponents()) {
@@ -43,11 +47,13 @@ class SelectOption {
                 { name: "HIGH", type: found },
             ]);
             input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, new basic_1.TableType(stru, { withHeader: true, keyType: basic_1.TableKeyType.default })));
-            return;
         }
-        if (nameToken) {
+        else {
             input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(nameToken, input.filename, new basic_1.UnknownType("Select option, fallback")));
         }
+        const magicName = "%_" + nameToken.getStr() + "_%_app_%";
+        const magicToken = new tokens_1.Identifier(nameToken.getStart(), magicName);
+        input.scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(magicToken, input.filename, new basic_1.VoidType("SELECT-OPTION magic")));
     }
 }
 exports.SelectOption = SelectOption;

package/build/src/objects/rename/rename_global_class.js

@@ -17,7 +17,7 @@ class RenameGlobalClass {
         }
         const main = obj.getMainABAPFile();
         if (main === undefined) {
-            throw new Error("Main file not found");
+            throw new Error(`Main file not found, ${obj.getType()} ${obj.getName()}`);
         }
         let changes = [];
         // todo, this is actually the same as "id" ?

package/build/src/registry.js

@@ -67,7 +67,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.8";
+        return "2.113.9";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/ambiguous_statement.js

@@ -28,8 +28,9 @@ Only works if the target version is 740sp05 or above`,
             badExample: `DELETE foo FROM bar.
 MODIFY foo FROM bar.`,
             goodExample: `DELETE foo FROM @bar.
-MODIFY TABLE foo FROM bar.
-MODIFY zfoo FROM @wa.`,
+DELETE TABLE itab FROM 2.
+MODIFY zfoo FROM @wa.
+MODIFY TABLE foo FROM bar.`,
         };
     }
     getMessage() {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.113.8",
+    "version": "2.113.9",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,10 +50,10 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.47.7",
+        "@microsoft/api-extractor": "^7.47.9",
         "@types/chai": "^4.3.19",
-        "@types/mocha": "^10.0.7",
-        "@types/node": "^22.5.4",
+        "@types/mocha": "^10.0.8",
+        "@types/node": "^22.5.5",
         "chai": "^4.5.0",
         "eslint": "^9.10.0",
         "mocha": "^10.7.3",