@abaplint/core 2.113.79 → 2.113.81
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +6 -6
- package/build/src/abap/5_syntax/expressions/source.js +6 -1
- package/build/src/abap/flow/flow_graph.js +7 -7
- package/build/src/cds/expressions/cds_case.js +2 -2
- package/build/src/lsp/help.js +10 -10
- package/build/src/registry.js +1 -1
- package/build/src/rules/7bit_ascii.js +4 -4
- package/build/src/rules/abapdoc.js +4 -4
- package/build/src/rules/add_test_attributes.js +20 -20
- package/build/src/rules/align_parameters.js +40 -40
- package/build/src/rules/align_type_expressions.js +28 -28
- package/build/src/rules/ambiguous_statement.js +7 -7
- package/build/src/rules/avoid_use.js +10 -10
- package/build/src/rules/begin_end_names.js +4 -4
- package/build/src/rules/begin_single_include.js +13 -13
- package/build/src/rules/call_transaction_authority_check.js +3 -3
- package/build/src/rules/cds_comment_style.js +4 -4
- package/build/src/rules/cds_legacy_view.js +4 -4
- package/build/src/rules/chain_mainly_declarations.js +4 -4
- package/build/src/rules/change_if_to_case.js +8 -8
- package/build/src/rules/check_abstract.js +2 -2
- package/build/src/rules/check_comments.js +4 -4
- package/build/src/rules/check_include.js +3 -3
- package/build/src/rules/check_subrc.js +8 -8
- package/build/src/rules/classic_exceptions_overlap.js +10 -10
- package/build/src/rules/commented_code.js +1 -1
- package/build/src/rules/constructor_visibility_public.js +4 -4
- package/build/src/rules/contains_tab.js +2 -2
- package/build/src/rules/cyclic_oo.js +4 -4
- package/build/src/rules/dangerous_statement.js +1 -1
- package/build/src/rules/definitions_top.js +6 -6
- package/build/src/rules/downport.js +84 -84
- package/build/src/rules/easy_to_find_messages.js +6 -6
- package/build/src/rules/empty_event.js +6 -6
- package/build/src/rules/empty_line_in_statement.js +2 -2
- package/build/src/rules/empty_structure.js +6 -6
- package/build/src/rules/exit_or_check.js +3 -3
- package/build/src/rules/expand_macros.js +5 -5
- package/build/src/rules/exporting.js +1 -1
- package/build/src/rules/forbidden_identifier.js +1 -1
- package/build/src/rules/forbidden_void_type.js +2 -2
- package/build/src/rules/fully_type_itabs.js +2 -2
- package/build/src/rules/functional_writing.js +17 -17
- package/build/src/rules/global_class.js +8 -8
- package/build/src/rules/identical_conditions.js +12 -12
- package/build/src/rules/identical_contents.js +14 -14
- package/build/src/rules/identical_descriptions.js +6 -6
- package/build/src/rules/if_in_if.js +35 -35
- package/build/src/rules/implement_methods.js +3 -3
- package/build/src/rules/implicit_start_of_selection.js +5 -5
- package/build/src/rules/in_statement_indentation.js +11 -11
- package/build/src/rules/indentation.js +16 -16
- package/build/src/rules/intf_referencing_clas.js +3 -3
- package/build/src/rules/invalid_table_index.js +2 -2
- package/build/src/rules/line_break_style.js +2 -2
- package/build/src/rules/line_length.js +1 -1
- package/build/src/rules/line_only_punc.js +1 -1
- package/build/src/rules/local_variable_names.js +6 -6
- package/build/src/rules/macro_naming.js +2 -2
- package/build/src/rules/main_file_contents.js +4 -4
- package/build/src/rules/many_parentheses.js +10 -10
- package/build/src/rules/max_one_method_parameter_per_line.js +7 -7
- package/build/src/rules/max_one_statement.js +5 -5
- package/build/src/rules/method_length.js +2 -2
- package/build/src/rules/method_overwrites_builtin.js +12 -12
- package/build/src/rules/mix_returning.js +6 -6
- package/build/src/rules/nesting.js +1 -1
- package/build/src/rules/no_chained_assignment.js +1 -1
- package/build/src/rules/no_external_form_calls.js +2 -2
- package/build/src/rules/no_inline_in_optional_branches.js +11 -11
- package/build/src/rules/no_prefixes.js +6 -6
- package/build/src/rules/no_public_attributes.js +1 -1
- package/build/src/rules/no_yoda_conditions.js +4 -4
- package/build/src/rules/nrob_consistency.js +2 -2
- package/build/src/rules/obsolete_statement.js +51 -51
- package/build/src/rules/omit_parameter_name.js +3 -3
- package/build/src/rules/omit_receiving.js +13 -13
- package/build/src/rules/parser_702_chaining.js +2 -2
- package/build/src/rules/parser_error.js +2 -2
- package/build/src/rules/parser_missing_space.js +1 -1
- package/build/src/rules/prefer_inline.js +16 -16
- package/build/src/rules/prefer_is_not.js +9 -9
- package/build/src/rules/prefer_raise_exception_new.js +5 -5
- package/build/src/rules/prefer_returning_to_exporting.js +4 -4
- package/build/src/rules/prefer_xsdbool.js +2 -2
- package/build/src/rules/preferred_compare_operator.js +2 -2
- package/build/src/rules/reduce_procedural_code.js +17 -17
- package/build/src/rules/remove_descriptions.js +4 -4
- package/build/src/rules/rfc_error_handling.js +7 -7
- package/build/src/rules/select_add_order_by.js +5 -5
- package/build/src/rules/select_performance.js +5 -5
- package/build/src/rules/select_single_full_key.js +2 -2
- package/build/src/rules/sicf_consistency.js +2 -2
- package/build/src/rules/slow_parameter_passing.js +16 -16
- package/build/src/rules/space_before_dot.js +2 -2
- package/build/src/rules/sql_value_conversion.js +6 -6
- package/build/src/rules/start_at_tab.js +1 -1
- package/build/src/rules/strict_sql.js +6 -6
- package/build/src/rules/sy_modification.js +3 -3
- package/build/src/rules/tabl_enhancement_category.js +2 -2
- package/build/src/rules/tables_declared_locally.js +2 -2
- package/build/src/rules/type_form_parameters.js +2 -2
- package/build/src/rules/unnecessary_pragma.js +29 -29
- package/build/src/rules/unnecessary_return.js +11 -11
- package/build/src/rules/unused_macros.js +6 -6
- package/build/src/rules/unused_methods.js +12 -12
- package/build/src/rules/unused_variables.js +12 -12
- package/build/src/rules/use_bool_expression.js +8 -8
- package/build/src/rules/use_class_based_exceptions.js +8 -8
- package/build/src/rules/use_line_exists.js +6 -6
- package/build/src/rules/use_new.js +4 -4
- package/build/src/rules/when_others_last.js +6 -6
- package/package.json +70 -70
|
@@ -85,58 +85,58 @@ class ObsoleteStatement extends _abap_rule_1.ABAPRule {
|
|
|
85
85
|
title: "Obsolete statements",
|
|
86
86
|
shortDescription: `Checks for usages of certain obsolete statements`,
|
|
87
87
|
tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix],
|
|
88
|
-
extendedInformation: `
|
|
89
|
-
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-language-constructs
|
|
90
|
-
|
|
91
|
-
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-obsolete-language-elements
|
|
92
|
-
|
|
93
|
-
SET EXTENDED CHECK: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapset_extended_check.htm
|
|
94
|
-
|
|
95
|
-
IS REQUESTED: https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abenlogexp_requested.htm
|
|
96
|
-
|
|
97
|
-
WITH HEADER LINE: https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapdata_header_line.htm
|
|
98
|
-
|
|
99
|
-
FIELD-SYMBOLS STRUCTURE: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapfield-symbols_obsolete_typing.htm
|
|
100
|
-
|
|
101
|
-
TYPE-POOLS: from 702, https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abennews-71-program_load.htm
|
|
102
|
-
|
|
103
|
-
LOAD addition: from 702, https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abennews-71-program_load.htm
|
|
104
|
-
|
|
105
|
-
COMMUICATION: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapcommunication.htm
|
|
106
|
-
|
|
107
|
-
OCCURS: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapdata_occurs.htm
|
|
108
|
-
|
|
109
|
-
PARAMETER: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abapparameter.htm
|
|
110
|
-
|
|
111
|
-
RANGES: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapranges.htm
|
|
112
|
-
|
|
113
|
-
PACK: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abappack.htm
|
|
114
|
-
|
|
115
|
-
MOVE: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapmove_obs.htm
|
|
116
|
-
|
|
117
|
-
SELECT without INTO: https://help.sap.com/doc/abapdocu_731_index_htm/7.31/en-US/abapselect_obsolete.htm
|
|
118
|
-
SELECT COUNT(*) is considered okay
|
|
119
|
-
|
|
120
|
-
FREE MEMORY: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-us/abapfree_mem_id_obsolete.htm
|
|
121
|
-
|
|
122
|
-
SORT BY FS: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapsort_itab_obsolete.htm
|
|
123
|
-
|
|
124
|
-
CALL TRANSFORMATION OBJECTS: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapcall_transformation_objects.htm
|
|
125
|
-
|
|
126
|
-
POSIX REGEX: https://help.sap.com/doc/abapdocu_755_index_htm/7.55/en-US/index.htm
|
|
127
|
-
|
|
128
|
-
OCCURENCES: check for OCCURENCES vs OCCURRENCES
|
|
129
|
-
|
|
88
|
+
extendedInformation: `
|
|
89
|
+
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-language-constructs
|
|
90
|
+
|
|
91
|
+
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-obsolete-language-elements
|
|
92
|
+
|
|
93
|
+
SET EXTENDED CHECK: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapset_extended_check.htm
|
|
94
|
+
|
|
95
|
+
IS REQUESTED: https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abenlogexp_requested.htm
|
|
96
|
+
|
|
97
|
+
WITH HEADER LINE: https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapdata_header_line.htm
|
|
98
|
+
|
|
99
|
+
FIELD-SYMBOLS STRUCTURE: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapfield-symbols_obsolete_typing.htm
|
|
100
|
+
|
|
101
|
+
TYPE-POOLS: from 702, https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abennews-71-program_load.htm
|
|
102
|
+
|
|
103
|
+
LOAD addition: from 702, https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abennews-71-program_load.htm
|
|
104
|
+
|
|
105
|
+
COMMUICATION: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapcommunication.htm
|
|
106
|
+
|
|
107
|
+
OCCURS: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapdata_occurs.htm
|
|
108
|
+
|
|
109
|
+
PARAMETER: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abapparameter.htm
|
|
110
|
+
|
|
111
|
+
RANGES: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapranges.htm
|
|
112
|
+
|
|
113
|
+
PACK: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abappack.htm
|
|
114
|
+
|
|
115
|
+
MOVE: https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abapmove_obs.htm
|
|
116
|
+
|
|
117
|
+
SELECT without INTO: https://help.sap.com/doc/abapdocu_731_index_htm/7.31/en-US/abapselect_obsolete.htm
|
|
118
|
+
SELECT COUNT(*) is considered okay
|
|
119
|
+
|
|
120
|
+
FREE MEMORY: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-us/abapfree_mem_id_obsolete.htm
|
|
121
|
+
|
|
122
|
+
SORT BY FS: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapsort_itab_obsolete.htm
|
|
123
|
+
|
|
124
|
+
CALL TRANSFORMATION OBJECTS: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abapcall_transformation_objects.htm
|
|
125
|
+
|
|
126
|
+
POSIX REGEX: https://help.sap.com/doc/abapdocu_755_index_htm/7.55/en-US/index.htm
|
|
127
|
+
|
|
128
|
+
OCCURENCES: check for OCCURENCES vs OCCURRENCES
|
|
129
|
+
|
|
130
130
|
CLIENT SPECIFIED, from 754: https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/index.htm?file=abapselect_client_obsolete.htm`,
|
|
131
|
-
badExample: `REFRESH itab.
|
|
132
|
-
|
|
133
|
-
COMPUTE foo = 2 + 2.
|
|
134
|
-
|
|
135
|
-
MULTIPLY lv_foo BY 2.
|
|
136
|
-
|
|
137
|
-
INTERFACE intf LOAD.
|
|
138
|
-
|
|
139
|
-
IF foo IS SUPPLIED.
|
|
131
|
+
badExample: `REFRESH itab.
|
|
132
|
+
|
|
133
|
+
COMPUTE foo = 2 + 2.
|
|
134
|
+
|
|
135
|
+
MULTIPLY lv_foo BY 2.
|
|
136
|
+
|
|
137
|
+
INTERFACE intf LOAD.
|
|
138
|
+
|
|
139
|
+
IF foo IS SUPPLIED.
|
|
140
140
|
ENDIF.`,
|
|
141
141
|
};
|
|
142
142
|
}
|
|
@@ -23,9 +23,9 @@ class OmitParameterName {
|
|
|
23
23
|
key: "omit_parameter_name",
|
|
24
24
|
title: "Omit parameter name",
|
|
25
25
|
shortDescription: `Omit the parameter name in single parameter calls`,
|
|
26
|
-
extendedInformation: `
|
|
27
|
-
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-parameter-name-in-single-parameter-calls
|
|
28
|
-
|
|
26
|
+
extendedInformation: `
|
|
27
|
+
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-parameter-name-in-single-parameter-calls
|
|
28
|
+
|
|
29
29
|
EXPORTING must already be omitted for this rule to take effect, https://rules.abaplint.org/exporting/`,
|
|
30
30
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix],
|
|
31
31
|
badExample: `method( param = 2 ).`,
|
|
@@ -21,20 +21,20 @@ class OmitReceiving extends _abap_rule_1.ABAPRule {
|
|
|
21
21
|
shortDescription: `Omit RECEIVING`,
|
|
22
22
|
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-receiving`,
|
|
23
23
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
|
|
24
|
-
badExample: `
|
|
25
|
-
upload_pack(
|
|
26
|
-
EXPORTING
|
|
27
|
-
io_client = lo_client
|
|
28
|
-
iv_url = iv_url
|
|
29
|
-
iv_deepen_level = iv_deepen_level
|
|
30
|
-
it_hashes = lt_hashes
|
|
31
|
-
RECEIVING
|
|
24
|
+
badExample: `
|
|
25
|
+
upload_pack(
|
|
26
|
+
EXPORTING
|
|
27
|
+
io_client = lo_client
|
|
28
|
+
iv_url = iv_url
|
|
29
|
+
iv_deepen_level = iv_deepen_level
|
|
30
|
+
it_hashes = lt_hashes
|
|
31
|
+
RECEIVING
|
|
32
32
|
rt_objects = et_objects ).`,
|
|
33
|
-
goodExample: `
|
|
34
|
-
et_objects = upload_pack(
|
|
35
|
-
io_client = lo_client
|
|
36
|
-
iv_url = iv_url
|
|
37
|
-
iv_deepen_level = iv_deepen_level
|
|
33
|
+
goodExample: `
|
|
34
|
+
et_objects = upload_pack(
|
|
35
|
+
io_client = lo_client
|
|
36
|
+
iv_url = iv_url
|
|
37
|
+
iv_deepen_level = iv_deepen_level
|
|
38
38
|
it_hashes = lt_hashes ).`,
|
|
39
39
|
};
|
|
40
40
|
}
|
|
@@ -19,8 +19,8 @@ class Parser702Chaining extends _abap_rule_1.ABAPRule {
|
|
|
19
19
|
return {
|
|
20
20
|
key: "parser_702_chaining",
|
|
21
21
|
title: "Parser Error, bad chanining on 702",
|
|
22
|
-
shortDescription: `ABAP on 702 does not allow for method chaining with IMPORTING/EXPORTING/CHANGING keywords,
|
|
23
|
-
this rule finds these and reports errors.
|
|
22
|
+
shortDescription: `ABAP on 702 does not allow for method chaining with IMPORTING/EXPORTING/CHANGING keywords,
|
|
23
|
+
this rule finds these and reports errors.
|
|
24
24
|
Only active on target version 702 and below.`,
|
|
25
25
|
tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.SingleFile],
|
|
26
26
|
};
|
|
@@ -19,8 +19,8 @@ class ParserError {
|
|
|
19
19
|
return {
|
|
20
20
|
key: "parser_error",
|
|
21
21
|
title: "Parser error",
|
|
22
|
-
shortDescription: `Checks for syntax not recognized by abaplint.
|
|
23
|
-
|
|
22
|
+
shortDescription: `Checks for syntax not recognized by abaplint.
|
|
23
|
+
|
|
24
24
|
See recognized syntax at https://syntax.abaplint.org`,
|
|
25
25
|
tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.SingleFile],
|
|
26
26
|
};
|
|
@@ -21,7 +21,7 @@ class ParserMissingSpace extends _abap_rule_1.ABAPRule {
|
|
|
21
21
|
return {
|
|
22
22
|
key: "parser_missing_space",
|
|
23
23
|
title: "Parser Error, missing space",
|
|
24
|
-
shortDescription: `In special cases the ABAP language allows for not having spaces before or after string literals.
|
|
24
|
+
shortDescription: `In special cases the ABAP language allows for not having spaces before or after string literals.
|
|
25
25
|
This rule makes sure the spaces are consistently required across the language.`,
|
|
26
26
|
tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.SingleFile],
|
|
27
27
|
badExample: `IF ( foo = 'bar').`,
|
|
@@ -23,25 +23,25 @@ class PreferInline {
|
|
|
23
23
|
key: "prefer_inline",
|
|
24
24
|
title: "Prefer Inline Declarations",
|
|
25
25
|
shortDescription: `Prefer inline to up-front declarations.`,
|
|
26
|
-
extendedInformation: `EXPERIMENTAL
|
|
27
|
-
|
|
28
|
-
Activates if language version is v740sp02 or above.
|
|
29
|
-
|
|
30
|
-
Variables must be local(METHOD or FORM).
|
|
31
|
-
|
|
32
|
-
No generic or void typed variables. No syntax errors.
|
|
33
|
-
|
|
34
|
-
First position used must be a full/pure write.
|
|
35
|
-
|
|
36
|
-
Move statment is not a cast(?=)
|
|
37
|
-
|
|
26
|
+
extendedInformation: `EXPERIMENTAL
|
|
27
|
+
|
|
28
|
+
Activates if language version is v740sp02 or above.
|
|
29
|
+
|
|
30
|
+
Variables must be local(METHOD or FORM).
|
|
31
|
+
|
|
32
|
+
No generic or void typed variables. No syntax errors.
|
|
33
|
+
|
|
34
|
+
First position used must be a full/pure write.
|
|
35
|
+
|
|
36
|
+
Move statment is not a cast(?=)
|
|
37
|
+
|
|
38
38
|
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-inline-to-up-front-declarations`,
|
|
39
39
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Upport, _irule_1.RuleTag.Experimental, _irule_1.RuleTag.Quickfix],
|
|
40
|
-
badExample: `DATA foo TYPE i.
|
|
41
|
-
foo = 2.
|
|
42
|
-
DATA percentage TYPE decfloat34.
|
|
40
|
+
badExample: `DATA foo TYPE i.
|
|
41
|
+
foo = 2.
|
|
42
|
+
DATA percentage TYPE decfloat34.
|
|
43
43
|
percentage = ( comment_number / abs_statement_number ) * 100.`,
|
|
44
|
-
goodExample: `DATA(foo) = 2.
|
|
44
|
+
goodExample: `DATA(foo) = 2.
|
|
45
45
|
DATA(percentage) = CONV decfloat34( comment_number / abs_statement_number ) * 100.`,
|
|
46
46
|
};
|
|
47
47
|
}
|
|
@@ -21,18 +21,18 @@ class PreferIsNot extends _abap_rule_1.ABAPRule {
|
|
|
21
21
|
key: "prefer_is_not",
|
|
22
22
|
title: "Prefer IS NOT to NOT IS",
|
|
23
23
|
shortDescription: `Prefer IS NOT to NOT IS`,
|
|
24
|
-
extendedInformation: `
|
|
25
|
-
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-is-not-to-not-is
|
|
26
|
-
|
|
24
|
+
extendedInformation: `
|
|
25
|
+
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-is-not-to-not-is
|
|
26
|
+
|
|
27
27
|
"if not is_valid( )." examples are skipped`,
|
|
28
28
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
|
|
29
|
-
goodExample: `IF variable IS NOT INITIAL.
|
|
30
|
-
IF variable NP 'TODO*'.
|
|
31
|
-
IF variable <> 42.
|
|
29
|
+
goodExample: `IF variable IS NOT INITIAL.
|
|
30
|
+
IF variable NP 'TODO*'.
|
|
31
|
+
IF variable <> 42.
|
|
32
32
|
IF variable CO 'hello'.`,
|
|
33
|
-
badExample: `IF NOT variable IS INITIAL.
|
|
34
|
-
IF NOT variable CP 'TODO*'.
|
|
35
|
-
IF NOT variable = 42.
|
|
33
|
+
badExample: `IF NOT variable IS INITIAL.
|
|
34
|
+
IF NOT variable CP 'TODO*'.
|
|
35
|
+
IF NOT variable = 42.
|
|
36
36
|
IF NOT variable CA 'hello'.`,
|
|
37
37
|
};
|
|
38
38
|
}
|
|
@@ -20,14 +20,14 @@ class PreferRaiseExceptionNew extends _abap_rule_1.ABAPRule {
|
|
|
20
20
|
key: "prefer_raise_exception_new",
|
|
21
21
|
title: "Prefer RAISE EXCEPTION NEW to RAISE EXCEPTION TYPE",
|
|
22
22
|
shortDescription: `Prefer RAISE EXCEPTION NEW to RAISE EXCEPTION TYPE`,
|
|
23
|
-
extendedInformation: `
|
|
24
|
-
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-raise-exception-new-to-raise-exception-type
|
|
25
|
-
|
|
23
|
+
extendedInformation: `
|
|
24
|
+
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-raise-exception-new-to-raise-exception-type
|
|
25
|
+
|
|
26
26
|
From 752 and up`,
|
|
27
27
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Upport],
|
|
28
28
|
goodExample: `RAISE EXCEPTION NEW cx_generation_error( previous = exception ).`,
|
|
29
|
-
badExample: `RAISE EXCEPTION TYPE cx_generation_error
|
|
30
|
-
EXPORTING
|
|
29
|
+
badExample: `RAISE EXCEPTION TYPE cx_generation_error
|
|
30
|
+
EXPORTING
|
|
31
31
|
previous = exception.`,
|
|
32
32
|
};
|
|
33
33
|
}
|
|
@@ -20,12 +20,12 @@ class PreferReturningToExporting extends _abap_rule_1.ABAPRule {
|
|
|
20
20
|
key: "prefer_returning_to_exporting",
|
|
21
21
|
title: "Prefer RETURNING to EXPORTING",
|
|
22
22
|
shortDescription: `Prefer RETURNING to EXPORTING. Generic types cannot be RETURNING.`,
|
|
23
|
-
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-returning-to-exporting
|
|
23
|
+
extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-returning-to-exporting
|
|
24
24
|
https://docs.abapopenchecks.org/checks/44/`,
|
|
25
25
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
|
|
26
|
-
badExample: `CLASS lcl DEFINITION.
|
|
27
|
-
PUBLIC SECTION.
|
|
28
|
-
METHODS test EXPORTING ev_foo TYPE i.
|
|
26
|
+
badExample: `CLASS lcl DEFINITION.
|
|
27
|
+
PUBLIC SECTION.
|
|
28
|
+
METHODS test EXPORTING ev_foo TYPE i.
|
|
29
29
|
ENDCLASS.`,
|
|
30
30
|
};
|
|
31
31
|
}
|
|
@@ -21,8 +21,8 @@ class PreferXsdbool extends _abap_rule_1.ABAPRule {
|
|
|
21
21
|
key: "prefer_xsdbool",
|
|
22
22
|
title: "Prefer xsdbool over boolc",
|
|
23
23
|
shortDescription: `Prefer xsdbool over boolc`,
|
|
24
|
-
extendedInformation: `Activates if language version is v740sp08 or above.
|
|
25
|
-
|
|
24
|
+
extendedInformation: `Activates if language version is v740sp08 or above.
|
|
25
|
+
|
|
26
26
|
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-xsdbool-to-set-boolean-variables`,
|
|
27
27
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Upport, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
|
|
28
28
|
badExample: `DATA(sdf) = boolc( 1 = 2 ).`,
|
|
@@ -27,9 +27,9 @@ class PreferredCompareOperator extends _abap_rule_1.ABAPRule {
|
|
|
27
27
|
title: "Preferred compare operator",
|
|
28
28
|
shortDescription: `Configure undesired operator variants`,
|
|
29
29
|
tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
|
|
30
|
-
badExample: `IF foo EQ bar.
|
|
30
|
+
badExample: `IF foo EQ bar.
|
|
31
31
|
ENDIF.`,
|
|
32
|
-
goodExample: `IF foo = bar.
|
|
32
|
+
goodExample: `IF foo = bar.
|
|
33
33
|
ENDIF.`,
|
|
34
34
|
};
|
|
35
35
|
}
|
|
@@ -24,26 +24,26 @@ class ReduceProceduralCode extends _abap_rule_1.ABAPRule {
|
|
|
24
24
|
key: "reduce_procedural_code",
|
|
25
25
|
title: "Reduce procedural code",
|
|
26
26
|
shortDescription: `Checks FORM and FUNCTION-MODULE have few statements`,
|
|
27
|
-
extendedInformation: `Delegate logic to a class method instead of using FORM or FUNCTION-MODULE.
|
|
28
|
-
|
|
29
|
-
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-object-orientation-to-procedural-programming
|
|
30
|
-
|
|
27
|
+
extendedInformation: `Delegate logic to a class method instead of using FORM or FUNCTION-MODULE.
|
|
28
|
+
|
|
29
|
+
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-object-orientation-to-procedural-programming
|
|
30
|
+
|
|
31
31
|
Comments are not counted as statements.`,
|
|
32
32
|
tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
|
|
33
|
-
badExample: `FORM foo.
|
|
34
|
-
DATA lv_bar TYPE i.
|
|
35
|
-
lv_bar = 2 + 2.
|
|
36
|
-
IF lv_bar = 4.
|
|
37
|
-
WRITE 'hello world'.
|
|
38
|
-
ENDIF.
|
|
39
|
-
DATA lv_bar TYPE i.
|
|
40
|
-
lv_bar = 2 + 2.
|
|
41
|
-
IF lv_bar = 4.
|
|
42
|
-
WRITE 'hello world'.
|
|
43
|
-
ENDIF.
|
|
33
|
+
badExample: `FORM foo.
|
|
34
|
+
DATA lv_bar TYPE i.
|
|
35
|
+
lv_bar = 2 + 2.
|
|
36
|
+
IF lv_bar = 4.
|
|
37
|
+
WRITE 'hello world'.
|
|
38
|
+
ENDIF.
|
|
39
|
+
DATA lv_bar TYPE i.
|
|
40
|
+
lv_bar = 2 + 2.
|
|
41
|
+
IF lv_bar = 4.
|
|
42
|
+
WRITE 'hello world'.
|
|
43
|
+
ENDIF.
|
|
44
44
|
ENDFORM.`,
|
|
45
|
-
goodExample: `FORM foo.
|
|
46
|
-
NEW zcl_global_class( )->run_logic( ).
|
|
45
|
+
goodExample: `FORM foo.
|
|
46
|
+
NEW zcl_global_class( )->run_logic( ).
|
|
47
47
|
ENDFORM.`,
|
|
48
48
|
};
|
|
49
49
|
}
|
|
@@ -26,10 +26,10 @@ class RemoveDescriptions {
|
|
|
26
26
|
return {
|
|
27
27
|
key: "remove_descriptions",
|
|
28
28
|
title: "Remove descriptions",
|
|
29
|
-
shortDescription: `Ensures you have no descriptions in metadata of methods, parameters, etc.
|
|
30
|
-
|
|
31
|
-
Class descriptions are required, see rule description_empty.
|
|
32
|
-
|
|
29
|
+
shortDescription: `Ensures you have no descriptions in metadata of methods, parameters, etc.
|
|
30
|
+
|
|
31
|
+
Class descriptions are required, see rule description_empty.
|
|
32
|
+
|
|
33
33
|
Consider using ABAP Doc for documentation.`,
|
|
34
34
|
tags: [],
|
|
35
35
|
};
|
|
@@ -22,14 +22,14 @@ class RFCErrorHandling extends _abap_rule_1.ABAPRule {
|
|
|
22
22
|
tags: [_irule_1.RuleTag.SingleFile],
|
|
23
23
|
shortDescription: `Checks that exceptions 'system_failure' and 'communication_failure' are handled in RFC calls`,
|
|
24
24
|
extendedInformation: `https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abenrfc_exception.htm`,
|
|
25
|
-
badExample: `CALL FUNCTION 'ZRFC'
|
|
25
|
+
badExample: `CALL FUNCTION 'ZRFC'
|
|
26
26
|
DESTINATION lv_rfc.`,
|
|
27
|
-
goodExample: `CALL FUNCTION 'ZRFC'
|
|
28
|
-
DESTINATION lv_rfc
|
|
29
|
-
EXCEPTIONS
|
|
30
|
-
system_failure = 1 MESSAGE msg
|
|
31
|
-
communication_failure = 2 MESSAGE msg
|
|
32
|
-
resource_failure = 3
|
|
27
|
+
goodExample: `CALL FUNCTION 'ZRFC'
|
|
28
|
+
DESTINATION lv_rfc
|
|
29
|
+
EXCEPTIONS
|
|
30
|
+
system_failure = 1 MESSAGE msg
|
|
31
|
+
communication_failure = 2 MESSAGE msg
|
|
32
|
+
resource_failure = 3
|
|
33
33
|
OTHERS = 4.`,
|
|
34
34
|
};
|
|
35
35
|
}
|
|
@@ -25,11 +25,11 @@ class SelectAddOrderBy {
|
|
|
25
25
|
key: "select_add_order_by",
|
|
26
26
|
title: "SELECT add ORDER BY",
|
|
27
27
|
shortDescription: `SELECTs add ORDER BY clause`,
|
|
28
|
-
extendedInformation: `
|
|
29
|
-
This will make sure that the SELECT statement returns results in the same sequence on different databases
|
|
30
|
-
|
|
31
|
-
add ORDER BY PRIMARY KEY if in doubt
|
|
32
|
-
|
|
28
|
+
extendedInformation: `
|
|
29
|
+
This will make sure that the SELECT statement returns results in the same sequence on different databases
|
|
30
|
+
|
|
31
|
+
add ORDER BY PRIMARY KEY if in doubt
|
|
32
|
+
|
|
33
33
|
If the target is a sorted/hashed table, no issue is reported`,
|
|
34
34
|
tags: [_irule_1.RuleTag.SingleFile],
|
|
35
35
|
badExample: `SELECT * FROM db INTO TABLE @DATA(tab).`,
|
|
@@ -34,14 +34,14 @@ class SelectPerformance {
|
|
|
34
34
|
key: "select_performance",
|
|
35
35
|
title: "SELECT performance",
|
|
36
36
|
shortDescription: `Various checks regarding SELECT performance.`,
|
|
37
|
-
extendedInformation: `ENDSELECT: not reported when the corresponding SELECT has PACKAGE SIZE
|
|
38
|
-
|
|
37
|
+
extendedInformation: `ENDSELECT: not reported when the corresponding SELECT has PACKAGE SIZE
|
|
38
|
+
|
|
39
39
|
SELECT *: not reported if using INTO/APPENDING CORRESPONDING FIELDS OF`,
|
|
40
40
|
tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Performance],
|
|
41
|
-
badExample: `SELECT field1, field2 FROM table
|
|
42
|
-
INTO @DATA(structure) UP TO 1 ROWS ORDER BY field3 DESCENDING.
|
|
41
|
+
badExample: `SELECT field1, field2 FROM table
|
|
42
|
+
INTO @DATA(structure) UP TO 1 ROWS ORDER BY field3 DESCENDING.
|
|
43
43
|
ENDSELECT.`,
|
|
44
|
-
goodExample: `SELECT field1, field2 FROM table UP TO 1 ROWS
|
|
44
|
+
goodExample: `SELECT field1, field2 FROM table UP TO 1 ROWS
|
|
45
45
|
INTO TABLE @DATA(table) ORDER BY field3 DESCENDING`,
|
|
46
46
|
};
|
|
47
47
|
}
|
|
@@ -22,8 +22,8 @@ class SelectSingleFullKey {
|
|
|
22
22
|
key: "select_single_full_key",
|
|
23
23
|
title: "Detect SELECT SINGLE which are possibily not unique",
|
|
24
24
|
shortDescription: `Detect SELECT SINGLE which are possibily not unique`,
|
|
25
|
-
extendedInformation: `Table definitions must be known, ie. inside the errorNamespace
|
|
26
|
-
|
|
25
|
+
extendedInformation: `Table definitions must be known, ie. inside the errorNamespace
|
|
26
|
+
|
|
27
27
|
If the statement contains a JOIN it is not checked`,
|
|
28
28
|
pseudoComment: "EC CI_NOORDER",
|
|
29
29
|
tags: [_irule_1.RuleTag.Quickfix],
|
|
@@ -24,8 +24,8 @@ class SICFConsistency {
|
|
|
24
24
|
key: "sicf_consistency",
|
|
25
25
|
title: "SICF consistency",
|
|
26
26
|
shortDescription: `Checks the validity of ICF services`,
|
|
27
|
-
extendedInformation: `* Class defined in handler must exist
|
|
28
|
-
* Class must not have any syntax errors
|
|
27
|
+
extendedInformation: `* Class defined in handler must exist
|
|
28
|
+
* Class must not have any syntax errors
|
|
29
29
|
* Class must implement interface IF_HTTP_EXTENSION`,
|
|
30
30
|
};
|
|
31
31
|
}
|
|
@@ -22,23 +22,23 @@ class SlowParameterPassing {
|
|
|
22
22
|
shortDescription: `Detects slow pass by value passing for methods where parameter is not changed`,
|
|
23
23
|
extendedInformation: `Method parameters defined in interfaces is not checked`,
|
|
24
24
|
tags: [_irule_1.RuleTag.Performance],
|
|
25
|
-
badExample: `CLASS lcl DEFINITION.
|
|
26
|
-
PUBLIC SECTION.
|
|
27
|
-
METHODS bar IMPORTING VALUE(sdf) TYPE string.
|
|
28
|
-
ENDCLASS.
|
|
29
|
-
CLASS lcl IMPLEMENTATION.
|
|
30
|
-
METHOD bar.
|
|
31
|
-
WRITE sdf.
|
|
32
|
-
ENDMETHOD.
|
|
25
|
+
badExample: `CLASS lcl DEFINITION.
|
|
26
|
+
PUBLIC SECTION.
|
|
27
|
+
METHODS bar IMPORTING VALUE(sdf) TYPE string.
|
|
28
|
+
ENDCLASS.
|
|
29
|
+
CLASS lcl IMPLEMENTATION.
|
|
30
|
+
METHOD bar.
|
|
31
|
+
WRITE sdf.
|
|
32
|
+
ENDMETHOD.
|
|
33
33
|
ENDCLASS.`,
|
|
34
|
-
goodExample: `CLASS lcl DEFINITION.
|
|
35
|
-
PUBLIC SECTION.
|
|
36
|
-
METHODS bar IMPORTING sdf TYPE string.
|
|
37
|
-
ENDCLASS.
|
|
38
|
-
CLASS lcl IMPLEMENTATION.
|
|
39
|
-
METHOD bar.
|
|
40
|
-
WRITE sdf.
|
|
41
|
-
ENDMETHOD.
|
|
34
|
+
goodExample: `CLASS lcl DEFINITION.
|
|
35
|
+
PUBLIC SECTION.
|
|
36
|
+
METHODS bar IMPORTING sdf TYPE string.
|
|
37
|
+
ENDCLASS.
|
|
38
|
+
CLASS lcl IMPLEMENTATION.
|
|
39
|
+
METHOD bar.
|
|
40
|
+
WRITE sdf.
|
|
41
|
+
ENDMETHOD.
|
|
42
42
|
ENDCLASS.`,
|
|
43
43
|
};
|
|
44
44
|
}
|
|
@@ -29,8 +29,8 @@ class SpaceBeforeDot extends _abap_rule_1.ABAPRule {
|
|
|
29
29
|
key: "space_before_dot",
|
|
30
30
|
title: "Space before dot",
|
|
31
31
|
shortDescription: `Checks for extra spaces before dots at the ends of statements`,
|
|
32
|
-
extendedInformation: `
|
|
33
|
-
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#be-consistent
|
|
32
|
+
extendedInformation: `
|
|
33
|
+
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#be-consistent
|
|
34
34
|
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#condense-your-code`,
|
|
35
35
|
tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
|
|
36
36
|
badExample: `WRITE bar .`,
|
|
@@ -18,12 +18,12 @@ class SQLValueConversion {
|
|
|
18
18
|
key: "sql_value_conversion",
|
|
19
19
|
title: "Implicit SQL Value Conversion",
|
|
20
20
|
shortDescription: `Ensure types match when selecting from database`,
|
|
21
|
-
extendedInformation: `
|
|
22
|
-
* Integer to CHAR conversion
|
|
23
|
-
* Integer to NUMC conversion
|
|
24
|
-
* NUMC to Integer conversion
|
|
25
|
-
* CHAR to Integer conversion
|
|
26
|
-
* Source field longer than database field, CHAR -> CHAR
|
|
21
|
+
extendedInformation: `
|
|
22
|
+
* Integer to CHAR conversion
|
|
23
|
+
* Integer to NUMC conversion
|
|
24
|
+
* NUMC to Integer conversion
|
|
25
|
+
* CHAR to Integer conversion
|
|
26
|
+
* Source field longer than database field, CHAR -> CHAR
|
|
27
27
|
* Source field longer than database field, NUMC -> NUMC`,
|
|
28
28
|
tags: [],
|
|
29
29
|
};
|
|
@@ -20,7 +20,7 @@ class StartAtTab extends _abap_rule_1.ABAPRule {
|
|
|
20
20
|
key: "start_at_tab",
|
|
21
21
|
title: "Start at tab",
|
|
22
22
|
shortDescription: `Checks that statements start at tabstops.`,
|
|
23
|
-
extendedInformation: `Reports max 100 issues per file
|
|
23
|
+
extendedInformation: `Reports max 100 issues per file
|
|
24
24
|
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#indent-and-snap-to-tab`,
|
|
25
25
|
tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
|
|
26
26
|
badExample: ` WRITE a.`,
|
|
@@ -22,12 +22,12 @@ class StrictSQL extends _abap_rule_1.ABAPRule {
|
|
|
22
22
|
key: "strict_sql",
|
|
23
23
|
title: "Strict SQL",
|
|
24
24
|
shortDescription: `Strict SQL`,
|
|
25
|
-
extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abapinto_clause.htm
|
|
26
|
-
|
|
27
|
-
https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abenopensql_strict_mode_750.htm
|
|
28
|
-
|
|
29
|
-
Also see separate rule sql_escape_host_variables
|
|
30
|
-
|
|
25
|
+
extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abapinto_clause.htm
|
|
26
|
+
|
|
27
|
+
https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-us/abenopensql_strict_mode_750.htm
|
|
28
|
+
|
|
29
|
+
Also see separate rule sql_escape_host_variables
|
|
30
|
+
|
|
31
31
|
Activates from v750 and up`,
|
|
32
32
|
tags: [_irule_1.RuleTag.Upport, _irule_1.RuleTag.Quickfix],
|
|
33
33
|
badExample: `SELECT * FROM ztabl INTO TABLE @rt_content WHERE type = @iv_type ORDER BY PRIMARY KEY.`,
|
|
@@ -19,11 +19,11 @@ class SyModification extends _abap_rule_1.ABAPRule {
|
|
|
19
19
|
key: "sy_modification",
|
|
20
20
|
title: "Modification of SY fields",
|
|
21
21
|
shortDescription: `Finds modification of sy fields`,
|
|
22
|
-
extendedInformation: `https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abensystem_fields.htm
|
|
23
|
-
|
|
22
|
+
extendedInformation: `https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abensystem_fields.htm
|
|
23
|
+
|
|
24
24
|
Changes to SY-TVAR* fields are not reported`,
|
|
25
25
|
tags: [_irule_1.RuleTag.SingleFile],
|
|
26
|
-
badExample: `sy-uname = 2.
|
|
26
|
+
badExample: `sy-uname = 2.
|
|
27
27
|
sy = sy.`,
|
|
28
28
|
};
|
|
29
29
|
}
|
|
@@ -17,8 +17,8 @@ class TABLEnhancementCategory {
|
|
|
17
17
|
key: "tabl_enhancement_category",
|
|
18
18
|
title: "TABL enhancement category must be set",
|
|
19
19
|
shortDescription: `Checks that tables do not have the enhancement category 'not classified'.`,
|
|
20
|
-
extendedInformation: `SAP note 3063227 changes the default to 'Cannot be enhanced'.
|
|
21
|
-
|
|
20
|
+
extendedInformation: `SAP note 3063227 changes the default to 'Cannot be enhanced'.
|
|
21
|
+
|
|
22
22
|
You may use standard report RS_DDIC_CLASSIFICATION_FINAL for adjustment.`,
|
|
23
23
|
tags: [],
|
|
24
24
|
};
|
|
@@ -22,8 +22,8 @@ class TablesDeclaredLocally extends _abap_rule_1.ABAPRule {
|
|
|
22
22
|
shortDescription: `TABLES are always global, so declare them globally`,
|
|
23
23
|
extendedInformation: `https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-us/abaptables.htm`,
|
|
24
24
|
tags: [_irule_1.RuleTag.SingleFile],
|
|
25
|
-
badExample: `FORM foo.
|
|
26
|
-
TABLES t100.
|
|
25
|
+
badExample: `FORM foo.
|
|
26
|
+
TABLES t100.
|
|
27
27
|
ENDFORM.`,
|
|
28
28
|
goodExample: `TABLES t000.`,
|
|
29
29
|
};
|
|
@@ -21,9 +21,9 @@ class TypeFormParameters extends _abap_rule_1.ABAPRule {
|
|
|
21
21
|
title: "Type FORM parameters",
|
|
22
22
|
shortDescription: `Checks for untyped FORM parameters`,
|
|
23
23
|
tags: [_irule_1.RuleTag.SingleFile],
|
|
24
|
-
badExample: `FORM foo USING bar.
|
|
24
|
+
badExample: `FORM foo USING bar.
|
|
25
25
|
ENDFORM.`,
|
|
26
|
-
goodExample: `FORM foo USING bar TYPE string.
|
|
26
|
+
goodExample: `FORM foo USING bar TYPE string.
|
|
27
27
|
ENDFORM.`,
|
|
28
28
|
};
|
|
29
29
|
}
|