@abaplint/core 2.113.68 → 2.113.69
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +6 -6
- package/build/abaplint.d.ts +1 -0
- package/build/src/abap/2_statements/statement_parser.js +6 -1
- package/build/src/abap/2_statements/statements/get_permissions.js +3 -1
- package/build/src/abap/2_statements/statements/modify_entities.js +1 -1
- package/build/src/abap/5_syntax/_reference.js +1 -0
- package/build/src/abap/5_syntax/expressions/new_object.js +2 -0
- package/build/src/abap/5_syntax/statements/create_object.js +42 -39
- package/build/src/abap/flow/flow_graph.js +7 -7
- package/build/src/lsp/help.js +10 -10
- package/build/src/objects/rename/renamer_helper.js +3 -0
- package/build/src/registry.js +1 -1
- package/build/src/rules/7bit_ascii.js +4 -4
- package/build/src/rules/abapdoc.js +4 -4
- package/build/src/rules/add_test_attributes.js +20 -20
- package/build/src/rules/align_parameters.js +40 -40
- package/build/src/rules/align_type_expressions.js +28 -28
- package/build/src/rules/ambiguous_statement.js +7 -7
- package/build/src/rules/avoid_use.js +10 -10
- package/build/src/rules/begin_end_names.js +4 -4
- package/build/src/rules/begin_single_include.js +13 -13
- package/build/src/rules/call_transaction_authority_check.js +3 -3
- package/build/src/rules/cds_comment_style.js +4 -4
- package/build/src/rules/cds_legacy_view.js +4 -4
- package/build/src/rules/chain_mainly_declarations.js +4 -4
- package/build/src/rules/change_if_to_case.js +8 -8
- package/build/src/rules/check_abstract.js +2 -2
- package/build/src/rules/check_comments.js +4 -4
- package/build/src/rules/check_include.js +3 -3
- package/build/src/rules/check_subrc.js +8 -8
- package/build/src/rules/classic_exceptions_overlap.js +10 -10
- package/build/src/rules/colon_missing_space.js +24 -12
- package/build/src/rules/commented_code.js +1 -1
- package/build/src/rules/constructor_visibility_public.js +4 -4
- package/build/src/rules/contains_tab.js +2 -2
- package/build/src/rules/cyclic_oo.js +4 -4
- package/build/src/rules/dangerous_statement.js +1 -1
- package/build/src/rules/definitions_top.js +6 -6
- package/build/src/rules/double_space.js +3 -0
- package/build/src/rules/downport.js +82 -82
- package/build/src/rules/easy_to_find_messages.js +6 -6
- package/build/src/rules/empty_event.js +6 -6
- package/build/src/rules/empty_line_in_statement.js +2 -2
- package/build/src/rules/empty_structure.js +6 -6
- package/build/src/rules/exit_or_check.js +3 -3
- package/build/src/rules/expand_macros.js +5 -5
- package/build/src/rules/exporting.js +1 -1
- package/build/src/rules/forbidden_identifier.js +1 -1
- package/build/src/rules/forbidden_void_type.js +2 -2
- package/build/src/rules/fully_type_itabs.js +2 -2
- package/build/src/rules/functional_writing.js +17 -17
- package/build/src/rules/global_class.js +8 -8
- package/build/src/rules/identical_conditions.js +12 -12
- package/build/src/rules/identical_contents.js +14 -14
- package/build/src/rules/identical_descriptions.js +6 -6
- package/build/src/rules/if_in_if.js +35 -35
- package/build/src/rules/implement_methods.js +3 -3
- package/build/src/rules/implicit_start_of_selection.js +5 -5
- package/build/src/rules/in_statement_indentation.js +11 -11
- package/build/src/rules/indentation.js +16 -16
- package/build/src/rules/intf_referencing_clas.js +3 -3
- package/build/src/rules/invalid_table_index.js +2 -2
- package/build/src/rules/line_break_style.js +2 -2
- package/build/src/rules/line_length.js +1 -1
- package/build/src/rules/line_only_punc.js +1 -1
- package/build/src/rules/local_variable_names.js +6 -6
- package/build/src/rules/macro_naming.js +2 -2
- package/build/src/rules/main_file_contents.js +4 -4
- package/build/src/rules/many_parentheses.js +10 -10
- package/build/src/rules/max_one_method_parameter_per_line.js +7 -7
- package/build/src/rules/max_one_statement.js +5 -5
- package/build/src/rules/method_length.js +2 -2
- package/build/src/rules/method_overwrites_builtin.js +12 -12
- package/build/src/rules/mix_returning.js +6 -6
- package/build/src/rules/nesting.js +1 -1
- package/build/src/rules/no_chained_assignment.js +1 -1
- package/build/src/rules/no_external_form_calls.js +2 -2
- package/build/src/rules/no_inline_in_optional_branches.js +11 -11
- package/build/src/rules/no_prefixes.js +6 -6
- package/build/src/rules/no_public_attributes.js +1 -1
- package/build/src/rules/no_yoda_conditions.js +4 -4
- package/build/src/rules/nrob_consistency.js +2 -2
- package/build/src/rules/obsolete_statement.js +51 -51
- package/build/src/rules/omit_parameter_name.js +3 -3
- package/build/src/rules/omit_receiving.js +13 -13
- package/build/src/rules/parser_702_chaining.js +2 -2
- package/build/src/rules/parser_error.js +2 -2
- package/build/src/rules/parser_missing_space.js +1 -1
- package/build/src/rules/prefer_inline.js +16 -16
- package/build/src/rules/prefer_is_not.js +9 -9
- package/build/src/rules/prefer_raise_exception_new.js +5 -5
- package/build/src/rules/prefer_returning_to_exporting.js +4 -4
- package/build/src/rules/prefer_xsdbool.js +2 -2
- package/build/src/rules/preferred_compare_operator.js +2 -2
- package/build/src/rules/reduce_procedural_code.js +17 -17
- package/build/src/rules/remove_descriptions.js +4 -4
- package/build/src/rules/rfc_error_handling.js +7 -7
- package/build/src/rules/select_add_order_by.js +5 -5
- package/build/src/rules/select_performance.js +5 -5
- package/build/src/rules/select_single_full_key.js +2 -2
- package/build/src/rules/sicf_consistency.js +2 -2
- package/build/src/rules/slow_parameter_passing.js +16 -16
- package/build/src/rules/space_before_colon.js +28 -14
- package/build/src/rules/space_before_dot.js +2 -2
- package/build/src/rules/sql_value_conversion.js +6 -6
- package/build/src/rules/start_at_tab.js +1 -1
- package/build/src/rules/strict_sql.js +6 -6
- package/build/src/rules/sy_modification.js +3 -3
- package/build/src/rules/tabl_enhancement_category.js +2 -2
- package/build/src/rules/tables_declared_locally.js +2 -2
- package/build/src/rules/type_form_parameters.js +2 -2
- package/build/src/rules/unnecessary_pragma.js +29 -29
- package/build/src/rules/unnecessary_return.js +11 -11
- package/build/src/rules/unused_macros.js +6 -6
- package/build/src/rules/unused_methods.js +12 -12
- package/build/src/rules/unused_variables.js +12 -12
- package/build/src/rules/use_bool_expression.js +8 -8
- package/build/src/rules/use_class_based_exceptions.js +8 -8
- package/build/src/rules/use_line_exists.js +6 -6
- package/build/src/rules/use_new.js +4 -4
- package/build/src/rules/when_others_last.js +6 -6
- package/package.json +70 -70
package/README.md
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
|
-
# @abaplint/core
|
|
2
|
-
|
|
3
|
-
[abaplint](https://abaplint.org) core library
|
|
4
|
-
|
|
5
|
-
Exposes functionality like the parser and rules, which can be used in other projects.
|
|
6
|
-
|
|
1
|
+
# @abaplint/core
|
|
2
|
+
|
|
3
|
+
[abaplint](https://abaplint.org) core library
|
|
4
|
+
|
|
5
|
+
Exposes functionality like the parser and rules, which can be used in other projects.
|
|
6
|
+
|
|
7
7
|
For more information see https://github.com/abaplint/abaplint
|
package/build/abaplint.d.ts
CHANGED
|
@@ -5383,6 +5383,7 @@ export declare enum ReferenceType {
|
|
|
5383
5383
|
TableVoidReference = "Table (Void)",
|
|
5384
5384
|
MethodReference = "Method",
|
|
5385
5385
|
BuiltinMethodReference = "Builtin Method",
|
|
5386
|
+
ConstructorReference = "Constructor Reference",
|
|
5386
5387
|
MethodImplementationReference = "Method Implementation",
|
|
5387
5388
|
TypeReference = "Type",
|
|
5388
5389
|
BuiltinTypeReference = "Builtin Type",
|
|
@@ -160,8 +160,13 @@ class StatementParser {
|
|
|
160
160
|
|| type instanceof Statements.EndMethod) {
|
|
161
161
|
sql = false;
|
|
162
162
|
}
|
|
163
|
-
else
|
|
163
|
+
else {
|
|
164
164
|
wa.statements[i] = new nodes_1.StatementNode(new _statement_1.NativeSQL()).setChildren(this.tokensToNodes(statement.getTokens()));
|
|
165
|
+
if (statement.concatTokens().toUpperCase().endsWith("ENDMETHOD.")) {
|
|
166
|
+
// yea, this is not completely correct
|
|
167
|
+
wa.statements[i] = new nodes_1.StatementNode(new Statements.EndMethod()).setChildren(this.tokensToNodes(statement.getTokens()));
|
|
168
|
+
sql = false;
|
|
169
|
+
}
|
|
165
170
|
}
|
|
166
171
|
}
|
|
167
172
|
}
|
|
@@ -6,7 +6,9 @@ const expressions_1 = require("../expressions");
|
|
|
6
6
|
const version_1 = require("../../../version");
|
|
7
7
|
class GetPermissions {
|
|
8
8
|
getMatcher() {
|
|
9
|
-
const
|
|
9
|
+
const type = (0, combi_1.altPrio)("GLOBAL AUTHORIZATION", "INSTANCE");
|
|
10
|
+
const from = (0, combi_1.seq)("FROM", expressions_1.Source);
|
|
11
|
+
const s = (0, combi_1.seq)("GET PERMISSIONS ONLY", type, "ENTITY", expressions_1.SimpleName, (0, combi_1.optPrio)(from), "REQUEST", expressions_1.Source, "RESULT", expressions_1.Target, "FAILED", expressions_1.Target, "REPORTED", expressions_1.Target);
|
|
10
12
|
return (0, combi_1.ver)(version_1.Version.v754, s);
|
|
11
13
|
}
|
|
12
14
|
}
|
|
@@ -14,7 +14,7 @@ class ModifyEntities {
|
|
|
14
14
|
const reported = (0, combi_1.seq)("REPORTED", expressions_1.Target);
|
|
15
15
|
const from = (0, combi_1.seq)("FROM", expressions_1.Source);
|
|
16
16
|
const execute = (0, combi_1.seq)("EXECUTE", expressions_1.NamespaceSimpleName);
|
|
17
|
-
const entities = (0, combi_1.seq)("ENTITIES OF", expressions_1.NamespaceSimpleName, (0, combi_1.opt)("IN LOCAL MODE"), "ENTITY", expressions_1.SimpleName, operation, (0, combi_1.optPrio)((0, combi_1.per)(failed, result, mapped, reported)));
|
|
17
|
+
const entities = (0, combi_1.seq)("ENTITIES OF", expressions_1.NamespaceSimpleName, (0, combi_1.opt)("IN LOCAL MODE"), (0, combi_1.plusPrio)((0, combi_1.seq)("ENTITY", expressions_1.SimpleName, operation)), (0, combi_1.optPrio)((0, combi_1.per)(failed, result, mapped, reported)));
|
|
18
18
|
const entity = (0, combi_1.seq)("ENTITY", expressions_1.NamespaceSimpleName, execute, from, mapped, failed, reported);
|
|
19
19
|
return (0, combi_1.ver)(version_1.Version.v754, (0, combi_1.seq)("MODIFY", (0, combi_1.alt)(entities, entity)));
|
|
20
20
|
}
|
|
@@ -11,6 +11,7 @@ var ReferenceType;
|
|
|
11
11
|
ReferenceType["TableVoidReference"] = "Table (Void)";
|
|
12
12
|
ReferenceType["MethodReference"] = "Method";
|
|
13
13
|
ReferenceType["BuiltinMethodReference"] = "Builtin Method";
|
|
14
|
+
ReferenceType["ConstructorReference"] = "Constructor Reference";
|
|
14
15
|
ReferenceType["MethodImplementationReference"] = "Method Implementation";
|
|
15
16
|
ReferenceType["TypeReference"] = "Type";
|
|
16
17
|
ReferenceType["BuiltinTypeReference"] = "Builtin Type";
|
|
@@ -24,6 +24,7 @@ class NewObject {
|
|
|
24
24
|
const clas = input.scope.findClassDefinition(targetType.getIdentifierName());
|
|
25
25
|
if (clas) {
|
|
26
26
|
input.scope.addReference(typeToken, clas, _reference_1.ReferenceType.InferredType, input.filename);
|
|
27
|
+
input.scope.addReference(typeToken, clas, _reference_1.ReferenceType.ConstructorReference, input.filename);
|
|
27
28
|
}
|
|
28
29
|
else {
|
|
29
30
|
const intf = input.scope.findInterfaceDefinition(targetType.getIdentifierName());
|
|
@@ -50,6 +51,7 @@ class NewObject {
|
|
|
50
51
|
const objDefinition = input.scope.findObjectDefinition(typeName);
|
|
51
52
|
if (objDefinition) {
|
|
52
53
|
input.scope.addReference(typeToken, objDefinition, _reference_1.ReferenceType.ObjectOrientedReference, input.filename);
|
|
54
|
+
input.scope.addReference(typeToken, objDefinition, _reference_1.ReferenceType.ConstructorReference, input.filename);
|
|
53
55
|
const objref = new basic_1.ObjectReferenceType(objDefinition);
|
|
54
56
|
const clas = input.scope.findClassDefinition(objref.getIdentifierName());
|
|
55
57
|
if ((clas === null || clas === void 0 ? void 0 : clas.isAbstract()) === true) {
|
|
@@ -13,6 +13,7 @@ const _type_utils_1 = require("../_type_utils");
|
|
|
13
13
|
const _syntax_input_1 = require("../_syntax_input");
|
|
14
14
|
class CreateObject {
|
|
15
15
|
runSyntax(node, input) {
|
|
16
|
+
var _a;
|
|
16
17
|
let cdef = undefined;
|
|
17
18
|
// CREATE OBJECT, TYPE
|
|
18
19
|
const type = node.findExpressionAfterToken("TYPE");
|
|
@@ -22,6 +23,7 @@ class CreateObject {
|
|
|
22
23
|
cdef = input.scope.findClassDefinition(name);
|
|
23
24
|
if (cdef) {
|
|
24
25
|
input.scope.addReference(token, cdef, _reference_1.ReferenceType.ObjectOrientedReference, input.filename);
|
|
26
|
+
input.scope.addReference(token, cdef, _reference_1.ReferenceType.ConstructorReference, input.filename);
|
|
25
27
|
if (cdef.isAbstract() === true) {
|
|
26
28
|
const message = cdef.getName() + " is abstract, cannot be instantiated";
|
|
27
29
|
input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
|
|
@@ -41,60 +43,61 @@ class CreateObject {
|
|
|
41
43
|
for (const s of node.findDirectExpressions(Expressions.Source)) {
|
|
42
44
|
new source_1.Source().runSyntax(s, input);
|
|
43
45
|
}
|
|
44
|
-
|
|
45
|
-
|
|
46
|
+
for (const t of ((_a = node.findDirectExpression(Expressions.ParameterListExceptions)) === null || _a === void 0 ? void 0 : _a.findAllExpressions(Expressions.Target)) || []) {
|
|
47
|
+
new target_1.Target().runSyntax(t, input);
|
|
48
|
+
}
|
|
49
|
+
const t = node.findDirectExpression(Expressions.Target);
|
|
50
|
+
if (t) {
|
|
46
51
|
const found = new target_1.Target().runSyntax(t, input);
|
|
47
|
-
if (
|
|
48
|
-
|
|
49
|
-
|
|
50
|
-
|
|
51
|
-
|
|
52
|
-
|
|
53
|
-
|
|
52
|
+
if (found instanceof basic_1.VoidType) {
|
|
53
|
+
// do nothing
|
|
54
|
+
}
|
|
55
|
+
else if (found instanceof basic_1.UnknownType) {
|
|
56
|
+
const message = "Target type unknown, " + t.concatTokens();
|
|
57
|
+
input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
|
|
58
|
+
return;
|
|
59
|
+
}
|
|
60
|
+
else if (!(found instanceof basic_1.ObjectReferenceType)
|
|
61
|
+
&& !(found instanceof basic_1.AnyType)
|
|
62
|
+
&& !(found instanceof basic_1.DataType)
|
|
63
|
+
&& !(found instanceof basic_1.GenericObjectReferenceType)) {
|
|
64
|
+
const message = "Target must be an object reference, " + t.concatTokens();
|
|
65
|
+
input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
|
|
66
|
+
return;
|
|
67
|
+
}
|
|
68
|
+
else if (found instanceof basic_1.GenericObjectReferenceType && type === undefined) {
|
|
69
|
+
const message = "Generic type, cannot be instantiated";
|
|
70
|
+
input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
|
|
71
|
+
return;
|
|
72
|
+
}
|
|
73
|
+
else if (found instanceof basic_1.ObjectReferenceType) {
|
|
74
|
+
const id = found.getIdentifier();
|
|
75
|
+
if (id instanceof types_1.InterfaceDefinition && type === undefined) {
|
|
76
|
+
const message = "Interface reference, cannot be instantiated";
|
|
54
77
|
input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
|
|
55
78
|
return;
|
|
56
79
|
}
|
|
57
|
-
else if (
|
|
58
|
-
&&
|
|
59
|
-
&&
|
|
60
|
-
|
|
61
|
-
const message = "Target must be an object reference, " + t.concatTokens();
|
|
80
|
+
else if (found instanceof basic_1.ObjectReferenceType
|
|
81
|
+
&& type === undefined
|
|
82
|
+
&& input.scope.findInterfaceDefinition(found.getQualifiedName())) {
|
|
83
|
+
const message = "Interface reference, cannot be instantiated";
|
|
62
84
|
input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
|
|
63
85
|
return;
|
|
64
86
|
}
|
|
65
|
-
else if (
|
|
66
|
-
|
|
87
|
+
else if (id instanceof types_1.ClassDefinition && cdef === undefined) {
|
|
88
|
+
cdef = id;
|
|
89
|
+
}
|
|
90
|
+
if (type === undefined && id instanceof types_1.ClassDefinition && id.isAbstract() === true) {
|
|
91
|
+
const message = id.getName() + " is abstract, cannot be instantiated";
|
|
67
92
|
input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
|
|
68
93
|
return;
|
|
69
94
|
}
|
|
70
|
-
else if (found instanceof basic_1.ObjectReferenceType) {
|
|
71
|
-
const id = found.getIdentifier();
|
|
72
|
-
if (id instanceof types_1.InterfaceDefinition && type === undefined) {
|
|
73
|
-
const message = "Interface reference, cannot be instantiated";
|
|
74
|
-
input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
|
|
75
|
-
return;
|
|
76
|
-
}
|
|
77
|
-
else if (found instanceof basic_1.ObjectReferenceType
|
|
78
|
-
&& type === undefined
|
|
79
|
-
&& input.scope.findInterfaceDefinition(found.getQualifiedName())) {
|
|
80
|
-
const message = "Interface reference, cannot be instantiated";
|
|
81
|
-
input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
|
|
82
|
-
return;
|
|
83
|
-
}
|
|
84
|
-
else if (id instanceof types_1.ClassDefinition && cdef === undefined) {
|
|
85
|
-
cdef = id;
|
|
86
|
-
}
|
|
87
|
-
if (type === undefined && id instanceof types_1.ClassDefinition && id.isAbstract() === true) {
|
|
88
|
-
const message = id.getName() + " is abstract, cannot be instantiated";
|
|
89
|
-
input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
|
|
90
|
-
return;
|
|
91
|
-
}
|
|
92
|
-
}
|
|
93
95
|
}
|
|
94
96
|
}
|
|
95
97
|
for (const t of node.findDirectExpressions(Expressions.Dynamic)) {
|
|
96
98
|
new dynamic_1.Dynamic().runSyntax(t, input);
|
|
97
99
|
}
|
|
100
|
+
input.scope.addReference(t === null || t === void 0 ? void 0 : t.getFirstToken(), cdef, _reference_1.ReferenceType.ConstructorReference, input.filename);
|
|
98
101
|
this.validateParameters(cdef, node, input);
|
|
99
102
|
}
|
|
100
103
|
validateParameters(cdef, node, input) {
|
|
@@ -94,13 +94,13 @@ class FlowGraph {
|
|
|
94
94
|
this.label = label;
|
|
95
95
|
}
|
|
96
96
|
toDigraph() {
|
|
97
|
-
return `digraph G {
|
|
98
|
-
labelloc="t";
|
|
99
|
-
label="${this.label}";
|
|
100
|
-
graph [fontname = "helvetica"];
|
|
101
|
-
node [fontname = "helvetica", shape="box"];
|
|
102
|
-
edge [fontname = "helvetica"];
|
|
103
|
-
${this.toTextEdges()}
|
|
97
|
+
return `digraph G {
|
|
98
|
+
labelloc="t";
|
|
99
|
+
label="${this.label}";
|
|
100
|
+
graph [fontname = "helvetica"];
|
|
101
|
+
node [fontname = "helvetica", shape="box"];
|
|
102
|
+
edge [fontname = "helvetica"];
|
|
103
|
+
${this.toTextEdges()}
|
|
104
104
|
}`;
|
|
105
105
|
}
|
|
106
106
|
listSources(node) {
|
package/build/src/lsp/help.js
CHANGED
|
@@ -20,13 +20,13 @@ class Help {
|
|
|
20
20
|
/////////////////////////////////////////////////
|
|
21
21
|
static dumpABAP(file, reg, textDocument, position) {
|
|
22
22
|
let content = "";
|
|
23
|
-
content = `
|
|
24
|
-
<a href="#_tokens" rel="no-refresh">Tokens</a> |
|
|
25
|
-
<a href="#_statements" rel="no-refresh">Statements</a> |
|
|
26
|
-
<a href="#_structure" rel="no-refresh">Structure</a> |
|
|
27
|
-
<a href="#_files" rel="no-refresh">Files</a> |
|
|
28
|
-
<a href="#_info" rel="no-refresh">Info Dump</a>
|
|
29
|
-
<hr>
|
|
23
|
+
content = `
|
|
24
|
+
<a href="#_tokens" rel="no-refresh">Tokens</a> |
|
|
25
|
+
<a href="#_statements" rel="no-refresh">Statements</a> |
|
|
26
|
+
<a href="#_structure" rel="no-refresh">Structure</a> |
|
|
27
|
+
<a href="#_files" rel="no-refresh">Files</a> |
|
|
28
|
+
<a href="#_info" rel="no-refresh">Info Dump</a>
|
|
29
|
+
<hr>
|
|
30
30
|
` +
|
|
31
31
|
"<tt>" + textDocument.uri + " (" +
|
|
32
32
|
(position.line + 1) + ", " +
|
|
@@ -181,9 +181,9 @@ class Help {
|
|
|
181
181
|
return ret + "</ul>";
|
|
182
182
|
}
|
|
183
183
|
static tokens(file) {
|
|
184
|
-
let inner = `<table><tr><td><b>String</b></td><td><b>Type</b></td>
|
|
185
|
-
<td><b>Row</b></td><td><b>Column</b></td>
|
|
186
|
-
<td><b>vRow</b></td><td><b>vColumn</b></td>
|
|
184
|
+
let inner = `<table><tr><td><b>String</b></td><td><b>Type</b></td>
|
|
185
|
+
<td><b>Row</b></td><td><b>Column</b></td>
|
|
186
|
+
<td><b>vRow</b></td><td><b>vColumn</b></td>
|
|
187
187
|
</tr>`;
|
|
188
188
|
for (const token of file.getTokens()) {
|
|
189
189
|
const tStart = token.getStart();
|
|
@@ -147,6 +147,9 @@ class RenamerHelper {
|
|
|
147
147
|
let ret = [];
|
|
148
148
|
if (node.getIdentifier().stype !== _scope_type_1.ScopeType.BuiltIn) {
|
|
149
149
|
for (const r of node.getData().references) {
|
|
150
|
+
if (r.referenceType === __1.ReferenceType.ConstructorReference) {
|
|
151
|
+
continue;
|
|
152
|
+
}
|
|
150
153
|
if (((_a = r.resolved) === null || _a === void 0 ? void 0 : _a.equals(identifier))
|
|
151
154
|
&& r.referenceType !== __1.ReferenceType.InferredType
|
|
152
155
|
&& !(r.position.getStart() instanceof virtual_position_1.VirtualPosition)) {
|
package/build/src/registry.js
CHANGED
|
@@ -17,10 +17,10 @@ class SevenBitAscii {
|
|
|
17
17
|
key: "7bit_ascii",
|
|
18
18
|
title: "Check for 7bit ascii",
|
|
19
19
|
shortDescription: `Only allow characters from the 7bit ASCII set.`,
|
|
20
|
-
extendedInformation: `https://docs.abapopenchecks.org/checks/05/
|
|
21
|
-
|
|
22
|
-
https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abencharacter_set_guidl.htm
|
|
23
|
-
|
|
20
|
+
extendedInformation: `https://docs.abapopenchecks.org/checks/05/
|
|
21
|
+
|
|
22
|
+
https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abencharacter_set_guidl.htm
|
|
23
|
+
|
|
24
24
|
Checkes files with extensions ".abap" and ".asddls"`,
|
|
25
25
|
tags: [_irule_1.RuleTag.SingleFile],
|
|
26
26
|
badExample: `WRITE '뽑'.`,
|
|
@@ -28,10 +28,10 @@ class Abapdoc extends _abap_rule_1.ABAPRule {
|
|
|
28
28
|
key: "abapdoc",
|
|
29
29
|
title: "Check abapdoc",
|
|
30
30
|
shortDescription: `Various checks regarding abapdoc.`,
|
|
31
|
-
extendedInformation: `Base rule checks for existence of abapdoc for public class methods and all interface methods.
|
|
32
|
-
|
|
33
|
-
Plus class and interface definitions.
|
|
34
|
-
|
|
31
|
+
extendedInformation: `Base rule checks for existence of abapdoc for public class methods and all interface methods.
|
|
32
|
+
|
|
33
|
+
Plus class and interface definitions.
|
|
34
|
+
|
|
35
35
|
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#abap-doc-only-for-public-apis`,
|
|
36
36
|
tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
|
|
37
37
|
};
|
|
@@ -21,27 +21,27 @@ class AddTestAttributes extends _abap_rule_1.ABAPRule {
|
|
|
21
21
|
title: "Add test attributes for tests classes with test methods",
|
|
22
22
|
shortDescription: `Add test attributes DURATION and RISK LEVEL for tests classes with test methods`,
|
|
23
23
|
tags: [_irule_1.RuleTag.SingleFile],
|
|
24
|
-
badExample: `CLASS ltcl_test1 DEFINITION FINAL FOR TESTING.
|
|
25
|
-
PUBLIC SECTION.
|
|
26
|
-
PROTECTED SECTION.
|
|
27
|
-
PRIVATE SECTION.
|
|
28
|
-
METHODS test FOR TESTING RAISING cx_static_check.
|
|
29
|
-
ENDCLASS.
|
|
30
|
-
|
|
31
|
-
CLASS ltcl_test1 IMPLEMENTATION.
|
|
32
|
-
METHOD test.
|
|
33
|
-
ENDMETHOD.
|
|
24
|
+
badExample: `CLASS ltcl_test1 DEFINITION FINAL FOR TESTING.
|
|
25
|
+
PUBLIC SECTION.
|
|
26
|
+
PROTECTED SECTION.
|
|
27
|
+
PRIVATE SECTION.
|
|
28
|
+
METHODS test FOR TESTING RAISING cx_static_check.
|
|
29
|
+
ENDCLASS.
|
|
30
|
+
|
|
31
|
+
CLASS ltcl_test1 IMPLEMENTATION.
|
|
32
|
+
METHOD test.
|
|
33
|
+
ENDMETHOD.
|
|
34
34
|
ENDCLASS.`,
|
|
35
|
-
goodExample: `CLASS ltcl_test2 DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
|
|
36
|
-
PUBLIC SECTION.
|
|
37
|
-
PROTECTED SECTION.
|
|
38
|
-
PRIVATE SECTION.
|
|
39
|
-
METHODS test FOR TESTING RAISING cx_static_check.
|
|
40
|
-
ENDCLASS.
|
|
41
|
-
|
|
42
|
-
CLASS ltcl_test2 IMPLEMENTATION.
|
|
43
|
-
METHOD test.
|
|
44
|
-
ENDMETHOD.
|
|
35
|
+
goodExample: `CLASS ltcl_test2 DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
|
|
36
|
+
PUBLIC SECTION.
|
|
37
|
+
PROTECTED SECTION.
|
|
38
|
+
PRIVATE SECTION.
|
|
39
|
+
METHODS test FOR TESTING RAISING cx_static_check.
|
|
40
|
+
ENDCLASS.
|
|
41
|
+
|
|
42
|
+
CLASS ltcl_test2 IMPLEMENTATION.
|
|
43
|
+
METHOD test.
|
|
44
|
+
ENDMETHOD.
|
|
45
45
|
ENDCLASS.`,
|
|
46
46
|
};
|
|
47
47
|
}
|
|
@@ -22,49 +22,49 @@ class AlignParameters extends _abap_rule_1.ABAPRule {
|
|
|
22
22
|
key: "align_parameters",
|
|
23
23
|
title: "Align Parameters",
|
|
24
24
|
shortDescription: `Checks for vertially aligned parameters`,
|
|
25
|
-
extendedInformation: `Checks:
|
|
26
|
-
* function module calls
|
|
27
|
-
* method calls
|
|
28
|
-
* VALUE constructors
|
|
29
|
-
* NEW constructors
|
|
30
|
-
* RAISE EXCEPTION statements
|
|
31
|
-
* CREATE OBJECT statements
|
|
32
|
-
* RAISE EVENT statements
|
|
33
|
-
|
|
34
|
-
https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
|
|
35
|
-
|
|
36
|
-
Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
|
|
37
|
-
|
|
38
|
-
If parameters are on the same row, no issues are reported, see
|
|
25
|
+
extendedInformation: `Checks:
|
|
26
|
+
* function module calls
|
|
27
|
+
* method calls
|
|
28
|
+
* VALUE constructors
|
|
29
|
+
* NEW constructors
|
|
30
|
+
* RAISE EXCEPTION statements
|
|
31
|
+
* CREATE OBJECT statements
|
|
32
|
+
* RAISE EVENT statements
|
|
33
|
+
|
|
34
|
+
https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
|
|
35
|
+
|
|
36
|
+
Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
|
|
37
|
+
|
|
38
|
+
If parameters are on the same row, no issues are reported, see
|
|
39
39
|
https://rules.abaplint.org/max_one_method_parameter_per_line/ for splitting parameters to lines`,
|
|
40
40
|
tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix],
|
|
41
|
-
badExample: `CALL FUNCTION 'FOOBAR'
|
|
42
|
-
EXPORTING
|
|
43
|
-
foo = 2
|
|
44
|
-
parameter = 3.
|
|
45
|
-
|
|
46
|
-
foobar( moo = 1
|
|
47
|
-
param = 1 ).
|
|
48
|
-
|
|
49
|
-
foo = VALUE #(
|
|
50
|
-
foo = bar
|
|
41
|
+
badExample: `CALL FUNCTION 'FOOBAR'
|
|
42
|
+
EXPORTING
|
|
43
|
+
foo = 2
|
|
44
|
+
parameter = 3.
|
|
45
|
+
|
|
46
|
+
foobar( moo = 1
|
|
47
|
+
param = 1 ).
|
|
48
|
+
|
|
49
|
+
foo = VALUE #(
|
|
50
|
+
foo = bar
|
|
51
51
|
moo = 2 ).`,
|
|
52
|
-
goodExample: `CALL FUNCTION 'FOOBAR'
|
|
53
|
-
EXPORTING
|
|
54
|
-
foo = 2
|
|
55
|
-
parameter = 3.
|
|
56
|
-
|
|
57
|
-
foobar( moo = 1
|
|
58
|
-
param = 1 ).
|
|
59
|
-
|
|
60
|
-
foo = VALUE #(
|
|
61
|
-
foo = bar
|
|
62
|
-
moo = 2 ).
|
|
63
|
-
|
|
64
|
-
DATA(sdf) = VALUE type(
|
|
65
|
-
common_val = 2
|
|
66
|
-
another_common = 5
|
|
67
|
-
( row_value = 4
|
|
52
|
+
goodExample: `CALL FUNCTION 'FOOBAR'
|
|
53
|
+
EXPORTING
|
|
54
|
+
foo = 2
|
|
55
|
+
parameter = 3.
|
|
56
|
+
|
|
57
|
+
foobar( moo = 1
|
|
58
|
+
param = 1 ).
|
|
59
|
+
|
|
60
|
+
foo = VALUE #(
|
|
61
|
+
foo = bar
|
|
62
|
+
moo = 2 ).
|
|
63
|
+
|
|
64
|
+
DATA(sdf) = VALUE type(
|
|
65
|
+
common_val = 2
|
|
66
|
+
another_common = 5
|
|
67
|
+
( row_value = 4
|
|
68
68
|
value_foo = 5 ) ).`,
|
|
69
69
|
};
|
|
70
70
|
}
|
|
@@ -30,37 +30,37 @@ class AlignTypeExpressions extends _abap_rule_1.ABAPRule {
|
|
|
30
30
|
key: "align_type_expressions",
|
|
31
31
|
title: "Align TYPE expressions",
|
|
32
32
|
shortDescription: `Align TYPE expressions in statements`,
|
|
33
|
-
extendedInformation: `
|
|
34
|
-
Currently works for METHODS + BEGIN OF
|
|
35
|
-
|
|
36
|
-
If BEGIN OF has an INCLUDE TYPE its ignored
|
|
37
|
-
|
|
38
|
-
Also note that clean ABAP does not recommend aligning TYPE clauses:
|
|
33
|
+
extendedInformation: `
|
|
34
|
+
Currently works for METHODS + BEGIN OF
|
|
35
|
+
|
|
36
|
+
If BEGIN OF has an INCLUDE TYPE its ignored
|
|
37
|
+
|
|
38
|
+
Also note that clean ABAP does not recommend aligning TYPE clauses:
|
|
39
39
|
https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-align-type-clauses`,
|
|
40
40
|
tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix],
|
|
41
|
-
badExample: `
|
|
42
|
-
TYPES: BEGIN OF foo,
|
|
43
|
-
bar TYPE i,
|
|
44
|
-
foobar TYPE i,
|
|
45
|
-
END OF foo.
|
|
46
|
-
|
|
47
|
-
INTERFACE lif.
|
|
48
|
-
METHODS bar
|
|
49
|
-
IMPORTING
|
|
50
|
-
foo TYPE i
|
|
51
|
-
foobar TYPE i.
|
|
41
|
+
badExample: `
|
|
42
|
+
TYPES: BEGIN OF foo,
|
|
43
|
+
bar TYPE i,
|
|
44
|
+
foobar TYPE i,
|
|
45
|
+
END OF foo.
|
|
46
|
+
|
|
47
|
+
INTERFACE lif.
|
|
48
|
+
METHODS bar
|
|
49
|
+
IMPORTING
|
|
50
|
+
foo TYPE i
|
|
51
|
+
foobar TYPE i.
|
|
52
52
|
ENDINTERFACE.`,
|
|
53
|
-
goodExample: `
|
|
54
|
-
TYPES: BEGIN OF foo,
|
|
55
|
-
bar TYPE i,
|
|
56
|
-
foobar TYPE i,
|
|
57
|
-
END OF foo.
|
|
58
|
-
|
|
59
|
-
INTERFACE lif.
|
|
60
|
-
METHODS bar
|
|
61
|
-
IMPORTING
|
|
62
|
-
foo TYPE i
|
|
63
|
-
foobar TYPE i.
|
|
53
|
+
goodExample: `
|
|
54
|
+
TYPES: BEGIN OF foo,
|
|
55
|
+
bar TYPE i,
|
|
56
|
+
foobar TYPE i,
|
|
57
|
+
END OF foo.
|
|
58
|
+
|
|
59
|
+
INTERFACE lif.
|
|
60
|
+
METHODS bar
|
|
61
|
+
IMPORTING
|
|
62
|
+
foo TYPE i
|
|
63
|
+
foobar TYPE i.
|
|
64
64
|
ENDINTERFACE.`,
|
|
65
65
|
};
|
|
66
66
|
}
|
|
@@ -20,16 +20,16 @@ class AmbiguousStatement extends _abap_rule_1.ABAPRule {
|
|
|
20
20
|
return {
|
|
21
21
|
key: "ambiguous_statement",
|
|
22
22
|
title: "Check for ambigious statements",
|
|
23
|
-
shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
|
|
24
|
-
Add "TABLE" keyword or "@" for escaping SQL variables
|
|
25
|
-
|
|
23
|
+
shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
|
|
24
|
+
Add "TABLE" keyword or "@" for escaping SQL variables
|
|
25
|
+
|
|
26
26
|
Only works if the target version is 740sp05 or above`,
|
|
27
27
|
tags: [_irule_1.RuleTag.SingleFile],
|
|
28
|
-
badExample: `DELETE foo FROM bar.
|
|
28
|
+
badExample: `DELETE foo FROM bar.
|
|
29
29
|
MODIFY foo FROM bar.`,
|
|
30
|
-
goodExample: `DELETE foo FROM @bar.
|
|
31
|
-
DELETE TABLE itab FROM 2.
|
|
32
|
-
MODIFY zfoo FROM @wa.
|
|
30
|
+
goodExample: `DELETE foo FROM @bar.
|
|
31
|
+
DELETE TABLE itab FROM 2.
|
|
32
|
+
MODIFY zfoo FROM @wa.
|
|
33
33
|
MODIFY TABLE foo FROM bar.`,
|
|
34
34
|
};
|
|
35
35
|
}
|
|
@@ -44,16 +44,16 @@ class AvoidUse extends _abap_rule_1.ABAPRule {
|
|
|
44
44
|
key: "avoid_use",
|
|
45
45
|
title: "Avoid use of certain statements",
|
|
46
46
|
shortDescription: `Detects usage of certain statements.`,
|
|
47
|
-
extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
|
|
48
|
-
|
|
49
|
-
Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
|
|
50
|
-
|
|
51
|
-
STATICS: use CLASS-DATA instead
|
|
52
|
-
|
|
53
|
-
DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
|
|
54
|
-
|
|
55
|
-
TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround
|
|
56
|
-
|
|
47
|
+
extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
|
|
48
|
+
|
|
49
|
+
Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
|
|
50
|
+
|
|
51
|
+
STATICS: use CLASS-DATA instead
|
|
52
|
+
|
|
53
|
+
DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
|
|
54
|
+
|
|
55
|
+
TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround
|
|
56
|
+
|
|
57
57
|
BREAK points`,
|
|
58
58
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
|
|
59
59
|
};
|
|
@@ -24,11 +24,11 @@ class BeginEndNames extends _abap_rule_1.ABAPRule {
|
|
|
24
24
|
title: "Check BEGIN END names",
|
|
25
25
|
shortDescription: `Check BEGIN OF and END OF names match, plus there must be statements between BEGIN and END`,
|
|
26
26
|
tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
|
|
27
|
-
badExample: `DATA: BEGIN OF stru,
|
|
28
|
-
field TYPE i,
|
|
27
|
+
badExample: `DATA: BEGIN OF stru,
|
|
28
|
+
field TYPE i,
|
|
29
29
|
END OF structure_not_the_same.`,
|
|
30
|
-
goodExample: `DATA: BEGIN OF stru,
|
|
31
|
-
field TYPE i,
|
|
30
|
+
goodExample: `DATA: BEGIN OF stru,
|
|
31
|
+
field TYPE i,
|
|
32
32
|
END OF stru.`,
|
|
33
33
|
};
|
|
34
34
|
}
|
|
@@ -21,20 +21,20 @@ class BeginSingleInclude extends _abap_rule_1.ABAPRule {
|
|
|
21
21
|
title: "BEGIN contains single INCLUDE",
|
|
22
22
|
shortDescription: `Finds TYPE BEGIN with just one INCLUDE TYPE, and DATA with single INCLUDE STRUCTURE`,
|
|
23
23
|
tags: [_irule_1.RuleTag.SingleFile],
|
|
24
|
-
badExample: `TYPES: BEGIN OF dummy1.
|
|
25
|
-
INCLUDE TYPE dselc.
|
|
26
|
-
TYPES: END OF dummy1.
|
|
27
|
-
|
|
28
|
-
DATA BEGIN OF foo.
|
|
29
|
-
INCLUDE STRUCTURE syst.
|
|
30
|
-
DATA END OF foo.
|
|
31
|
-
|
|
32
|
-
STATICS BEGIN OF bar.
|
|
33
|
-
INCLUDE STRUCTURE syst.
|
|
24
|
+
badExample: `TYPES: BEGIN OF dummy1.
|
|
25
|
+
INCLUDE TYPE dselc.
|
|
26
|
+
TYPES: END OF dummy1.
|
|
27
|
+
|
|
28
|
+
DATA BEGIN OF foo.
|
|
29
|
+
INCLUDE STRUCTURE syst.
|
|
30
|
+
DATA END OF foo.
|
|
31
|
+
|
|
32
|
+
STATICS BEGIN OF bar.
|
|
33
|
+
INCLUDE STRUCTURE syst.
|
|
34
34
|
STATICS END OF bar.`,
|
|
35
|
-
goodExample: `DATA BEGIN OF foo.
|
|
36
|
-
DATA field TYPE i.
|
|
37
|
-
INCLUDE STRUCTURE dselc.
|
|
35
|
+
goodExample: `DATA BEGIN OF foo.
|
|
36
|
+
DATA field TYPE i.
|
|
37
|
+
INCLUDE STRUCTURE dselc.
|
|
38
38
|
DATA END OF foo.`,
|
|
39
39
|
};
|
|
40
40
|
}
|
|
@@ -24,9 +24,9 @@ class CallTransactionAuthorityCheck extends _abap_rule_1.ABAPRule {
|
|
|
24
24
|
extendedInformation: `https://docs.abapopenchecks.org/checks/54/`,
|
|
25
25
|
tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
|
|
26
26
|
badExample: `CALL TRANSACTION 'FOO'.`,
|
|
27
|
-
goodExample: `TRY.
|
|
28
|
-
CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
|
|
29
|
-
CATCH cx_sy_authorization_error.
|
|
27
|
+
goodExample: `TRY.
|
|
28
|
+
CALL TRANSACTION 'FOO' WITH AUTHORITY-CHECK.
|
|
29
|
+
CATCH cx_sy_authorization_error.
|
|
30
30
|
ENDTRY.`,
|
|
31
31
|
};
|
|
32
32
|
}
|