@abaplint/core 2.113.67 → 2.113.69

package/README.md

@@ -1,7 +1,7 @@
-# @abaplint/core
-
-[abaplint](https://abaplint.org) core library
-
-Exposes functionality like the parser and rules, which can be used in other projects.
-
+# @abaplint/core
+
+[abaplint](https://abaplint.org) core library
+
+Exposes functionality like the parser and rules, which can be used in other projects.
+
 For more information see https://github.com/abaplint/abaplint

package/build/abaplint.d.ts

@@ -5383,6 +5383,7 @@ export declare enum ReferenceType {
     TableVoidReference = "Table (Void)",
     MethodReference = "Method",
     BuiltinMethodReference = "Builtin Method",
+    ConstructorReference = "Constructor Reference",
     MethodImplementationReference = "Method Implementation",
     TypeReference = "Type",
     BuiltinTypeReference = "Builtin Type",

package/build/src/abap/2_statements/statement_parser.js

@@ -160,8 +160,13 @@ class StatementParser {
                     || type instanceof Statements.EndMethod) {
                     sql = false;
                 }
-                else if (!(type instanceof _statement_1.Comment)) {
+                else {
                     wa.statements[i] = new nodes_1.StatementNode(new _statement_1.NativeSQL()).setChildren(this.tokensToNodes(statement.getTokens()));
+                    if (statement.concatTokens().toUpperCase().endsWith("ENDMETHOD.")) {
+                        // yea, this is not completely correct
+                        wa.statements[i] = new nodes_1.StatementNode(new Statements.EndMethod()).setChildren(this.tokensToNodes(statement.getTokens()));
+                        sql = false;
+                    }
                 }
             }
         }

package/build/src/abap/2_statements/statements/get_permissions.js

@@ -6,7 +6,9 @@ const expressions_1 = require("../expressions");
 const version_1 = require("../../../version");
 class GetPermissions {
     getMatcher() {
-        const s = (0, combi_1.seq)("GET PERMISSIONS ONLY GLOBAL AUTHORIZATION ENTITY", expressions_1.SimpleName, "REQUEST", expressions_1.Source, "RESULT", expressions_1.Target, "FAILED", expressions_1.Target, "REPORTED", expressions_1.Target);
+        const type = (0, combi_1.altPrio)("GLOBAL AUTHORIZATION", "INSTANCE");
+        const from = (0, combi_1.seq)("FROM", expressions_1.Source);
+        const s = (0, combi_1.seq)("GET PERMISSIONS ONLY", type, "ENTITY", expressions_1.SimpleName, (0, combi_1.optPrio)(from), "REQUEST", expressions_1.Source, "RESULT", expressions_1.Target, "FAILED", expressions_1.Target, "REPORTED", expressions_1.Target);
         return (0, combi_1.ver)(version_1.Version.v754, s);
     }
 }

package/build/src/abap/2_statements/statements/method_def.js

@@ -10,7 +10,7 @@ class MethodDef {
         const parameters = (0, combi_1.seq)((0, combi_1.optPrio)((0, combi_1.altPrio)("FINAL", def, expressions_1.Abstract)), (0, combi_1.optPrio)(expressions_1.MethodDefImporting), (0, combi_1.optPrio)(expressions_1.MethodDefExporting), (0, combi_1.optPrio)(expressions_1.MethodDefChanging), (0, combi_1.optPrio)(expressions_1.MethodDefReturning), (0, combi_1.optPrio)((0, combi_1.altPrio)(expressions_1.MethodDefRaising, expressions_1.MethodDefExceptions)));
         const testing = (0, combi_1.seq)((0, combi_1.optPrio)(expressions_1.Abstract), "FOR TESTING", (0, combi_1.optPrio)((0, combi_1.altPrio)(expressions_1.MethodDefRaising, expressions_1.MethodDefExceptions)));
         // todo, this is only from version something
-        const tableFunction = (0, combi_1.seq)("TABLE FUNCTION", (0, combi_1.regex)(/^\w+?$/));
+        const tableFunction = (0, combi_1.seq)("TABLE FUNCTION", expressions_1.NamespaceSimpleName);
         // todo, this is only from version something
         const ddl = "DDL OBJECT OPTIONS CDS SESSION CLIENT REQUIRED";
         const result = (0, combi_1.seq)("RESULT", expressions_1.MethodParamName);

package/build/src/abap/2_statements/statements/modify_entities.js

@@ -14,7 +14,7 @@ class ModifyEntities {
         const reported = (0, combi_1.seq)("REPORTED", expressions_1.Target);
         const from = (0, combi_1.seq)("FROM", expressions_1.Source);
         const execute = (0, combi_1.seq)("EXECUTE", expressions_1.NamespaceSimpleName);
-        const entities = (0, combi_1.seq)("ENTITIES OF", expressions_1.NamespaceSimpleName, (0, combi_1.opt)("IN LOCAL MODE"), "ENTITY", expressions_1.SimpleName, operation, (0, combi_1.optPrio)((0, combi_1.per)(failed, result, mapped, reported)));
+        const entities = (0, combi_1.seq)("ENTITIES OF", expressions_1.NamespaceSimpleName, (0, combi_1.opt)("IN LOCAL MODE"), (0, combi_1.plusPrio)((0, combi_1.seq)("ENTITY", expressions_1.SimpleName, operation)), (0, combi_1.optPrio)((0, combi_1.per)(failed, result, mapped, reported)));
         const entity = (0, combi_1.seq)("ENTITY", expressions_1.NamespaceSimpleName, execute, from, mapped, failed, reported);
         return (0, combi_1.ver)(version_1.Version.v754, (0, combi_1.seq)("MODIFY", (0, combi_1.alt)(entities, entity)));
     }

package/build/src/abap/5_syntax/_reference.js

@@ -11,6 +11,7 @@ var ReferenceType;
     ReferenceType["TableVoidReference"] = "Table (Void)";
     ReferenceType["MethodReference"] = "Method";
     ReferenceType["BuiltinMethodReference"] = "Builtin Method";
+    ReferenceType["ConstructorReference"] = "Constructor Reference";
     ReferenceType["MethodImplementationReference"] = "Method Implementation";
     ReferenceType["TypeReference"] = "Type";
     ReferenceType["BuiltinTypeReference"] = "Builtin Type";

package/build/src/abap/5_syntax/expressions/new_object.js

@@ -24,6 +24,7 @@ class NewObject {
             const clas = input.scope.findClassDefinition(targetType.getIdentifierName());
             if (clas) {
                 input.scope.addReference(typeToken, clas, _reference_1.ReferenceType.InferredType, input.filename);
+                input.scope.addReference(typeToken, clas, _reference_1.ReferenceType.ConstructorReference, input.filename);
             }
             else {
                 const intf = input.scope.findInterfaceDefinition(targetType.getIdentifierName());
@@ -50,6 +51,7 @@ class NewObject {
             const objDefinition = input.scope.findObjectDefinition(typeName);
             if (objDefinition) {
                 input.scope.addReference(typeToken, objDefinition, _reference_1.ReferenceType.ObjectOrientedReference, input.filename);
+                input.scope.addReference(typeToken, objDefinition, _reference_1.ReferenceType.ConstructorReference, input.filename);
                 const objref = new basic_1.ObjectReferenceType(objDefinition);
                 const clas = input.scope.findClassDefinition(objref.getIdentifierName());
                 if ((clas === null || clas === void 0 ? void 0 : clas.isAbstract()) === true) {

package/build/src/abap/5_syntax/statements/create_object.js

@@ -13,6 +13,7 @@ const _type_utils_1 = require("../_type_utils");
 const _syntax_input_1 = require("../_syntax_input");
 class CreateObject {
     runSyntax(node, input) {
+        var _a;
         let cdef = undefined;
         // CREATE OBJECT, TYPE
         const type = node.findExpressionAfterToken("TYPE");
@@ -22,6 +23,7 @@ class CreateObject {
             cdef = input.scope.findClassDefinition(name);
             if (cdef) {
                 input.scope.addReference(token, cdef, _reference_1.ReferenceType.ObjectOrientedReference, input.filename);
+                input.scope.addReference(token, cdef, _reference_1.ReferenceType.ConstructorReference, input.filename);
                 if (cdef.isAbstract() === true) {
                     const message = cdef.getName() + " is abstract, cannot be instantiated";
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
@@ -41,60 +43,61 @@ class CreateObject {
         for (const s of node.findDirectExpressions(Expressions.Source)) {
             new source_1.Source().runSyntax(s, input);
         }
-        let first = true;
-        for (const t of node.findAllExpressions(Expressions.Target)) {
+        for (const t of ((_a = node.findDirectExpression(Expressions.ParameterListExceptions)) === null || _a === void 0 ? void 0 : _a.findAllExpressions(Expressions.Target)) || []) {
+            new target_1.Target().runSyntax(t, input);
+        }
+        const t = node.findDirectExpression(Expressions.Target);
+        if (t) {
             const found = new target_1.Target().runSyntax(t, input);
-            if (first === true) {
-                first = false;
-                if (found instanceof basic_1.VoidType) {
-                    continue;
-                }
-                else if (found instanceof basic_1.UnknownType) {
-                    const message = "Target type unknown, " + t.concatTokens();
+            if (found instanceof basic_1.VoidType) {
+                // do nothing
+            }
+            else if (found instanceof basic_1.UnknownType) {
+                const message = "Target type unknown, " + t.concatTokens();
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                return;
+            }
+            else if (!(found instanceof basic_1.ObjectReferenceType)
+                && !(found instanceof basic_1.AnyType)
+                && !(found instanceof basic_1.DataType)
+                && !(found instanceof basic_1.GenericObjectReferenceType)) {
+                const message = "Target must be an object reference, " + t.concatTokens();
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                return;
+            }
+            else if (found instanceof basic_1.GenericObjectReferenceType && type === undefined) {
+                const message = "Generic type, cannot be instantiated";
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                return;
+            }
+            else if (found instanceof basic_1.ObjectReferenceType) {
+                const id = found.getIdentifier();
+                if (id instanceof types_1.InterfaceDefinition && type === undefined) {
+                    const message = "Interface reference, cannot be instantiated";
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                     return;
                 }
-                else if (!(found instanceof basic_1.ObjectReferenceType)
-                    && !(found instanceof basic_1.AnyType)
-                    && !(found instanceof basic_1.DataType)
-                    && !(found instanceof basic_1.GenericObjectReferenceType)) {
-                    const message = "Target must be an object reference, " + t.concatTokens();
+                else if (found instanceof basic_1.ObjectReferenceType
+                    && type === undefined
+                    && input.scope.findInterfaceDefinition(found.getQualifiedName())) {
+                    const message = "Interface reference, cannot be instantiated";
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                     return;
                 }
-                else if (found instanceof basic_1.GenericObjectReferenceType && type === undefined) {
-                    const message = "Generic type, cannot be instantiated";
+                else if (id instanceof types_1.ClassDefinition && cdef === undefined) {
+                    cdef = id;
+                }
+                if (type === undefined && id instanceof types_1.ClassDefinition && id.isAbstract() === true) {
+                    const message = id.getName() + " is abstract, cannot be instantiated";
                     input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                     return;
                 }
-                else if (found instanceof basic_1.ObjectReferenceType) {
-                    const id = found.getIdentifier();
-                    if (id instanceof types_1.InterfaceDefinition && type === undefined) {
-                        const message = "Interface reference, cannot be instantiated";
-                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
-                        return;
-                    }
-                    else if (found instanceof basic_1.ObjectReferenceType
-                        && type === undefined
-                        && input.scope.findInterfaceDefinition(found.getQualifiedName())) {
-                        const message = "Interface reference, cannot be instantiated";
-                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
-                        return;
-                    }
-                    else if (id instanceof types_1.ClassDefinition && cdef === undefined) {
-                        cdef = id;
-                    }
-                    if (type === undefined && id instanceof types_1.ClassDefinition && id.isAbstract() === true) {
-                        const message = id.getName() + " is abstract, cannot be instantiated";
-                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
-                        return;
-                    }
-                }
             }
         }
         for (const t of node.findDirectExpressions(Expressions.Dynamic)) {
             new dynamic_1.Dynamic().runSyntax(t, input);
         }
+        input.scope.addReference(t === null || t === void 0 ? void 0 : t.getFirstToken(), cdef, _reference_1.ReferenceType.ConstructorReference, input.filename);
         this.validateParameters(cdef, node, input);
     }
     validateParameters(cdef, node, input) {

package/build/src/abap/flow/flow_graph.js

@@ -94,13 +94,13 @@ class FlowGraph {
         this.label = label;
     }
     toDigraph() {
-        return `digraph G {
-labelloc="t";
-label="${this.label}";
-graph [fontname = "helvetica"];
-node [fontname = "helvetica", shape="box"];
-edge [fontname = "helvetica"];
-${this.toTextEdges()}
+        return `digraph G {
+labelloc="t";
+label="${this.label}";
+graph [fontname = "helvetica"];
+node [fontname = "helvetica", shape="box"];
+edge [fontname = "helvetica"];
+${this.toTextEdges()}
 }`;
     }
     listSources(node) {

package/build/src/lsp/help.js

@@ -20,13 +20,13 @@ class Help {
     /////////////////////////////////////////////////
     static dumpABAP(file, reg, textDocument, position) {
         let content = "";
-        content = `
-    <a href="#_tokens" rel="no-refresh">Tokens</a> |
-    <a href="#_statements" rel="no-refresh">Statements</a> |
-    <a href="#_structure" rel="no-refresh">Structure</a> |
-    <a href="#_files" rel="no-refresh">Files</a> |
-    <a href="#_info" rel="no-refresh">Info Dump</a>
-    <hr>
+        content = `
+    <a href="#_tokens" rel="no-refresh">Tokens</a> |
+    <a href="#_statements" rel="no-refresh">Statements</a> |
+    <a href="#_structure" rel="no-refresh">Structure</a> |
+    <a href="#_files" rel="no-refresh">Files</a> |
+    <a href="#_info" rel="no-refresh">Info Dump</a>
+    <hr>
     ` +
             "<tt>" + textDocument.uri + " (" +
             (position.line + 1) + ", " +
@@ -181,9 +181,9 @@ class Help {
         return ret + "</ul>";
     }
     static tokens(file) {
-        let inner = `<table><tr><td><b>String</b></td><td><b>Type</b></td>
-    <td><b>Row</b></td><td><b>Column</b></td>
-    <td><b>vRow</b></td><td><b>vColumn</b></td>
+        let inner = `<table><tr><td><b>String</b></td><td><b>Type</b></td>
+    <td><b>Row</b></td><td><b>Column</b></td>
+    <td><b>vRow</b></td><td><b>vColumn</b></td>
     </tr>`;
         for (const token of file.getTokens()) {
             const tStart = token.getStart();

package/build/src/objects/rename/renamer_helper.js

@@ -147,6 +147,9 @@ class RenamerHelper {
         let ret = [];
         if (node.getIdentifier().stype !== _scope_type_1.ScopeType.BuiltIn) {
             for (const r of node.getData().references) {
+                if (r.referenceType === __1.ReferenceType.ConstructorReference) {
+                    continue;
+                }
                 if (((_a = r.resolved) === null || _a === void 0 ? void 0 : _a.equals(identifier))
                     && r.referenceType !== __1.ReferenceType.InferredType
                     && !(r.position.getStart() instanceof virtual_position_1.VirtualPosition)) {

package/build/src/registry.js

@@ -67,7 +67,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.67";
+        return "2.113.69";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/7bit_ascii.js

@@ -17,10 +17,10 @@ class SevenBitAscii {
             key: "7bit_ascii",
             title: "Check for 7bit ascii",
             shortDescription: `Only allow characters from the 7bit ASCII set.`,
-            extendedInformation: `https://docs.abapopenchecks.org/checks/05/
-
-https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abencharacter_set_guidl.htm
-
+            extendedInformation: `https://docs.abapopenchecks.org/checks/05/
+
+https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abencharacter_set_guidl.htm
+
 Checkes files with extensions ".abap" and ".asddls"`,
             tags: [_irule_1.RuleTag.SingleFile],
             badExample: `WRITE '뽑'.`,

package/build/src/rules/abapdoc.js

@@ -28,10 +28,10 @@ class Abapdoc extends _abap_rule_1.ABAPRule {
             key: "abapdoc",
             title: "Check abapdoc",
             shortDescription: `Various checks regarding abapdoc.`,
-            extendedInformation: `Base rule checks for existence of abapdoc for public class methods and all interface methods.
-
-Plus class and interface definitions.
-
+            extendedInformation: `Base rule checks for existence of abapdoc for public class methods and all interface methods.
+
+Plus class and interface definitions.
+
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#abap-doc-only-for-public-apis`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
         };

package/build/src/rules/add_test_attributes.js

@@ -21,27 +21,27 @@ class AddTestAttributes extends _abap_rule_1.ABAPRule {
             title: "Add test attributes for tests classes with test methods",
             shortDescription: `Add test attributes DURATION and RISK LEVEL for tests classes with test methods`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `CLASS ltcl_test1 DEFINITION FINAL FOR TESTING.
-  PUBLIC SECTION.
-  PROTECTED SECTION.
-  PRIVATE SECTION.
-    METHODS test FOR TESTING RAISING cx_static_check.
-ENDCLASS.
-
-CLASS ltcl_test1 IMPLEMENTATION.
-  METHOD test.
-  ENDMETHOD.
+            badExample: `CLASS ltcl_test1 DEFINITION FINAL FOR TESTING.
+  PUBLIC SECTION.
+  PROTECTED SECTION.
+  PRIVATE SECTION.
+    METHODS test FOR TESTING RAISING cx_static_check.
+ENDCLASS.
+
+CLASS ltcl_test1 IMPLEMENTATION.
+  METHOD test.
+  ENDMETHOD.
 ENDCLASS.`,
-            goodExample: `CLASS ltcl_test2 DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
-  PUBLIC SECTION.
-  PROTECTED SECTION.
-  PRIVATE SECTION.
-    METHODS test FOR TESTING RAISING cx_static_check.
-ENDCLASS.
-
-CLASS ltcl_test2 IMPLEMENTATION.
-  METHOD test.
-  ENDMETHOD.
+            goodExample: `CLASS ltcl_test2 DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
+  PUBLIC SECTION.
+  PROTECTED SECTION.
+  PRIVATE SECTION.
+    METHODS test FOR TESTING RAISING cx_static_check.
+ENDCLASS.
+
+CLASS ltcl_test2 IMPLEMENTATION.
+  METHOD test.
+  ENDMETHOD.
 ENDCLASS.`,
         };
     }

package/build/src/rules/align_parameters.js

@@ -22,49 +22,49 @@ class AlignParameters extends _abap_rule_1.ABAPRule {
             key: "align_parameters",
             title: "Align Parameters",
             shortDescription: `Checks for vertially aligned parameters`,
-            extendedInformation: `Checks:
-* function module calls
-* method calls
-* VALUE constructors
-* NEW constructors
-* RAISE EXCEPTION statements
-* CREATE OBJECT statements
-* RAISE EVENT statements
-
-https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
-
-Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
-
-If parameters are on the same row, no issues are reported, see
+            extendedInformation: `Checks:
+* function module calls
+* method calls
+* VALUE constructors
+* NEW constructors
+* RAISE EXCEPTION statements
+* CREATE OBJECT statements
+* RAISE EVENT statements
+
+https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
+
+Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
+
+If parameters are on the same row, no issues are reported, see
 https://rules.abaplint.org/max_one_method_parameter_per_line/ for splitting parameters to lines`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix],
-            badExample: `CALL FUNCTION 'FOOBAR'
-  EXPORTING
-    foo = 2
-    parameter = 3.
-
-foobar( moo = 1
-  param = 1 ).
-
-foo = VALUE #(
-    foo = bar
+            badExample: `CALL FUNCTION 'FOOBAR'
+  EXPORTING
+    foo = 2
+    parameter = 3.
+
+foobar( moo = 1
+  param = 1 ).
+
+foo = VALUE #(
+    foo = bar
         moo = 2 ).`,
-            goodExample: `CALL FUNCTION 'FOOBAR'
-  EXPORTING
-    foo       = 2
-    parameter = 3.
-
-foobar( moo   = 1
-        param = 1 ).
-
-foo = VALUE #(
-    foo = bar
-    moo = 2 ).
-
-DATA(sdf) = VALUE type(
-  common_val     = 2
-  another_common = 5
-  ( row_value = 4
+            goodExample: `CALL FUNCTION 'FOOBAR'
+  EXPORTING
+    foo       = 2
+    parameter = 3.
+
+foobar( moo   = 1
+        param = 1 ).
+
+foo = VALUE #(
+    foo = bar
+    moo = 2 ).
+
+DATA(sdf) = VALUE type(
+  common_val     = 2
+  another_common = 5
+  ( row_value = 4
     value_foo = 5 ) ).`,
         };
     }

package/build/src/rules/align_type_expressions.js

@@ -30,37 +30,37 @@ class AlignTypeExpressions extends _abap_rule_1.ABAPRule {
             key: "align_type_expressions",
             title: "Align TYPE expressions",
             shortDescription: `Align TYPE expressions in statements`,
-            extendedInformation: `
-Currently works for METHODS + BEGIN OF
-
-If BEGIN OF has an INCLUDE TYPE its ignored
-
-Also note that clean ABAP does not recommend aligning TYPE clauses:
+            extendedInformation: `
+Currently works for METHODS + BEGIN OF
+
+If BEGIN OF has an INCLUDE TYPE its ignored
+
+Also note that clean ABAP does not recommend aligning TYPE clauses:
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-align-type-clauses`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix],
-            badExample: `
-TYPES: BEGIN OF foo,
-         bar TYPE i,
-         foobar TYPE i,
-       END OF foo.
-
-INTERFACE lif.
-  METHODS bar
-    IMPORTING
-      foo TYPE i
-      foobar TYPE i.
+            badExample: `
+TYPES: BEGIN OF foo,
+         bar TYPE i,
+         foobar TYPE i,
+       END OF foo.
+
+INTERFACE lif.
+  METHODS bar
+    IMPORTING
+      foo TYPE i
+      foobar TYPE i.
 ENDINTERFACE.`,
-            goodExample: `
-TYPES: BEGIN OF foo,
-         bar    TYPE i,
-         foobar TYPE i,
-       END OF foo.
-
-INTERFACE lif.
-  METHODS bar
-    IMPORTING
-      foo    TYPE i
-      foobar TYPE i.
+            goodExample: `
+TYPES: BEGIN OF foo,
+         bar    TYPE i,
+         foobar TYPE i,
+       END OF foo.
+
+INTERFACE lif.
+  METHODS bar
+    IMPORTING
+      foo    TYPE i
+      foobar TYPE i.
 ENDINTERFACE.`,
         };
     }

package/build/src/rules/ambiguous_statement.js

@@ -20,16 +20,16 @@ class AmbiguousStatement extends _abap_rule_1.ABAPRule {
         return {
             key: "ambiguous_statement",
             title: "Check for ambigious statements",
-            shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
-Add "TABLE" keyword or "@" for escaping SQL variables
-
+            shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
+Add "TABLE" keyword or "@" for escaping SQL variables
+
 Only works if the target version is 740sp05 or above`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `DELETE foo FROM bar.
+            badExample: `DELETE foo FROM bar.
 MODIFY foo FROM bar.`,
-            goodExample: `DELETE foo FROM @bar.
-DELETE TABLE itab FROM 2.
-MODIFY zfoo FROM @wa.
+            goodExample: `DELETE foo FROM @bar.
+DELETE TABLE itab FROM 2.
+MODIFY zfoo FROM @wa.
 MODIFY TABLE foo FROM bar.`,
         };
     }

package/build/src/rules/avoid_use.js

@@ -44,16 +44,16 @@ class AvoidUse extends _abap_rule_1.ABAPRule {
             key: "avoid_use",
             title: "Avoid use of certain statements",
             shortDescription: `Detects usage of certain statements.`,
-            extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
-
-Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
-
-STATICS: use CLASS-DATA instead
-
-DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
-
-TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround
-
+            extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
+
+Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
+
+STATICS: use CLASS-DATA instead
+
+DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
+
+TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround
+
 BREAK points`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };

package/build/src/rules/begin_end_names.js

@@ -24,11 +24,11 @@ class BeginEndNames extends _abap_rule_1.ABAPRule {
             title: "Check BEGIN END names",
             shortDescription: `Check BEGIN OF and END OF names match, plus there must be statements between BEGIN and END`,
             tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
-            badExample: `DATA: BEGIN OF stru,
-        field TYPE i,
+            badExample: `DATA: BEGIN OF stru,
+        field TYPE i,
       END OF structure_not_the_same.`,
-            goodExample: `DATA: BEGIN OF stru,
-        field TYPE i,
+            goodExample: `DATA: BEGIN OF stru,
+        field TYPE i,
       END OF stru.`,
         };
     }

package/build/src/rules/begin_single_include.js

@@ -21,20 +21,20 @@ class BeginSingleInclude extends _abap_rule_1.ABAPRule {
             title: "BEGIN contains single INCLUDE",
             shortDescription: `Finds TYPE BEGIN with just one INCLUDE TYPE, and DATA with single INCLUDE STRUCTURE`,
             tags: [_irule_1.RuleTag.SingleFile],
-            badExample: `TYPES: BEGIN OF dummy1.
-  INCLUDE TYPE dselc.
-TYPES: END OF dummy1.
-
-DATA BEGIN OF foo.
-INCLUDE STRUCTURE syst.
-DATA END OF foo.
-
-STATICS BEGIN OF bar.
-INCLUDE STRUCTURE syst.
+            badExample: `TYPES: BEGIN OF dummy1.
+  INCLUDE TYPE dselc.
+TYPES: END OF dummy1.
+
+DATA BEGIN OF foo.
+INCLUDE STRUCTURE syst.
+DATA END OF foo.
+
+STATICS BEGIN OF bar.
+INCLUDE STRUCTURE syst.
 STATICS END OF bar.`,
-            goodExample: `DATA BEGIN OF foo.
-  DATA field TYPE i.
-  INCLUDE STRUCTURE dselc.
+            goodExample: `DATA BEGIN OF foo.
+  DATA field TYPE i.
+  INCLUDE STRUCTURE dselc.
 DATA END OF foo.`,
         };
     }