@abaplint/core 2.113.55 → 2.113.57

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (125) hide show
  1. package/README.md +6 -6
  2. package/build/src/abap/2_statements/expressions/message_class.js +1 -1
  3. package/build/src/abap/2_statements/expressions/raise_with.js +3 -3
  4. package/build/src/abap/2_statements/expressions/sql_aggregation.js +1 -1
  5. package/build/src/abap/2_statements/expressions/type_table.js +2 -2
  6. package/build/src/abap/2_statements/statements/assign_local_copy.js +4 -1
  7. package/build/src/abap/2_statements/statements/describe.js +1 -1
  8. package/build/src/abap/2_statements/statements/format.js +1 -1
  9. package/build/src/abap/2_statements/statements/modify_line.js +2 -2
  10. package/build/src/abap/2_statements/statements/move.js +1 -1
  11. package/build/src/abap/2_statements/statements/parameter.js +2 -1
  12. package/build/src/abap/2_statements/statements/print_control.js +4 -1
  13. package/build/src/abap/2_statements/statements/provide.js +2 -1
  14. package/build/src/abap/5_syntax/expressions/raise_with.js +1 -1
  15. package/build/src/abap/flow/flow_graph.js +7 -7
  16. package/build/src/lsp/help.js +10 -10
  17. package/build/src/objects/table.js +16 -16
  18. package/build/src/registry.js +1 -1
  19. package/build/src/rules/7bit_ascii.js +4 -4
  20. package/build/src/rules/abapdoc.js +4 -4
  21. package/build/src/rules/add_test_attributes.js +20 -20
  22. package/build/src/rules/align_parameters.js +40 -40
  23. package/build/src/rules/align_type_expressions.js +28 -28
  24. package/build/src/rules/ambiguous_statement.js +7 -7
  25. package/build/src/rules/avoid_use.js +10 -10
  26. package/build/src/rules/begin_end_names.js +4 -4
  27. package/build/src/rules/begin_single_include.js +13 -13
  28. package/build/src/rules/call_transaction_authority_check.js +3 -3
  29. package/build/src/rules/cds_comment_style.js +4 -4
  30. package/build/src/rules/cds_legacy_view.js +4 -4
  31. package/build/src/rules/chain_mainly_declarations.js +4 -4
  32. package/build/src/rules/change_if_to_case.js +8 -8
  33. package/build/src/rules/check_abstract.js +2 -2
  34. package/build/src/rules/check_comments.js +4 -4
  35. package/build/src/rules/check_include.js +3 -3
  36. package/build/src/rules/check_subrc.js +8 -8
  37. package/build/src/rules/classic_exceptions_overlap.js +10 -10
  38. package/build/src/rules/commented_code.js +1 -1
  39. package/build/src/rules/constructor_visibility_public.js +4 -4
  40. package/build/src/rules/contains_tab.js +2 -2
  41. package/build/src/rules/cyclic_oo.js +4 -4
  42. package/build/src/rules/dangerous_statement.js +1 -1
  43. package/build/src/rules/definitions_top.js +6 -6
  44. package/build/src/rules/downport.js +83 -83
  45. package/build/src/rules/easy_to_find_messages.js +6 -6
  46. package/build/src/rules/empty_event.js +6 -6
  47. package/build/src/rules/empty_line_in_statement.js +2 -2
  48. package/build/src/rules/empty_structure.js +6 -6
  49. package/build/src/rules/exit_or_check.js +3 -3
  50. package/build/src/rules/expand_macros.js +5 -5
  51. package/build/src/rules/exporting.js +1 -1
  52. package/build/src/rules/forbidden_identifier.js +1 -1
  53. package/build/src/rules/forbidden_void_type.js +2 -2
  54. package/build/src/rules/fully_type_itabs.js +2 -2
  55. package/build/src/rules/functional_writing.js +17 -17
  56. package/build/src/rules/global_class.js +8 -8
  57. package/build/src/rules/identical_conditions.js +12 -12
  58. package/build/src/rules/identical_contents.js +14 -14
  59. package/build/src/rules/identical_descriptions.js +6 -6
  60. package/build/src/rules/if_in_if.js +35 -35
  61. package/build/src/rules/implement_methods.js +3 -3
  62. package/build/src/rules/implicit_start_of_selection.js +5 -5
  63. package/build/src/rules/in_statement_indentation.js +11 -11
  64. package/build/src/rules/indentation.js +16 -16
  65. package/build/src/rules/intf_referencing_clas.js +3 -3
  66. package/build/src/rules/invalid_table_index.js +2 -2
  67. package/build/src/rules/line_break_style.js +2 -2
  68. package/build/src/rules/line_length.js +1 -1
  69. package/build/src/rules/line_only_punc.js +1 -1
  70. package/build/src/rules/local_variable_names.js +6 -6
  71. package/build/src/rules/macro_naming.js +2 -2
  72. package/build/src/rules/main_file_contents.js +4 -4
  73. package/build/src/rules/many_parentheses.js +10 -10
  74. package/build/src/rules/max_one_method_parameter_per_line.js +7 -7
  75. package/build/src/rules/max_one_statement.js +5 -5
  76. package/build/src/rules/method_length.js +2 -2
  77. package/build/src/rules/method_overwrites_builtin.js +12 -12
  78. package/build/src/rules/mix_returning.js +6 -6
  79. package/build/src/rules/nesting.js +1 -1
  80. package/build/src/rules/no_chained_assignment.js +1 -1
  81. package/build/src/rules/no_external_form_calls.js +2 -2
  82. package/build/src/rules/no_inline_in_optional_branches.js +11 -11
  83. package/build/src/rules/no_prefixes.js +6 -6
  84. package/build/src/rules/no_public_attributes.js +1 -1
  85. package/build/src/rules/no_yoda_conditions.js +4 -4
  86. package/build/src/rules/nrob_consistency.js +2 -2
  87. package/build/src/rules/obsolete_statement.js +51 -51
  88. package/build/src/rules/omit_parameter_name.js +3 -3
  89. package/build/src/rules/omit_receiving.js +13 -13
  90. package/build/src/rules/parser_702_chaining.js +2 -2
  91. package/build/src/rules/parser_error.js +2 -2
  92. package/build/src/rules/parser_missing_space.js +1 -1
  93. package/build/src/rules/prefer_inline.js +16 -16
  94. package/build/src/rules/prefer_is_not.js +9 -9
  95. package/build/src/rules/prefer_raise_exception_new.js +5 -5
  96. package/build/src/rules/prefer_returning_to_exporting.js +4 -4
  97. package/build/src/rules/prefer_xsdbool.js +2 -2
  98. package/build/src/rules/preferred_compare_operator.js +2 -2
  99. package/build/src/rules/reduce_procedural_code.js +17 -17
  100. package/build/src/rules/remove_descriptions.js +4 -4
  101. package/build/src/rules/rfc_error_handling.js +7 -7
  102. package/build/src/rules/select_add_order_by.js +5 -5
  103. package/build/src/rules/select_performance.js +5 -5
  104. package/build/src/rules/select_single_full_key.js +2 -2
  105. package/build/src/rules/sicf_consistency.js +2 -2
  106. package/build/src/rules/slow_parameter_passing.js +16 -16
  107. package/build/src/rules/space_before_dot.js +2 -2
  108. package/build/src/rules/sql_value_conversion.js +6 -6
  109. package/build/src/rules/start_at_tab.js +1 -1
  110. package/build/src/rules/strict_sql.js +6 -6
  111. package/build/src/rules/sy_modification.js +3 -3
  112. package/build/src/rules/tabl_enhancement_category.js +2 -2
  113. package/build/src/rules/tables_declared_locally.js +2 -2
  114. package/build/src/rules/type_form_parameters.js +2 -2
  115. package/build/src/rules/unnecessary_pragma.js +29 -29
  116. package/build/src/rules/unnecessary_return.js +11 -11
  117. package/build/src/rules/unused_macros.js +6 -6
  118. package/build/src/rules/unused_methods.js +12 -12
  119. package/build/src/rules/unused_variables.js +12 -12
  120. package/build/src/rules/use_bool_expression.js +8 -8
  121. package/build/src/rules/use_class_based_exceptions.js +8 -8
  122. package/build/src/rules/use_line_exists.js +6 -6
  123. package/build/src/rules/use_new.js +4 -4
  124. package/build/src/rules/when_others_last.js +6 -6
  125. package/package.json +70 -70
package/README.md CHANGED
@@ -1,7 +1,7 @@
1
- # @abaplint/core
2
-
3
- [abaplint](https://abaplint.org) core library
4
-
5
- Exposes functionality like the parser and rules, which can be used in other projects.
6
-
1
+ # @abaplint/core
2
+
3
+ [abaplint](https://abaplint.org) core library
4
+
5
+ Exposes functionality like the parser and rules, which can be used in other projects.
6
+
7
7
  For more information see https://github.com/abaplint/abaplint
@@ -6,7 +6,7 @@ const combi_1 = require("../combi");
6
6
  class MessageClass extends combi_1.Expression {
7
7
  getRunnable() {
8
8
  // "&1" can be used for almost anything(field names, method names etc.) in macros
9
- return (0, combi_1.seq)((0, combi_1.regex)(/^>?[\w\/]+#?@?\/?!?&?>?\$?\??$/), (0, combi_1.starPrio)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.Dash), (0, combi_1.optPrio)((0, combi_1.regex)(/^\w+$/)))), (0, combi_1.optPrio)((0, combi_1.tok)(tokens_1.DashW)));
9
+ return (0, combi_1.seq)((0, combi_1.regex)(/^>?[\w\/]+#?@?\/?!?&?>?\$?\??<?$/), (0, combi_1.starPrio)((0, combi_1.tok)(tokens_1.PlusW)), (0, combi_1.starPrio)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.Dash), (0, combi_1.optPrio)((0, combi_1.regex)(/^\w+$/)))), (0, combi_1.optPrio)((0, combi_1.tok)(tokens_1.DashW)));
10
10
  }
11
11
  }
12
12
  exports.MessageClass = MessageClass;
@@ -5,10 +5,10 @@ const combi_1 = require("../combi");
5
5
  const _1 = require(".");
6
6
  class RaiseWith extends combi_1.Expression {
7
7
  getRunnable() {
8
- const wit = (0, combi_1.seq)("WITH", _1.SimpleSource1, (0, combi_1.opt)(_1.SimpleSource1), (0, combi_1.opt)(_1.SimpleSource1), (0, combi_1.opt)(_1.SimpleSource1));
8
+ const wit = (0, combi_1.seq)(_1.SimpleSource1, (0, combi_1.opt)(_1.SimpleSource1), (0, combi_1.opt)(_1.SimpleSource1), (0, combi_1.opt)(_1.SimpleSource1));
9
9
  // todo: I guess this is from version something?
10
- const witComplex = (0, combi_1.seq)("WITH", _1.Source, (0, combi_1.opt)(_1.Source), (0, combi_1.opt)(_1.Source), (0, combi_1.opt)(_1.Source));
11
- return (0, combi_1.alt)(wit, witComplex);
10
+ const witComplex = (0, combi_1.seq)(_1.Source, (0, combi_1.opt)(_1.Source), (0, combi_1.opt)(_1.Source), (0, combi_1.opt)(_1.Source));
11
+ return (0, combi_1.seq)("WITH", (0, combi_1.altPrio)(witComplex, wit));
12
12
  }
13
13
  }
14
14
  exports.RaiseWith = RaiseWith;
@@ -8,7 +8,7 @@ const dynamic_1 = require("./dynamic");
8
8
  const sql_arithmetics_1 = require("./sql_arithmetics");
9
9
  class SQLAggregation extends combi_1.Expression {
10
10
  getRunnable() {
11
- const f = (0, combi_1.seq)((0, combi_1.optPrio)("DISTINCT"), (0, combi_1.altPrio)(sql_arithmetics_1.SQLArithmetics, dynamic_1.Dynamic, _1.SQLFunction, _1.SQLCase));
11
+ const f = (0, combi_1.seq)((0, combi_1.optPrio)("DISTINCT"), (0, combi_1.altPrio)(_1.SQLCase, sql_arithmetics_1.SQLArithmetics, dynamic_1.Dynamic, _1.SQLFunction));
12
12
  const fparen = (0, combi_1.seq)("(", _1.Field, ")");
13
13
  const count = (0, combi_1.seq)("COUNT", (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.ParenLeft), (0, combi_1.tok)(tokens_1.ParenLeftW)), (0, combi_1.optPrio)("DISTINCT"), (0, combi_1.altPrio)("*", _1.Field, fparen), ")");
14
14
  const max = (0, combi_1.seq)("MAX", (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.ParenLeft), (0, combi_1.tok)(tokens_1.ParenLeftW)), f, ")");
@@ -18,12 +18,12 @@ class TypeTable extends combi_1.Expression {
18
18
  // a maximum of 15 secondary table keys can be defined
19
19
  // "WITH" is not allowed as a field name in keys
20
20
  const typetable = (0, combi_1.alt)(generic, (0, combi_1.seq)(normal1, (0, combi_1.alt)((0, combi_1.opt)((0, combi_1.per)(header, initial, (0, combi_1.plusPrio)(type_table_key_1.TypeTableKey))), (0, combi_1.seq)((0, combi_1.plus)(type_table_key_1.TypeTableKey), (0, combi_1.optPrio)(initial)))));
21
- const occurs = (0, combi_1.seq)("OCCURS", _1.Integer);
21
+ const occurs = (0, combi_1.seq)("OCCURS", (0, combi_1.altPrio)(_1.Integer, field_chain_1.FieldChain));
22
22
  const derived = (0, combi_1.ver)(version_1.Version.v754, (0, combi_1.seq)("TABLE FOR", (0, combi_1.altPrio)("ACTION IMPORT", "ACTION RESULT", "CREATE", "EVENT", "FAILED", "LOCK", "READ RESULT", "UPDATE"), _1.TypeName));
23
23
  const oldType = (0, combi_1.seq)((0, combi_1.opt)("REF TO"), _1.TypeName, (0, combi_1.alt)((0, combi_1.seq)(occurs, (0, combi_1.opt)(header)), header));
24
24
  const oldLike = (0, combi_1.seq)((0, combi_1.opt)("REF TO"), field_chain_1.FieldChain, (0, combi_1.alt)((0, combi_1.seq)(occurs, (0, combi_1.opt)(header)), header));
25
25
  const typeLine = (0, combi_1.seq)("LINE OF", _1.TypeName, occurs, header);
26
- const ret = (0, combi_1.altPrio)((0, combi_1.seq)(occurs, (0, combi_1.opt)(header)), (0, combi_1.seq)("LIKE", (0, combi_1.alt)(oldLike, likeType, rangeLike)), (0, combi_1.seq)("TYPE", (0, combi_1.alt)(oldType, typetable, rangeType, typeLine, derived)));
26
+ const ret = (0, combi_1.altPrio)((0, combi_1.seq)(occurs, (0, combi_1.opt)(header)), (0, combi_1.seq)("LIKE", (0, combi_1.alt)(oldLike, likeType, rangeLike, typeLine)), (0, combi_1.seq)("TYPE", (0, combi_1.alt)(oldType, typetable, rangeType, typeLine, derived)));
27
27
  return ret;
28
28
  }
29
29
  }
@@ -6,7 +6,10 @@ const expressions_1 = require("../expressions");
6
6
  const version_1 = require("../../../version");
7
7
  class AssignLocalCopy {
8
8
  getMatcher() {
9
- const ret = (0, combi_1.seq)("ASSIGN LOCAL COPY OF", (0, combi_1.opt)((0, combi_1.seq)("INITIAL", (0, combi_1.opt)("LINE OF"))), (0, combi_1.alt)(expressions_1.Source, expressions_1.Dynamic), "TO", expressions_1.TargetFieldSymbol);
9
+ const init = (0, combi_1.seq)("INITIAL", (0, combi_1.alt)(expressions_1.Source, expressions_1.Dynamic));
10
+ const iline = (0, combi_1.seq)("INITIAL LINE OF", (0, combi_1.alt)(expressions_1.Source, expressions_1.Dynamic));
11
+ const main = (0, combi_1.seq)("MAIN TABLE FIELD", expressions_1.Dynamic);
12
+ const ret = (0, combi_1.seq)("ASSIGN LOCAL COPY OF", (0, combi_1.alt)(init, iline, main, expressions_1.Source), "TO", expressions_1.TargetFieldSymbol);
10
13
  return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
11
14
  }
12
15
  }
@@ -12,7 +12,7 @@ class Describe {
12
12
  const table = (0, combi_1.seq)("TABLE", expressions_1.FieldChain, (0, combi_1.opt)((0, combi_1.per)(tlines, kind, occurs)));
13
13
  const mode = (0, combi_1.seq)("IN", (0, combi_1.alt)("BYTE", "CHARACTER"), "MODE");
14
14
  const field = (0, combi_1.seq)("FIELD", expressions_1.Source, (0, combi_1.per)((0, combi_1.seq)("TYPE", expressions_1.Target), (0, combi_1.seq)("COMPONENTS", expressions_1.Target), (0, combi_1.seq)("LENGTH", expressions_1.Target, (0, combi_1.opt)(mode)), (0, combi_1.seq)("DECIMALS", expressions_1.Target), (0, combi_1.seq)("HELP-ID", expressions_1.Target), (0, combi_1.seq)("OUTPUT-LENGTH", expressions_1.Target), (0, combi_1.seq)("EDIT MASK", expressions_1.Target), (0, combi_1.seq)("INTO", expressions_1.Target)));
15
- const distance = (0, combi_1.seq)("DISTANCE BETWEEN", expressions_1.Source, "AND", expressions_1.Source, "INTO", expressions_1.Target, mode);
15
+ const distance = (0, combi_1.seq)("DISTANCE BETWEEN", expressions_1.Source, "AND", expressions_1.Source, "INTO", expressions_1.Target, (0, combi_1.opt)(mode));
16
16
  const lines = (0, combi_1.seq)("NUMBER OF LINES", expressions_1.Target);
17
17
  const pages = (0, combi_1.seq)("NUMBER OF PAGES", expressions_1.Target);
18
18
  const line = (0, combi_1.seq)("LINE", expressions_1.Source);
@@ -8,7 +8,7 @@ class Format {
8
8
  getMatcher() {
9
9
  const eq = (0, combi_1.seq)("=", expressions_1.Source);
10
10
  const value = (0, combi_1.altPrio)(eq, "ON", "OFF");
11
- const options = (0, combi_1.per)("RESET", (0, combi_1.seq)("INTENSIFIED", (0, combi_1.opt)(value)), (0, combi_1.seq)("INVERSE", (0, combi_1.opt)(value)), (0, combi_1.seq)("HOTSPOT", (0, combi_1.opt)(value)), (0, combi_1.seq)("FRAMES", value), (0, combi_1.seq)("INPUT", value), expressions_1.Color);
11
+ const options = (0, combi_1.per)("RESET", (0, combi_1.seq)("INTENSIFIED", (0, combi_1.opt)(value)), (0, combi_1.seq)("INVERSE", (0, combi_1.opt)(value)), (0, combi_1.seq)("HOTSPOT", (0, combi_1.opt)(value)), (0, combi_1.seq)("FRAMES", value), (0, combi_1.seq)("INPUT", (0, combi_1.opt)(value)), expressions_1.Color);
12
12
  const ret = (0, combi_1.seq)("FORMAT", options);
13
13
  return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
14
14
  }
@@ -6,7 +6,7 @@ const expressions_1 = require("../expressions");
6
6
  const version_1 = require("../../../version");
7
7
  class ModifyLine {
8
8
  getMatcher() {
9
- const form = (0, combi_1.seq)((0, combi_1.alt)("INVERSE", "INPUT"), "=", expressions_1.Source);
9
+ const form = (0, combi_1.seq)((0, combi_1.alt)("INVERSE", "INPUT", "COLOR"), "=", expressions_1.Source);
10
10
  const from = (0, combi_1.seq)("FROM", expressions_1.Source);
11
11
  const value = (0, combi_1.seq)("FIELD VALUE", (0, combi_1.plus)((0, combi_1.seq)(expressions_1.Source, (0, combi_1.optPrio)(from))));
12
12
  const format = (0, combi_1.seq)("FIELD FORMAT", expressions_1.Source, (0, combi_1.opt)(form));
@@ -14,7 +14,7 @@ class ModifyLine {
14
14
  const index = (0, combi_1.seq)("INDEX", expressions_1.Source);
15
15
  const page = (0, combi_1.seq)("OF PAGE", expressions_1.Source);
16
16
  const ocp = (0, combi_1.str)("OF CURRENT PAGE");
17
- const lineFormat = (0, combi_1.seq)("LINE FORMAT", (0, combi_1.alt)("INPUT OFF", "INVERSE", "RESET", "INTENSIFIED"));
17
+ const lineFormat = (0, combi_1.seq)("LINE FORMAT", (0, combi_1.per)("INPUT OFF", "INVERSE", "RESET", "INTENSIFIED", "COLOR COL_NORMAL"));
18
18
  const onOff = (0, combi_1.alt)("ON", "OFF");
19
19
  const intensified = (0, combi_1.seq)("INTENSIFIED", onOff);
20
20
  const options = (0, combi_1.per)(index, value, format, page, lineFormat, lineValue, ocp, intensified, expressions_1.Color);
@@ -8,7 +8,7 @@ const tokens_1 = require("../../1_lexer/tokens");
8
8
  class Move {
9
9
  getMatcher() {
10
10
  const mov = (0, combi_1.verNot)(version_1.Version.Cloud, "MOVE");
11
- const move = (0, combi_1.seq)(mov, (0, combi_1.altPrio)((0, combi_1.seq)("EXACT", expressions_1.Source, "TO", expressions_1.Target), (0, combi_1.seq)(expressions_1.Source, (0, combi_1.altPrio)("?TO", "TO"), expressions_1.Target)));
11
+ const move = (0, combi_1.seq)(mov, (0, combi_1.altPrio)((0, combi_1.seq)("EXACT", expressions_1.Source, "TO", expressions_1.Target), (0, combi_1.seq)(expressions_1.Source, (0, combi_1.altPrio)("?TO", "TO"), expressions_1.Target)), (0, combi_1.opt)((0, combi_1.seq)("PERCENTAGE", expressions_1.Source)));
12
12
  const calcAssign = (0, combi_1.ver)(version_1.Version.v754, (0, combi_1.alt)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.WPlus), "="), (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WDash), "="), "/=", "*=", "&&="));
13
13
  const chained = (0, combi_1.seq)("=", (0, combi_1.star)((0, combi_1.seq)(expressions_1.Target, "=")));
14
14
  const equals = (0, combi_1.altPrio)((0, combi_1.altPrio)(chained, "?="), calcAssign);
@@ -18,7 +18,8 @@ class Parameter {
18
18
  const length = (0, combi_1.seq)("LENGTH", expressions_1.Constant);
19
19
  const match = (0, combi_1.seq)("MATCHCODE OBJECT", expressions_1.Field);
20
20
  const decimals = (0, combi_1.seq)("DECIMALS", expressions_1.Source);
21
- const perm = (0, combi_1.per)(type, def, "OBLIGATORY", match, cmd, length, decimals, radio, memory, modif, listbox, visible, "VALUE CHECK", "NO-DISPLAY", "AS CHECKBOX", "LOWER CASE");
21
+ const forTable = (0, combi_1.seq)("FOR TABLE", expressions_1.DatabaseTable);
22
+ const perm = (0, combi_1.per)(type, def, "OBLIGATORY", match, cmd, length, decimals, radio, memory, modif, listbox, visible, forTable, "VALUE CHECK", "NO-DISPLAY", "AS CHECKBOX", "LOWER CASE");
22
23
  const ret = (0, combi_1.seq)(para, expressions_1.FieldSub, (0, combi_1.opt)(expressions_1.FieldLength), (0, combi_1.opt)(perm));
23
24
  return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
24
25
  }
@@ -8,7 +8,10 @@ class PrintControl {
8
8
  getMatcher() {
9
9
  const index = (0, combi_1.seq)("INDEX-LINE", expressions_1.Source);
10
10
  const func = (0, combi_1.seq)("FUNCTION", expressions_1.Source);
11
- const ret = (0, combi_1.seq)("PRINT-CONTROL", (0, combi_1.alt)(index, func));
11
+ const line = (0, combi_1.seq)("LINE", expressions_1.Source);
12
+ const position = (0, combi_1.seq)("POSITION", expressions_1.Source);
13
+ const size = (0, combi_1.seq)("SIZE", expressions_1.Source);
14
+ const ret = (0, combi_1.seq)("PRINT-CONTROL", (0, combi_1.per)(index, func, line, position, size));
12
15
  return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
13
16
  }
14
17
  }
@@ -9,7 +9,8 @@ class Provide {
9
9
  const list = (0, combi_1.plus)((0, combi_1.altPrio)("*", expressions_1.Field));
10
10
  const fields = (0, combi_1.seq)("FIELDS", list, "FROM", expressions_1.Source, "INTO", expressions_1.Target, "VALID", expressions_1.Field, "BOUNDS", expressions_1.Field, "AND", expressions_1.Field);
11
11
  const fieldList = (0, combi_1.altPrio)((0, combi_1.seq)(list, "FROM", expressions_1.Source), list);
12
- const ret = (0, combi_1.seq)("PROVIDE", (0, combi_1.altPrio)((0, combi_1.plus)(fields), (0, combi_1.plus)(fieldList)), "BETWEEN", expressions_1.SimpleSource3, "AND", expressions_1.SimpleSource3);
12
+ const where = (0, combi_1.seq)("WHERE", expressions_1.Cond);
13
+ const ret = (0, combi_1.seq)("PROVIDE", (0, combi_1.altPrio)((0, combi_1.plus)(fields), (0, combi_1.plus)(fieldList)), "BETWEEN", expressions_1.SimpleSource3, "AND", expressions_1.SimpleSource3, (0, combi_1.optPrio)(where));
13
14
  return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
14
15
  }
15
16
  }
@@ -5,7 +5,7 @@ const Expressions = require("../../2_statements/expressions");
5
5
  const source_1 = require("./source");
6
6
  class RaiseWith {
7
7
  runSyntax(node, input) {
8
- for (const f of node.findDirectExpressions(Expressions.SimpleSource1)) {
8
+ for (const f of node.findAllExpressionsMulti([Expressions.SimpleSource1, Expressions.Source])) {
9
9
  new source_1.Source().runSyntax(f, input);
10
10
  }
11
11
  }
@@ -94,13 +94,13 @@ class FlowGraph {
94
94
  this.label = label;
95
95
  }
96
96
  toDigraph() {
97
- return `digraph G {
98
- labelloc="t";
99
- label="${this.label}";
100
- graph [fontname = "helvetica"];
101
- node [fontname = "helvetica", shape="box"];
102
- edge [fontname = "helvetica"];
103
- ${this.toTextEdges()}
97
+ return `digraph G {
98
+ labelloc="t";
99
+ label="${this.label}";
100
+ graph [fontname = "helvetica"];
101
+ node [fontname = "helvetica", shape="box"];
102
+ edge [fontname = "helvetica"];
103
+ ${this.toTextEdges()}
104
104
  }`;
105
105
  }
106
106
  listSources(node) {
@@ -20,13 +20,13 @@ class Help {
20
20
  /////////////////////////////////////////////////
21
21
  static dumpABAP(file, reg, textDocument, position) {
22
22
  let content = "";
23
- content = `
24
- <a href="#_tokens" rel="no-refresh">Tokens</a> |
25
- <a href="#_statements" rel="no-refresh">Statements</a> |
26
- <a href="#_structure" rel="no-refresh">Structure</a> |
27
- <a href="#_files" rel="no-refresh">Files</a> |
28
- <a href="#_info" rel="no-refresh">Info Dump</a>
29
- <hr>
23
+ content = `
24
+ <a href="#_tokens" rel="no-refresh">Tokens</a> |
25
+ <a href="#_statements" rel="no-refresh">Statements</a> |
26
+ <a href="#_structure" rel="no-refresh">Structure</a> |
27
+ <a href="#_files" rel="no-refresh">Files</a> |
28
+ <a href="#_info" rel="no-refresh">Info Dump</a>
29
+ <hr>
30
30
  ` +
31
31
  "<tt>" + textDocument.uri + " (" +
32
32
  (position.line + 1) + ", " +
@@ -181,9 +181,9 @@ class Help {
181
181
  return ret + "</ul>";
182
182
  }
183
183
  static tokens(file) {
184
- let inner = `<table><tr><td><b>String</b></td><td><b>Type</b></td>
185
- <td><b>Row</b></td><td><b>Column</b></td>
186
- <td><b>vRow</b></td><td><b>vColumn</b></td>
184
+ let inner = `<table><tr><td><b>String</b></td><td><b>Type</b></td>
185
+ <td><b>Row</b></td><td><b>Column</b></td>
186
+ <td><b>vRow</b></td><td><b>vColumn</b></td>
187
187
  </tr>`;
188
188
  for (const token of file.getTokens()) {
189
189
  const tStart = token.getStart();
@@ -99,9 +99,10 @@ class Table extends _abstract_object_1.AbstractObject {
99
99
  references.push({ object: lookup.object });
100
100
  }
101
101
  }
102
- else if (field.FIELDNAME === ".INCLUDE" || field.FIELDNAME === ".INCLU--AP") { // incude or append structure
102
+ else if (field.FIELDNAME === ".INCLUDE"
103
+ || field.FIELDNAME.startsWith(".INCLU-")) {
103
104
  if (field.PRECFIELD === undefined) {
104
- return new Types.UnknownType("Table, parser error, PRECFIELD undefined");
105
+ return new Types.UnknownType("Table, parser error, PRECFIELD undefined, " + this.getName());
105
106
  }
106
107
  const lookup = ddic.lookupTableOrView(field.PRECFIELD);
107
108
  let found = lookup.type;
@@ -133,26 +134,25 @@ class Table extends _abstract_object_1.AbstractObject {
133
134
  else {
134
135
  components.push({ name: field.FIELDNAME, type: found });
135
136
  }
136
- }
137
- else if (comptype === "S" && field.FIELDNAME.startsWith(".INCLU-")) {
137
+ /*
138
+ } else if (comptype === "S" && field.FIELDNAME.startsWith(".INCLU-")) {
138
139
  const lookup = ddic.lookupTableOrView(field.PRECFIELD);
139
140
  if (lookup.object) {
140
- references.push({ object: lookup.object });
141
+ references.push({object: lookup.object});
141
142
  }
142
143
  const found = lookup.type;
143
144
  if (found instanceof Types.VoidType) {
144
- // set the full structure to void
145
- return found;
146
- }
147
- else if (found instanceof Types.StructureType) {
148
- const suffix = field.FIELDNAME.split("-")[1];
149
- for (const c of found.getComponents()) {
150
- components.push({ name: c.name + suffix, type: c.type });
151
- }
152
- }
153
- else if (found instanceof Types.UnknownType) {
154
- return found;
145
+ // set the full structure to void
146
+ return found;
147
+ } else if (found instanceof Types.StructureType) {
148
+ const suffix = field.FIELDNAME.split("-")[1];
149
+ for (const c of found.getComponents()) {
150
+ components.push({name: c.name + suffix, type: c.type});
151
+ }
152
+ } else if (found instanceof Types.UnknownType) {
153
+ return found;
155
154
  }
155
+ */
156
156
  }
157
157
  else if (comptype === "S") {
158
158
  const lookup = ddic.lookupTableOrView(field.ROLLNAME);
@@ -67,7 +67,7 @@ class Registry {
67
67
  }
68
68
  static abaplintVersion() {
69
69
  // magic, see build script "version.sh"
70
- return "2.113.55";
70
+ return "2.113.57";
71
71
  }
72
72
  getDDICReferences() {
73
73
  return this.ddicReferences;
@@ -17,10 +17,10 @@ class SevenBitAscii {
17
17
  key: "7bit_ascii",
18
18
  title: "Check for 7bit ascii",
19
19
  shortDescription: `Only allow characters from the 7bit ASCII set.`,
20
- extendedInformation: `https://docs.abapopenchecks.org/checks/05/
21
-
22
- https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abencharacter_set_guidl.htm
23
-
20
+ extendedInformation: `https://docs.abapopenchecks.org/checks/05/
21
+
22
+ https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abencharacter_set_guidl.htm
23
+
24
24
  Checkes files with extensions ".abap" and ".asddls"`,
25
25
  tags: [_irule_1.RuleTag.SingleFile],
26
26
  badExample: `WRITE '뽑'.`,
@@ -28,10 +28,10 @@ class Abapdoc extends _abap_rule_1.ABAPRule {
28
28
  key: "abapdoc",
29
29
  title: "Check abapdoc",
30
30
  shortDescription: `Various checks regarding abapdoc.`,
31
- extendedInformation: `Base rule checks for existence of abapdoc for public class methods and all interface methods.
32
-
33
- Plus class and interface definitions.
34
-
31
+ extendedInformation: `Base rule checks for existence of abapdoc for public class methods and all interface methods.
32
+
33
+ Plus class and interface definitions.
34
+
35
35
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#abap-doc-only-for-public-apis`,
36
36
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
37
37
  };
@@ -21,27 +21,27 @@ class AddTestAttributes extends _abap_rule_1.ABAPRule {
21
21
  title: "Add test attributes for tests classes with test methods",
22
22
  shortDescription: `Add test attributes DURATION and RISK LEVEL for tests classes with test methods`,
23
23
  tags: [_irule_1.RuleTag.SingleFile],
24
- badExample: `CLASS ltcl_test1 DEFINITION FINAL FOR TESTING.
25
- PUBLIC SECTION.
26
- PROTECTED SECTION.
27
- PRIVATE SECTION.
28
- METHODS test FOR TESTING RAISING cx_static_check.
29
- ENDCLASS.
30
-
31
- CLASS ltcl_test1 IMPLEMENTATION.
32
- METHOD test.
33
- ENDMETHOD.
24
+ badExample: `CLASS ltcl_test1 DEFINITION FINAL FOR TESTING.
25
+ PUBLIC SECTION.
26
+ PROTECTED SECTION.
27
+ PRIVATE SECTION.
28
+ METHODS test FOR TESTING RAISING cx_static_check.
29
+ ENDCLASS.
30
+
31
+ CLASS ltcl_test1 IMPLEMENTATION.
32
+ METHOD test.
33
+ ENDMETHOD.
34
34
  ENDCLASS.`,
35
- goodExample: `CLASS ltcl_test2 DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
36
- PUBLIC SECTION.
37
- PROTECTED SECTION.
38
- PRIVATE SECTION.
39
- METHODS test FOR TESTING RAISING cx_static_check.
40
- ENDCLASS.
41
-
42
- CLASS ltcl_test2 IMPLEMENTATION.
43
- METHOD test.
44
- ENDMETHOD.
35
+ goodExample: `CLASS ltcl_test2 DEFINITION FINAL FOR TESTING DURATION SHORT RISK LEVEL HARMLESS.
36
+ PUBLIC SECTION.
37
+ PROTECTED SECTION.
38
+ PRIVATE SECTION.
39
+ METHODS test FOR TESTING RAISING cx_static_check.
40
+ ENDCLASS.
41
+
42
+ CLASS ltcl_test2 IMPLEMENTATION.
43
+ METHOD test.
44
+ ENDMETHOD.
45
45
  ENDCLASS.`,
46
46
  };
47
47
  }
@@ -22,49 +22,49 @@ class AlignParameters extends _abap_rule_1.ABAPRule {
22
22
  key: "align_parameters",
23
23
  title: "Align Parameters",
24
24
  shortDescription: `Checks for vertially aligned parameters`,
25
- extendedInformation: `Checks:
26
- * function module calls
27
- * method calls
28
- * VALUE constructors
29
- * NEW constructors
30
- * RAISE EXCEPTION statements
31
- * CREATE OBJECT statements
32
- * RAISE EVENT statements
33
-
34
- https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
35
-
36
- Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
37
-
38
- If parameters are on the same row, no issues are reported, see
25
+ extendedInformation: `Checks:
26
+ * function module calls
27
+ * method calls
28
+ * VALUE constructors
29
+ * NEW constructors
30
+ * RAISE EXCEPTION statements
31
+ * CREATE OBJECT statements
32
+ * RAISE EVENT statements
33
+
34
+ https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#align-parameters
35
+
36
+ Does not take effect on non functional method calls, use https://rules.abaplint.org/functional_writing/
37
+
38
+ If parameters are on the same row, no issues are reported, see
39
39
  https://rules.abaplint.org/max_one_method_parameter_per_line/ for splitting parameters to lines`,
40
40
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix],
41
- badExample: `CALL FUNCTION 'FOOBAR'
42
- EXPORTING
43
- foo = 2
44
- parameter = 3.
45
-
46
- foobar( moo = 1
47
- param = 1 ).
48
-
49
- foo = VALUE #(
50
- foo = bar
41
+ badExample: `CALL FUNCTION 'FOOBAR'
42
+ EXPORTING
43
+ foo = 2
44
+ parameter = 3.
45
+
46
+ foobar( moo = 1
47
+ param = 1 ).
48
+
49
+ foo = VALUE #(
50
+ foo = bar
51
51
  moo = 2 ).`,
52
- goodExample: `CALL FUNCTION 'FOOBAR'
53
- EXPORTING
54
- foo = 2
55
- parameter = 3.
56
-
57
- foobar( moo = 1
58
- param = 1 ).
59
-
60
- foo = VALUE #(
61
- foo = bar
62
- moo = 2 ).
63
-
64
- DATA(sdf) = VALUE type(
65
- common_val = 2
66
- another_common = 5
67
- ( row_value = 4
52
+ goodExample: `CALL FUNCTION 'FOOBAR'
53
+ EXPORTING
54
+ foo = 2
55
+ parameter = 3.
56
+
57
+ foobar( moo = 1
58
+ param = 1 ).
59
+
60
+ foo = VALUE #(
61
+ foo = bar
62
+ moo = 2 ).
63
+
64
+ DATA(sdf) = VALUE type(
65
+ common_val = 2
66
+ another_common = 5
67
+ ( row_value = 4
68
68
  value_foo = 5 ) ).`,
69
69
  };
70
70
  }
@@ -30,37 +30,37 @@ class AlignTypeExpressions extends _abap_rule_1.ABAPRule {
30
30
  key: "align_type_expressions",
31
31
  title: "Align TYPE expressions",
32
32
  shortDescription: `Align TYPE expressions in statements`,
33
- extendedInformation: `
34
- Currently works for METHODS + BEGIN OF
35
-
36
- If BEGIN OF has an INCLUDE TYPE its ignored
37
-
38
- Also note that clean ABAP does not recommend aligning TYPE clauses:
33
+ extendedInformation: `
34
+ Currently works for METHODS + BEGIN OF
35
+
36
+ If BEGIN OF has an INCLUDE TYPE its ignored
37
+
38
+ Also note that clean ABAP does not recommend aligning TYPE clauses:
39
39
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-align-type-clauses`,
40
40
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix],
41
- badExample: `
42
- TYPES: BEGIN OF foo,
43
- bar TYPE i,
44
- foobar TYPE i,
45
- END OF foo.
46
-
47
- INTERFACE lif.
48
- METHODS bar
49
- IMPORTING
50
- foo TYPE i
51
- foobar TYPE i.
41
+ badExample: `
42
+ TYPES: BEGIN OF foo,
43
+ bar TYPE i,
44
+ foobar TYPE i,
45
+ END OF foo.
46
+
47
+ INTERFACE lif.
48
+ METHODS bar
49
+ IMPORTING
50
+ foo TYPE i
51
+ foobar TYPE i.
52
52
  ENDINTERFACE.`,
53
- goodExample: `
54
- TYPES: BEGIN OF foo,
55
- bar TYPE i,
56
- foobar TYPE i,
57
- END OF foo.
58
-
59
- INTERFACE lif.
60
- METHODS bar
61
- IMPORTING
62
- foo TYPE i
63
- foobar TYPE i.
53
+ goodExample: `
54
+ TYPES: BEGIN OF foo,
55
+ bar TYPE i,
56
+ foobar TYPE i,
57
+ END OF foo.
58
+
59
+ INTERFACE lif.
60
+ METHODS bar
61
+ IMPORTING
62
+ foo TYPE i
63
+ foobar TYPE i.
64
64
  ENDINTERFACE.`,
65
65
  };
66
66
  }
@@ -20,16 +20,16 @@ class AmbiguousStatement extends _abap_rule_1.ABAPRule {
20
20
  return {
21
21
  key: "ambiguous_statement",
22
22
  title: "Check for ambigious statements",
23
- shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
24
- Add "TABLE" keyword or "@" for escaping SQL variables
25
-
23
+ shortDescription: `Checks for ambiguity between deleting or modifying from internal and database table
24
+ Add "TABLE" keyword or "@" for escaping SQL variables
25
+
26
26
  Only works if the target version is 740sp05 or above`,
27
27
  tags: [_irule_1.RuleTag.SingleFile],
28
- badExample: `DELETE foo FROM bar.
28
+ badExample: `DELETE foo FROM bar.
29
29
  MODIFY foo FROM bar.`,
30
- goodExample: `DELETE foo FROM @bar.
31
- DELETE TABLE itab FROM 2.
32
- MODIFY zfoo FROM @wa.
30
+ goodExample: `DELETE foo FROM @bar.
31
+ DELETE TABLE itab FROM 2.
32
+ MODIFY zfoo FROM @wa.
33
33
  MODIFY TABLE foo FROM bar.`,
34
34
  };
35
35
  }
@@ -44,16 +44,16 @@ class AvoidUse extends _abap_rule_1.ABAPRule {
44
44
  key: "avoid_use",
45
45
  title: "Avoid use of certain statements",
46
46
  shortDescription: `Detects usage of certain statements.`,
47
- extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
48
-
49
- Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
50
-
51
- STATICS: use CLASS-DATA instead
52
-
53
- DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
54
-
55
- TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround
56
-
47
+ extendedInformation: `DEFAULT KEY: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-default-key
48
+
49
+ Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
50
+
51
+ STATICS: use CLASS-DATA instead
52
+
53
+ DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
54
+
55
+ TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround
56
+
57
57
  BREAK points`,
58
58
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
59
59
  };
@@ -24,11 +24,11 @@ class BeginEndNames extends _abap_rule_1.ABAPRule {
24
24
  title: "Check BEGIN END names",
25
25
  shortDescription: `Check BEGIN OF and END OF names match, plus there must be statements between BEGIN and END`,
26
26
  tags: [_irule_1.RuleTag.Syntax, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
27
- badExample: `DATA: BEGIN OF stru,
28
- field TYPE i,
27
+ badExample: `DATA: BEGIN OF stru,
28
+ field TYPE i,
29
29
  END OF structure_not_the_same.`,
30
- goodExample: `DATA: BEGIN OF stru,
31
- field TYPE i,
30
+ goodExample: `DATA: BEGIN OF stru,
31
+ field TYPE i,
32
32
  END OF stru.`,
33
33
  };
34
34
  }