@abaplint/core 2.113.246 → 2.114.0

package/build/abaplint.d.ts

@@ -2023,6 +2023,15 @@ declare class ElseIf_2 implements IStatement {
     getMatcher(): IStatementRunnable;
 }
 
+declare class EmailTemplate extends AbstractObject {
+    getType(): string;
+    getAllowedNaming(): {
+        maxLength: number;
+        allowNamespace: boolean;
+    };
+    getDescription(): string | undefined;
+}
+
 export declare class Empty implements IStatement {
     getMatcher(): IStatementRunnable;
 }
@@ -2463,7 +2472,6 @@ declare namespace Expressions {
         SQLArithmetics,
         SQLAsName,
         SQLCase,
-        SQLCast,
         SQLCDSParameters,
         SQLClient,
         SQLCompareOperator,
@@ -5009,7 +5017,6 @@ declare namespace Objects {
         BRFPlusSystemApplication,
         BSPApplication,
         BusinessAddInImplementation,
-        CDSEntityBuffer,
         BusinessCatalogAppAssignment,
         BusinessCatalog,
         BusinessConfigurationMaintenanceObject,
@@ -5018,6 +5025,7 @@ declare namespace Objects {
         BusinessFunctionSetAssignment,
         BusinessObjectModel,
         BusinessObjectType,
+        CDSEntityBuffer,
         ParsedMetadataExtension,
         CDSMetadataExtension,
         CDSType,
@@ -5047,6 +5055,7 @@ declare namespace Objects {
         EcattTestConfiguration,
         EcattTestDataContainer,
         EcattTestScript,
+        EmailTemplate,
         EnhancementImplementation,
         IBadiDefinition,
         EnhancementSpot,
@@ -5143,6 +5152,7 @@ declare namespace Objects {
         TableType,
         EnhancementCategory,
         TableCategory,
+        SecondaryIndex,
         Table,
         TechnicalJobDefinition,
         TransactionVariant,
@@ -5872,6 +5882,11 @@ declare class SearchHelp extends AbstractObject {
     getDescription(): string | undefined;
 }
 
+declare type SecondaryIndex = {
+    name: string;
+    fields: string[];
+};
+
 declare class SectionContents implements IStructure {
     getMatcher(): IStructureRunnable;
 }
@@ -6196,10 +6211,6 @@ declare class SQLCase extends Expression {
     getRunnable(): IStatementRunnable;
 }
 
-declare class SQLCast extends Expression {
-    getRunnable(): IStatementRunnable;
-}
-
 declare class SQLCDSParameters extends Expression {
     getRunnable(): IStatementRunnable;
 }
@@ -6968,6 +6979,7 @@ declare class Table extends AbstractObject {
     private parsedType;
     getType(): string;
     getDescription(): string | undefined;
+    getSecondaryIndexes(): SecondaryIndex[] | undefined;
     getAllowedNaming(): IAllowedNaming;
     setDirty(): void;
     listKeys(reg: IRegistry): string[];

package/build/src/abap/2_statements/expressions/index.js

@@ -179,7 +179,6 @@ __exportStar(require("./sql_arithmetic_operator"), exports);
 __exportStar(require("./sql_arithmetics"), exports);
 __exportStar(require("./sql_as_name"), exports);
 __exportStar(require("./sql_case"), exports);
-__exportStar(require("./sql_cast"), exports);
 __exportStar(require("./sql_cds_parameters"), exports);
 __exportStar(require("./sql_client"), exports);
 __exportStar(require("./sql_compare_operator"), exports);

package/build/src/abap/2_statements/expressions/sql_field.js

@@ -12,7 +12,7 @@ class SQLField extends combi_1.Expression {
         const abap = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WAt), _1.SimpleFieldChain2), version_1.Version.OpenABAP);
         const as = (0, combi_1.seq)("AS", _1.SQLAsName);
         const parenFieldName = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WParenLeftW), _1.SQLFieldName, (0, combi_1.altPrio)((0, combi_1.tok)(tokens_1.WParenRightW), (0, combi_1.tok)(tokens_1.WParenRight)));
-        const field = (0, combi_1.altPrio)(_1.SQLAggregation, _1.SQLCase, _1.SQLCast, sql_function_1.SQLFunction, sql_path_1.SQLPath, _1.SQLFieldName, abap, _1.Constant, parenFieldName);
+        const field = (0, combi_1.altPrio)(_1.SQLAggregation, _1.SQLCase, sql_function_1.SQLFunction, sql_path_1.SQLPath, _1.SQLFieldName, abap, _1.Constant, parenFieldName);
         const parenField = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WParenLeftW), field, (0, combi_1.tok)(tokens_1.WParenRightW));
         const sub = (0, combi_1.plusPrio)((0, combi_1.seq)((0, combi_1.altPrio)("+", "-", "*", "/", "&&"), (0, combi_1.altPrio)(parenField, field)));
         const arith = (0, combi_1.ver)(version_1.Version.v740sp05, sub);

package/build/src/abap/2_statements/expressions/sql_function.js

@@ -8,10 +8,11 @@ const integer_1 = require("./integer");
 const sql_function_input_1 = require("./sql_function_input");
 class SQLFunction extends combi_1.Expression {
     getRunnable() {
-        const castTypes = (0, combi_1.altPrio)((0, combi_1.seq)("CHAR", (0, combi_1.optPrio)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.ParenLeftW), integer_1.Integer, (0, combi_1.tok)(tokens_1.WParenRightW)))), (0, combi_1.seq)("DEC", (0, combi_1.tok)(tokens_1.ParenLeftW), integer_1.Integer, ",", integer_1.Integer, (0, combi_1.tok)(tokens_1.WParenRightW)), (0, combi_1.seq)("NUMC", (0, combi_1.optPrio)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.ParenLeftW), integer_1.Integer, (0, combi_1.tok)(tokens_1.WParenRightW)))), "FLTP", "INT2", "INT4", "INT8");
+        const castTypes = (0, combi_1.altPrio)((0, combi_1.seq)("CHAR", (0, combi_1.optPrio)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.ParenLeftW), integer_1.Integer, (0, combi_1.tok)(tokens_1.WParenRightW)))), (0, combi_1.seq)("DEC", (0, combi_1.tok)(tokens_1.ParenLeftW), integer_1.Integer, ",", integer_1.Integer, (0, combi_1.tok)(tokens_1.WParenRightW)), (0, combi_1.seq)("NUMC", (0, combi_1.optPrio)((0, combi_1.seq)((0, combi_1.tok)(tokens_1.ParenLeftW), integer_1.Integer, (0, combi_1.tok)(tokens_1.WParenRightW)))), "DATS", "FLTP", "INT2", "INT4", "INT8");
         const commaParam = (0, combi_1.seq)(",", sql_function_input_1.SQLFunctionInput);
         // note: the function names are not keywords, they are usually in lower case
         const abs = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)((0, combi_1.regex)(/^abs$/i), (0, combi_1.tok)(tokens_1.ParenLeftW), sql_function_input_1.SQLFunctionInput, (0, combi_1.tok)(tokens_1.WParenRightW)));
+        // yea, 750 is correct, but it also works technically in version v740sp05
         const cast = (0, combi_1.ver)(version_1.Version.v750, (0, combi_1.seq)((0, combi_1.regex)(/^cast$/i), (0, combi_1.tok)(tokens_1.ParenLeftW), sql_function_input_1.SQLFunctionInput, "AS", castTypes, (0, combi_1.tok)(tokens_1.WParenRightW)));
         const ceil = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)((0, combi_1.regex)(/^ceil$/i), (0, combi_1.tok)(tokens_1.ParenLeftW), sql_function_input_1.SQLFunctionInput, (0, combi_1.tok)(tokens_1.WParenRightW)));
         const coalesce = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)((0, combi_1.regex)(/^coalesce$/i), (0, combi_1.tok)(tokens_1.ParenLeftW), sql_function_input_1.SQLFunctionInput, commaParam, (0, combi_1.optPrio)(commaParam), (0, combi_1.tok)(tokens_1.WParenRightW)));

package/build/src/abap/5_syntax/expressions/select.js

@@ -17,7 +17,7 @@ const _syntax_input_1 = require("../_syntax_input");
 const isSimple = /^\w+$/;
 class Select {
     static runSyntax(node, input, skipImplicitInto = false) {
-        var _a, _b;
+        var _a;
         const token = node.getFirstToken();
         let from = node.findDirectExpression(Expressions.SQLFrom);
         if (from === undefined) {
@@ -38,10 +38,8 @@ class Select {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return;
         }
-        const isSingle = ((_a = node.getChildren()[1]) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase()) === "SINGLE"
-            || node.get() instanceof Expressions.SelectLoop;
         this.checkFields(fields, dbSources, input, node);
-        this.handleInto(node, input, fields, dbSources, isSingle);
+        const intoExpression = this.handleInto(node, input, fields, dbSources);
         const fae = node.findDirectExpression(Expressions.SQLForAllEntries);
         if (fae) {
             input.scope.push(_scope_type_1.ScopeType.OpenSQL, "SELECT", token.getStart(), input.filename);
@@ -55,7 +53,7 @@ class Select {
             && node.findDirectExpression(Expressions.SQLIntoTable) === undefined
             && node.findDirectExpression(Expressions.SQLIntoList) === undefined
             && node.findDirectExpression(Expressions.SQLIntoStructure) === undefined) {
-            const fields = (_b = node.findFirstExpression(Expressions.SQLAggregation)) === null || _b === void 0 ? void 0 : _b.concatTokens();
+            const fields = (_a = node.findFirstExpression(Expressions.SQLAggregation)) === null || _a === void 0 ? void 0 : _a.concatTokens();
             const c = new RegExp(/^count\(\s*\*\s*\)$/, "i");
             if (fields === undefined || c.test(fields) === false) {
                 const nameToken = from === null || from === void 0 ? void 0 : from.findDirectExpression(Expressions.SQLFromSource);
@@ -89,8 +87,18 @@ class Select {
         for (const s of node.findAllExpressions(Expressions.SQLCompare)) {
             sql_compare_1.SQLCompare.runSyntax(s, input, dbSources);
         }
-        for (const s of node.findDirectExpressions(Expressions.SQLOrderBy)) {
-            sql_order_by_1.SQLOrderBy.runSyntax(s, input);
+        const orderBy = node.findDirectExpression(Expressions.SQLOrderBy);
+        if (orderBy) {
+            sql_order_by_1.SQLOrderBy.runSyntax(orderBy, input);
+            const where = node.findDirectExpression(Expressions.SQLCond);
+            if (intoExpression
+                && where
+                && intoExpression.getFirstToken().getStart().isBefore(orderBy.getFirstToken().getStart())
+                && where.getFirstToken().getStart().isBefore(orderBy.getFirstToken().getStart())
+                && where.getFirstToken().getStart().isBefore(intoExpression.getFirstToken().getStart())) {
+                const message = `ORDER BY must be before INTO, after WHERE`;
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, orderBy.getFirstToken(), message));
+            }
         }
         if (this.isStrictMode(node)) {
             this.strictModeChecks(node, input);
@@ -141,13 +149,14 @@ class Select {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
         }
     }
-    static handleInto(node, input, fields, dbSources, _isSingle) {
+    static handleInto(node, input, fields, dbSources) {
         const intoTable = node.findDirectExpression(Expressions.SQLIntoTable);
         if (intoTable) {
             const inline = intoTable.findFirstExpression(Expressions.InlineData);
             if (inline) {
                 inline_data_1.InlineData.runSyntax(inline, input, this.buildTableType(fields, dbSources, input.scope));
             }
+            return intoTable;
         }
         const intoStructure = node.findDirectExpression(Expressions.SQLIntoStructure);
         if (intoStructure) {
@@ -161,6 +170,7 @@ class Select {
                     inline_data_1.InlineData.runSyntax(inline, input, basic_1.VoidType.get("SELECT_todo1"));
                 }
             }
+            return intoStructure;
         }
         const intoList = node.findDirectExpression(Expressions.SQLIntoList);
         if (intoList) {
@@ -200,7 +210,9 @@ class Select {
                     inline_data_1.InlineData.runSyntax(inline, input, type);
                 }
             }
+            return intoList;
         }
+        return undefined;
     }
     static checkFields(fields, dbSources, input, node) {
         if (dbSources.length > 1) {

package/build/src/objects/_abap_object.js

@@ -30,6 +30,7 @@ class ABAPObject extends _abstract_object_1.AbstractObject {
     setDirty() {
         this.syntaxResult = undefined;
         this.texts = undefined;
+        this.parsed = [];
         super.setDirty();
     }
     getABAPFiles() {

package/build/src/objects/_abstract_object.js

@@ -22,6 +22,7 @@ class AbstractObject {
         return this.name;
     }
     setDirty() {
+        this.old = [];
         this.dirty = true;
     }
     addFile(file) {

package/build/src/objects/email_template.js

@@ -0,0 +1,21 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.EmailTemplate = void 0;
+const _abstract_object_1 = require("./_abstract_object");
+class EmailTemplate extends _abstract_object_1.AbstractObject {
+    getType() {
+        return "SMTG";
+    }
+    getAllowedNaming() {
+        return {
+            maxLength: 60, // todo
+            allowNamespace: true,
+        };
+    }
+    getDescription() {
+        // todo
+        return undefined;
+    }
+}
+exports.EmailTemplate = EmailTemplate;
+//# sourceMappingURL=email_template.js.map

package/build/src/objects/index.js

@@ -36,7 +36,6 @@ __exportStar(require("./behavior_definition"), exports);
 __exportStar(require("./brf_plus_system_application"), exports);
 __exportStar(require("./bsp_application"), exports);
 __exportStar(require("./business_add_in_implementation"), exports);
-__exportStar(require("./cds_entity_buffer"), exports);
 __exportStar(require("./business_catalog_app_assignment"), exports);
 __exportStar(require("./business_catalog"), exports);
 __exportStar(require("./business_configuration_maintenance_object"), exports);
@@ -45,6 +44,7 @@ __exportStar(require("./business_function_assignment"), exports);
 __exportStar(require("./business_function_set_assignment"), exports);
 __exportStar(require("./business_object_model"), exports);
 __exportStar(require("./business_object_type"), exports);
+__exportStar(require("./cds_entity_buffer"), exports);
 __exportStar(require("./cds_metadata_extension"), exports);
 __exportStar(require("./cds_type"), exports);
 __exportStar(require("./change_document"), exports);
@@ -70,6 +70,7 @@ __exportStar(require("./domain"), exports);
 __exportStar(require("./ecatt_test_configuration"), exports);
 __exportStar(require("./ecatt_test_data_container"), exports);
 __exportStar(require("./ecatt_test_script"), exports);
+__exportStar(require("./email_template"), exports);
 __exportStar(require("./enhancement_implementation"), exports);
 __exportStar(require("./enhancement_spot"), exports);
 __exportStar(require("./entity_type"), exports);

package/build/src/objects/table.js

@@ -40,6 +40,13 @@ class Table extends _abstract_object_1.AbstractObject {
         }
         return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.description;
     }
+    getSecondaryIndexes() {
+        var _a;
+        if (this.parsedData === undefined) {
+            this.parseXML();
+        }
+        return (_a = this.parsedData) === null || _a === void 0 ? void 0 : _a.secondaryIndexes;
+    }
     getAllowedNaming() {
         let length = 30;
         const regex = /^((\/[A-Z_\d]{3,8}\/)|[a-zA-Z0-9]{3}|CI_)\w+$/;
@@ -267,7 +274,7 @@ class Table extends _abstract_object_1.AbstractObject {
     }
     ///////////////
     parseXML() {
-        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l;
+        var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o;
         const parsed = super.parseRaw2();
         if (parsed === undefined) {
             return;
@@ -306,6 +313,25 @@ class Table extends _abstract_object_1.AbstractObject {
                 DDTEXT: field.DDTEXT,
             });
         }
+        // secondary indexes
+        const indexes = (_m = parsed.abapGit["asx:abap"]["asx:values"]) === null || _m === void 0 ? void 0 : _m.DD12V;
+        ;
+        this.parsedData.secondaryIndexes = [];
+        for (const index of (0, xml_utils_1.xmlToArray)(indexes === null || indexes === void 0 ? void 0 : indexes.DD12V)) {
+            const indexName = index.INDEXNAME;
+            const indexFields = [];
+            const indexFieldsXml = (_o = parsed.abapGit["asx:abap"]["asx:values"]) === null || _o === void 0 ? void 0 : _o.DD17V;
+            for (const indexField of (0, xml_utils_1.xmlToArray)(indexFieldsXml === null || indexFieldsXml === void 0 ? void 0 : indexFieldsXml.DD17V)) {
+                if (indexField.INDEXNAME === indexName) {
+                    // assumption: fields are listed by POSITION in the xml
+                    indexFields.push(indexField.FIELDNAME);
+                }
+            }
+            this.parsedData.secondaryIndexes.push({
+                name: indexName,
+                fields: indexFields,
+            });
+        }
     }
 }
 exports.Table = Table;

package/build/src/registry.js

@@ -74,7 +74,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.246";
+        return "2.114.0";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/index.js

@@ -83,6 +83,7 @@ __exportStar(require("./implement_methods"), exports);
 __exportStar(require("./implicit_start_of_selection"), exports);
 __exportStar(require("./in_statement_indentation"), exports);
 __exportStar(require("./indentation"), exports);
+__exportStar(require("./index_completely_contained"), exports);
 __exportStar(require("./inline_data_old_versions"), exports);
 __exportStar(require("./intf_referencing_clas"), exports);
 __exportStar(require("./invalid_table_index"), exports);

package/build/src/rules/index_completely_contained.js

@@ -0,0 +1,67 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.IndexCompletelyContained = exports.IndexCompletelyContainedConf = void 0;
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+const issue_1 = require("../issue");
+const position_1 = require("../position");
+const Objects = require("../objects");
+class IndexCompletelyContainedConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.IndexCompletelyContainedConf = IndexCompletelyContainedConf;
+class IndexCompletelyContained {
+    constructor() {
+        this.conf = new IndexCompletelyContainedConf();
+    }
+    getMetadata() {
+        return {
+            key: "index_completely_contained",
+            title: "Check if database table indexes are completely contained",
+            shortDescription: `If indexes are completely contained in other indexes, they can be removed to improve performance.`,
+            tags: [_irule_1.RuleTag.Performance],
+        };
+    }
+    initialize() {
+        return this;
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    run(obj) {
+        if (!(obj instanceof Objects.Table)) {
+            return [];
+        }
+        const indexes = obj.getSecondaryIndexes();
+        if (indexes === undefined || indexes.length === 0) {
+            return [];
+        }
+        const issues = [];
+        for (let i = 0; i < indexes.length; i++) {
+            const indexA = indexes[i];
+            for (let j = 0; j < indexes.length; j++) {
+                if (i === j) {
+                    continue;
+                }
+                const indexB = indexes[j];
+                let contained = true;
+                for (const field of indexA.fields) {
+                    if (indexB.fields.indexOf(field) === -1) {
+                        contained = false;
+                        break;
+                    }
+                }
+                if (contained) {
+                    const position = new position_1.Position(1, 1);
+                    const message = `Index "${indexA.name}" is completely contained in index "${indexB.name}"`;
+                    issues.push(issue_1.Issue.atPosition(obj.getFiles()[0], position, message, this.getMetadata().key, this.conf.severity));
+                }
+            }
+        }
+        return issues;
+    }
+}
+exports.IndexCompletelyContained = IndexCompletelyContained;
+//# sourceMappingURL=index_completely_contained.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.113.246",
+    "version": "2.114.0",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",

package/build/src/abap/2_statements/expressions/sql_cast.js

@@ -1,17 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-exports.SQLCast = void 0;
-const _1 = require(".");
-const version_1 = require("../../../version");
-const tokens_1 = require("../../1_lexer/tokens");
-const combi_1 = require("../combi");
-const sql_field_name_1 = require("./sql_field_name");
-class SQLCast extends combi_1.Expression {
-    getRunnable() {
-        const abap = (0, combi_1.ver)(version_1.Version.v740sp05, (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WAt), _1.SimpleFieldChain2), version_1.Version.OpenABAP);
-        // todo: from version something
-        return (0, combi_1.seq)("CAST", "(", (0, combi_1.opt)((0, combi_1.altPrio)(sql_field_name_1.SQLFieldName, abap)), "AS", sql_field_name_1.SQLFieldName, ")");
-    }
-}
-exports.SQLCast = SQLCast;
-//# sourceMappingURL=sql_cast.js.map