@abaplint/core 2.113.231 → 2.113.233

package/build/src/abap/2_statements/expressions/component_compare_simple.js

@@ -7,7 +7,7 @@ const component_chain_simple_1 = require("./component_chain_simple");
 const version_1 = require("../../../version");
 class ComponentCompareSimple extends combi_1.Expression {
     getRunnable() {
-        const source = (0, combi_1.alt)(_1.SimpleSource4, (0, combi_1.ver)(version_1.Version.v740sp02, _1.Source, version_1.Version.OpenABAP));
+        const source = (0, combi_1.altPrio)((0, combi_1.ver)(version_1.Version.v740sp02, _1.Source, version_1.Version.OpenABAP), _1.SimpleSource4);
         const ret = (0, combi_1.seq)((0, combi_1.altPrio)(component_chain_simple_1.ComponentChainSimple, _1.Dynamic), "=", source);
         return (0, combi_1.plus)(ret);
     }

package/build/src/abap/2_statements/statements/read_table.js

@@ -10,12 +10,11 @@ class ReadTable {
         const comparing = (0, combi_1.seq)("COMPARING", (0, combi_1.alt)((0, combi_1.plus)(expressions_1.FieldSub), (0, combi_1.plus)(expressions_1.Dynamic)));
         const index = (0, combi_1.seq)("INDEX", expressions_1.Source);
         const components = (0, combi_1.seq)((0, combi_1.alt)(expressions_1.Field, expressions_1.Dynamic), "COMPONENTS", expressions_1.ComponentCompareSimple);
-        const source = (0, combi_1.alt)(expressions_1.SimpleSource2, (0, combi_1.ver)(version_1.Version.v740sp02, expressions_1.Source, version_1.Version.OpenABAP));
-        const key = (0, combi_1.seq)((0, combi_1.altPrio)("WITH KEY", "WITH TABLE KEY"), (0, combi_1.alt)(expressions_1.ComponentCompareSimple, components, (0, combi_1.seq)((0, combi_1.optPrio)("="), source)));
+        const key = (0, combi_1.seq)((0, combi_1.altPrio)("WITH KEY", "WITH TABLE KEY"), (0, combi_1.alt)(expressions_1.ComponentCompareSimple, components, (0, combi_1.seq)((0, combi_1.optPrio)("="), expressions_1.Source)));
         const using = (0, combi_1.seq)("USING KEY", (0, combi_1.alt)(expressions_1.Field, expressions_1.Dynamic));
-        const from = (0, combi_1.seq)("FROM", source);
+        const from = (0, combi_1.seq)("FROM", expressions_1.Source);
         const perm = (0, combi_1.per)((0, combi_1.alt)(index, key, from), expressions_1.ReadTableTarget, using, comparing, "CASTING", (0, combi_1.seq)("TRANSPORTING", (0, combi_1.altPrio)("ALL FIELDS", "NO FIELDS", transporting_fields_1.TransportingFields)), "BINARY SEARCH");
-        return (0, combi_1.seq)("READ TABLE", source, (0, combi_1.opt)(perm));
+        return (0, combi_1.seq)("READ TABLE", (0, combi_1.alt)(expressions_1.SimpleSource2, (0, combi_1.ver)(version_1.Version.v740sp02, expressions_1.Source, version_1.Version.OpenABAP)), (0, combi_1.opt)(perm));
     }
 }
 exports.ReadTable = ReadTable;

package/build/src/abap/5_syntax/_type_utils.js

@@ -503,9 +503,30 @@ class TypeUtils {
                 return true;
             }
             else if (source instanceof basic_1.StructureType) {
-                if (this.structureContainsString(target) && !this.structureContainsString(source)) {
+                const targetDeep = this.structureContainsString(target);
+                const sourceDeep = this.structureContainsString(source);
+                if (targetDeep && !sourceDeep) {
                     return false;
                 }
+                const targetComponents = target.getComponents();
+                const sourceComponents = source.getComponents();
+                if (targetComponents.length !== sourceComponents.length) {
+                    if (targetDeep === true || sourceDeep === true) {
+                        return false;
+                    }
+                }
+                for (let i = 0; i < targetComponents.length; i++) {
+                    if (sourceComponents[i] === undefined) {
+                        continue;
+                    }
+                    // hmm
+                    if (sourceComponents[i].type instanceof basic_1.StringType && !(targetComponents[i].type instanceof basic_1.StringType)) {
+                        return false;
+                    }
+                    else if (!(sourceComponents[i].type instanceof basic_1.StringType) && targetComponents[i].type instanceof basic_1.StringType) {
+                        return false;
+                    }
+                }
                 return true;
             }
             else if (target.containsVoid() === true) {

package/build/src/abap/5_syntax/expressions/component_compare_simple.js

@@ -18,7 +18,9 @@ class ComponentCompareSimple {
                 else if (c.get() instanceof Expressions.Dynamic) {
                     targetType = undefined;
                 }
-                else if (c.get() instanceof Expressions.Source || c.get() instanceof Expressions.SimpleSource4) {
+                else if (c.get() instanceof Expressions.Source
+                    || c.get() instanceof Expressions.SimpleSource4
+                    || c.get() instanceof Expressions.SimpleSource2) {
                     const sourceType = source_1.Source.runSyntax(c, input, targetType);
                     if (targetType && new _type_utils_1.TypeUtils(input.scope).isAssignable(sourceType, targetType) === false) {
                         const message = "ComponentCompareSimple, incompatible types";

package/build/src/abap/5_syntax/expressions/field_assignment.js

@@ -26,7 +26,7 @@ class FieldAssignment {
                 const text = c.concatTokens();
                 if (text !== "-" && context instanceof basic_1.StructureType) {
                     context = context.getComponentByName(text);
-                    if (context === undefined && targetType.containsVoid() === false) {
+                    if (context === undefined) {
                         const message = `field ${text} does not exist in structure`;
                         input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                         return;

package/build/src/abap/5_syntax/statements/method_implementation.js

@@ -6,6 +6,7 @@ const _object_oriented_1 = require("../_object_oriented");
 const _scope_type_1 = require("../_scope_type");
 const _reference_1 = require("../_reference");
 const _syntax_input_1 = require("../_syntax_input");
+const visibility_1 = require("../../4_file_information/visibility");
 class MethodImplementation {
     runSyntax(node, input) {
         const helper = new _object_oriented_1.ObjectOriented(input.scope);
@@ -19,6 +20,13 @@ class MethodImplementation {
             return;
         }
         const { method: methodDefinition } = helper.searchMethodName(classDefinition, methodName);
+        if (classDefinition.isForTesting()
+            && (methodDefinition === null || methodDefinition === void 0 ? void 0 : methodDefinition.getVisibility()) !== visibility_1.Visibility.Private
+            && ["SETUP", "TEARDOWN", "CLASS_SETUP", "CLASS_TEARDOWN"].includes(methodName.toUpperCase())) {
+            const message = "Special test method \"" + methodName + "\" must be private";
+            input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+            return;
+        }
         const start = node.getFirstToken().getStart();
         if ((methodDefinition === null || methodDefinition === void 0 ? void 0 : methodDefinition.isStatic()) === false) {
             input.scope.push(_scope_type_1.ScopeType.MethodInstance, methodName, start, input.filename);

package/build/src/abap/5_syntax/statements/read_table.js

@@ -42,6 +42,11 @@ class ReadTable {
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                 return;
             }
+            else if (sourceType instanceof basic_1.TableType && sourceType.getAccessType() === basic_1.TableAccessType.hashed) {
+                const message = "INDEX on hashed table not possible";
+                input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                return;
+            }
         }
         const fromSource = node.findExpressionAfterToken("FROM");
         if (fromSource) {

package/build/src/registry.js

@@ -67,7 +67,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.231";
+        return "2.113.233";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.113.231",
+    "version": "2.113.233",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -53,9 +53,9 @@
         "@microsoft/api-extractor": "^7.53.1",
         "@types/chai": "^4.3.20",
         "@types/mocha": "^10.0.10",
-        "@types/node": "^24.7.2",
+        "@types/node": "^24.9.1",
         "chai": "^4.5.0",
-        "eslint": "^9.37.0",
+        "eslint": "^9.38.0",
         "mocha": "^11.7.4",
         "c8": "^10.1.3",
         "source-map-support": "^0.5.21",