@abaplint/core 2.113.127 → 2.113.129

package/build/src/abap/2_statements/expressions/color.js

@@ -8,7 +8,7 @@ class Color extends combi_1.Expression {
         const eq = (0, combi_1.seq)("=", source_1.Source);
         const integers = (0, combi_1.altPrio)("1", "2", "3", "4", "5", "6", "7");
         const texts = (0, combi_1.altPrio)("COL_BACKGROUND", "COL_HEADING", "COL_NORMAL", "COL_TOTAL", "COL_KEY", "COL_POSITIVE", "COL_NEGATIVE", "COL_GROUP");
-        const value = (0, combi_1.alt)(eq, (0, combi_1.altPrio)("ON", "OFF", (0, combi_1.altPrio)(integers, texts)));
+        const value = (0, combi_1.alt)(eq, (0, combi_1.altPrio)("ON", "OFF", "COLOR OFF", (0, combi_1.altPrio)(integers, texts)));
         const toggle = (0, combi_1.altPrio)("ON", "OFF");
         return (0, combi_1.seq)("COLOR", (0, combi_1.opt)((0, combi_1.seq)(value, (0, combi_1.opt)(toggle))));
     }

package/build/src/abap/2_statements/statements/data_begin.js

@@ -6,8 +6,8 @@ const expressions_1 = require("../expressions");
 class DataBegin {
     getMatcher() {
         const occurs = (0, combi_1.seq)("OCCURS", expressions_1.Integer);
-        const common = (0, combi_1.altPrio)((0, combi_1.seq)("COMMON PART", expressions_1.DefinitionName), "COMMON PART");
-        const structure = (0, combi_1.seq)("BEGIN OF", (0, combi_1.altPrio)(common, (0, combi_1.seq)(expressions_1.DefinitionName, (0, combi_1.opt)("READ-ONLY"), (0, combi_1.opt)(occurs))));
+        const common = (0, combi_1.seq)("COMMON PART", (0, combi_1.optPrio)(expressions_1.DefinitionName));
+        const structure = (0, combi_1.seq)("BEGIN OF", (0, combi_1.altPrio)(common, (0, combi_1.seq)(expressions_1.DefinitionName, (0, combi_1.optPrio)("READ-ONLY"), (0, combi_1.optPrio)(occurs))));
         return (0, combi_1.seq)("DATA", structure);
     }
 }

package/build/src/abap/3_structures/structures/dynpro_logic.js

@@ -5,7 +5,7 @@ const Structures = require("./");
 const _combi_1 = require("./_combi");
 class DynproLogic {
     getMatcher() {
-        return (0, _combi_1.seq)((0, _combi_1.sub)(Structures.ProcessBeforeOutput), (0, _combi_1.sub)(Structures.ProcessAfterInput), (0, _combi_1.opt)((0, _combi_1.sub)(Structures.ProcessOnValueRequest)), (0, _combi_1.opt)((0, _combi_1.sub)(Structures.ProcessOnHelpRequest)));
+        return (0, _combi_1.seq)((0, _combi_1.sub)(Structures.ProcessBeforeOutput), (0, _combi_1.sub)(Structures.ProcessAfterInput), (0, _combi_1.opt)((0, _combi_1.sub)(Structures.ProcessOnHelpRequest)), (0, _combi_1.opt)((0, _combi_1.sub)(Structures.ProcessOnValueRequest)), (0, _combi_1.opt)((0, _combi_1.sub)(Structures.ProcessOnHelpRequest)));
     }
 }
 exports.DynproLogic = DynproLogic;

package/build/src/abap/3_structures/structures/dynpro_loop.js

@@ -6,7 +6,7 @@ const _combi_1 = require("./_combi");
 const chain_1 = require("./chain");
 class DynproLoop {
     getMatcher() {
-        return (0, _combi_1.beginEnd)((0, _combi_1.sta)(Statements.DynproLoop), (0, _combi_1.star)((0, _combi_1.alt)((0, _combi_1.sta)(Statements.Module), (0, _combi_1.sub)(chain_1.Chain))), (0, _combi_1.sta)(Statements.EndLoop));
+        return (0, _combi_1.beginEnd)((0, _combi_1.sta)(Statements.DynproLoop), (0, _combi_1.star)((0, _combi_1.alt)((0, _combi_1.sta)(Statements.Module), (0, _combi_1.sta)(Statements.Field), (0, _combi_1.sub)(chain_1.Chain))), (0, _combi_1.sta)(Statements.EndLoop));
     }
 }
 exports.DynproLoop = DynproLoop;

package/build/src/abap/5_syntax/_type_utils.js

@@ -524,6 +524,9 @@ class TypeUtils {
             else if ((target instanceof basic_1.StringType || target instanceof basic_1.CharacterType)
                 && source instanceof basic_1.StructureType
                 && this.isCharLike(source)) {
+                if (this.structureContainsString(source) === true) {
+                    return false;
+                }
                 return true;
             }
             else if (source instanceof basic_1.StructureType) {

package/build/src/abap/5_syntax/expressions/attribute_chain.js

@@ -15,8 +15,7 @@ class AttributeChain {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), "Not an object reference(AttributeChain)"));
             return void_type_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
         }
-        const children = node.getChildren().slice();
-        const first = children[0];
+        const first = node.getChildren()[0];
         if (!(first.get() instanceof expressions_1.AttributeName)) {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), "AttributeChain, unexpected first child"));
             return void_type_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);

package/build/src/abap/5_syntax/expressions/method_call_chain.js

@@ -18,23 +18,25 @@ class MethodCallChain {
     static runSyntax(node, input, targetType) {
         var _a, _b;
         const helper = new _object_oriented_1.ObjectOriented(input.scope);
-        const children = node.getChildren().slice();
-        const first = children.shift();
+        const children = node.getChildren();
+        const first = children[0];
         if (first === undefined) {
             const message = "MethodCallChain, first child expected";
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
         }
+        let currentIndex = 1;
         let context = this.findTop(first, input, targetType);
         if (first.get() instanceof Expressions.MethodCall) {
-            children.unshift(first);
+            currentIndex--;
         }
         let previous = undefined;
-        while (children.length > 0) {
-            const current = children.shift();
+        while (currentIndex <= children.length) {
+            const current = children[currentIndex];
             if (current === undefined) {
                 break;
             }
+            currentIndex++;
             if (current instanceof nodes_1.ExpressionNode && current.get() instanceof Expressions.MethodCall) {
                 // for built-in methods set className to undefined
                 const className = context instanceof basic_1.ObjectReferenceType ? context.getIdentifierName() : undefined;

package/build/src/abap/5_syntax/expressions/source.js

@@ -189,46 +189,49 @@ class Source {
         let hexExpected = false;
         let hexNext = false;
         while (children.length >= 0) {
-            if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.MethodCallChain) {
-                context = method_call_chain_1.MethodCallChain.runSyntax(first, input, targetType);
-                if (context === undefined) {
-                    const message = "Method has no RETURNING value";
-                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
-                    return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+            if (first instanceof nodes_1.ExpressionNode) {
+                const get = first.get();
+                if (get instanceof Expressions.MethodCallChain) {
+                    context = method_call_chain_1.MethodCallChain.runSyntax(first, input, targetType);
+                    if (context === undefined) {
+                        const message = "Method has no RETURNING value";
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                        return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                    }
                 }
-            }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.FieldChain) {
-                context = field_chain_1.FieldChain.runSyntax(first, input, type);
-            }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.StringTemplate) {
-                context = string_template_1.StringTemplate.runSyntax(first, input);
-            }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.Source) {
-                const found = Source.runSyntax(first, input);
-                context = this.infer(context, found);
-            }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.Constant) {
-                const found = constant_1.Constant.runSyntax(first);
-                context = this.infer(context, found);
-            }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.Dereference) {
-                context = dereference_1.Dereference.runSyntax(first, context, input);
-            }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.ComponentChain) {
-                context = component_chain_1.ComponentChain.runSyntax(context, first, input);
-            }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.ArithOperator) {
-                if (first.concatTokens() === "**") {
-                    context = new basic_1.FloatType();
+                else if (get instanceof Expressions.FieldChain) {
+                    context = field_chain_1.FieldChain.runSyntax(first, input, type);
                 }
-                const operator = first.concatTokens().toUpperCase();
-                if (operator === "BIT-OR" || operator === "BIT-AND" || operator === "BIT-XOR") {
-                    hexExpected = true;
-                    hexNext = true;
+                else if (get instanceof Expressions.StringTemplate) {
+                    context = string_template_1.StringTemplate.runSyntax(first, input);
+                }
+                else if (get instanceof Expressions.Source) {
+                    const found = Source.runSyntax(first, input);
+                    context = this.infer(context, found);
+                }
+                else if (get instanceof Expressions.Constant) {
+                    const found = constant_1.Constant.runSyntax(first);
+                    context = this.infer(context, found);
+                }
+                else if (get instanceof Expressions.Dereference) {
+                    context = dereference_1.Dereference.runSyntax(first, context, input);
+                }
+                else if (get instanceof Expressions.ComponentChain) {
+                    context = component_chain_1.ComponentChain.runSyntax(context, first, input);
+                }
+                else if (get instanceof Expressions.ArithOperator) {
+                    if (first.concatTokens() === "**") {
+                        context = new basic_1.FloatType();
+                    }
+                    const operator = first.concatTokens().toUpperCase();
+                    if (operator === "BIT-OR" || operator === "BIT-AND" || operator === "BIT-XOR") {
+                        hexExpected = true;
+                        hexNext = true;
+                    }
+                }
+                else if (get instanceof Expressions.AttributeChain) {
+                    context = attribute_chain_1.AttributeChain.runSyntax(context, first, input, type);
                 }
-            }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.AttributeChain) {
-                context = attribute_chain_1.AttributeChain.runSyntax(context, first, input, type);
             }
             if (hexExpected === true) {
                 if (!(context instanceof basic_1.VoidType)
@@ -273,7 +276,7 @@ class Source {
     }
     static addIfInferred(node, input, inferredType) {
         const basic = new basic_types_1.BasicTypes(input);
-        const typeExpression = node.findFirstExpression(Expressions.TypeNameOrInfer);
+        const typeExpression = node.findDirectExpression(Expressions.TypeNameOrInfer);
         const typeToken = typeExpression === null || typeExpression === void 0 ? void 0 : typeExpression.getFirstToken();
         const typeName = typeToken === null || typeToken === void 0 ? void 0 : typeToken.getStr();
         if (typeName === "#" && inferredType && typeToken) {
@@ -297,7 +300,7 @@ class Source {
     }
     static determineType(node, input, targetType) {
         const basic = new basic_types_1.BasicTypes(input);
-        const typeExpression = node.findFirstExpression(Expressions.TypeNameOrInfer);
+        const typeExpression = node.findDirectExpression(Expressions.TypeNameOrInfer);
         const typeToken = typeExpression === null || typeExpression === void 0 ? void 0 : typeExpression.getFirstToken();
         const typeName = typeToken === null || typeToken === void 0 ? void 0 : typeToken.getStr();
         if (typeExpression === undefined) {

package/build/src/abap/5_syntax/expressions/target.js

@@ -26,8 +26,8 @@ class Target {
                 return found.getType();
             }
         }
-        const children = node.getChildren().slice();
-        const first = children.shift();
+        const children = node.getChildren();
+        const first = children[0];
         if (first === undefined || !(first instanceof nodes_1.ExpressionNode)) {
             return undefined;
         }
@@ -37,11 +37,13 @@ class Target {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
         }
-        while (children.length > 0) {
-            const current = children.shift();
+        let currentIndex = 1;
+        while (currentIndex <= children.length) {
+            const current = children[currentIndex];
             if (current === undefined) {
                 break;
             }
+            currentIndex++;
             if (current.get() instanceof tokens_1.Dash) {
                 if (context instanceof unknown_type_1.UnknownType) {
                     const message = "Not a structure, type unknown, target";

package/build/src/abap/5_syntax/structures/data.js

@@ -1,18 +1,26 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.Data = void 0;
-const Expressions = require("../../2_statements/expressions");
-const Statements = require("../../2_statements/statements");
-const Structures = require("../../3_structures/structures");
+const _syntax_input_1 = require("../_syntax_input");
+const data_1 = require("../statements/data");
+const _reference_1 = require("../_reference");
 const nodes_1 = require("../../nodes");
+const type_1 = require("../statements/type");
 const _typed_identifier_1 = require("../../types/_typed_identifier");
+const types_1 = require("./types");
 const Basic = require("../../types/basic");
-const data_1 = require("../statements/data");
-const _reference_1 = require("../_reference");
-const _syntax_input_1 = require("../_syntax_input");
+const Expressions = require("../../2_statements/expressions");
+const Statements = require("../../2_statements/statements");
+const Structures = require("../../3_structures/structures");
 class Data {
-    runSyntax(node, input) {
-        var _a;
+    static runSyntax(node, input) {
+        var _a, _b;
+        const fouth = (_a = node.getFirstChild()) === null || _a === void 0 ? void 0 : _a.getChildren()[3];
+        const isCommonPart = fouth instanceof nodes_1.TokenNode && fouth.concatTokens() === "COMMON";
+        if (isCommonPart) {
+            this.runCommonPartSyntax(node, input);
+            return undefined;
+        }
         const name = node.findFirstExpression(Expressions.DefinitionName).getFirstToken();
         let table = false;
         const values = {};
@@ -29,7 +37,7 @@ class Data {
                 }
             }
             else if (c instanceof nodes_1.StructureNode && ctyp instanceof Structures.Data) {
-                const found = new Data().runSyntax(c, input);
+                const found = Data.runSyntax(c, input);
                 if (found) {
                     components.push({ name: found.getName(), type: found.getType() });
                 }
@@ -41,7 +49,7 @@ class Data {
             }
             else if (c instanceof nodes_1.StatementNode && ctyp instanceof Statements.IncludeType) {
                 // INCLUDES
-                const typeToken = (_a = c.findFirstExpression(Expressions.TypeName)) === null || _a === void 0 ? void 0 : _a.getFirstToken();
+                const typeToken = (_b = c.findFirstExpression(Expressions.TypeName)) === null || _b === void 0 ? void 0 : _b.getFirstToken();
                 const typeName = typeToken === null || typeToken === void 0 ? void 0 : typeToken.getStr();
                 let foundId = input.scope.findType(typeName);
                 if (foundId === undefined) {
@@ -93,6 +101,35 @@ class Data {
             return new _typed_identifier_1.TypedIdentifier(name, input.filename, new Basic.StructureType(components), undefined, val);
         }
     }
+    static runCommonPartSyntax(node, input) {
+        for (const c of node.getChildren()) {
+            const ctyp = c.get();
+            if (c instanceof nodes_1.StatementNode && ctyp instanceof Statements.Data) {
+                const found = new data_1.Data().runSyntax(c, input);
+                if (found) {
+                    input.scope.addIdentifier(found);
+                }
+            }
+            else if (c instanceof nodes_1.StructureNode && ctyp instanceof Structures.Data) {
+                const found = Data.runSyntax(c, input);
+                if (found) {
+                    input.scope.addIdentifier(found);
+                }
+            }
+            else if (c instanceof nodes_1.StatementNode && ctyp instanceof Statements.Type) {
+                const found = new type_1.Type().runSyntax(c, input);
+                if (found) {
+                    input.scope.addIdentifier(found);
+                }
+            }
+            else if (c instanceof nodes_1.StructureNode && ctyp instanceof Structures.Types) {
+                const found = new types_1.Types().runSyntax(c, input);
+                if (found) {
+                    input.scope.addIdentifier(found);
+                }
+            }
+        }
+    }
 }
 exports.Data = Data;
 //# sourceMappingURL=data.js.map

package/build/src/abap/5_syntax/syntax.js

@@ -410,7 +410,7 @@ class SyntaxLogic {
             return true;
         }
         else if (stru instanceof Structures.Data) {
-            this.scope.addIdentifier(new data_1.Data().runSyntax(node, input));
+            this.scope.addIdentifier(data_1.Data.runSyntax(node, input));
             return true;
         }
         else if (stru instanceof Structures.Statics) {

package/build/src/abap/types/class_attributes.js

@@ -123,7 +123,7 @@ class Attributes {
             const ctyp = c.get();
             if (c instanceof nodes_1.StructureNode) {
                 if (ctyp instanceof Structures.Data) {
-                    const found = new data_2.Data().runSyntax(c, input);
+                    const found = data_2.Data.runSyntax(c, input);
                     if (found !== undefined) {
                         const attr = new class_attribute_1.ClassAttribute(found, visibility, found.getMeta(), found.getValue());
                         this.instance.push(attr);

package/build/src/registry.js

@@ -67,7 +67,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.127";
+        return "2.113.129";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/downport.js

@@ -1239,7 +1239,8 @@ ${indentation}${uniqueName1}-attr3 = 'IF_T100_DYN_MSG~MSGV3'.
 ${indentation}${uniqueName1}-attr4 = 'IF_T100_DYN_MSG~MSGV4'.\n`;
         }
         abap += `${indentation}DATA ${uniqueName2} TYPE REF TO ${className}.
-${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.\n`;
+${indentation}CREATE OBJECT ${uniqueName2}.
+${indentation}${uniqueName2}->if_t100_message~t100key = ${uniqueName1}.\n`;
         if (withs.length > 0) {
             abap += `${indentation}${uniqueName2}->if_t100_dyn_msg~msgty = 'E'.\n`;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.113.127",
+    "version": "2.113.129",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -53,9 +53,9 @@
         "@microsoft/api-extractor": "^7.52.8",
         "@types/chai": "^4.3.20",
         "@types/mocha": "^10.0.10",
-        "@types/node": "^24.0.0",
+        "@types/node": "^24.0.1",
         "chai": "^4.5.0",
-        "eslint": "^9.28.0",
+        "eslint": "^9.29.0",
         "mocha": "^11.6.0",
         "c8": "^10.1.3",
         "source-map-support": "^0.5.21",