@abaplint/core 2.113.127 → 2.113.128

package/build/src/abap/3_structures/structures/dynpro_loop.js

@@ -6,7 +6,7 @@ const _combi_1 = require("./_combi");
 const chain_1 = require("./chain");
 class DynproLoop {
     getMatcher() {
-        return (0, _combi_1.beginEnd)((0, _combi_1.sta)(Statements.DynproLoop), (0, _combi_1.star)((0, _combi_1.alt)((0, _combi_1.sta)(Statements.Module), (0, _combi_1.sub)(chain_1.Chain))), (0, _combi_1.sta)(Statements.EndLoop));
+        return (0, _combi_1.beginEnd)((0, _combi_1.sta)(Statements.DynproLoop), (0, _combi_1.star)((0, _combi_1.alt)((0, _combi_1.sta)(Statements.Module), (0, _combi_1.sta)(Statements.Field), (0, _combi_1.sub)(chain_1.Chain))), (0, _combi_1.sta)(Statements.EndLoop));
     }
 }
 exports.DynproLoop = DynproLoop;

package/build/src/abap/5_syntax/_type_utils.js

@@ -524,6 +524,9 @@ class TypeUtils {
             else if ((target instanceof basic_1.StringType || target instanceof basic_1.CharacterType)
                 && source instanceof basic_1.StructureType
                 && this.isCharLike(source)) {
+                if (this.structureContainsString(source) === true) {
+                    return false;
+                }
                 return true;
             }
             else if (source instanceof basic_1.StructureType) {

package/build/src/abap/5_syntax/expressions/attribute_chain.js

@@ -15,8 +15,7 @@ class AttributeChain {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), "Not an object reference(AttributeChain)"));
             return void_type_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
         }
-        const children = node.getChildren().slice();
-        const first = children[0];
+        const first = node.getChildren()[0];
         if (!(first.get() instanceof expressions_1.AttributeName)) {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), "AttributeChain, unexpected first child"));
             return void_type_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);

package/build/src/abap/5_syntax/expressions/method_call_chain.js

@@ -18,23 +18,25 @@ class MethodCallChain {
     static runSyntax(node, input, targetType) {
         var _a, _b;
         const helper = new _object_oriented_1.ObjectOriented(input.scope);
-        const children = node.getChildren().slice();
-        const first = children.shift();
+        const children = node.getChildren();
+        const first = children[0];
         if (first === undefined) {
             const message = "MethodCallChain, first child expected";
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
         }
+        let currentIndex = 1;
         let context = this.findTop(first, input, targetType);
         if (first.get() instanceof Expressions.MethodCall) {
-            children.unshift(first);
+            currentIndex--;
         }
         let previous = undefined;
-        while (children.length > 0) {
-            const current = children.shift();
+        while (currentIndex <= children.length) {
+            const current = children[currentIndex];
             if (current === undefined) {
                 break;
             }
+            currentIndex++;
             if (current instanceof nodes_1.ExpressionNode && current.get() instanceof Expressions.MethodCall) {
                 // for built-in methods set className to undefined
                 const className = context instanceof basic_1.ObjectReferenceType ? context.getIdentifierName() : undefined;

package/build/src/abap/5_syntax/expressions/source.js

@@ -189,46 +189,49 @@ class Source {
         let hexExpected = false;
         let hexNext = false;
         while (children.length >= 0) {
-            if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.MethodCallChain) {
-                context = method_call_chain_1.MethodCallChain.runSyntax(first, input, targetType);
-                if (context === undefined) {
-                    const message = "Method has no RETURNING value";
-                    input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
-                    return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+            if (first instanceof nodes_1.ExpressionNode) {
+                const get = first.get();
+                if (get instanceof Expressions.MethodCallChain) {
+                    context = method_call_chain_1.MethodCallChain.runSyntax(first, input, targetType);
+                    if (context === undefined) {
+                        const message = "Method has no RETURNING value";
+                        input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
+                        return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
+                    }
                 }
-            }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.FieldChain) {
-                context = field_chain_1.FieldChain.runSyntax(first, input, type);
-            }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.StringTemplate) {
-                context = string_template_1.StringTemplate.runSyntax(first, input);
-            }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.Source) {
-                const found = Source.runSyntax(first, input);
-                context = this.infer(context, found);
-            }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.Constant) {
-                const found = constant_1.Constant.runSyntax(first);
-                context = this.infer(context, found);
-            }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.Dereference) {
-                context = dereference_1.Dereference.runSyntax(first, context, input);
-            }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.ComponentChain) {
-                context = component_chain_1.ComponentChain.runSyntax(context, first, input);
-            }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.ArithOperator) {
-                if (first.concatTokens() === "**") {
-                    context = new basic_1.FloatType();
+                else if (get instanceof Expressions.FieldChain) {
+                    context = field_chain_1.FieldChain.runSyntax(first, input, type);
                 }
-                const operator = first.concatTokens().toUpperCase();
-                if (operator === "BIT-OR" || operator === "BIT-AND" || operator === "BIT-XOR") {
-                    hexExpected = true;
-                    hexNext = true;
+                else if (get instanceof Expressions.StringTemplate) {
+                    context = string_template_1.StringTemplate.runSyntax(first, input);
+                }
+                else if (get instanceof Expressions.Source) {
+                    const found = Source.runSyntax(first, input);
+                    context = this.infer(context, found);
+                }
+                else if (get instanceof Expressions.Constant) {
+                    const found = constant_1.Constant.runSyntax(first);
+                    context = this.infer(context, found);
+                }
+                else if (get instanceof Expressions.Dereference) {
+                    context = dereference_1.Dereference.runSyntax(first, context, input);
+                }
+                else if (get instanceof Expressions.ComponentChain) {
+                    context = component_chain_1.ComponentChain.runSyntax(context, first, input);
+                }
+                else if (get instanceof Expressions.ArithOperator) {
+                    if (first.concatTokens() === "**") {
+                        context = new basic_1.FloatType();
+                    }
+                    const operator = first.concatTokens().toUpperCase();
+                    if (operator === "BIT-OR" || operator === "BIT-AND" || operator === "BIT-XOR") {
+                        hexExpected = true;
+                        hexNext = true;
+                    }
+                }
+                else if (get instanceof Expressions.AttributeChain) {
+                    context = attribute_chain_1.AttributeChain.runSyntax(context, first, input, type);
                 }
-            }
-            else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.AttributeChain) {
-                context = attribute_chain_1.AttributeChain.runSyntax(context, first, input, type);
             }
             if (hexExpected === true) {
                 if (!(context instanceof basic_1.VoidType)
@@ -273,7 +276,7 @@ class Source {
     }
     static addIfInferred(node, input, inferredType) {
         const basic = new basic_types_1.BasicTypes(input);
-        const typeExpression = node.findFirstExpression(Expressions.TypeNameOrInfer);
+        const typeExpression = node.findDirectExpression(Expressions.TypeNameOrInfer);
         const typeToken = typeExpression === null || typeExpression === void 0 ? void 0 : typeExpression.getFirstToken();
         const typeName = typeToken === null || typeToken === void 0 ? void 0 : typeToken.getStr();
         if (typeName === "#" && inferredType && typeToken) {
@@ -297,7 +300,7 @@ class Source {
     }
     static determineType(node, input, targetType) {
         const basic = new basic_types_1.BasicTypes(input);
-        const typeExpression = node.findFirstExpression(Expressions.TypeNameOrInfer);
+        const typeExpression = node.findDirectExpression(Expressions.TypeNameOrInfer);
         const typeToken = typeExpression === null || typeExpression === void 0 ? void 0 : typeExpression.getFirstToken();
         const typeName = typeToken === null || typeToken === void 0 ? void 0 : typeToken.getStr();
         if (typeExpression === undefined) {

package/build/src/abap/5_syntax/expressions/target.js

@@ -26,8 +26,8 @@ class Target {
                 return found.getType();
             }
         }
-        const children = node.getChildren().slice();
-        const first = children.shift();
+        const children = node.getChildren();
+        const first = children[0];
         if (first === undefined || !(first instanceof nodes_1.ExpressionNode)) {
             return undefined;
         }
@@ -37,11 +37,13 @@ class Target {
             input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
             return basic_1.VoidType.get(_syntax_input_1.CheckSyntaxKey);
         }
-        while (children.length > 0) {
-            const current = children.shift();
+        let currentIndex = 1;
+        while (currentIndex <= children.length) {
+            const current = children[currentIndex];
             if (current === undefined) {
                 break;
             }
+            currentIndex++;
             if (current.get() instanceof tokens_1.Dash) {
                 if (context instanceof unknown_type_1.UnknownType) {
                     const message = "Not a structure, type unknown, target";

package/build/src/registry.js

@@ -67,7 +67,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.127";
+        return "2.113.128";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/downport.js

@@ -1239,7 +1239,8 @@ ${indentation}${uniqueName1}-attr3 = 'IF_T100_DYN_MSG~MSGV3'.
 ${indentation}${uniqueName1}-attr4 = 'IF_T100_DYN_MSG~MSGV4'.\n`;
         }
         abap += `${indentation}DATA ${uniqueName2} TYPE REF TO ${className}.
-${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.\n`;
+${indentation}CREATE OBJECT ${uniqueName2}.
+${indentation}${uniqueName2}->if_t100_message~t100key = ${uniqueName1}.\n`;
         if (withs.length > 0) {
             abap += `${indentation}${uniqueName2}->if_t100_dyn_msg~msgty = 'E'.\n`;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.113.127",
+    "version": "2.113.128",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -53,9 +53,9 @@
         "@microsoft/api-extractor": "^7.52.8",
         "@types/chai": "^4.3.20",
         "@types/mocha": "^10.0.10",
-        "@types/node": "^24.0.0",
+        "@types/node": "^24.0.1",
         "chai": "^4.5.0",
-        "eslint": "^9.28.0",
+        "eslint": "^9.29.0",
         "mocha": "^11.6.0",
         "c8": "^10.1.3",
         "source-map-support": "^0.5.21",