@abaplint/core 2.113.121 → 2.113.123

package/build/abaplint.d.ts

@@ -3241,6 +3241,8 @@ export declare const enum IdentifierMeta {
 export declare interface IDependency {
     /** Url of a git repository */
     url?: string;
+    /** Git branch */
+    branch?: string;
     /** Name of local folder with dependencies */
     folder?: string;
     /** File search, glob pattern */

package/build/src/abap/5_syntax/_type_utils.js

@@ -4,6 +4,7 @@ exports.TypeUtils = void 0;
 const types_1 = require("../types");
 const basic_1 = require("../types/basic");
 const cgeneric_type_1 = require("../types/basic/cgeneric_type");
+const Expressions = require("../2_statements/expressions");
 // todo: refactor to static? for performance
 class TypeUtils {
     constructor(scope) {
@@ -222,8 +223,22 @@ class TypeUtils {
         }
         return false;
     }
-    isAssignableStrict(source, target, calculated = false) {
+    isCalculated(node) {
+        /*
+        if (node.getChildren().length === 1
+            && node.get() instanceof Expressions.Source
+            && node.getFirstChild()?.get() instanceof Expressions.MethodCallChain) {
+          return false;
+        }
+        */
+        const calculated = node.findFirstExpression(Expressions.MethodCallChain) !== undefined
+            || node.findFirstExpression(Expressions.StringTemplate) !== undefined
+            || node.findFirstExpression(Expressions.ArithOperator) !== undefined;
+        return calculated;
+    }
+    isAssignableStrict(source, target, node) {
         var _a, _b, _c, _d, _e, _f, _g, _h;
+        const calculated = node ? this.isCalculated(node) : false;
         /*
             console.dir(source);
             console.dir(target);
@@ -275,6 +290,13 @@ class TypeUtils {
         else if (source instanceof basic_1.StringType) {
             if (target instanceof basic_1.StructureType && this.structureContainsString(target)) {
                 return false;
+                /*
+              } else if (target instanceof CharacterType) {
+                if (source.getAbstractTypeData()?.derivedFromConstant === true) {
+                  return true;
+                }
+                return false;
+                */
             }
             else if (target instanceof basic_1.IntegerType) {
                 if (((_f = source.getAbstractTypeData()) === null || _f === void 0 ? void 0 : _f.derivedFromConstant) === true) {

package/build/src/abap/5_syntax/expressions/method_call_param.js

@@ -70,15 +70,12 @@ class MethodCallParam {
             if (child.get() instanceof Expressions.Source) {
                 sourceType = new source_1.Source().runSyntax(child, input, targetType);
             }
-            const calculated = child.findFirstExpression(Expressions.MethodCallChain) !== undefined
-                || child.findFirstExpression(Expressions.StringTemplate) !== undefined
-                || child.findFirstExpression(Expressions.ArithOperator) !== undefined;
             if (sourceType === undefined) {
                 const message = "No source type determined, method source";
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                 return;
             }
-            else if (new _type_utils_1.TypeUtils(input.scope).isAssignableStrict(sourceType, targetType, calculated) === false) {
+            else if (new _type_utils_1.TypeUtils(input.scope).isAssignableStrict(sourceType, targetType, child) === false) {
                 const message = "Method parameter type not compatible";
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                 return;

package/build/src/abap/5_syntax/expressions/method_parameters.js

@@ -158,15 +158,12 @@ class MethodParameters {
         }
         for (const item of items) {
             const parameter = allImporting.find(p => p.getName().toUpperCase() === item.name);
-            const calculated = item.source.findFirstExpression(Expressions.MethodCallChain) !== undefined
-                || item.source.findFirstExpression(Expressions.StringTemplate) !== undefined
-                || item.source.findFirstExpression(Expressions.ArithOperator) !== undefined;
             if (parameter === undefined) {
                 const message = "Method importing parameter \"" + item.name + "\" does not exist";
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                 continue;
             }
-            else if (new _type_utils_1.TypeUtils(input.scope).isAssignableStrict(item.sourceType, parameter.getType(), calculated) === false) {
+            else if (new _type_utils_1.TypeUtils(input.scope).isAssignableStrict(item.sourceType, parameter.getType(), item.source) === false) {
                 const message = "Method parameter type not compatible, " + item.name;
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                 return;

package/build/src/abap/5_syntax/statements/create_object.js

@@ -120,16 +120,13 @@ class CreateObject {
             }
             const source = p.findDirectExpression(Expressions.Source);
             const sourceType = new source_1.Source().runSyntax(source, input);
-            const calculated = (source === null || source === void 0 ? void 0 : source.findFirstExpression(Expressions.MethodCallChain)) !== undefined
-                || (source === null || source === void 0 ? void 0 : source.findFirstExpression(Expressions.StringTemplate)) !== undefined
-                || (source === null || source === void 0 ? void 0 : source.findFirstExpression(Expressions.ArithOperator)) !== undefined;
             const found = allImporting === null || allImporting === void 0 ? void 0 : allImporting.find(p => p.getName().toUpperCase() === name);
             if (found === undefined) {
                 const message = `constructor parameter "${name}" does not exist`;
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                 return;
             }
-            else if (new _type_utils_1.TypeUtils(input.scope).isAssignableStrict(sourceType, found.getType(), calculated) === false) {
+            else if (new _type_utils_1.TypeUtils(input.scope).isAssignableStrict(sourceType, found.getType(), source) === false) {
                 const message = `constructor parameter "${name}" type not compatible`;
                 input.issues.push((0, _syntax_input_1.syntaxIssue)(input, node.getFirstToken(), message));
                 return;

package/build/src/registry.js

@@ -67,7 +67,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.121";
+        return "2.113.123";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/exit_or_check.js

@@ -59,6 +59,7 @@ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-re
             else if (this.conf.allowCheck === false && get instanceof Statements.Check && stack.length === 0) {
                 const message = "CHECK is not allowed outside of loops";
                 let tokensString = statement.concatTokens();
+                tokensString = tokensString.replace(/^check /i, "CHECK ");
                 tokensString = tokensString.split("CHECK")[1].trim();
                 const replacement = "IF NOT " + tokensString + "\n  RETURN.\nENDIF.";
                 const fix = edit_helper_1.EditHelper.replaceRange(file, statement.getFirstToken().getStart(), statement.getLastToken().getEnd(), replacement);

package/build/src/rules/use_class_based_exceptions.js

@@ -47,8 +47,9 @@ ENDINTERFACE.`,
         var _a;
         const issues = [];
         for (const s of ((_a = file.getStructure()) === null || _a === void 0 ? void 0 : _a.findAllStatements(Statements.MethodDef)) || []) {
-            if (s.findDirectExpression(Expressions.MethodDefExceptions)) {
-                issues.push(issue_1.Issue.atStatement(file, s, this.getMessage(), this.getMetadata().key));
+            const expr = s.findDirectExpression(Expressions.MethodDefExceptions);
+            if (expr) {
+                issues.push(issue_1.Issue.atToken(file, expr.getFirstToken(), this.getMessage(), this.getMetadata().key));
             }
         }
         return issues;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.113.121",
+    "version": "2.113.123",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -53,10 +53,10 @@
         "@microsoft/api-extractor": "^7.52.8",
         "@types/chai": "^4.3.20",
         "@types/mocha": "^10.0.10",
-        "@types/node": "^22.15.19",
+        "@types/node": "^22.15.21",
         "chai": "^4.5.0",
         "eslint": "^9.27.0",
-        "mocha": "^11.3.0",
+        "mocha": "^11.5.0",
         "c8": "^10.1.3",
         "source-map-support": "^0.5.21",
         "ts-json-schema-generator": "^2.4.0",