@abaplint/core 2.113.12 → 2.113.14

package/build/abaplint.d.ts

@@ -3502,6 +3502,7 @@ declare interface InfoMethodDefinition {
     isEventHandler: boolean;
     isForTesting: boolean;
     isAbstract: boolean;
+    isFinal: boolean;
     visibility: Visibility;
     parameters: InfoMethodParameter[];
     exceptions: string[];

package/build/src/abap/4_file_information/abap_file_information.js

@@ -305,6 +305,7 @@ class ABAPFileInformation {
                 identifier: new _identifier_1.Identifier(methodName, this.filename),
                 isRedefinition: def.findDirectExpression(Expressions.Redefinition) !== undefined,
                 isForTesting: def.concatTokens().toUpperCase().includes(" FOR TESTING"),
+                isFinal: def.concatTokens().toUpperCase().includes(" FINAL"),
                 isAbstract: def.findDirectExpression(Expressions.Abstract) !== undefined,
                 isEventHandler: def.findDirectExpression(Expressions.EventHandler) !== undefined,
                 visibility,

package/build/src/registry.js

@@ -67,7 +67,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.12";
+        return "2.113.14";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/unused_methods.js

@@ -63,7 +63,7 @@ class UnusedMethods {
             extendedInformation: `Checks private and protected methods.
 
 Unused methods are not reported if the object contains parser or syntax errors.
-Quick fixes only appears for private methods.
+Quick fixes only appears for private methods or projected methods where the class doesnt have any subclasses.
 
 Skips:
 * methods FOR TESTING
@@ -156,7 +156,9 @@ Skips:
                 continue;
             }
             let fix = undefined;
-            if (i.visibility === visibility_1.Visibility.Private) {
+            if (i.visibility === visibility_1.Visibility.Private
+                || i.isFinal === true
+                || (i.visibility === visibility_1.Visibility.Protected && this.hasSubClass(obj) === false)) {
                 const implementation = this.findMethodImplementation(i, file);
                 if (implementation !== undefined) {
                     const fix1 = edit_helper_1.EditHelper.deleteStatement(file, statement);
@@ -169,6 +171,22 @@ Skips:
         }
         return issues;
     }
+    hasSubClass(obj) {
+        var _a, _b, _c;
+        if (!(obj instanceof objects_1.Class)) {
+            return false;
+        }
+        if (((_a = obj.getDefinition()) === null || _a === void 0 ? void 0 : _a.isFinal()) === true) {
+            return false;
+        }
+        for (const r of this.reg.getObjects()) {
+            if (r instanceof objects_1.Class
+                && ((_c = (_b = r.getDefinition()) === null || _b === void 0 ? void 0 : _b.getSuperClass()) === null || _c === void 0 ? void 0 : _c.toUpperCase()) === obj.getName().toUpperCase()) {
+                return true;
+            }
+        }
+        return false;
+    }
     findMethodImplementation(method, file) {
         var _a, _b;
         for (const classImplementation of ((_a = file.getStructure()) === null || _a === void 0 ? void 0 : _a.findAllStructures(Structures.ClassImplementation)) || []) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.113.12",
+    "version": "2.113.14",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",