@abaplint/core 2.113.111 → 2.113.112

package/build/abaplint.d.ts

@@ -1,7 +1,7 @@
 import * as LServer from 'vscode-languageserver-types';
 import { WorkspaceEdit } from 'vscode-languageserver-types';
 
-export declare class ABAPFile extends AbstractFile {
+declare class ABAPFile extends AbstractFile {
     private readonly tokens;
     private readonly statements;
     private readonly structure;
@@ -55,7 +55,7 @@ declare class Abstract extends Expression {
     getRunnable(): IStatementRunnable;
 }
 
-export declare abstract class AbstractFile implements IFile {
+declare abstract class AbstractFile implements IFile {
     private readonly filename;
     constructor(filename: string);
     getFilename(): string;
@@ -229,9 +229,9 @@ declare class ApplicationLogObject extends AbstractObject {
 }
 
 /** returns list of filenames which were changed */
-export declare function applyEditList(reg: IRegistry, edits: IEdit[]): string[];
+declare function applyEditList(reg: IRegistry, edits: IEdit[]): string[];
 
-export declare function applyEditSingle(reg: IRegistry, edit: IEdit): void;
+declare function applyEditSingle(reg: IRegistry, edit: IEdit): void;
 
 declare class ArithOperator extends Expression {
     getRunnable(): IStatementRunnable;
@@ -1938,6 +1938,11 @@ declare class EditorCall implements IStatement {
     getMatcher(): IStatementRunnable;
 }
 
+export declare const Edits: {
+    applyEditSingle: typeof applyEditSingle;
+    applyEditList: typeof applyEditList;
+};
+
 declare class Else implements IStructure {
     getMatcher(): IStructureRunnable;
 }
@@ -2572,6 +2577,12 @@ declare class FieldSymbol_2 extends Expression {
     getRunnable(): IStatementRunnable;
 }
 
+export declare const Files: {
+    MemoryFile: typeof MemoryFile;
+    ABAPFile: typeof ABAPFile;
+    AbstractFile: typeof AbstractFile;
+};
+
 declare class FilterBody extends Expression {
     getRunnable(): IStatementRunnable;
 }
@@ -4249,7 +4260,7 @@ declare class MaintenanceAndTransportObject extends AbstractObject {
     };
 }
 
-export declare class MemoryFile extends AbstractFile {
+declare class MemoryFile extends AbstractFile {
     private readonly raw;
     constructor(filename: string, raw: string);
     getRaw(): string;
@@ -5417,7 +5428,7 @@ declare class ReduceNext extends Expression {
     getRunnable(): IStatementRunnable;
 }
 
-declare enum ReferenceType {
+export declare enum ReferenceType {
     /** for classes and interface references */
     ObjectOrientedReference = "Object",
     ObjectOrientedVoidReference = "Object (Void)",

package/build/src/index.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.Rename = exports.PrettyPrinter = exports.Position = exports.CurrentScope = exports.ABAPFile = exports.RulesRunner = exports.SpaghettiScope = exports.SyntaxLogic = exports.ABAPObject = exports.Tokens = exports.ExpressionsCDS = exports.CDSParser = exports.LanguageServerTypes = exports.DDLParser = exports.NativeSQL = exports.MacroContent = exports.MacroCall = exports.applyEditList = exports.applyEditSingle = exports.SpaghettiScopeNode = exports.AbstractFile = exports.Token = exports.ScopeType = exports.BasicTypes = exports.TypedIdentifier = exports.AbstractType = exports.VirtualPosition = exports.Comment = exports.Unknown = exports.Empty = exports.Identifier = exports.Nodes = exports.Types = exports.Expressions = exports.Statements = exports.Structures = exports.SkipLogic = exports.Objects = exports.ArtifactsRules = exports.ArtifactsObjects = exports.ArtifactsABAP = exports.BuiltIn = exports.MethodLengthStats = exports.LanguageServer = exports.Registry = exports.CyclomaticComplexityStats = exports.Version = exports.Config = exports.Issue = exports.MemoryFile = void 0;
-exports.LSPEdit = exports.RuleTag = exports.Severity = exports.Visibility = exports.Info = exports.Diagnostics = void 0;
+exports.Info = exports.Diagnostics = exports.Rename = exports.PrettyPrinter = exports.Position = exports.CurrentScope = exports.RulesRunner = exports.SpaghettiScope = exports.SyntaxLogic = exports.ABAPObject = exports.Tokens = exports.ExpressionsCDS = exports.CDSParser = exports.LanguageServerTypes = exports.DDLParser = exports.Files = exports.Edits = exports.ReferenceType = exports.NativeSQL = exports.MacroContent = exports.MacroCall = exports.SpaghettiScopeNode = exports.Token = exports.ScopeType = exports.BasicTypes = exports.TypedIdentifier = exports.AbstractType = exports.VirtualPosition = exports.Comment = exports.Unknown = exports.Empty = exports.Identifier = exports.Nodes = exports.Types = exports.Expressions = exports.Statements = exports.Structures = exports.SkipLogic = exports.Objects = exports.ArtifactsRules = exports.ArtifactsObjects = exports.ArtifactsABAP = exports.BuiltIn = exports.MethodLengthStats = exports.LanguageServer = exports.Registry = exports.CyclomaticComplexityStats = exports.Version = exports.Config = exports.Issue = void 0;
+exports.LSPEdit = exports.RuleTag = exports.Severity = exports.Visibility = void 0;
 const issue_1 = require("./issue");
 Object.defineProperty(exports, "Issue", { enumerable: true, get: function () { return issue_1.Issue; } });
 const config_1 = require("./config");
@@ -62,7 +62,6 @@ Object.defineProperty(exports, "Position", { enumerable: true, get: function ()
 const virtual_position_1 = require("./virtual_position");
 Object.defineProperty(exports, "VirtualPosition", { enumerable: true, get: function () { return virtual_position_1.VirtualPosition; } });
 const _abstract_file_1 = require("./files/_abstract_file");
-Object.defineProperty(exports, "AbstractFile", { enumerable: true, get: function () { return _abstract_file_1.AbstractFile; } });
 const pretty_printer_1 = require("./pretty_printer/pretty_printer");
 Object.defineProperty(exports, "PrettyPrinter", { enumerable: true, get: function () { return pretty_printer_1.PrettyPrinter; } });
 const _statement_1 = require("./abap/2_statements/statements/_statement");
@@ -73,14 +72,10 @@ Object.defineProperty(exports, "MacroCall", { enumerable: true, get: function ()
 Object.defineProperty(exports, "MacroContent", { enumerable: true, get: function () { return _statement_1.MacroContent; } });
 Object.defineProperty(exports, "NativeSQL", { enumerable: true, get: function () { return _statement_1.NativeSQL; } });
 const edit_helper_1 = require("./edit_helper");
-Object.defineProperty(exports, "applyEditSingle", { enumerable: true, get: function () { return edit_helper_1.applyEditSingle; } });
-Object.defineProperty(exports, "applyEditList", { enumerable: true, get: function () { return edit_helper_1.applyEditList; } });
 const _builtin_1 = require("./abap/5_syntax/_builtin");
 Object.defineProperty(exports, "BuiltIn", { enumerable: true, get: function () { return _builtin_1.BuiltIn; } });
 const abap_file_1 = require("./abap/abap_file");
-Object.defineProperty(exports, "ABAPFile", { enumerable: true, get: function () { return abap_file_1.ABAPFile; } });
 const memory_file_1 = require("./files/memory_file");
-Object.defineProperty(exports, "MemoryFile", { enumerable: true, get: function () { return memory_file_1.MemoryFile; } });
 const renamer_1 = require("./objects/rename/renamer");
 Object.defineProperty(exports, "Rename", { enumerable: true, get: function () { return renamer_1.Renamer; } });
 const Info = require("./abap/4_file_information/_abap_file_information");
@@ -107,4 +102,19 @@ const diagnostics_1 = require("./lsp/diagnostics");
 Object.defineProperty(exports, "Diagnostics", { enumerable: true, get: function () { return diagnostics_1.Diagnostics; } });
 const _edit_1 = require("./lsp/_edit");
 Object.defineProperty(exports, "LSPEdit", { enumerable: true, get: function () { return _edit_1.LSPEdit; } });
+const _reference_1 = require("./abap/5_syntax/_reference");
+Object.defineProperty(exports, "ReferenceType", { enumerable: true, get: function () { return _reference_1.ReferenceType; } });
+// do not include this file from anywhere within abaplint
+// https://github.com/abaplint/abaplint/issues/873
+const Edits = {
+    applyEditSingle: edit_helper_1.applyEditSingle,
+    applyEditList: edit_helper_1.applyEditList,
+};
+exports.Edits = Edits;
+const Files = {
+    MemoryFile: memory_file_1.MemoryFile,
+    ABAPFile: abap_file_1.ABAPFile,
+    AbstractFile: _abstract_file_1.AbstractFile,
+};
+exports.Files = Files;
 //# sourceMappingURL=index.js.map

package/build/src/registry.js

@@ -67,7 +67,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.111";
+        return "2.113.112";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/align_parameters.js

@@ -7,7 +7,7 @@ const _abap_rule_1 = require("./_abap_rule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
 const position_1 = require("../position");
-const __1 = require("..");
+const Statements = require("../abap/2_statements/statements");
 const edit_helper_1 = require("../edit_helper");
 class AlignParametersConf extends _basic_rule_config_1.BasicRuleConfig {
 }
@@ -215,9 +215,9 @@ DATA(sdf) = VALUE type(
     }
     raiseAndCreateCandidates(stru) {
         const candidates = [];
-        const statements = stru.findAllStatements(__1.Statements.Raise);
-        statements.push(...stru.findAllStatements(__1.Statements.CreateObject));
-        statements.push(...stru.findAllStatements(__1.Statements.RaiseEvent));
+        const statements = stru.findAllStatements(Statements.Raise);
+        statements.push(...stru.findAllStatements(Statements.CreateObject));
+        statements.push(...stru.findAllStatements(Statements.RaiseEvent));
         for (const raise of statements) {
             const parameters = [];
             const param = raise.findDirectExpression(Expressions.ParameterListS);

package/build/src/rules/constant_classes.js

@@ -4,7 +4,8 @@ exports.ConstantClasses = exports.ConstantClassesConf = void 0;
 const issue_1 = require("../issue");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
-const __1 = require("..");
+const Objects = require("../objects");
+const visibility_1 = require("../abap/4_file_information/visibility");
 /** Checks that constants classes are in sync with domain fixed values */
 class ConstantClassesConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
@@ -40,7 +41,7 @@ class ConstantClasses {
     run(obj) {
         if (this.conf
             && this.conf.mapping
-            && obj instanceof __1.Objects.Domain) {
+            && obj instanceof Objects.Domain) {
             const configEntry = this.conf.mapping.find(x => x.domain.toUpperCase() === obj.getName().toUpperCase());
             if (!configEntry) {
                 return [];
@@ -84,7 +85,7 @@ class ConstantClasses {
                     issues.push(this.issueAtConstant(constant, `Use exact type ${configEntry.domain} instead of ${constant.typeName}`));
                     // quickfix will change the type
                 }
-                if (constant.visibility !== __1.Visibility.Public) {
+                if (constant.visibility !== visibility_1.Visibility.Public) {
                     issues.push(this.issueAtConstant(constant, `Constant ${constant.name} should be public`));
                     // quickfix will move constant
                 }

package/build/src/rules/function_module_recommendations.js

@@ -1,8 +1,8 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.FunctionModuleRecommendations = exports.FunctionModuleRecommendationsConf = void 0;
-const __1 = require("..");
 const expressions_1 = require("../abap/2_statements/expressions");
+const issue_1 = require("../issue");
 const _abap_rule_1 = require("./_abap_rule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
@@ -85,7 +85,7 @@ class FunctionModuleRecommendations extends _abap_rule_1.ABAPRule {
             funcName = funcName.slice(1, funcName.length - 1);
             const index = this.conf.recommendations.findIndex(i => i.name.toUpperCase() === funcName && (i.from === undefined || configVersion >= i.from));
             if (index >= 0) {
-                issues.push(__1.Issue.atToken(file, token, this.getMessage(index), this.getMetadata().key, this.conf.severity));
+                issues.push(issue_1.Issue.atToken(file, token, this.getMessage(index), this.getMetadata().key, this.conf.severity));
             }
         }
         return issues;

package/build/src/rules/method_overwrites_builtin.js

@@ -1,8 +1,8 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.MethodOverwritesBuiltIn = exports.MethodOverwritesBuiltInConf = void 0;
-const __1 = require("..");
 const _builtin_1 = require("../abap/5_syntax/_builtin");
+const issue_1 = require("../issue");
 const _abap_rule_1 = require("./_abap_rule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
@@ -52,7 +52,7 @@ ENDCLASS.`,
         for (const method of methods) {
             if (builtIn.searchBuiltin(method.name.toUpperCase())) {
                 const message = `Method name "${method.name}" overwrites built-in SAP function name`;
-                issues.push(__1.Issue.atIdentifier(method.identifier, message, this.getMetadata().key));
+                issues.push(issue_1.Issue.atIdentifier(method.identifier, message, this.getMetadata().key));
             }
         }
         return issues;

package/build/src/rules/prefer_raise_exception_new.js

@@ -6,7 +6,8 @@ const _abap_rule_1 = require("./_abap_rule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const edit_helper_1 = require("../edit_helper");
 const _irule_1 = require("./_irule");
-const __1 = require("..");
+const version_1 = require("../version");
+const Statements = require("../abap/2_statements/statements");
 class PreferRaiseExceptionNewConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.PreferRaiseExceptionNewConf = PreferRaiseExceptionNewConf;
@@ -38,12 +39,12 @@ From 752 and up`,
         this.conf = conf;
     }
     runParsed(file) {
-        if (this.reg.getConfig().getVersion() < __1.Version.v752) {
+        if (this.reg.getConfig().getVersion() < version_1.Version.v752) {
             return [];
         }
         const issues = [];
         for (const statement of file.getStatements()) {
-            if (statement.get() instanceof __1.Statements.Raise) {
+            if (statement.get() instanceof Statements.Raise) {
                 const concat = statement.concatTokens().toUpperCase();
                 if (concat.includes(" MESSAGE")) {
                     continue;

package/build/src/rules/select_single_full_key.js

@@ -1,11 +1,15 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.SelectSingleFullKey = exports.SelectSingleFullKeyConf = void 0;
-const issue_1 = require("../issue");
+const _abap_object_1 = require("../objects/_abap_object");
 const _basic_rule_config_1 = require("./_basic_rule_config");
-const _irule_1 = require("./_irule");
-const __1 = require("..");
 const edit_helper_1 = require("../edit_helper");
+const _irule_1 = require("./_irule");
+const issue_1 = require("../issue");
+const syntax_1 = require("../abap/5_syntax/syntax");
+const Expressions = require("../abap/2_statements/expressions");
+const Statements = require("../abap/2_statements/statements");
+const _statement_1 = require("../abap/2_statements/statements/_statement");
 class SelectSingleFullKeyConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
@@ -55,10 +59,10 @@ If the statement contains a JOIN it is not checked`,
     }
     run(obj) {
         var _a, _b;
-        if (!(obj instanceof __1.ABAPObject)) {
+        if (!(obj instanceof _abap_object_1.ABAPObject)) {
             return [];
         }
-        const syntax = new __1.SyntaxLogic(this.reg, obj).run();
+        const syntax = new syntax_1.SyntaxLogic(this.reg, obj).run();
         if (syntax.issues.length > 0) {
             return [];
         }
@@ -68,21 +72,21 @@ If the statement contains a JOIN it is not checked`,
             const statements = file.getStatements();
             for (let i = 0; i < statements.length; i++) {
                 const s = statements[i];
-                if (!(s.get() instanceof __1.Statements.Select)) {
+                if (!(s.get() instanceof Statements.Select)) {
                     continue;
                 }
-                else if (s.findFirstExpression(__1.Expressions.SQLJoin)) {
+                else if (s.findFirstExpression(Expressions.SQLJoin)) {
                     continue;
                 }
                 else if (s.findTokenSequencePosition("SELECT", "SINGLE") === undefined) {
                     continue;
                 }
-                const databaseTable = s.findFirstExpression(__1.Expressions.DatabaseTable);
+                const databaseTable = s.findFirstExpression(Expressions.DatabaseTable);
                 if (databaseTable === undefined) {
                     continue;
                 }
                 const next = statements[i + 1];
-                if ((next === null || next === void 0 ? void 0 : next.get()) instanceof __1.Comment
+                if ((next === null || next === void 0 ? void 0 : next.get()) instanceof _statement_1.Comment
                     && next.concatTokens().includes(this.getMetadata().pseudoComment + "")) {
                     if (this.getConfig().allowPseudo !== true) {
                         issues.push(issue_1.Issue.atStatement(file, s, "Pseudo comment not allowed", this.getMetadata().key, this.getConfig().severity));
@@ -95,7 +99,7 @@ If the statement contains a JOIN it is not checked`,
                     continue;
                 }
                 const keys = table.listKeys(this.reg);
-                const cond = s.findFirstExpression(__1.Expressions.SQLCond);
+                const cond = s.findFirstExpression(Expressions.SQLCond);
                 const set = new Set();
                 for (const key of keys) {
                     if (key === "MANDT") {
@@ -104,10 +108,10 @@ If the statement contains a JOIN it is not checked`,
                     }
                     set.add(key);
                 }
-                for (const compare of (cond === null || cond === void 0 ? void 0 : cond.findAllExpressionsRecursive(__1.Expressions.SQLCompare)) || []) {
+                for (const compare of (cond === null || cond === void 0 ? void 0 : cond.findAllExpressionsRecursive(Expressions.SQLCompare)) || []) {
                     if (compare.getChildren().length === 3) {
-                        const fname = (_a = compare.findDirectExpression(__1.Expressions.SQLFieldName)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
-                        const operator = (_b = compare.findDirectExpression(__1.Expressions.SQLCompareOperator)) === null || _b === void 0 ? void 0 : _b.concatTokens().toUpperCase();
+                        const fname = (_a = compare.findDirectExpression(Expressions.SQLFieldName)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
+                        const operator = (_b = compare.findDirectExpression(Expressions.SQLCompareOperator)) === null || _b === void 0 ? void 0 : _b.concatTokens().toUpperCase();
                         if (fname && (operator === "=" || operator === "EQ")) {
                             set.delete(fname);
                         }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.113.111",
+    "version": "2.113.112",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",