@abaplint/core 2.113.11 → 2.113.13

package/build/src/registry.js

@@ -67,7 +67,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.113.11";
+        return "2.113.13";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/unused_methods.js

@@ -63,6 +63,7 @@ class UnusedMethods {
             extendedInformation: `Checks private and protected methods.
 
 Unused methods are not reported if the object contains parser or syntax errors.
+Quick fixes only appears for private methods or projected methods where the class doesnt have any subclasses.
 
 Skips:
 * methods FOR TESTING
@@ -154,18 +155,37 @@ Skips:
             else if (this.suppressedbyPseudo(statement, file)) {
                 continue;
             }
-            const implementation = this.findMethodImplementation(i, file);
             let fix = undefined;
-            if (implementation !== undefined) {
-                const fix1 = edit_helper_1.EditHelper.deleteStatement(file, statement);
-                const fix2 = edit_helper_1.EditHelper.deleteRange(file, implementation.getFirstToken().getStart(), implementation.getLastToken().getEnd());
-                fix = edit_helper_1.EditHelper.merge(fix1, fix2);
+            if (i.visibility === visibility_1.Visibility.Private
+                || (i.visibility === visibility_1.Visibility.Protected && this.hasSubClass(obj) === false)) {
+                const implementation = this.findMethodImplementation(i, file);
+                if (implementation !== undefined) {
+                    const fix1 = edit_helper_1.EditHelper.deleteStatement(file, statement);
+                    const fix2 = edit_helper_1.EditHelper.deleteRange(file, implementation.getFirstToken().getStart(), implementation.getLastToken().getEnd());
+                    fix = edit_helper_1.EditHelper.merge(fix1, fix2);
+                }
             }
             const message = "Method \"" + i.identifier.getName() + "\" not used";
             issues.push(issue_1.Issue.atIdentifier(i.identifier, message, this.getMetadata().key, this.conf.severity, fix));
         }
         return issues;
     }
+    hasSubClass(obj) {
+        var _a, _b, _c;
+        if (!(obj instanceof objects_1.Class)) {
+            return false;
+        }
+        if (((_a = obj.getDefinition()) === null || _a === void 0 ? void 0 : _a.isFinal()) === true) {
+            return false;
+        }
+        for (const r of this.reg.getObjects()) {
+            if (r instanceof objects_1.Class
+                && ((_c = (_b = r.getDefinition()) === null || _b === void 0 ? void 0 : _b.getSuperClass()) === null || _c === void 0 ? void 0 : _c.toUpperCase()) === obj.getName().toUpperCase()) {
+                return true;
+            }
+        }
+        return false;
+    }
     findMethodImplementation(method, file) {
         var _a, _b;
         for (const classImplementation of ((_a = file.getStructure()) === null || _a === void 0 ? void 0 : _a.findAllStructures(Structures.ClassImplementation)) || []) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.113.11",
+    "version": "2.113.13",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",