@abaplint/core 2.112.18 → 2.112.20

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (110) hide show
  1. package/README.md +6 -6
  2. package/build/abaplint.d.ts +2 -0
  3. package/build/src/abap/flow/flow_graph.js +7 -7
  4. package/build/src/abap/flow/statement_flow.js +77 -10
  5. package/build/src/lsp/help.js +7 -7
  6. package/build/src/registry.js +1 -1
  7. package/build/src/rules/7bit_ascii.js +4 -4
  8. package/build/src/rules/abapdoc.js +4 -4
  9. package/build/src/rules/align_parameters.js +40 -40
  10. package/build/src/rules/align_type_expressions.js +28 -28
  11. package/build/src/rules/ambiguous_statement.js +6 -6
  12. package/build/src/rules/avoid_use.js +10 -10
  13. package/build/src/rules/begin_end_names.js +4 -4
  14. package/build/src/rules/begin_single_include.js +13 -13
  15. package/build/src/rules/call_transaction_authority_check.js +3 -3
  16. package/build/src/rules/cds_comment_style.js +4 -4
  17. package/build/src/rules/cds_legacy_view.js +4 -4
  18. package/build/src/rules/chain_mainly_declarations.js +4 -4
  19. package/build/src/rules/change_if_to_case.js +8 -8
  20. package/build/src/rules/check_abstract.js +2 -2
  21. package/build/src/rules/check_comments.js +4 -4
  22. package/build/src/rules/check_include.js +3 -3
  23. package/build/src/rules/check_subrc.js +8 -8
  24. package/build/src/rules/classic_exceptions_overlap.js +10 -10
  25. package/build/src/rules/commented_code.js +1 -1
  26. package/build/src/rules/constructor_visibility_public.js +4 -4
  27. package/build/src/rules/contains_tab.js +2 -2
  28. package/build/src/rules/cyclic_oo.js +4 -4
  29. package/build/src/rules/dangerous_statement.js +1 -1
  30. package/build/src/rules/definitions_top.js +6 -6
  31. package/build/src/rules/downport.js +82 -82
  32. package/build/src/rules/easy_to_find_messages.js +6 -6
  33. package/build/src/rules/empty_line_in_statement.js +2 -2
  34. package/build/src/rules/empty_structure.js +6 -6
  35. package/build/src/rules/exit_or_check.js +3 -3
  36. package/build/src/rules/expand_macros.js +5 -5
  37. package/build/src/rules/exporting.js +1 -1
  38. package/build/src/rules/forbidden_identifier.js +1 -1
  39. package/build/src/rules/forbidden_void_type.js +2 -2
  40. package/build/src/rules/fully_type_itabs.js +1 -1
  41. package/build/src/rules/functional_writing.js +17 -17
  42. package/build/src/rules/global_class.js +8 -8
  43. package/build/src/rules/identical_conditions.js +12 -12
  44. package/build/src/rules/identical_contents.js +14 -14
  45. package/build/src/rules/identical_descriptions.js +6 -6
  46. package/build/src/rules/if_in_if.js +35 -35
  47. package/build/src/rules/implement_methods.js +3 -3
  48. package/build/src/rules/in_statement_indentation.js +11 -11
  49. package/build/src/rules/indentation.js +16 -16
  50. package/build/src/rules/intf_referencing_clas.js +3 -3
  51. package/build/src/rules/invalid_table_index.js +2 -2
  52. package/build/src/rules/line_break_style.js +2 -2
  53. package/build/src/rules/line_length.js +1 -1
  54. package/build/src/rules/line_only_punc.js +1 -1
  55. package/build/src/rules/local_variable_names.js +6 -6
  56. package/build/src/rules/macro_naming.js +2 -2
  57. package/build/src/rules/main_file_contents.js +4 -4
  58. package/build/src/rules/many_parentheses.js +10 -10
  59. package/build/src/rules/max_one_method_parameter_per_line.js +7 -7
  60. package/build/src/rules/max_one_statement.js +5 -5
  61. package/build/src/rules/method_length.js +2 -2
  62. package/build/src/rules/method_overwrites_builtin.js +12 -12
  63. package/build/src/rules/mix_returning.js +6 -6
  64. package/build/src/rules/nesting.js +1 -1
  65. package/build/src/rules/no_chained_assignment.js +1 -1
  66. package/build/src/rules/no_external_form_calls.js +2 -2
  67. package/build/src/rules/no_inline_in_optional_branches.js +11 -11
  68. package/build/src/rules/no_prefixes.js +6 -6
  69. package/build/src/rules/no_public_attributes.js +1 -1
  70. package/build/src/rules/no_yoda_conditions.js +4 -4
  71. package/build/src/rules/nrob_consistency.js +2 -2
  72. package/build/src/rules/obsolete_statement.js +51 -51
  73. package/build/src/rules/omit_parameter_name.js +3 -3
  74. package/build/src/rules/omit_receiving.js +13 -13
  75. package/build/src/rules/parser_702_chaining.js +2 -2
  76. package/build/src/rules/parser_error.js +2 -2
  77. package/build/src/rules/parser_missing_space.js +1 -1
  78. package/build/src/rules/prefer_inline.js +16 -16
  79. package/build/src/rules/prefer_is_not.js +9 -9
  80. package/build/src/rules/prefer_raise_exception_new.js +5 -5
  81. package/build/src/rules/prefer_returning_to_exporting.js +4 -4
  82. package/build/src/rules/prefer_xsdbool.js +2 -2
  83. package/build/src/rules/preferred_compare_operator.js +2 -2
  84. package/build/src/rules/reduce_procedural_code.js +17 -17
  85. package/build/src/rules/remove_descriptions.js +4 -4
  86. package/build/src/rules/rfc_error_handling.js +7 -7
  87. package/build/src/rules/select_add_order_by.js +5 -5
  88. package/build/src/rules/select_performance.js +5 -5
  89. package/build/src/rules/select_single_full_key.js +2 -2
  90. package/build/src/rules/sicf_consistency.js +2 -2
  91. package/build/src/rules/slow_parameter_passing.js +16 -16
  92. package/build/src/rules/space_before_dot.js +2 -2
  93. package/build/src/rules/sql_value_conversion.js +6 -6
  94. package/build/src/rules/start_at_tab.js +1 -1
  95. package/build/src/rules/strict_sql.js +6 -6
  96. package/build/src/rules/sy_modification.js +3 -3
  97. package/build/src/rules/tabl_enhancement_category.js +2 -2
  98. package/build/src/rules/tables_declared_locally.js +2 -2
  99. package/build/src/rules/type_form_parameters.js +2 -2
  100. package/build/src/rules/unnecessary_pragma.js +29 -29
  101. package/build/src/rules/unnecessary_return.js +11 -11
  102. package/build/src/rules/unused_macros.js +6 -6
  103. package/build/src/rules/unused_methods.js +11 -11
  104. package/build/src/rules/unused_variables.js +12 -12
  105. package/build/src/rules/use_bool_expression.js +8 -8
  106. package/build/src/rules/use_class_based_exceptions.js +8 -8
  107. package/build/src/rules/use_line_exists.js +6 -6
  108. package/build/src/rules/use_new.js +4 -4
  109. package/build/src/rules/when_others_last.js +6 -6
  110. package/package.json +70 -70
@@ -21,17 +21,17 @@ class ClassicExceptionsOverlap extends _abap_rule_1.ABAPRule {
21
21
  shortDescription: `Find overlapping classic exceptions`,
22
22
  extendedInformation: `When debugging its typically good to know exactly which exception is caught`,
23
23
  tags: [_irule_1.RuleTag.SingleFile],
24
- badExample: `CALL FUNCTION 'SOMETHING'
25
- EXCEPTIONS
26
- system_failure = 1 MESSAGE lv_message
27
- communication_failure = 1 MESSAGE lv_message
28
- resource_failure = 1
24
+ badExample: `CALL FUNCTION 'SOMETHING'
25
+ EXCEPTIONS
26
+ system_failure = 1 MESSAGE lv_message
27
+ communication_failure = 1 MESSAGE lv_message
28
+ resource_failure = 1
29
29
  OTHERS = 1.`,
30
- goodExample: `CALL FUNCTION 'SOMETHING'
31
- EXCEPTIONS
32
- system_failure = 1 MESSAGE lv_message
33
- communication_failure = 2 MESSAGE lv_message
34
- resource_failure = 3
30
+ goodExample: `CALL FUNCTION 'SOMETHING'
31
+ EXCEPTIONS
32
+ system_failure = 1 MESSAGE lv_message
33
+ communication_failure = 2 MESSAGE lv_message
34
+ resource_failure = 3
35
35
  OTHERS = 4.`,
36
36
  };
37
37
  }
@@ -30,7 +30,7 @@ class CommentedCode extends _abap_rule_1.ABAPRule {
30
30
  key: "commented_code",
31
31
  title: "Find commented code",
32
32
  shortDescription: `Detects usage of commented out code.`,
33
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
33
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#delete-code-instead-of-commenting-it
34
34
  https://docs.abapopenchecks.org/checks/14/`,
35
35
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
36
36
  badExample: `* WRITE 'hello world'.`,
@@ -18,10 +18,10 @@ class ConstructorVisibilityPublic {
18
18
  key: "constructor_visibility_public",
19
19
  title: "Check constructor visibility is public",
20
20
  shortDescription: `Constructor must be placed in the public section, even if the class is not CREATE PUBLIC.`,
21
- extendedInformation: `
22
- This only applies to global classes.
23
-
24
- https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
21
+ extendedInformation: `
22
+ This only applies to global classes.
23
+
24
+ https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#if-your-global-class-is-create-private-leave-the-constructor-public
25
25
  https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abeninstance_constructor_guidl.htm`,
26
26
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
27
27
  };
@@ -25,8 +25,8 @@ class ContainsTab extends _abap_rule_1.ABAPRule {
25
25
  key: "contains_tab",
26
26
  title: "Code contains tab",
27
27
  shortDescription: `Checks for usage of tabs (enable to enforce spaces)`,
28
- extendedInformation: `
29
- https://docs.abapopenchecks.org/checks/09/
28
+ extendedInformation: `
29
+ https://docs.abapopenchecks.org/checks/09/
30
30
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#indent-and-snap-to-tab`,
31
31
  tags: [_irule_1.RuleTag.Whitespace, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
32
32
  badExample: `\tWRITE 'hello world'.`,
@@ -32,10 +32,10 @@ class CyclicOO {
32
32
  key: "cyclic_oo",
33
33
  title: "Cyclic OO",
34
34
  shortDescription: `Finds cyclic/circular OO references`,
35
- extendedInformation: `Runs for global INTF + CLAS objects
36
-
37
- Objects must be without syntax errors for this rule to take effect
38
-
35
+ extendedInformation: `Runs for global INTF + CLAS objects
36
+
37
+ Objects must be without syntax errors for this rule to take effect
38
+
39
39
  References in testclass includes are ignored`,
40
40
  };
41
41
  }
@@ -40,7 +40,7 @@ class DangerousStatement extends _abap_rule_1.ABAPRule {
40
40
  key: "dangerous_statement",
41
41
  title: "Dangerous statement",
42
42
  shortDescription: `Detects potentially dangerous statements`,
43
- extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
43
+ extendedInformation: `Dynamic SQL: Typically ABAP logic does not need dynamic SQL,
44
44
  dynamic SQL can potentially create SQL injection problems`,
45
45
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Security],
46
46
  };
@@ -30,13 +30,13 @@ class DefinitionsTop extends _abap_rule_1.ABAPRule {
30
30
  shortDescription: `Checks that definitions are placed at the beginning of METHODs, FORMs and FUNCTIONs.`,
31
31
  extendedInformation: `https://docs.abapopenchecks.org/checks/17/`,
32
32
  tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
33
- badExample: `FROM foo.
34
- WRITE 'hello'.
35
- DATA int TYPE i.
33
+ badExample: `FROM foo.
34
+ WRITE 'hello'.
35
+ DATA int TYPE i.
36
36
  ENDFORM.`,
37
- goodExample: `FROM foo.
38
- DATA int TYPE i.
39
- WRITE 'hello'.
37
+ goodExample: `FROM foo.
38
+ DATA int TYPE i.
39
+ WRITE 'hello'.
40
40
  ENDFORM.`,
41
41
  };
42
42
  }
@@ -125,39 +125,39 @@ class Downport {
125
125
  key: "downport",
126
126
  title: "Downport statement",
127
127
  shortDescription: `Downport functionality`,
128
- extendedInformation: `Much like the 'commented_code' rule this rule loops through unknown statements and tries parsing with
129
- a higher level language version. If successful, various rules are applied to downport the statement.
130
- Target downport version is always v702, thus rule is only enabled if target version is v702.
131
-
132
- Current rules:
133
- * NEW transformed to CREATE OBJECT, opposite of https://rules.abaplint.org/use_new/
134
- * DATA() definitions are outlined, opposite of https://rules.abaplint.org/prefer_inline/
135
- * FIELD-SYMBOL() definitions are outlined
136
- * CONV is outlined
137
- * COND is outlined
138
- * REDUCE is outlined
139
- * SWITCH is outlined
140
- * FILTER is outlined
141
- * APPEND expression is outlined
142
- * INSERT expression is outlined
143
- * EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
144
- * CAST changed to ?=
145
- * LOOP AT method_call( ) is outlined
146
- * VALUE # with structure fields
147
- * VALUE # with internal table lines
148
- * Table Expressions are outlined
149
- * SELECT INTO @DATA definitions are outlined
150
- * Some occurrences of string template formatting option ALPHA changed to function module call
151
- * SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
152
- * PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
153
- * RAISE EXCEPTION ... MESSAGE
154
- * Moving with +=, -=, /=, *=, &&= is expanded
155
- * line_exists and line_index is downported to READ TABLE
156
- * ENUMs, but does not nessesarily give the correct type and value
157
- * MESSAGE with non simple source
158
-
159
- Only one transformation is applied to a statement at a time, so multiple steps might be required to do the full downport.
160
-
128
+ extendedInformation: `Much like the 'commented_code' rule this rule loops through unknown statements and tries parsing with
129
+ a higher level language version. If successful, various rules are applied to downport the statement.
130
+ Target downport version is always v702, thus rule is only enabled if target version is v702.
131
+
132
+ Current rules:
133
+ * NEW transformed to CREATE OBJECT, opposite of https://rules.abaplint.org/use_new/
134
+ * DATA() definitions are outlined, opposite of https://rules.abaplint.org/prefer_inline/
135
+ * FIELD-SYMBOL() definitions are outlined
136
+ * CONV is outlined
137
+ * COND is outlined
138
+ * REDUCE is outlined
139
+ * SWITCH is outlined
140
+ * FILTER is outlined
141
+ * APPEND expression is outlined
142
+ * INSERT expression is outlined
143
+ * EMPTY KEY is changed to DEFAULT KEY, opposite of DEFAULT KEY in https://rules.abaplint.org/avoid_use/
144
+ * CAST changed to ?=
145
+ * LOOP AT method_call( ) is outlined
146
+ * VALUE # with structure fields
147
+ * VALUE # with internal table lines
148
+ * Table Expressions are outlined
149
+ * SELECT INTO @DATA definitions are outlined
150
+ * Some occurrences of string template formatting option ALPHA changed to function module call
151
+ * SELECT/INSERT/MODIFY/DELETE/UPDATE "," in field list removed, "@" in source/targets removed
152
+ * PARTIALLY IMPLEMENTED removed, it can be quick fixed via rule implement_methods
153
+ * RAISE EXCEPTION ... MESSAGE
154
+ * Moving with +=, -=, /=, *=, &&= is expanded
155
+ * line_exists and line_index is downported to READ TABLE
156
+ * ENUMs, but does not nessesarily give the correct type and value
157
+ * MESSAGE with non simple source
158
+
159
+ Only one transformation is applied to a statement at a time, so multiple steps might be required to do the full downport.
160
+
161
161
  Make sure to test the downported code, it might not always be completely correct.`,
162
162
  tags: [_irule_1.RuleTag.Downport, _irule_1.RuleTag.Quickfix],
163
163
  };
@@ -735,10 +735,10 @@ Make sure to test the downported code, it might not always be completely correct
735
735
  const fieldName = f.concatTokens();
736
736
  fieldDefinition += indentation + " " + fieldName + " TYPE " + tableName + "-" + fieldName + ",\n";
737
737
  }
738
- fieldDefinition = `DATA: BEGIN OF ${name},
738
+ fieldDefinition = `DATA: BEGIN OF ${name},
739
739
  ${fieldDefinition}${indentation} END OF ${name}.`;
740
740
  }
741
- const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `${fieldDefinition}
741
+ const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `${fieldDefinition}
742
742
  ${indentation}`);
743
743
  const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
744
744
  const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -782,12 +782,12 @@ ${indentation}`);
782
782
  }
783
783
  const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
784
784
  const name = ((_c = inlineData.findFirstExpression(Expressions.TargetField)) === null || _c === void 0 ? void 0 : _c.concatTokens()) || "error";
785
- let fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
786
- ${fieldDefinitions}${indentation} END OF ${uniqueName}.
787
- ${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
785
+ let fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `TYPES: BEGIN OF ${uniqueName},
786
+ ${fieldDefinitions}${indentation} END OF ${uniqueName}.
787
+ ${indentation}DATA ${name} TYPE STANDARD TABLE OF ${uniqueName} WITH DEFAULT KEY.
788
788
  ${indentation}`);
789
789
  if (fieldDefinitions === "") {
790
- fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `DATA ${name} TYPE STANDARD TABLE OF ${tableName} WITH DEFAULT KEY.
790
+ fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getStart(), `DATA ${name} TYPE STANDARD TABLE OF ${tableName} WITH DEFAULT KEY.
791
791
  ${indentation}`);
792
792
  }
793
793
  const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, inlineData.getFirstToken().getStart(), inlineData.getLastToken().getEnd(), name);
@@ -855,7 +855,7 @@ ${indentation}`);
855
855
  const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
856
856
  const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
857
857
  const firstToken = high.getFirstToken();
858
- const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
858
+ const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
859
859
  ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
860
860
  const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, source.getFirstToken().getStart(), source.getLastToken().getEnd(), uniqueName);
861
861
  const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -909,7 +909,7 @@ ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
909
909
  const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
910
910
  const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
911
911
  const firstToken = high.getFirstToken();
912
- const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
912
+ const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${target === null || target === void 0 ? void 0 : target.concatTokens()}.
913
913
  ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
914
914
  const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, source.getFirstToken().getStart(), source.getLastToken().getEnd(), uniqueName);
915
915
  const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -951,14 +951,14 @@ ${indentation}${uniqueName} = ${source.concatTokens()}.\n${indentation}`);
951
951
  const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
952
952
  const firstToken = high.getFirstToken();
953
953
  // note that the tabix restore should be done before throwing the exception
954
- const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
955
- ${indentation}DATA ${tabixBackup} LIKE sy-tabix.
956
- ${indentation}${tabixBackup} = sy-tabix.
957
- ${indentation}READ TABLE ${pre} ${condition}INTO ${uniqueName}.
958
- ${indentation}sy-tabix = ${tabixBackup}.
959
- ${indentation}IF sy-subrc <> 0.
960
- ${indentation} RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
961
- ${indentation}ENDIF.
954
+ const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, firstToken.getStart(), `DATA ${uniqueName} LIKE LINE OF ${pre}.
955
+ ${indentation}DATA ${tabixBackup} LIKE sy-tabix.
956
+ ${indentation}${tabixBackup} = sy-tabix.
957
+ ${indentation}READ TABLE ${pre} ${condition}INTO ${uniqueName}.
958
+ ${indentation}sy-tabix = ${tabixBackup}.
959
+ ${indentation}IF sy-subrc <> 0.
960
+ ${indentation} RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
961
+ ${indentation}ENDIF.
962
962
  ${indentation}`);
963
963
  const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, startToken.getStart(), tableExpression.getLastToken().getEnd(), uniqueName);
964
964
  const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
@@ -1015,7 +1015,7 @@ ${indentation}`);
1015
1015
  const className = classNames[0].concatTokens();
1016
1016
  const targetName = (_b = target.findFirstExpression(Expressions.TargetField)) === null || _b === void 0 ? void 0 : _b.concatTokens();
1017
1017
  const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
1018
- const code = ` DATA ${targetName} TYPE REF TO ${className}.
1018
+ const code = ` DATA ${targetName} TYPE REF TO ${className}.
1019
1019
  ${indentation}CATCH ${className} INTO ${targetName}.`;
1020
1020
  const fix = edit_helper_1.EditHelper.replaceRange(lowFile, node.getStart(), node.getEnd(), code);
1021
1021
  return issue_1.Issue.atToken(lowFile, node.getFirstToken(), "Outline DATA", this.getMetadata().key, this.conf.severity, fix);
@@ -1177,16 +1177,16 @@ ${indentation}CATCH ${className} INTO ${targetName}.`;
1177
1177
  const uniqueName1 = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
1178
1178
  const uniqueName2 = this.uniqueName(node.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
1179
1179
  const indentation = " ".repeat(node.getFirstToken().getStart().getCol() - 1);
1180
- let abap = `DATA ${uniqueName1} LIKE if_t100_message=>t100key.
1181
- ${indentation}${uniqueName1}-msgid = ${id}.
1180
+ let abap = `DATA ${uniqueName1} LIKE if_t100_message=>t100key.
1181
+ ${indentation}${uniqueName1}-msgid = ${id}.
1182
1182
  ${indentation}${uniqueName1}-msgno = ${number}.\n`;
1183
1183
  if (withs.length > 0) {
1184
- abap += `${indentation}${uniqueName1}-attr1 = 'IF_T100_DYN_MSG~MSGV1'.
1185
- ${indentation}${uniqueName1}-attr2 = 'IF_T100_DYN_MSG~MSGV2'.
1186
- ${indentation}${uniqueName1}-attr3 = 'IF_T100_DYN_MSG~MSGV3'.
1184
+ abap += `${indentation}${uniqueName1}-attr1 = 'IF_T100_DYN_MSG~MSGV1'.
1185
+ ${indentation}${uniqueName1}-attr2 = 'IF_T100_DYN_MSG~MSGV2'.
1186
+ ${indentation}${uniqueName1}-attr3 = 'IF_T100_DYN_MSG~MSGV3'.
1187
1187
  ${indentation}${uniqueName1}-attr4 = 'IF_T100_DYN_MSG~MSGV4'.\n`;
1188
1188
  }
1189
- abap += `${indentation}DATA ${uniqueName2} TYPE REF TO ${className}.
1189
+ abap += `${indentation}DATA ${uniqueName2} TYPE REF TO ${className}.
1190
1190
  ${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.\n`;
1191
1191
  if (withs.length > 0) {
1192
1192
  abap += `${indentation}${uniqueName2}->if_t100_dyn_msg~msgty = 'E'.\n`;
@@ -1298,10 +1298,10 @@ ${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.\n`
1298
1298
  let code = "";
1299
1299
  if (sourceRef.findFirstExpression(Expressions.TableExpression)) {
1300
1300
  const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
1301
- code = `ASSIGN ${sourceRef.concatTokens()} TO FIELD-SYMBOL(<${uniqueName}>).
1302
- IF sy-subrc <> 0.
1303
- RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
1304
- ENDIF.
1301
+ code = `ASSIGN ${sourceRef.concatTokens()} TO FIELD-SYMBOL(<${uniqueName}>).
1302
+ IF sy-subrc <> 0.
1303
+ RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
1304
+ ENDIF.
1305
1305
  GET REFERENCE OF <${uniqueName}> INTO ${target.concatTokens()}`;
1306
1306
  }
1307
1307
  else {
@@ -1390,20 +1390,20 @@ GET REFERENCE OF <${uniqueName}> INTO ${target.concatTokens()}`;
1390
1390
  const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
1391
1391
  const uniqueFS = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
1392
1392
  const uniqueNameIndex = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
1393
- code += ` items LIKE ${loopSourceName},
1394
- END OF ${groupTargetName}type.
1395
- DATA ${groupTargetName}tab TYPE STANDARD TABLE OF ${groupTargetName}type WITH DEFAULT KEY.
1396
- DATA ${uniqueName} LIKE LINE OF ${groupTargetName}tab.
1393
+ code += ` items LIKE ${loopSourceName},
1394
+ END OF ${groupTargetName}type.
1395
+ DATA ${groupTargetName}tab TYPE STANDARD TABLE OF ${groupTargetName}type WITH DEFAULT KEY.
1396
+ DATA ${uniqueName} LIKE LINE OF ${groupTargetName}tab.
1397
1397
  LOOP AT ${loopSourceName} ${(_l = high.findFirstExpression(Expressions.LoopTarget)) === null || _l === void 0 ? void 0 : _l.concatTokens()}.\n`;
1398
1398
  if (groupIndexName !== undefined) {
1399
1399
  code += `DATA(${uniqueNameIndex}) = sy-tabix.\n`;
1400
1400
  }
1401
- code += `READ TABLE ${groupTargetName}tab ASSIGNING FIELD-SYMBOL(<${uniqueFS}>) WITH KEY ${condition}.
1401
+ code += `READ TABLE ${groupTargetName}tab ASSIGNING FIELD-SYMBOL(<${uniqueFS}>) WITH KEY ${condition}.
1402
1402
  IF sy-subrc = 0.\n`;
1403
1403
  if (groupCountName !== undefined) {
1404
1404
  code += ` <${uniqueFS}>-${groupCountName} = <${uniqueFS}>-${groupCountName} + 1.\n`;
1405
1405
  }
1406
- code += ` INSERT ${loopTargetName}${isReference ? "->*" : ""} INTO TABLE <${uniqueFS}>-items.
1406
+ code += ` INSERT ${loopTargetName}${isReference ? "->*" : ""} INTO TABLE <${uniqueFS}>-items.
1407
1407
  ELSE.\n`;
1408
1408
  code += ` CLEAR ${uniqueName}.\n`;
1409
1409
  for (const c of group.findAllExpressions(Expressions.LoopGroupByComponent)) {
@@ -1424,8 +1424,8 @@ ELSE.\n`;
1424
1424
  }
1425
1425
  code += ` INSERT ${loopTargetName}${isReference ? "->*" : ""} INTO TABLE ${uniqueName}-items.\n`;
1426
1426
  code += ` INSERT ${uniqueName} INTO TABLE ${groupTargetName}tab.\n`;
1427
- code += `ENDIF.
1428
- ENDLOOP.
1427
+ code += `ENDIF.
1428
+ ENDLOOP.
1429
1429
  LOOP AT ${groupTargetName}tab ${groupTarget}.`;
1430
1430
  let fix = edit_helper_1.EditHelper.replaceRange(lowFile, high.getFirstToken().getStart(), high.getLastToken().getEnd(), code);
1431
1431
  for (const l of ((_m = highFile.getStructure()) === null || _m === void 0 ? void 0 : _m.findAllStructures(Structures.Loop)) || []) {
@@ -1597,7 +1597,7 @@ LOOP AT ${groupTargetName}tab ${groupTarget}.`;
1597
1597
  const enumName = (_b = high.findExpressionAfterToken("ENUM")) === null || _b === void 0 ? void 0 : _b.concatTokens();
1598
1598
  const structureName = (_c = high.findExpressionAfterToken("STRUCTURE")) === null || _c === void 0 ? void 0 : _c.concatTokens();
1599
1599
  // all ENUMS are char like?
1600
- let code = `TYPES ${enumName} TYPE string.
1600
+ let code = `TYPES ${enumName} TYPE string.
1601
1601
  CONSTANTS: BEGIN OF ${structureName},\n`;
1602
1602
  let count = 1;
1603
1603
  for (const e of enumStructure.findDirectStatements(Statements.TypeEnum).concat(enumStructure.findDirectStatements(Statements.Type))) {
@@ -1641,14 +1641,14 @@ CONSTANTS: BEGIN OF ${structureName},\n`;
1641
1641
  const tabixBackup = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
1642
1642
  const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
1643
1643
  // restore tabix before exeption
1644
- const code = `FIELD-SYMBOLS ${uniqueName} LIKE LINE OF ${tName}.
1645
- ${indentation}DATA ${tabixBackup} LIKE sy-tabix.
1646
- ${indentation}${tabixBackup} = sy-tabix.
1647
- ${indentation}READ TABLE ${tName} ${condition}ASSIGNING ${uniqueName}.
1648
- ${indentation}sy-tabix = ${tabixBackup}.
1649
- ${indentation}IF sy-subrc <> 0.
1650
- ${indentation} RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
1651
- ${indentation}ENDIF.
1644
+ const code = `FIELD-SYMBOLS ${uniqueName} LIKE LINE OF ${tName}.
1645
+ ${indentation}DATA ${tabixBackup} LIKE sy-tabix.
1646
+ ${indentation}${tabixBackup} = sy-tabix.
1647
+ ${indentation}READ TABLE ${tName} ${condition}ASSIGNING ${uniqueName}.
1648
+ ${indentation}sy-tabix = ${tabixBackup}.
1649
+ ${indentation}IF sy-subrc <> 0.
1650
+ ${indentation} RAISE EXCEPTION TYPE cx_sy_itab_line_not_found.
1651
+ ${indentation}ENDIF.
1652
1652
  ${indentation}${uniqueName}`;
1653
1653
  const start = target.getFirstToken().getStart();
1654
1654
  const end = (_a = tableExpression.findDirectTokenByText("]")) === null || _a === void 0 ? void 0 : _a.getEnd();
@@ -1732,11 +1732,11 @@ ${indentation}${uniqueName}`;
1732
1732
  const indentation = " ".repeat(high.getFirstToken().getStart().getCol() - 1);
1733
1733
  const source = (_b = templateSource === null || templateSource === void 0 ? void 0 : templateSource.findDirectExpression(Expressions.Source)) === null || _b === void 0 ? void 0 : _b.concatTokens();
1734
1734
  const uniqueName = this.uniqueName(high.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
1735
- const code = `DATA ${uniqueName} TYPE string.
1736
- ${indentation}CALL FUNCTION '${functionName}'
1737
- ${indentation} EXPORTING
1738
- ${indentation} input = ${source}
1739
- ${indentation} IMPORTING
1735
+ const code = `DATA ${uniqueName} TYPE string.
1736
+ ${indentation}CALL FUNCTION '${functionName}'
1737
+ ${indentation} EXPORTING
1738
+ ${indentation} input = ${source}
1739
+ ${indentation} IMPORTING
1740
1740
  ${indentation} output = ${uniqueName}.\n`;
1741
1741
  const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), code);
1742
1742
  const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, child.getFirstToken().getStart(), child.getLastToken().getEnd(), uniqueName);
@@ -19,12 +19,12 @@ class EasyToFindMessages {
19
19
  key: "easy_to_find_messages",
20
20
  title: "Easy to find messages",
21
21
  shortDescription: `Make messages easy to find`,
22
- extendedInformation: `All messages must be statically referenced exactly once
23
-
24
- Only MESSAGE and RAISE statments are counted as static references
25
-
26
- Also see rule "message_exists"
27
-
22
+ extendedInformation: `All messages must be statically referenced exactly once
23
+
24
+ Only MESSAGE and RAISE statments are counted as static references
25
+
26
+ Also see rule "message_exists"
27
+
28
28
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#make-messages-easy-to-find`,
29
29
  tags: [_irule_1.RuleTag.Styleguide],
30
30
  };
@@ -27,8 +27,8 @@ class EmptyLineinStatement extends _abap_rule_1.ABAPRule {
27
27
  key: "empty_line_in_statement",
28
28
  title: "Find empty lines in statements",
29
29
  shortDescription: `Checks that statements do not contain empty lines.`,
30
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-obsess-with-separating-blank-lines
31
-
30
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#dont-obsess-with-separating-blank-lines
31
+
32
32
  https://docs.abapopenchecks.org/checks/41/`,
33
33
  tags: [_irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Whitespace, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
34
34
  badExample: `WRITE\n\nhello.`,
@@ -46,13 +46,13 @@ class EmptyStructure extends _abap_rule_1.ABAPRule {
46
46
  shortDescription: `Checks that the code does not contain empty blocks.`,
47
47
  extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#no-empty-if-branches`,
48
48
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
49
- badExample: `IF foo = bar.
50
- ENDIF.
51
-
52
- DO 2 TIMES.
49
+ badExample: `IF foo = bar.
50
+ ENDIF.
51
+
52
+ DO 2 TIMES.
53
53
  ENDDO.`,
54
- goodExample: `LOOP AT itab WHERE qty = 0 OR date > sy-datum.
55
- ENDLOOP.
54
+ goodExample: `LOOP AT itab WHERE qty = 0 OR date > sy-datum.
55
+ ENDLOOP.
56
56
  result = xsdbool( sy-subrc = 0 ).`,
57
57
  };
58
58
  }
@@ -24,10 +24,10 @@ class ExitOrCheck extends _abap_rule_1.ABAPRule {
24
24
  return {
25
25
  key: "exit_or_check",
26
26
  title: "Find EXIT or CHECK outside loops",
27
- shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
27
+ shortDescription: `Detects usages of EXIT or CHECK statements outside of loops.
28
28
  Use RETURN to leave procesing blocks instead.`,
29
- extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
30
- https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
29
+ extendedInformation: `https://help.sap.com/doc/abapdocu_751_index_htm/7.51/en-US/abenleave_processing_blocks.htm
30
+ https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/abapcheck_processing_blocks.htm
31
31
  https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#check-vs-return`,
32
32
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
33
33
  };
@@ -21,12 +21,12 @@ class ExpandMacros extends _abap_rule_1.ABAPRule {
21
21
  key: "expand_macros",
22
22
  title: "Expand Macros",
23
23
  shortDescription: `Allows expanding macro calls with quick fixes`,
24
- extendedInformation: `Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
25
-
24
+ extendedInformation: `Macros: https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-US/abenmacros_guidl.htm
25
+
26
26
  Note that macros/DEFINE cannot be used in the ABAP Cloud programming model`,
27
- badExample: `DEFINE _hello.
28
- WRITE 'hello'.
29
- END-OF-DEFINITION.
27
+ badExample: `DEFINE _hello.
28
+ WRITE 'hello'.
29
+ END-OF-DEFINITION.
30
30
  _hello.`,
31
31
  goodExample: `WRITE 'hello'.`,
32
32
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.Upport],
@@ -22,7 +22,7 @@ class Exporting extends _abap_rule_1.ABAPRule {
22
22
  shortDescription: `Detects EXPORTING statements which can be omitted.`,
23
23
  badExample: `call_method( EXPORTING foo = bar ).`,
24
24
  goodExample: `call_method( foo = bar ).`,
25
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting
25
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#omit-the-optional-keyword-exporting
26
26
  https://docs.abapopenchecks.org/checks/30/`,
27
27
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
28
28
  };
@@ -26,7 +26,7 @@ class ForbiddenIdentifier extends _abap_rule_1.ABAPRule {
26
26
  key: "forbidden_identifier",
27
27
  title: "Forbidden Identifier",
28
28
  shortDescription: `Forbid use of specified identifiers, list of regex.`,
29
- extendedInformation: `Used in the transpiler to find javascript keywords in ABAP identifiers,
29
+ extendedInformation: `Used in the transpiler to find javascript keywords in ABAP identifiers,
30
30
  https://github.com/abaplint/transpiler/blob/bda94b8b56e2b7f2f87be2168f12361aa530220e/packages/transpiler/src/validation.ts#L44`,
31
31
  tags: [_irule_1.RuleTag.SingleFile],
32
32
  };
@@ -28,8 +28,8 @@ class ForbiddenVoidType {
28
28
  key: "forbidden_void_type",
29
29
  title: "Forbidden Void Types",
30
30
  shortDescription: `Avoid usage of specified void types.`,
31
- extendedInformation: `Inspiration:
32
- BOOLEAN, BOOLE_D, CHAR01, CHAR1, CHAR10, CHAR12, CHAR128, CHAR2, CHAR20, CHAR4, CHAR70,
31
+ extendedInformation: `Inspiration:
32
+ BOOLEAN, BOOLE_D, CHAR01, CHAR1, CHAR10, CHAR12, CHAR128, CHAR2, CHAR20, CHAR4, CHAR70,
33
33
  DATS, TIMS, DATUM, FLAG, INT4, NUMC3, NUMC4, SAP_BOOL, TEXT25, TEXT80, X255, XFELD`,
34
34
  };
35
35
  }
@@ -20,7 +20,7 @@ class FullyTypeITabs extends _abap_rule_1.ABAPRule {
20
20
  key: "fully_type_itabs",
21
21
  title: "Fully type internal tables",
22
22
  shortDescription: `No implict table types or table keys`,
23
- badExample: `DATA lt_foo TYPE TABLE OF ty.
23
+ badExample: `DATA lt_foo TYPE TABLE OF ty.
24
24
  DATA lt_bar TYPE STANDARD TABLE OF ty.`,
25
25
  goodExample: `DATA lt_foo TYPE STANDARD TABLE OF ty WITH EMPTY KEY.`,
26
26
  tags: [_irule_1.RuleTag.SingleFile],
@@ -28,26 +28,26 @@ class FunctionalWriting extends _abap_rule_1.ABAPRule {
28
28
  key: "functional_writing",
29
29
  title: "Use functional writing",
30
30
  shortDescription: `Detects usage of call method when functional style calls can be used.`,
31
- extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
31
+ extendedInformation: `https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-functional-to-procedural-calls
32
32
  https://docs.abapopenchecks.org/checks/07/`,
33
33
  tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.Quickfix, _irule_1.RuleTag.SingleFile],
34
- badExample: `CALL METHOD zcl_class=>method( ).
35
- CALL METHOD cl_abap_typedescr=>describe_by_name
36
- EXPORTING
37
- p_name = 'NAME'
38
- RECEIVING
39
- p_descr_ref = lr_typedescr
40
- EXCEPTIONS
41
- type_not_found = 1
34
+ badExample: `CALL METHOD zcl_class=>method( ).
35
+ CALL METHOD cl_abap_typedescr=>describe_by_name
36
+ EXPORTING
37
+ p_name = 'NAME'
38
+ RECEIVING
39
+ p_descr_ref = lr_typedescr
40
+ EXCEPTIONS
41
+ type_not_found = 1
42
42
  OTHERS = 2.`,
43
- goodExample: `zcl_class=>method( ).
44
- cl_abap_typedescr=>describe_by_name(
45
- EXPORTING
46
- p_name = 'NAME'
47
- RECEIVING
48
- p_descr_ref = lr_typedescr
49
- EXCEPTIONS
50
- type_not_found = 1
43
+ goodExample: `zcl_class=>method( ).
44
+ cl_abap_typedescr=>describe_by_name(
45
+ EXPORTING
46
+ p_name = 'NAME'
47
+ RECEIVING
48
+ p_descr_ref = lr_typedescr
49
+ EXCEPTIONS
50
+ type_not_found = 1
51
51
  OTHERS = 2 ).`,
52
52
  };
53
53
  }
@@ -19,14 +19,14 @@ class GlobalClass extends _abap_rule_1.ABAPRule {
19
19
  key: "global_class",
20
20
  title: "Global class checks",
21
21
  shortDescription: `Checks related to global classes`,
22
- extendedInformation: `* global classes must be in own files
23
-
24
- * file names must match class name
25
-
26
- * file names must match interface name
27
-
28
- * global classes must be global definitions
29
-
22
+ extendedInformation: `* global classes must be in own files
23
+
24
+ * file names must match class name
25
+
26
+ * file names must match interface name
27
+
28
+ * global classes must be global definitions
29
+
30
30
  * global interfaces must be global definitions`,
31
31
  tags: [_irule_1.RuleTag.Syntax],
32
32
  };
@@ -33,21 +33,21 @@ class IdenticalConditions extends _abap_rule_1.ABAPRule {
33
33
  return {
34
34
  key: "identical_conditions",
35
35
  title: "Identical conditions",
36
- shortDescription: `Find identical conditions in IF + CASE + WHILE etc
37
-
36
+ shortDescription: `Find identical conditions in IF + CASE + WHILE etc
37
+
38
38
  Prerequsites: code is pretty printed with identical cAsE`,
39
39
  tags: [_irule_1.RuleTag.SingleFile],
40
- badExample: `IF foo = bar OR 1 = a OR foo = bar.
41
- ENDIF.
42
- CASE bar.
43
- WHEN '1'.
44
- WHEN 'A' OR '1'.
40
+ badExample: `IF foo = bar OR 1 = a OR foo = bar.
41
+ ENDIF.
42
+ CASE bar.
43
+ WHEN '1'.
44
+ WHEN 'A' OR '1'.
45
45
  ENDCASE.`,
46
- goodExample: `IF foo = bar OR 1 = a.
47
- ENDIF.
48
- CASE bar.
49
- WHEN '1'.
50
- WHEN 'A'.
46
+ goodExample: `IF foo = bar OR 1 = a.
47
+ ENDIF.
48
+ CASE bar.
49
+ WHEN '1'.
50
+ WHEN 'A'.
51
51
  ENDCASE.`,
52
52
  };
53
53
  }