@abaplint/core 2.110.8 → 2.111.1

package/build/abaplint.d.ts

@@ -1378,6 +1378,7 @@ export declare class CurrentScope {
     addFormDefinitions(f: readonly IFormDefinition[]): void;
     addInterfaceDefinition(i: IInterfaceDefinition): void;
     addNamedIdentifier(name: string, identifier: TypedIdentifier): void;
+    addNamedIdentifierToParent(name: string, identifier: TypedIdentifier): void;
     addIdentifier(identifier: TypedIdentifier | undefined): void;
     addDeferred(token: Token | undefined, type: "CLAS" | "INTF"): void;
     addListPrefix(identifiers: readonly TypedIdentifier[], prefix: string): void;

package/build/src/abap/5_syntax/_current_scope.js

@@ -120,6 +120,23 @@ class CurrentScope {
         }
         this.current.getData().vars[upper] = identifier;
     }
+    addNamedIdentifierToParent(name, identifier) {
+        if (this.current === undefined) {
+            return;
+        }
+        const parent = this.current.getParent();
+        if (parent === undefined) {
+            return;
+        }
+        const upper = name.toUpperCase();
+        if (parent.getData().vars[upper] !== undefined) {
+            throw new Error(`Variable name "${name}" already defined`);
+        }
+        else if (this.isOO() && parent.getData().types[upper] !== undefined) {
+            throw new Error(`"${name}" already defined`);
+        }
+        parent.getData().vars[upper] = identifier;
+    }
     addIdentifier(identifier) {
         if (identifier === undefined) {
             return;

package/build/src/abap/5_syntax/basic_types.js

@@ -158,17 +158,18 @@ class BasicTypes {
                     }
                 }
                 else { // field name
-                    let sub = undefined;
                     if (type instanceof Types.TableType) {
                         type = type.getRowType();
                     }
                     if (type instanceof Types.StructureType) {
-                        sub = type.getComponentByName(child.getFirstToken().getStr());
+                        type = type.getComponentByName(child.getFirstToken().getStr());
+                        if (type === undefined) {
+                            return new Types.UnknownType("Type error, field not part of structure " + fullName);
+                        }
                     }
-                    if (sub === undefined) {
+                    else if (!(type instanceof Types.VoidType)) {
                         return new Types.UnknownType("Type error, field not part of structure " + fullName);
                     }
-                    type = sub;
                 }
             }
             if (type instanceof Types.VoidType) {

package/build/src/abap/5_syntax/expressions/component_compare_simple.js

@@ -24,7 +24,7 @@ class ComponentCompareSimple {
                     }
                 }
                 else {
-                    throw "ComponentCompareSimple, unexpected node";
+                    throw new Error("ComponentCompareSimple, unexpected node");
                 }
             }
         }

package/build/src/abap/5_syntax/expressions/default.js

@@ -4,12 +4,18 @@ exports.Default = void 0;
 const Expressions = require("../../2_statements/expressions");
 const field_chain_1 = require("./field_chain");
 const _reference_1 = require("../_reference");
+const constant_1 = require("./constant");
 class Default {
     runSyntax(node, scope, filename) {
         const chain = node.findDirectExpression(Expressions.FieldChain);
         if (chain) {
-            new field_chain_1.FieldChain().runSyntax(chain, scope, filename, _reference_1.ReferenceType.DataReadReference);
+            return new field_chain_1.FieldChain().runSyntax(chain, scope, filename, _reference_1.ReferenceType.DataReadReference);
         }
+        const constant = node.findDirectExpression(Expressions.Constant);
+        if (constant) {
+            return new constant_1.Constant().runSyntax(constant);
+        }
+        return undefined;
     }
 }
 exports.Default = Default;

package/build/src/abap/5_syntax/expressions/field_chain.js

@@ -17,29 +17,25 @@ const source_field_symbol_1 = require("./source_field_symbol");
 const source_field_1 = require("./source_field");
 class FieldChain {
     runSyntax(node, scope, filename, refType) {
-        var _a, _b, _c, _d, _e;
-        const children = node.getChildren();
-        let context = undefined;
-        try {
-            context = this.findTop(children[0], scope, filename, refType);
-        }
-        catch (error) {
+        var _a, _b, _c;
+        if (((_a = node.getFirstChild()) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.SourceField
+            && node.findDirectExpression(Expressions.ComponentName)) {
+            // workaround for names with dashes, eg. "sy-repid"
             const concat = node.concatTokens();
-            if (concat.includes("-") && ((_a = node.getFirstChild()) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.SourceField) {
-                // workaround for names with dashes, eg. "sy-repid"
-                const offset = ((_b = node.findDirectExpression(Expressions.FieldOffset)) === null || _b === void 0 ? void 0 : _b.concatTokens()) || "";
-                const length = ((_c = node.findDirectExpression(Expressions.FieldLength)) === null || _c === void 0 ? void 0 : _c.concatTokens()) || "";
-                const found = scope.findVariable(concat.replace(offset, "").replace(length, ""));
-                if (found) {
-                    if (refType) {
-                        scope.addReference(node.getFirstToken(), found, refType, filename);
-                    }
-                    // this is not completely correct, but will work, dashes in names is a mess anyhow
-                    return found.getType();
+            const offset = ((_b = node.findDirectExpression(Expressions.FieldOffset)) === null || _b === void 0 ? void 0 : _b.concatTokens()) || "";
+            const length = ((_c = node.findDirectExpression(Expressions.FieldLength)) === null || _c === void 0 ? void 0 : _c.concatTokens()) || "";
+            const found = scope.findVariable(concat.replace(offset, "").replace(length, ""));
+            if (found) {
+                if (refType) {
+                    scope.addReference(node.getFirstToken(), found, refType, filename);
                 }
+                // this is not completely correct, but will work, dashes in names is a mess anyhow
+                return found.getType();
             }
-            throw error;
         }
+        let context = undefined;
+        const children = node.getChildren();
+        context = this.findTop(children[0], scope, filename, refType);
         for (let i = 1; i < children.length; i++) {
             const current = children[i];
             if (current === undefined) {
@@ -90,30 +86,7 @@ class FieldChain {
                 if (context instanceof basic_1.TableType && context.isWithHeader()) {
                     context = context.getRowType();
                 }
-                try {
-                    context = new component_name_1.ComponentName().runSyntax(context, current);
-                }
-                catch (error) {
-                    const concat = node.concatTokens();
-                    if (concat.includes("-")) {
-                        // workaround for names with dashes, eg. "sy-repid"
-                        const offset = ((_d = node.findDirectExpression(Expressions.FieldOffset)) === null || _d === void 0 ? void 0 : _d.concatTokens()) || "";
-                        const length = ((_e = node.findDirectExpression(Expressions.FieldLength)) === null || _e === void 0 ? void 0 : _e.concatTokens()) || "";
-                        const found = scope.findVariable(concat.replace(offset, "").replace(length, ""));
-                        if (found) {
-                            if (refType) {
-                                scope.addReference(node.getFirstToken(), found, refType, filename);
-                            }
-                            context = found.getType();
-                        }
-                        else {
-                            throw error;
-                        }
-                    }
-                    else {
-                        throw error;
-                    }
-                }
+                context = new component_name_1.ComponentName().runSyntax(context, current);
             }
             else if (current instanceof nodes_1.ExpressionNode
                 && current.get() instanceof Expressions.TableExpression) {

package/build/src/abap/5_syntax/expressions/select.js

@@ -12,10 +12,11 @@ const sql_source_1 = require("./sql_source");
 const sql_compare_1 = require("./sql_compare");
 const sql_order_by_1 = require("./sql_order_by");
 const dynamic_1 = require("./dynamic");
+const _reference_1 = require("../_reference");
 const isSimple = /^\w+$/;
 class Select {
     runSyntax(node, scope, filename, skipImplicitInto = false) {
-        var _a, _b;
+        var _a;
         const token = node.getFirstToken();
         const from = node.findDirectExpression(Expressions.SQLFrom);
         const dbSources = from ? new sql_from_1.SQLFrom().runSyntax(from, scope, filename) : [];
@@ -45,9 +46,15 @@ class Select {
             const fields = (_a = node.findFirstExpression(Expressions.SQLAggregation)) === null || _a === void 0 ? void 0 : _a.concatTokens();
             const c = new RegExp(/^count\(\s*\*\s*\)$/, "i");
             if (fields === undefined || c.test(fields) === false) {
-                const name = (_b = from === null || from === void 0 ? void 0 : from.findDirectExpression(Expressions.SQLFromSource)) === null || _b === void 0 ? void 0 : _b.concatTokens();
-                if (name && scope.findVariable(name) === undefined) {
-                    throw new Error(`Target variable ${name} not found in scope`);
+                const nameToken = from === null || from === void 0 ? void 0 : from.findDirectExpression(Expressions.SQLFromSource);
+                if (nameToken) {
+                    const found = scope.findVariable(nameToken.concatTokens());
+                    if (found) {
+                        scope.addReference(nameToken.getFirstToken(), found, _reference_1.ReferenceType.DataWriteReference, filename);
+                    }
+                    else {
+                        throw new Error(`Target variable ${nameToken.concatTokens()} not found in scope`);
+                    }
                 }
             }
         }

package/build/src/abap/5_syntax/statements/tables.js

@@ -4,6 +4,7 @@ exports.Tables = void 0;
 const Expressions = require("../../2_statements/expressions");
 const _typed_identifier_1 = require("../../types/_typed_identifier");
 const unknown_type_1 = require("../../types/basic/unknown_type");
+const _scope_type_1 = require("../_scope_type");
 class Tables {
     runSyntax(node, scope, filename) {
         var _a, _b;
@@ -19,7 +20,13 @@ class Tables {
         const found = (_b = scope.getDDIC()) === null || _b === void 0 ? void 0 : _b.lookupTableOrView(name);
         if (found) {
             scope.getDDICReferences().addUsing(scope.getParentObj(), { object: found.object, filename: filename, token: nameToken });
-            scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(nameToken, filename, found.type));
+            if (scope.getType() === _scope_type_1.ScopeType.Form || scope.getType() === _scope_type_1.ScopeType.FunctionModule) {
+                // hoist TABLES definitions to global scope
+                scope.addNamedIdentifierToParent(nameToken.getStr(), new _typed_identifier_1.TypedIdentifier(nameToken, filename, found.type));
+            }
+            else {
+                scope.addIdentifier(new _typed_identifier_1.TypedIdentifier(nameToken, filename, found.type));
+            }
             return;
         }
         // this should never happen,

package/build/src/registry.js

@@ -67,7 +67,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.110.8";
+        return "2.111.1";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/index.js

@@ -159,6 +159,7 @@ __exportStar(require("./superclass_final"), exports);
 __exportStar(require("./superfluous_value"), exports);
 __exportStar(require("./sy_modification"), exports);
 __exportStar(require("./tabl_enhancement_category"), exports);
+__exportStar(require("./tables_declared_locally"), exports);
 __exportStar(require("./try_without_catch"), exports);
 __exportStar(require("./type_form_parameters"), exports);
 __exportStar(require("./types_naming"), exports);

package/build/src/rules/macro_naming.js

@@ -26,7 +26,7 @@ class MacroNaming extends _abap_rule_1.ABAPRule {
             key: "macro_naming",
             title: "Macro naming conventions",
             shortDescription: `Allows you to enforce a pattern for macro definitions`,
-            extendedInformation: `Use rule "avoid_use" to avoid macros alotogether.`,
+            extendedInformation: `Use rule "avoid_use" to avoid macros altogether.`,
             tags: [_irule_1.RuleTag.Naming, _irule_1.RuleTag.SingleFile],
             badExample: `DEFINE something.
 END-OF-DEFINITION.`,

package/build/src/rules/tables_declared_locally.js

@@ -0,0 +1,56 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.TablesDeclaredLocally = exports.TablesDeclaredLocallyConf = void 0;
+const issue_1 = require("../issue");
+const Statements = require("../abap/2_statements/statements");
+const Structures = require("../abap/3_structures/structures");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+class TablesDeclaredLocallyConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.TablesDeclaredLocallyConf = TablesDeclaredLocallyConf;
+class TablesDeclaredLocally extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new TablesDeclaredLocallyConf();
+    }
+    getMetadata() {
+        return {
+            key: "tables_declared_locally",
+            title: "Check for locally declared TABLES",
+            shortDescription: `TABLES are always global, so declare them globally`,
+            extendedInformation: `https://help.sap.com/doc/abapdocu_752_index_htm/7.52/en-us/abaptables.htm`,
+            tags: [_irule_1.RuleTag.SingleFile],
+            badExample: `FORM foo.
+  TABLES t100.
+ENDFORM.`,
+            goodExample: `TABLES t000.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        const structure = file.getStructure();
+        if (structure === undefined) {
+            return issues;
+        }
+        const procedures = structure.findAllStructuresMulti([Structures.Form, Structures.FunctionModule]);
+        for (const p of procedures) {
+            const tablesStatement = p.findFirstStatement(Statements.Tables);
+            if (tablesStatement) {
+                const message = "Declare TABLES globaly";
+                const issue = issue_1.Issue.atStatement(file, tablesStatement, message, this.getMetadata().key, this.conf.severity);
+                issues.push(issue);
+            }
+        }
+        return issues;
+    }
+}
+exports.TablesDeclaredLocally = TablesDeclaredLocally;
+//# sourceMappingURL=tables_declared_locally.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.110.8",
+    "version": "2.111.1",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,7 +50,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.47.0",
+        "@microsoft/api-extractor": "^7.47.1",
         "@types/chai": "^4.3.16",
         "@types/mocha": "^10.0.7",
         "@types/node": "^20.14.10",