@abaplint/core 2.109.0 → 2.109.2

package/build/abaplint.d.ts

@@ -3217,10 +3217,14 @@ declare interface ILookupResult {
 }
 
 declare interface IMacroReferences {
-    addDefinition(ref: IFilenameAndToken): void;
+    addDefinition(ref: IFilenameAndToken, start: Position, end: Position): void;
     addReference(ref: IFilenameAndToken): void;
-    listDefinitionsByFile(filename: string): IFilenameAndToken[];
+    listDefinitionsByFile(filename: string): Token[];
     listUsagesbyMacro(filename: string, token: Token): IFilenameAndToken[];
+    getDefinitionPosition(filename: string, token: Token): {
+        start: Position;
+        end: Position;
+    } | undefined;
     clear(filename: string): void;
 }
 

package/build/src/abap/2_statements/expand_macros.js

@@ -54,18 +54,22 @@ class ExpandMacros {
         this.globalMacros = globalMacros;
         this.reg = reg;
     }
-    find(statements, file) {
+    find(statements, file, clear = true) {
         var _a, _b, _c;
         let nameToken = undefined;
+        let start = undefined;
         let contents = [];
         const macroReferences = (_a = this.reg) === null || _a === void 0 ? void 0 : _a.getMacroReferences();
-        macroReferences === null || macroReferences === void 0 ? void 0 : macroReferences.clear(file.getFilename());
+        if (clear) {
+            macroReferences === null || macroReferences === void 0 ? void 0 : macroReferences.clear(file.getFilename());
+        }
         for (let i = 0; i < statements.length; i++) {
             const statement = statements[i];
             const type = statement.get();
             if (type instanceof Statements.Define) {
                 // todo, will this break if first token is a pragma?
                 nameToken = statement.getTokens()[1];
+                start = statement.getFirstToken().getStart();
                 contents = [];
             }
             else if (type instanceof Statements.Include) {
@@ -77,14 +81,14 @@ class ExpandMacros {
                     const includeMainFile = prog.getMainABAPFile();
                     if (includeMainFile) {
                         // slow, this copies everything,
-                        this.find([...includeMainFile.getStatements()], includeMainFile);
+                        this.find([...includeMainFile.getStatements()], includeMainFile, false);
                     }
                 }
             }
             else if (nameToken) {
                 if (type instanceof Statements.EndOfDefinition) {
                     this.macros.addMacro(nameToken.getStr(), contents, file.getFilename());
-                    macroReferences === null || macroReferences === void 0 ? void 0 : macroReferences.addDefinition({ filename: file.getFilename(), token: nameToken });
+                    macroReferences === null || macroReferences === void 0 ? void 0 : macroReferences.addDefinition({ filename: file.getFilename(), token: nameToken }, start, statement.getLastToken().getEnd());
                     nameToken = undefined;
                 }
                 else if (!(type instanceof _statement_1.Comment)) {

package/build/src/lsp/hover.js

@@ -7,6 +7,7 @@ const LServer = require("vscode-languageserver-types");
 const _abap_object_1 = require("../objects/_abap_object");
 const _lsp_utils_1 = require("./_lsp_utils");
 const _lookup_1 = require("./_lookup");
+const _statement_1 = require("../abap/2_statements/statements/_statement");
 class Hover {
     constructor(reg) {
         this.reg = reg;
@@ -30,6 +31,9 @@ class Hover {
             || found.token instanceof Tokens.StringTemplateMiddle) {
             return { kind: LServer.MarkupKind.Markdown, value: "String Template" };
         }
+        else if (found.snode.get() instanceof _statement_1.MacroCall) {
+            return { kind: LServer.MarkupKind.Markdown, value: "Macro Call" };
+        }
         else if (found.snode.get() instanceof Statements.Define && found.stack.length === 2) {
             return { kind: LServer.MarkupKind.Markdown, value: "Macro Name" };
         }

package/build/src/macro_references.js

@@ -6,11 +6,22 @@ class MacroReferences {
         this.definitions = {};
         this.references = {};
     }
-    addDefinition(ref) {
+    addDefinition(ref, start, end) {
         if (this.definitions[ref.filename] === undefined) {
             this.definitions[ref.filename] = [];
         }
-        this.definitions[ref.filename].push(ref);
+        else if (this.definitions[ref.filename].find((d) => d.token.getStart().equals(ref.token.getStart()))) {
+            return;
+        }
+        this.definitions[ref.filename].push({ token: ref.token, start, end });
+    }
+    getDefinitionPosition(filename, token) {
+        for (const d of this.definitions[filename] || []) {
+            if (d.token.getStart().equals(token.getStart())) {
+                return { start: d.start, end: d.end };
+            }
+        }
+        return undefined;
     }
     addReference(ref) {
         if (this.references[ref.filename] === undefined) {
@@ -19,7 +30,11 @@ class MacroReferences {
         this.references[ref.filename].push(ref);
     }
     listDefinitionsByFile(filename) {
-        return this.definitions[filename] || [];
+        const ret = [];
+        for (const d of this.definitions[filename] || []) {
+            ret.push(d.token);
+        }
+        return ret;
     }
     listUsagesbyMacro(filename, token) {
         const ret = [];

package/build/src/registry.js

@@ -67,7 +67,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.109.0";
+        return "2.109.2";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/unused_macros.js

@@ -5,6 +5,7 @@ const issue_1 = require("../issue");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
 const _abap_object_1 = require("../objects/_abap_object");
+const edit_helper_1 = require("../edit_helper");
 class UnusedMacrosConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
@@ -25,6 +26,14 @@ class UnusedMacros {
             title: "Unused macros",
             shortDescription: `Checks for unused macro definitions definitions`,
             tags: [_irule_1.RuleTag.Quickfix],
+            badExample: `DEFINE foobar1.
+  WRITE 'hello'.
+END-OF-DEFINITION.`,
+            goodExample: `DEFINE foobar2.
+  WRITE 'hello'.
+END-OF-DEFINITION.
+
+foobar2.`,
         };
     }
     getConfig() {
@@ -48,11 +57,13 @@ class UnusedMacros {
         }
         const references = this.reg.getMacroReferences();
         for (const file of obj.getABAPFiles()) {
-            for (const macro of references.listDefinitionsByFile(file.getFilename())) {
-                const usages = references.listUsagesbyMacro(file.getFilename(), macro.token);
-                if (usages.length === 0 && ((_a = this.conf.skipNames) === null || _a === void 0 ? void 0 : _a.includes(macro.token.getStr().toUpperCase())) === false) {
-                    const message = "Unused macro definition: " + macro.token.getStr();
-                    result.push(issue_1.Issue.atToken(file, macro.token, message, this.getMetadata().key, this.conf.severity));
+            for (const macroToken of references.listDefinitionsByFile(file.getFilename())) {
+                const usages = references.listUsagesbyMacro(file.getFilename(), macroToken);
+                if (usages.length === 0 && ((_a = this.conf.skipNames) === null || _a === void 0 ? void 0 : _a.includes(macroToken.getStr().toUpperCase())) === false) {
+                    const message = "Unused macro definition: " + macroToken.getStr();
+                    const pos = references.getDefinitionPosition(file.getFilename(), macroToken);
+                    const fix = edit_helper_1.EditHelper.deleteRange(file, pos.start, pos.end);
+                    result.push(issue_1.Issue.atToken(file, macroToken, message, this.getMetadata().key, this.conf.severity, fix));
                 }
             }
         }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.109.0",
+    "version": "2.109.2",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",