@abaplint/core 2.108.8 → 2.108.10

package/build/src/abap/3_structures/structures/_combi.js

@@ -22,7 +22,7 @@ class Sequence {
     }
     run(statements, parent) {
         let inn = statements;
-        const out = [];
+        let out = [];
         for (const i of this.list) {
             const match = i.run(inn, parent);
             if (match.error) {
@@ -34,7 +34,14 @@ class Sequence {
                     errorMatched: out.length,
                 };
             }
-            out.push(...match.matched);
+            if (match.matched.length < 100) {
+                out.push(...match.matched);
+            }
+            else {
+                // avoid using the spread operator, it might trigger "Maximum call stack size exceeded"
+                // when the number of matched elements is very large
+                out = out.concat(match.matched);
+            }
             inn = match.unmatched;
         }
         return {
@@ -166,7 +173,7 @@ class Star {
     }
     run(statements, parent) {
         let inn = statements;
-        const out = [];
+        let out = [];
         while (true) {
             if (inn.length === 0) {
                 return {
@@ -198,7 +205,14 @@ class Star {
                     };
                 }
             }
-            out.push(...match.matched);
+            if (match.matched.length < 100) {
+                out.push(...match.matched);
+            }
+            else {
+                // avoid using the spread operator, it might trigger "Maximum call stack size exceeded"
+                // when the number of matched elements is very large
+                out = out.concat(match.matched);
+            }
             inn = match.unmatched;
         }
     }

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.108.8";
+        return "2.108.10";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/check_subrc.js

@@ -44,7 +44,7 @@ If sy-dbcnt is checked after database statements, it is considered okay.
 If IS ASSIGNED is checked after assigning, it is considered okay.
 
 FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
-            tags: [_irule_1.RuleTag.SingleFile],
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
             pseudoComment: "EC CI_SUBRC",
             pragma: "##SUBRC_OK",
         };

package/build/src/rules/select_single_full_key.js

@@ -3,7 +3,9 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.SelectSingleFullKey = exports.SelectSingleFullKeyConf = void 0;
 const issue_1 = require("../issue");
 const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
 const __1 = require("..");
+const edit_helper_1 = require("../edit_helper");
 class SelectSingleFullKeyConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
@@ -24,7 +26,7 @@ class SelectSingleFullKey {
 
 If the statement contains a JOIN it is not checked`,
             pseudoComment: "EC CI_NOORDER",
-            tags: [],
+            tags: [_irule_1.RuleTag.Quickfix],
         };
     }
     initialize(reg) {
@@ -45,6 +47,12 @@ If the statement contains a JOIN it is not checked`,
     setConfig(conf) {
         this.conf = conf;
     }
+    buildFix(file, statement) {
+        return {
+            description: `Add "#EC CI_NOORDER`,
+            edit: edit_helper_1.EditHelper.insertAt(file, statement.getLastToken().getStart(), ` "#EC CI_NOORDER`),
+        };
+    }
     run(obj) {
         var _a, _b;
         if (!(obj instanceof __1.ABAPObject)) {
@@ -106,7 +114,8 @@ If the statement contains a JOIN it is not checked`,
                     }
                 }
                 if (set.size > 0) {
-                    issues.push(issue_1.Issue.atStatement(file, s, message, this.getMetadata().key, this.getConfig().severity));
+                    const fix = this.buildFix(file, s);
+                    issues.push(issue_1.Issue.atStatement(file, s, message, this.getMetadata().key, this.getConfig().severity, undefined, [fix]));
                 }
             }
         }

package/build/src/rules/unnecessary_return.js

@@ -7,7 +7,13 @@ const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
 const Statements = require("../abap/2_statements/statements");
 const edit_helper_1 = require("../edit_helper");
+const _statement_1 = require("../abap/2_statements/statements/_statement");
 class UnnecessaryReturnConf extends _basic_rule_config_1.BasicRuleConfig {
+    constructor() {
+        super(...arguments);
+        /** Allow empty METHODs + FORMs + FUNCTION-MODULEs */
+        this.allowEmpty = false;
+    }
 }
 exports.UnnecessaryReturnConf = UnnecessaryReturnConf;
 class UnnecessaryReturn extends _abap_rule_1.ABAPRule {
@@ -51,15 +57,29 @@ ENDFORM.`,
         }
         const message = "Unnecessary RETURN";
         const statements = file.getStatements();
+        let statementCounter = 0;
         for (let i = 0; i < statements.length; i++) {
             const node = statements[i];
-            if (!(node.get() instanceof Statements.EndMethod
-                || node.get() instanceof Statements.EndForm
-                || node.get() instanceof Statements.EndFunction)) {
+            const nodeType = node.get();
+            if ((nodeType instanceof Statements.MethodImplementation
+                || nodeType instanceof Statements.Form
+                || nodeType instanceof Statements.FunctionModule)) {
+                statementCounter = 0;
+                continue;
+            }
+            if (!(nodeType instanceof _statement_1.Comment)) {
+                statementCounter++;
+            }
+            if (!(nodeType instanceof Statements.EndMethod
+                || nodeType instanceof Statements.EndForm
+                || nodeType instanceof Statements.EndFunction)) {
                 continue;
             }
             const prev = statements[i - 1];
             if (prev && prev.get() instanceof Statements.Return) {
+                if (this.conf.allowEmpty === true && statementCounter === 2) {
+                    continue;
+                }
                 const fix = edit_helper_1.EditHelper.deleteStatement(file, prev);
                 issues.push(issue_1.Issue.atStatement(file, prev, message, this.getMetadata().key, this.getConfig().severity, fix));
             }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.108.8",
+    "version": "2.108.10",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -10,7 +10,7 @@
         "lint:fix": "eslint src/**/*.ts test/**/*.ts --format unix --fix",
         "compile": "tsc && sh scripts/version.sh",
         "test": "npm run compile && mocha --timeout 1000 && npm run lint && npm run schema && api-extractor run",
-        "test:only": "npm run compile && mocha",
+        "test:only": "npm run compile && mocha --timeout 1000000",
         "test:parallel": "npm run compile && mocha --timeout 1000 --parallel --reporter dot",
         "coverage": "npm run compile && c8 mocha && c8 report --reporter=html",
         "lexer_performance": "tsc && curl -o lexer_performance.abap https://raw.githubusercontent.com/abapGit/build/main/zabapgit_standalone.prog.abap && node build/adhoc/lexer_performance.js",
@@ -50,7 +50,7 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.43.7",
+        "@microsoft/api-extractor": "^7.43.8",
         "@types/chai": "^4.3.16",
         "@types/mocha": "^10.0.6",
         "@types/node": "^20.12.12",
@@ -63,7 +63,7 @@
         "typescript": "^5.4.5"
     },
     "dependencies": {
-        "fast-xml-parser": "^4.3.6",
+        "fast-xml-parser": "^4.4.0",
         "json5": "^2.2.3",
         "vscode-languageserver-types": "^3.17.5"
     }