@abaplint/core 2.107.4 → 2.108.0

package/build/src/abap/2_statements/statements/editor_call.js

@@ -6,9 +6,9 @@ const expressions_1 = require("../expressions");
 const version_1 = require("../../../version");
 class EditorCall {
     getMatcher() {
-        const title = (0, combi_1.seq)("TITLE", expressions_1.Source);
+        const title = (0, combi_1.seq)("TITLE", expressions_1.SimpleSource3);
         const options = (0, combi_1.per)("DISPLAY-MODE", title);
-        const ret = (0, combi_1.seq)("EDITOR-CALL FOR", (0, combi_1.opt)("REPORT"), expressions_1.Source, (0, combi_1.opt)(options));
+        const ret = (0, combi_1.seq)("EDITOR-CALL FOR", (0, combi_1.optPrio)("REPORT"), expressions_1.Source, (0, combi_1.optPrio)(options));
         return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
     }
 }

package/build/src/abap/5_syntax/statements/editor_call.js

@@ -0,0 +1,17 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.EditorCall = void 0;
+const Expressions = require("../../2_statements/expressions");
+const source_1 = require("../expressions/source");
+class EditorCall {
+    runSyntax(node, scope, filename) {
+        for (const s of node.findDirectExpressions(Expressions.Source)) {
+            new source_1.Source().runSyntax(s, scope, filename);
+        }
+        for (const t of node.findDirectExpressions(Expressions.SimpleSource3)) {
+            new source_1.Source().runSyntax(t, scope, filename);
+        }
+    }
+}
+exports.EditorCall = EditorCall;
+//# sourceMappingURL=editor_call.js.map

package/build/src/abap/5_syntax/syntax.js

@@ -93,6 +93,7 @@ const close_dataset_1 = require("./statements/close_dataset");
 const get_run_time_1 = require("./statements/get_run_time");
 const update_database_1 = require("./statements/update_database");
 const add_1 = require("./statements/add");
+const editor_call_1 = require("./statements/editor_call");
 const subtract_1 = require("./statements/subtract");
 const add_corresponding_1 = require("./statements/add_corresponding");
 const subtract_corresponding_1 = require("./statements/subtract_corresponding");
@@ -268,6 +269,7 @@ if (Object.keys(map).length === 0) {
     addToMap(new translate_1.Translate());
     addToMap(new modify_internal_1.ModifyInternal());
     addToMap(new read_textpool_1.ReadTextpool());
+    addToMap(new editor_call_1.EditorCall());
 }
 // -----------------------------------
 class SyntaxLogic {

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.107.4";
+        return "2.108.0";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/align_pseudo_comments.js

@@ -0,0 +1,65 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.AlignPseudoComments = exports.AlignPseudoCommentsConf = void 0;
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+const issue_1 = require("../issue");
+const _statement_1 = require("../abap/2_statements/statements/_statement");
+class AlignPseudoCommentsConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.AlignPseudoCommentsConf = AlignPseudoCommentsConf;
+class AlignPseudoComments extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new AlignPseudoCommentsConf();
+    }
+    getMetadata() {
+        return {
+            key: "align_pseudo_comments",
+            title: "Align pseudo comments",
+            shortDescription: `Align code inspector pseudo comments in statements`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Whitespace],
+            badExample: `WRITE 'sdf'. "#EC sdf`,
+            goodExample: `WRITE 'sdf'.                                                "#EC sdf`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        const issues = [];
+        let previousEnd = undefined;
+        for (const statement of file.getStatements()) {
+            if (!(statement.get() instanceof _statement_1.Comment)) {
+                previousEnd = statement.getLastToken().getEnd();
+                continue;
+            }
+            const commentLength = statement.concatTokens().length;
+            const firstCommentToken = statement.getFirstToken();
+            if (firstCommentToken.getStr().startsWith(`"#`) === false) {
+                continue;
+            }
+            else if (previousEnd === undefined) {
+                continue;
+            }
+            else if (commentLength > 10) {
+                const expectedColumn = 72 - commentLength + 1;
+                if (previousEnd.getCol() < expectedColumn && firstCommentToken.getStart().getCol() !== expectedColumn) {
+                    const message = "Align pseudo comment to column " + expectedColumn;
+                    issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity));
+                }
+            }
+            else if (previousEnd.getCol() < 62 && firstCommentToken.getStart().getCol() !== 62) {
+                const message = "Align pseudo comment to column 62";
+                issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity));
+            }
+        }
+        return issues;
+    }
+}
+exports.AlignPseudoComments = AlignPseudoComments;
+//# sourceMappingURL=align_pseudo_comments.js.map

package/build/src/rules/index.js

@@ -17,6 +17,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 __exportStar(require("./7bit_ascii"), exports);
 __exportStar(require("./abapdoc"), exports);
 __exportStar(require("./align_parameters"), exports);
+__exportStar(require("./align_pseudo_comments"), exports);
 __exportStar(require("./align_type_expressions"), exports);
 __exportStar(require("./allowed_object_naming"), exports);
 __exportStar(require("./allowed_object_types"), exports);

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.107.4",
+    "version": "2.108.0",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,10 +50,10 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.43.1",
+        "@microsoft/api-extractor": "^7.43.2",
         "@types/chai": "^4.3.16",
         "@types/mocha": "^10.0.6",
-        "@types/node": "^20.12.8",
+        "@types/node": "^20.12.10",
         "chai": "^4.4.1",
         "eslint": "^8.57.0",
         "mocha": "^10.4.0",