@abaplint/core 2.106.7 → 2.106.9

package/build/src/abap/5_syntax/expressions/select.js

@@ -11,6 +11,7 @@ const _scope_type_1 = require("../_scope_type");
 const sql_source_1 = require("./sql_source");
 const sql_compare_1 = require("./sql_compare");
 const sql_order_by_1 = require("./sql_order_by");
+const dynamic_1 = require("./dynamic");
 const isSimple = /^\w+$/;
 class Select {
     runSyntax(node, scope, filename, skipImplicitInto = false) {
@@ -21,7 +22,7 @@ class Select {
         if (from === undefined) {
             throw new Error(`Missing FROM`);
         }
-        const fields = this.findFields(node);
+        const fields = this.findFields(node, scope, filename);
         if (fields.length === 0
             && node.findDirectExpression(Expressions.SQLFieldListLoop) === undefined) {
             throw new Error(`fields missing`);
@@ -179,17 +180,20 @@ class Select {
         }
         return new basic_1.VoidType("SELECT_todo");
     }
-    findFields(node) {
-        var _a;
+    findFields(node, scope, filename) {
+        var _a, _b;
         let expr = undefined;
         const ret = [];
         expr = node.findFirstExpression(Expressions.SQLFieldList);
         if (expr === undefined) {
             expr = node.findDirectExpression(Expressions.SQLFieldListLoop);
         }
+        if (((_a = expr === null || expr === void 0 ? void 0 : expr.getFirstChild()) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.Dynamic) {
+            new dynamic_1.Dynamic().runSyntax(expr.getFirstChild(), scope, filename);
+        }
         for (const field of (expr === null || expr === void 0 ? void 0 : expr.findDirectExpressionsMulti([Expressions.SQLField, Expressions.SQLFieldName])) || []) {
             let code = field.concatTokens().toUpperCase();
-            const as = ((_a = field.findDirectExpression(Expressions.SQLAsName)) === null || _a === void 0 ? void 0 : _a.concatTokens()) || "";
+            const as = ((_b = field.findDirectExpression(Expressions.SQLAsName)) === null || _b === void 0 ? void 0 : _b.concatTokens()) || "";
             if (as !== "") {
                 code = code.replace(" AS " + as, "");
             }

package/build/src/abap/5_syntax/expressions/sql_compare.js

@@ -4,13 +4,18 @@ exports.SQLCompare = void 0;
 const Expressions = require("../../2_statements/expressions");
 const nodes_1 = require("../../nodes");
 const basic_1 = require("../../types/basic");
+const dynamic_1 = require("./dynamic");
 const source_1 = require("./source");
 const sql_source_1 = require("./sql_source");
 class SQLCompare {
     runSyntax(node, scope, filename, tables) {
-        var _a;
+        var _a, _b;
         let sourceType;
         let token;
+        if (((_a = node.getFirstChild()) === null || _a === void 0 ? void 0 : _a.get()) instanceof Expressions.Dynamic) {
+            new dynamic_1.Dynamic().runSyntax(node.getFirstChild(), scope, filename);
+            return;
+        }
         for (const s of node.findAllExpressions(Expressions.SimpleSource3)) {
             new source_1.Source().runSyntax(s, scope, filename);
         }
@@ -36,7 +41,7 @@ class SQLCompare {
                 }
             }
         }
-        const fieldName = (_a = node.findDirectExpression(Expressions.SQLFieldName)) === null || _a === void 0 ? void 0 : _a.concatTokens();
+        const fieldName = (_b = node.findDirectExpression(Expressions.SQLFieldName)) === null || _b === void 0 ? void 0 : _b.concatTokens();
         if (fieldName && sourceType && token) {
             // check compatibility for rule sql_value_conversion
             const targetType = this.findType(fieldName, tables, scope);

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.106.7";
+        return "2.106.9";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/no_prefixes.js

@@ -22,6 +22,7 @@ class NoPrefixesConf extends _basic_rule_config_1.BasicRuleConfig {
         this.types = "^TY_";
         /** importing, exporting, returning and changing parameters, case insensitive regex */
         this.methodParameters = "^[ICER].?_";
+        this.allowIsPrefixBoolean = true;
         // todo, public localClass: string = "";
         // todo, public localInterface: string = "";
         // todo, public functionModuleParameters: string = "";
@@ -166,12 +167,18 @@ https://github.com/SAP/styleguides/blob/main/clean-abap/sub-sections/AvoidEncodi
         return ret;
     }
     checkMethodParameters(topNode, regex, file) {
+        var _a, _b;
         const ret = [];
         for (const method of topNode.findAllStatements(Statements.MethodDef)) {
-            for (const def of method.findAllExpressions(Expressions.MethodParamName)) {
-                const name = def.concatTokens();
-                if (name !== "" && name.match(regex)) {
-                    const issue = issue_1.Issue.atToken(file, def.getFirstToken(), MESSAGE, this.getMetadata().key, this.conf.severity);
+            for (const param of method.findAllExpressionsMulti([Expressions.MethodDefReturning, Expressions.MethodParam])) {
+                const nameToken = param === null || param === void 0 ? void 0 : param.findFirstExpression(Expressions.MethodParamName);
+                const type = (_b = (_a = param === null || param === void 0 ? void 0 : param.findFirstExpression(Expressions.TypeParam)) === null || _a === void 0 ? void 0 : _a.concatTokens()) === null || _b === void 0 ? void 0 : _b.toUpperCase();
+                if (this.getConfig().allowIsPrefixBoolean === true && (type === null || type === void 0 ? void 0 : type.endsWith("TYPE ABAP_BOOL"))) {
+                    continue;
+                }
+                const name = nameToken === null || nameToken === void 0 ? void 0 : nameToken.concatTokens();
+                if (nameToken && name && name !== "" && name.match(regex)) {
+                    const issue = issue_1.Issue.atToken(file, nameToken.getFirstToken(), MESSAGE, this.getMetadata().key, this.conf.severity);
                     ret.push(issue);
                 }
             }

package/build/src/rules/unused_methods.js

@@ -70,6 +70,7 @@ Skips:
 `,
             tags: [],
             pragma: "##CALLED",
+            pseudoComment: "EC CALLED",
         };
     }
     getConfig() {
@@ -146,11 +147,32 @@ Skips:
             if (statement.getPragmas().some(t => t.getStr() === this.getMetadata().pragma)) {
                 continue;
             }
+            else if (this.suppressedbyPseudo(statement, file)) {
+                continue;
+            }
             const message = "Method \"" + i.identifier.getName() + "\" not used";
             issues.push(issue_1.Issue.atIdentifier(i.identifier, message, this.getMetadata().key, this.conf.severity));
         }
         return issues;
     }
+    suppressedbyPseudo(statement, file) {
+        if (statement === undefined) {
+            return false;
+        }
+        if (file === undefined) {
+            return false;
+        }
+        let next = false;
+        for (const s of file.getStatements()) {
+            if (next === true && s.get() instanceof _statement_1.Comment) {
+                return s.concatTokens().includes(this.getMetadata().pseudoComment + "");
+            }
+            if (s === statement) {
+                next = true;
+            }
+        }
+        return false;
+    }
     searchGlobalSubclasses(obj) {
         var _a, _b;
         if (this.wa.getLength() === 0

package/build/src/rules/unused_types.js

@@ -59,6 +59,7 @@ class UnusedTypes {
             extendedInformation: `Unused types are not reported if the object contains parser or syntax errors.`,
             tags: [_irule_1.RuleTag.Quickfix],
             pragma: "##NEEDED",
+            pseudoComment: "EC NEEDED",
         };
     }
     getConfig() {
@@ -126,11 +127,32 @@ class UnusedTypes {
             if (statement.getPragmas().some(t => t.getStr() === this.getMetadata().pragma)) {
                 continue;
             }
+            else if (this.suppressedbyPseudo(statement, file)) {
+                continue;
+            }
             const fix = this.buildFix(file, statement);
             ret.push(issue_1.Issue.atIdentifier(t, message, this.getMetadata().key, this.conf.severity, fix));
         }
         return ret;
     }
+    suppressedbyPseudo(statement, file) {
+        if (statement === undefined) {
+            return false;
+        }
+        if (file === undefined) {
+            return false;
+        }
+        let next = false;
+        for (const s of file.getStatements()) {
+            if (next === true && s.get() instanceof _statement_1.Comment) {
+                return s.concatTokens().includes(this.getMetadata().pseudoComment + "");
+            }
+            if (s === statement) {
+                next = true;
+            }
+        }
+        return false;
+    }
     ////////////////////////////
     traverse(node, obj, add) {
         if (node.getIdentifier().stype !== _scope_type_1.ScopeType.BuiltIn) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.106.7",
+    "version": "2.106.9",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -59,7 +59,7 @@
         "mocha": "^10.4.0",
         "c8": "^9.1.0",
         "source-map-support": "^0.5.21",
-        "ts-json-schema-generator": "^2.0.1",
+        "ts-json-schema-generator": "=2.0.1",
         "typescript": "^5.4.5"
     },
     "dependencies": {