@abaplint/core 2.106.3 → 2.106.5

package/build/abaplint.d.ts

@@ -6980,6 +6980,7 @@ export declare enum Version {
     v755 = "v755",
     v756 = "v756",
     v757 = "v757",
+    v758 = "v758",
     Cloud = "Cloud"
 }
 

package/build/src/abap/2_statements/statements/return.js

@@ -2,9 +2,11 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.Return = void 0;
 const combi_1 = require("../combi");
+const version_1 = require("../../../version");
+const expressions_1 = require("../expressions");
 class Return {
     getMatcher() {
-        return (0, combi_1.str)("RETURN");
+        return (0, combi_1.seq)((0, combi_1.str)("RETURN"), (0, combi_1.optPrio)((0, combi_1.ver)(version_1.Version.v758, expressions_1.Source)));
     }
 }
 exports.Return = Return;

package/build/src/abap/5_syntax/_type_utils.js

@@ -117,6 +117,10 @@ class TypeUtils {
         if (tname === sname) {
             return true;
         }
+        /*
+            console.dir(sid);
+            console.dir(tid);
+        */
         if (!(sid instanceof types_1.ClassDefinition || sid instanceof types_1.InterfaceDefinition)) {
             const found = this.scope.findObjectDefinition(sid.getName());
             if (found) {
@@ -336,7 +340,11 @@ class TypeUtils {
             }
         }
         else if (source instanceof basic_1.GenericObjectReferenceType) {
-            if (target instanceof basic_1.ObjectReferenceType) {
+            if (target instanceof basic_1.ObjectReferenceType
+                || target instanceof basic_1.StringType
+                || target instanceof basic_1.CharacterType
+                || target instanceof basic_1.TableType
+                || target instanceof basic_1.CLikeType) {
                 return false;
             }
         }

package/build/src/abap/5_syntax/expressions/component_compare_simple.js

@@ -3,6 +3,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.ComponentCompareSimple = void 0;
 const Expressions = require("../../2_statements/expressions");
 const nodes_1 = require("../../nodes");
+const _type_utils_1 = require("../_type_utils");
 const component_chain_1 = require("./component_chain");
 const source_1 = require("./source");
 class ComponentCompareSimple {
@@ -17,7 +18,10 @@ class ComponentCompareSimple {
                     targetType = undefined;
                 }
                 else if (c.get() instanceof Expressions.Source) {
-                    new source_1.Source().runSyntax(c, scope, filename, targetType);
+                    const sourceType = new source_1.Source().runSyntax(c, scope, filename, targetType);
+                    if (targetType && new _type_utils_1.TypeUtils(scope).isAssignable(sourceType, targetType) === false) {
+                        throw new Error("ComponentCompareSimple, incompatible types");
+                    }
                 }
                 else {
                     throw "ComponentCompareSimple, unexpected node";

package/build/src/abap/5_syntax/expressions/method_parameters.js

@@ -98,6 +98,9 @@ class MethodParameters {
     checkChanging(node, scope, method, filename) {
         var _a;
         for (const item of this.parameterListT(node, scope, filename)) {
+            if (item.target.findFirstExpression(Expressions.InlineData) !== undefined) {
+                throw new Error("CHANGING cannot be inlined");
+            }
             let parameterType = undefined;
             if (method instanceof basic_1.VoidType) {
                 parameterType = method;

package/build/src/abap/5_syntax/expressions/value_body.js

@@ -9,6 +9,7 @@ const field_assignment_1 = require("./field_assignment");
 const basic_1 = require("../../types/basic");
 class ValueBody {
     runSyntax(node, scope, filename, targetType) {
+        var _a;
         if (node === undefined) {
             return targetType;
         }
@@ -24,8 +25,16 @@ class ValueBody {
                 forScopes++;
             }
         }
+        const fields = new Set();
         for (const s of node.findDirectExpressions(Expressions.FieldAssignment)) {
             new field_assignment_1.FieldAssignment().runSyntax(s, scope, filename, targetType);
+            const fieldname = (_a = s.findDirectExpression(Expressions.FieldSub)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
+            if (fieldname) {
+                if (fields.has(fieldname)) {
+                    throw new Error("Duplicate field assignment");
+                }
+                fields.add(fieldname);
+            }
         }
         let type = undefined; // todo, this is only correct if there is a single source in the body
         for (const s of node.findDirectExpressions(Expressions.Source)) {

package/build/src/abap/5_syntax/statements/do.js

@@ -3,11 +3,21 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.Do = void 0;
 const Expressions = require("../../2_statements/expressions");
 const source_1 = require("../expressions/source");
+const target_1 = require("../expressions/target");
+const _type_utils_1 = require("../_type_utils");
+const basic_1 = require("../../types/basic");
 class Do {
     runSyntax(node, scope, filename) {
-        // just recurse
+        const afterDo = node.findExpressionAfterToken("DO");
         for (const s of node.findDirectExpressions(Expressions.Source)) {
-            new source_1.Source().runSyntax(s, scope, filename);
+            const type = new source_1.Source().runSyntax(s, scope, filename);
+            if (s === afterDo
+                && new _type_utils_1.TypeUtils(scope).isAssignable(type, basic_1.IntegerType.get()) === false) {
+                throw new Error("DO TIMES must be numeric");
+            }
+        }
+        for (const t of node.findDirectExpressions(Expressions.Target)) {
+            new target_1.Target().runSyntax(t, scope, filename);
         }
     }
 }

package/build/src/abap/5_syntax/statements/insert_internal.js

@@ -16,7 +16,14 @@ class InsertInternal {
         if (t) {
             targetType = new target_1.Target().runSyntax(t, scope, filename);
         }
-        if (targetType instanceof basic_1.TableType
+        if (!(targetType instanceof basic_1.TableType)
+            && !(targetType instanceof basic_1.VoidType)
+            && !(targetType instanceof basic_1.AnyType)
+            && !(targetType instanceof basic_1.UnknownType)
+            && targetType !== undefined) {
+            throw new Error("INSERT target must be a table");
+        }
+        else if (targetType instanceof basic_1.TableType
             && node.findDirectTokenByText("LINES") === undefined) {
             targetType = targetType.getRowType();
         }
@@ -25,6 +32,13 @@ class InsertInternal {
             source = node.findDirectExpression(Expressions.Source);
         }
         const sourceType = source ? new source_1.Source().runSyntax(source, scope, filename, targetType) : targetType;
+        if (targetType === undefined
+            && !(sourceType instanceof basic_1.TableType)
+            && !(sourceType instanceof basic_1.VoidType)
+            && !(sourceType instanceof basic_1.AnyType)
+            && !(sourceType instanceof basic_1.UnknownType)) {
+            throw new Error("INSERT target must be a table");
+        }
         const afterAssigning = node.findExpressionAfterToken("ASSIGNING");
         if ((afterAssigning === null || afterAssigning === void 0 ? void 0 : afterAssigning.get()) instanceof Expressions.FSTarget) {
             const inlinefs = afterAssigning === null || afterAssigning === void 0 ? void 0 : afterAssigning.findDirectExpression(Expressions.InlineFS);
@@ -35,9 +49,14 @@ class InsertInternal {
                 new fstarget_1.FSTarget().runSyntax(afterAssigning, scope, filename, sourceType);
             }
         }
-        if (node.findDirectTokenByText("INITIAL") === undefined
-            && new _type_utils_1.TypeUtils(scope).isAssignableStrict(sourceType, targetType) === false) {
-            throw new Error("Types not compatible");
+        if (node.findDirectTokenByText("INITIAL") === undefined) {
+            if (new _type_utils_1.TypeUtils(scope).isAssignableStrict(sourceType, targetType) === false) {
+                throw new Error("Types not compatible");
+            }
+            else if (sourceType instanceof basic_1.CharacterType && targetType instanceof basic_1.StringType) {
+                // yea, well, INSERT doesnt convert the values automatically, like everything else?
+                throw new Error("Types not compatible");
+            }
         }
         const afterInto = node.findExpressionAfterToken("INTO");
         if ((afterInto === null || afterInto === void 0 ? void 0 : afterInto.get()) instanceof Expressions.Target && sourceType) {

package/build/src/abap/5_syntax/statements/read_table.js

@@ -46,11 +46,17 @@ class ReadTable {
                 throw new Error("READ TABLE, FROM must be compatible");
             }
         }
+        const afterKey = node.findExpressionAfterToken("KEY");
         for (const s of sources) {
             if (s === firstSource || s === indexSource || s === fromSource) {
                 continue;
             }
-            new source_1.Source().runSyntax(s, scope, filename);
+            const type = new source_1.Source().runSyntax(s, scope, filename);
+            if (s === afterKey) {
+                if (type instanceof basic_1.StringType || type instanceof basic_1.TableType || type instanceof basic_1.ObjectReferenceType) {
+                    throw new Error("Key cannot be string or table or reference");
+                }
+            }
         }
         const target = node.findDirectExpression(Expressions.ReadTableTarget);
         if (target) {

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.106.3";
+        return "2.106.5";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/begin_end_names.js

@@ -7,6 +7,7 @@ const _basic_rule_config_1 = require("./_basic_rule_config");
 const Structures = require("../abap/3_structures/structures");
 const Expressions = require("../abap/2_statements/expressions");
 const Statements = require("../abap/2_statements/statements");
+const _statement_1 = require("../abap/2_statements/statements/_statement");
 const _irule_1 = require("./_irule");
 const edit_helper_1 = require("../edit_helper");
 class BeginEndNamesConf extends _basic_rule_config_1.BasicRuleConfig {
@@ -43,6 +44,10 @@ class BeginEndNames extends _abap_rule_1.ABAPRule {
         if (struc === undefined) {
             return [];
         }
+        const containsUnknown = file.getStatements().some(s => s.get() instanceof _statement_1.Unknown);
+        if (containsUnknown === true) {
+            return [];
+        }
         output.push(...this.test(struc, Structures.Data, Statements.DataBegin, Statements.DataEnd, file));
         output.push(...this.test(struc, Structures.ClassData, Statements.ClassDataBegin, Statements.ClassDataEnd, file));
         output.push(...this.test(struc, Structures.Constants, Statements.ConstantBegin, Statements.ConstantEnd, file));

package/build/src/rules/unnecessary_pragma.js

@@ -8,6 +8,7 @@ const _abap_rule_1 = require("./_abap_rule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _statement_1 = require("../abap/2_statements/statements/_statement");
 const _irule_1 = require("./_irule");
+const edit_helper_1 = require("../edit_helper");
 class UnnecessaryPragmaConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
@@ -122,7 +123,8 @@ DATA: BEGIN OF blah ##NEEDED,
         if (statement.findFirstExpression(Expressions.ConstantString) === undefined
             && statement.findFirstExpression(Expressions.StringTemplate) === undefined) {
             const message = "There is no text, NO_TEXT can be removed";
-            return [issue_1.Issue.atToken(file, p, message, this.getMetadata().key, this.getConfig().severity)];
+            const fix = edit_helper_1.EditHelper.deleteToken(file, p);
+            return [issue_1.Issue.atToken(file, p, message, this.getMetadata().key, this.getConfig().severity, fix)];
         }
         return [];
     }
@@ -134,7 +136,8 @@ DATA: BEGIN OF blah ##NEEDED,
         const concat = next.concatTokens().toUpperCase();
         if (concat.includes(" SY-SUBRC")) {
             const message = "SUBRC_OK can be removed as sy-subrc is checked";
-            return [issue_1.Issue.atToken(file, p, message, this.getMetadata().key, this.getConfig().severity)];
+            const fix = edit_helper_1.EditHelper.deleteToken(file, p);
+            return [issue_1.Issue.atToken(file, p, message, this.getMetadata().key, this.getConfig().severity, fix)];
         }
         return [];
     }
@@ -161,7 +164,8 @@ DATA: BEGIN OF blah ##NEEDED,
             && !(statement.get() instanceof Statements.MethodDef)
             && statement.findFirstExpression(Expressions.InlineFS) === undefined) {
             const message = "There is no data definition, NEEDED can be removed";
-            return [issue_1.Issue.atToken(file, p, message, this.getMetadata().key, this.getConfig().severity)];
+            const fix = edit_helper_1.EditHelper.deleteToken(file, p);
+            return [issue_1.Issue.atToken(file, p, message, this.getMetadata().key, this.getConfig().severity, fix)];
         }
         return [];
     }

package/build/src/version.js

@@ -17,9 +17,10 @@ var Version;
     Version["v755"] = "v755";
     Version["v756"] = "v756";
     Version["v757"] = "v757";
+    Version["v758"] = "v758";
     Version["Cloud"] = "Cloud";
 })(Version || (exports.Version = Version = {}));
-exports.defaultVersion = Version.v757;
+exports.defaultVersion = Version.v758;
 function getPreviousVersion(v) {
     if (v === Version.OpenABAP) {
         return Version.v702;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.106.3",
+    "version": "2.106.5",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",