@abaplint/core 2.105.26 → 2.106.1

package/build/src/abap/2_statements/statements/concatenate.js

@@ -7,9 +7,9 @@ class Concatenate {
     getMatcher() {
         const mode = (0, combi_1.seq)("IN", (0, combi_1.altPrio)("BYTE", "CHARACTER"), "MODE");
         const blanks = (0, combi_1.str)("RESPECTING BLANKS");
-        const sep = (0, combi_1.seq)("SEPARATED BY", expressions_1.Source);
+        const sep = (0, combi_1.seq)("SEPARATED BY", expressions_1.SimpleSource3);
         const options = (0, combi_1.per)(mode, blanks, sep);
-        const sourc = (0, combi_1.seq)(expressions_1.Source, (0, combi_1.plus)(expressions_1.Source));
+        const sourc = (0, combi_1.seq)(expressions_1.SimpleSource3, (0, combi_1.plus)(expressions_1.SimpleSource3));
         const lines = (0, combi_1.seq)("LINES OF", expressions_1.Source);
         return (0, combi_1.seq)("CONCATENATE", (0, combi_1.altPrio)(lines, sourc), "INTO", expressions_1.Target, (0, combi_1.optPrio)(options));
     }

package/build/src/abap/5_syntax/_procedural.js

@@ -81,6 +81,7 @@ class Procedural {
             throw new Error("Function module definition \"" + name + "\" not found");
         }
         const ddic = new ddic_1.DDIC(this.reg);
+        const allNames = new Set();
         for (const param of definition.getParameters()) {
             let found = undefined;
             if (param.type === undefined || param.type === "") {
@@ -157,8 +158,16 @@ class Procedural {
             if (found instanceof basic_1.UnknownType && new ddic_1.DDIC(this.reg).inErrorNamespace(param.type) === false) {
                 found = new basic_1.VoidType(param.type);
             }
-            const type = new _typed_identifier_1.TypedIdentifier(nameToken, filename, found);
-            this.scope.addNamedIdentifier(param.name, type);
+            if (allNames.has(param.name.toUpperCase())) {
+                // yea, IMPORTING and EXPORTING can have the same name
+                // workaround to avoid false postivies, can be improved
+                continue;
+            }
+            else {
+                const type = new _typed_identifier_1.TypedIdentifier(nameToken, filename, found);
+                this.scope.addNamedIdentifier(param.name, type);
+                allNames.add(param.name.toUpperCase());
+            }
         }
     }
 }

package/build/src/abap/5_syntax/expressions/source.js

@@ -176,6 +176,8 @@ class Source {
         if (writeReference) {
             type.push(_reference_1.ReferenceType.DataWriteReference);
         }
+        let hexExpected = false;
+        let hexNext = false;
         while (children.length >= 0) {
             if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.MethodCallChain) {
                 context = new method_call_chain_1.MethodCallChain().runSyntax(first, scope, filename, targetType);
@@ -207,10 +209,29 @@ class Source {
                 if (first.concatTokens() === "**") {
                     context = new basic_1.FloatType();
                 }
+                const operator = first.concatTokens().toUpperCase();
+                if (operator === "BIT-OR" || operator === "BIT-AND" || operator === "BIT-XOR") {
+                    hexExpected = true;
+                    hexNext = true;
+                }
             }
             else if (first instanceof nodes_1.ExpressionNode && first.get() instanceof Expressions.AttributeChain) {
                 context = new attribute_chain_1.AttributeChain().runSyntax(context, first, scope, filename, type);
             }
+            if (hexExpected === true) {
+                if (!(context instanceof basic_1.VoidType)
+                    && !(context instanceof basic_1.XStringType)
+                    && !(context instanceof basic_1.HexType)
+                    && !(context instanceof basic_1.XGenericType)
+                    && !(context instanceof basic_1.XSequenceType)
+                    && !(context instanceof unknown_type_1.UnknownType)) {
+                    throw new Error("Operator only valid for XSTRING or HEX");
+                }
+                if (hexNext === false) {
+                    hexExpected = false;
+                }
+                hexNext = false;
+            }
             first = children.shift();
             if (first === undefined) {
                 break;

package/build/src/abap/5_syntax/statements/append.js

@@ -50,8 +50,15 @@ class Append {
             else if (targetType instanceof basic_1.VoidType) {
                 rowType = targetType;
             }
-            const sourceType = new source_1.Source().runSyntax(source, scope, filename, rowType);
+            let sourceType = new source_1.Source().runSyntax(source, scope, filename, rowType);
             if (node.findDirectTokenByText("LINES")) {
+                // hmm, checking only the row types are compatible will not check the table type, e.g. sorted or hashed
+                if (sourceType instanceof basic_1.TableType) {
+                    sourceType = sourceType.getRowType();
+                }
+                if (targetType instanceof basic_1.TableType) {
+                    targetType = targetType.getRowType();
+                }
                 if (new _type_utils_1.TypeUtils(scope).isAssignable(sourceType, targetType) === false) {
                     throw new Error("Incompatible types");
                 }

package/build/src/abap/5_syntax/statements/concatenate.js

@@ -10,7 +10,7 @@ const _type_utils_1 = require("../_type_utils");
 class Concatenate {
     runSyntax(node, scope, filename) {
         const byteMode = node.findDirectTokenByText("BYTE") !== undefined;
-        let linesMode = node.findDirectTokenByText("LINES") !== undefined;
+        const linesMode = node.findDirectTokenByText("LINES") !== undefined;
         const target = node.findFirstExpression(Expressions.Target);
         const inline = target === null || target === void 0 ? void 0 : target.findDirectExpression(Expressions.InlineData);
         if (inline) {
@@ -28,18 +28,21 @@ class Concatenate {
                 throw new Error("Target type not compatible");
             }
         }
-        for (const s of node.findDirectExpressions(Expressions.Source)) {
-            const type = new source_1.Source().runSyntax(s, scope, filename);
-            if (linesMode) {
+        if (linesMode) {
+            for (const s of node.findDirectExpressions(Expressions.Source)) {
+                const type = new source_1.Source().runSyntax(s, scope, filename);
                 if (!(type instanceof basic_1.UnknownType) && !(type instanceof basic_1.VoidType) && !(type instanceof basic_1.TableType)) {
                     throw new Error("Source must be an internal table");
                 }
-                linesMode = false;
-                continue;
             }
-            const compatible = byteMode ? new _type_utils_1.TypeUtils(scope).isHexLike(type) : new _type_utils_1.TypeUtils(scope).isCharLikeStrict(type);
-            if (compatible === false) {
-                throw new Error("Source type not compatible");
+        }
+        else {
+            for (const s of node.findDirectExpressions(Expressions.SimpleSource3)) {
+                const type = new source_1.Source().runSyntax(s, scope, filename);
+                const compatible = byteMode ? new _type_utils_1.TypeUtils(scope).isHexLike(type) : new _type_utils_1.TypeUtils(scope).isCharLikeStrict(type);
+                if (compatible === false) {
+                    throw new Error("Source type not compatible");
+                }
             }
         }
     }

package/build/src/abap/5_syntax/statements/modify_internal.js

@@ -13,7 +13,8 @@ class ModifyInternal {
             new source_1.Source().runSyntax(s, scope, filename);
         }
         // there is only one
-        const targetExpression = node.findFirstExpression(Expressions.Target);
+        const target = node.findFirstExpression(Expressions.Target);
+        const targetExpression = target;
         if (targetExpression) {
             // it might be a dynamic target
             const targetType = new target_1.Target().runSyntax(targetExpression, scope, filename);
@@ -30,13 +31,19 @@ class ModifyInternal {
                     throw new Error("Table does not have header line");
                 }
             }
+            else if (targetType instanceof basic_1.StructureType) {
+                // it might originate from a TABLES statement
+                if (target.concatTokens().toUpperCase() !== targetType.getDDICName()) {
+                    throw new Error("Not an internal table");
+                }
+            }
             else {
                 throw new Error("Not an internal table");
             }
         }
-        const target = node.findDirectExpression(Expressions.FSTarget);
-        if (target) {
-            new fstarget_1.FSTarget().runSyntax(target, scope, filename, undefined);
+        const fstarget = node.findDirectExpression(Expressions.FSTarget);
+        if (fstarget) {
+            new fstarget_1.FSTarget().runSyntax(fstarget, scope, filename, undefined);
         }
         for (const t of node.findDirectExpressions(Expressions.ComponentCond)) {
             new component_cond_1.ComponentCond().runSyntax(t, scope, filename);

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.105.26";
+        return "2.106.1";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/identical_conditions.js

@@ -37,6 +37,18 @@ class IdenticalConditions extends _abap_rule_1.ABAPRule {
 
 Prerequsites: code is pretty printed with identical cAsE`,
             tags: [_irule_1.RuleTag.SingleFile],
+            badExample: `IF foo = bar OR 1 = a OR foo = bar.
+ENDIF.
+CASE bar.
+  WHEN '1'.
+  WHEN 'A' OR '1'.
+ENDCASE.`,
+            goodExample: `IF foo = bar OR 1 = a.
+ENDIF.
+CASE bar.
+  WHEN '1'.
+  WHEN 'A'.
+ENDCASE.`,
         };
     }
     getConfig() {

package/build/src/rules/index.js

@@ -80,6 +80,7 @@ __exportStar(require("./in_statement_indentation"), exports);
 __exportStar(require("./indentation"), exports);
 __exportStar(require("./inline_data_old_versions"), exports);
 __exportStar(require("./intf_referencing_clas"), exports);
+__exportStar(require("./invalid_table_index"), exports);
 __exportStar(require("./keep_single_parameter_on_one_line"), exports);
 __exportStar(require("./keyword_case"), exports);
 __exportStar(require("./line_break_multiple_parameters"), exports);

package/build/src/rules/invalid_table_index.js

@@ -0,0 +1,73 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.InvalidTableIndex = exports.InvalidTableIndexConf = void 0;
+const issue_1 = require("../issue");
+const Expressions = require("../abap/2_statements/expressions");
+const _abap_rule_1 = require("./_abap_rule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const _irule_1 = require("./_irule");
+const edit_helper_1 = require("../edit_helper");
+const statements_1 = require("../abap/2_statements/statements");
+class InvalidTableIndexConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.InvalidTableIndexConf = InvalidTableIndexConf;
+class InvalidTableIndex extends _abap_rule_1.ABAPRule {
+    constructor() {
+        super(...arguments);
+        this.conf = new InvalidTableIndexConf();
+    }
+    getMetadata() {
+        return {
+            key: "invalid_table_index",
+            title: "Invalid Table Index",
+            shortDescription: `Issues error for constant table index zero, as ABAP starts from 1`,
+            tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
+            badExample: `DATA(first) = table[ 0 ].
+READ TABLE gt_stack ASSIGNING <ls_stack> INDEX 0.`,
+            goodExample: `DATA(first) = table[ 1 ].
+READ TABLE gt_stack ASSIGNING <ls_stack> INDEX 1.`,
+        };
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    runParsed(file) {
+        var _a, _b, _c, _d, _e, _f;
+        const issues = [];
+        const stru = file.getStructure();
+        if (stru === undefined) {
+            return issues; // parser error
+        }
+        const expr = stru.findAllExpressionsRecursive(Expressions.TableExpression);
+        for (const e of expr) {
+            const token = (_c = (_b = (_a = e.findDirectExpression(Expressions.Source)) === null || _a === void 0 ? void 0 : _a.findDirectExpression(Expressions.Constant)) === null || _b === void 0 ? void 0 : _b.findFirstExpression(Expressions.Integer)) === null || _c === void 0 ? void 0 : _c.getFirstToken();
+            if (token === undefined) {
+                continue;
+            }
+            if (token.getStr() === "0") {
+                const message = "Table index starts from 1";
+                const fix = edit_helper_1.EditHelper.replaceToken(file, token, "1");
+                const issue = issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.conf.severity, fix);
+                issues.push(issue);
+            }
+        }
+        for (const rt of stru.findAllStatements(statements_1.ReadTable)) {
+            const token = (_f = (_e = (_d = rt.findExpressionAfterToken("INDEX")) === null || _d === void 0 ? void 0 : _d.findDirectExpression(Expressions.Constant)) === null || _e === void 0 ? void 0 : _e.findFirstExpression(Expressions.Integer)) === null || _f === void 0 ? void 0 : _f.getFirstToken();
+            if (token === undefined) {
+                continue;
+            }
+            if (token.getStr() === "0") {
+                const message = "Table index starts from 1";
+                const fix = edit_helper_1.EditHelper.replaceToken(file, token, "1");
+                const issue = issue_1.Issue.atToken(file, token, message, this.getMetadata().key, this.conf.severity, fix);
+                issues.push(issue);
+            }
+        }
+        return issues;
+    }
+}
+exports.InvalidTableIndex = InvalidTableIndex;
+//# sourceMappingURL=invalid_table_index.js.map

package/build/src/rules/slow_parameter_passing.js

@@ -22,6 +22,24 @@ class SlowParameterPassing {
             shortDescription: `Detects slow pass by value passing for methods where parameter is not changed`,
             extendedInformation: `Method parameters defined in interfaces is not checked`,
             tags: [_irule_1.RuleTag.Performance],
+            badExample: `CLASS lcl DEFINITION.
+  PUBLIC SECTION.
+    METHODS bar IMPORTING VALUE(sdf) TYPE string.
+ENDCLASS.
+CLASS lcl IMPLEMENTATION.
+  METHOD bar.
+    WRITE sdf.
+  ENDMETHOD.
+ENDCLASS.`,
+            goodExample: `CLASS lcl DEFINITION.
+  PUBLIC SECTION.
+    METHODS bar IMPORTING sdf TYPE string.
+ENDCLASS.
+CLASS lcl IMPLEMENTATION.
+  METHOD bar.
+    WRITE sdf.
+  ENDMETHOD.
+ENDCLASS.`,
         };
     }
     getConfig() {

package/build/src/rules/strict_sql.js

@@ -30,6 +30,8 @@ Also see separate rule sql_escape_host_variables
 
 Activates from v750 and up`,
             tags: [_irule_1.RuleTag.Upport, _irule_1.RuleTag.Quickfix],
+            badExample: `SELECT * FROM ztabl INTO TABLE @rt_content WHERE type = @iv_type ORDER BY PRIMARY KEY.`,
+            goodExample: `SELECT * FROM ztabl WHERE type = @iv_type ORDER BY PRIMARY KEY INTO TABLE @rt_content.`,
         };
     }
     getConfig() {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.105.26",
+    "version": "2.106.1",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,17 +50,17 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.41.1",
+        "@microsoft/api-extractor": "^7.42.3",
         "@types/chai": "^4.3.12",
         "@types/mocha": "^10.0.6",
-        "@types/node": "^20.11.22",
+        "@types/node": "^20.11.25",
         "chai": "^4.4.1",
         "eslint": "^8.57.0",
         "mocha": "^10.3.0",
         "c8": "^9.1.0",
         "source-map-support": "^0.5.21",
         "ts-json-schema-generator": "^1.5.0",
-        "typescript": "^5.3.3"
+        "typescript": "^5.4.2"
     },
     "dependencies": {
         "fast-xml-parser": "^4.3.5",