@abaplint/core 2.105.23 → 2.105.25

package/build/src/abap/5_syntax/_type_utils.js

@@ -278,7 +278,8 @@ class TypeUtils {
                 }
                 return false;
             }
-            else if (target instanceof cgeneric_type_1.CGenericType) {
+            else if (target instanceof cgeneric_type_1.CGenericType
+                || target instanceof basic_1.GenericObjectReferenceType) {
                 return false;
             }
             else if (target instanceof basic_1.XSequenceType || target instanceof basic_1.XStringType) {
@@ -468,8 +469,14 @@ class TypeUtils {
             if (source instanceof basic_1.TableType && source.isWithHeader() === false) {
                 return false;
             }
+            else if (target instanceof basic_1.StringType
+                && source instanceof basic_1.StructureType
+                && this.isCharLike(source)) {
+                return true;
+            }
             else if (source instanceof basic_1.DataReference
                 || source instanceof basic_1.ObjectReferenceType
+                || source instanceof basic_1.StructureType
                 || source instanceof basic_1.GenericObjectReferenceType) {
                 return false;
             }

package/build/src/abap/5_syntax/expressions/conv_body.js

@@ -7,19 +7,22 @@ const let_1 = require("./let");
 class ConvBody {
     runSyntax(node, scope, filename) {
         if (node === undefined) {
-            return;
+            throw new Error("ConvBody, node undefined");
         }
         let scoped = false;
         const l = node.findDirectExpression(Expressions.Let);
         if (l) {
             scoped = new let_1.Let().runSyntax(l, scope, filename);
         }
-        for (const s of node.findDirectExpressions(Expressions.Source)) {
-            new source_1.Source().runSyntax(s, scope, filename);
+        const s = node.findDirectExpression(Expressions.Source);
+        if (s === undefined) {
+            throw new Error("ConvBody, no source found");
         }
+        const sourceType = new source_1.Source().runSyntax(s, scope, filename);
         if (scoped === true) {
             scope.pop(node.getLastToken().getEnd());
         }
+        return sourceType;
     }
 }
 exports.ConvBody = ConvBody;

package/build/src/abap/5_syntax/expressions/source.js

@@ -24,6 +24,7 @@ const _builtin_1 = require("../_builtin");
 const attribute_chain_1 = require("./attribute_chain");
 const dereference_1 = require("./dereference");
 const _typed_identifier_1 = require("../../types/_typed_identifier");
+const _type_utils_1 = require("../_type_utils");
 /*
 * Type interference, valid scenarios:
 * typed = VALUE #( ... ).         right hand side must follow left hand type
@@ -107,7 +108,10 @@ class Source {
                 case "CONV":
                     {
                         const foundType = this.determineType(node, scope, filename, targetType);
-                        new conv_body_1.ConvBody().runSyntax(node.findDirectExpression(Expressions.ConvBody), scope, filename);
+                        const bodyType = new conv_body_1.ConvBody().runSyntax(node.findDirectExpression(Expressions.ConvBody), scope, filename);
+                        if (new _type_utils_1.TypeUtils(scope).isAssignable(foundType, bodyType) === false) {
+                            throw new Error("CONV: Types not compatible");
+                        }
                         this.addIfInferred(node, scope, filename, foundType);
                         return foundType;
                     }

package/build/src/abap/5_syntax/statements/append.js

@@ -7,6 +7,7 @@ const target_1 = require("../expressions/target");
 const basic_1 = require("../../types/basic");
 const fstarget_1 = require("../expressions/fstarget");
 const inline_data_1 = require("../expressions/inline_data");
+const _type_utils_1 = require("../_type_utils");
 // todo: issue error for short APPEND if the source is without header line
 class Append {
     runSyntax(node, scope, filename) {
@@ -49,7 +50,17 @@ class Append {
             else if (targetType instanceof basic_1.VoidType) {
                 rowType = targetType;
             }
-            new source_1.Source().runSyntax(source, scope, filename, rowType);
+            const sourceType = new source_1.Source().runSyntax(source, scope, filename, rowType);
+            if (node.findDirectTokenByText("LINES")) {
+                if (new _type_utils_1.TypeUtils(scope).isAssignable(sourceType, targetType) === false) {
+                    throw new Error("Incompatible types");
+                }
+            }
+            else {
+                if (new _type_utils_1.TypeUtils(scope).isAssignable(sourceType, rowType) === false) {
+                    throw new Error("Incompatible types");
+                }
+            }
         }
         const from = node.findExpressionAfterToken("FROM");
         if (from && from.get() instanceof Expressions.Source) {

package/build/src/abap/5_syntax/statements/read_table.js

@@ -42,8 +42,8 @@ class ReadTable {
         const fromSource = node.findExpressionAfterToken("FROM");
         if (fromSource) {
             const fromType = new source_1.Source().runSyntax(fromSource, scope, filename);
-            if (new _type_utils_1.TypeUtils(scope).isAssignable(fromType, basic_1.IntegerType.get()) === false) {
-                throw new Error("READ TABLE, FROM must be simple");
+            if (new _type_utils_1.TypeUtils(scope).isAssignable(fromType, rowType) === false) {
+                throw new Error("READ TABLE, FROM must be compatible");
             }
         }
         for (const s of sources) {

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.105.23";
+        return "2.105.25";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.105.23",
+    "version": "2.105.25",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,10 +50,10 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.41.0",
+        "@microsoft/api-extractor": "^7.41.1",
         "@types/chai": "^4.3.12",
         "@types/mocha": "^10.0.6",
-        "@types/node": "^20.11.20",
+        "@types/node": "^20.11.22",
         "chai": "^4.4.1",
         "eslint": "^8.57.0",
         "mocha": "^10.3.0",