@abaplint/core 2.105.20 → 2.105.22

package/build/src/abap/5_syntax/_type_utils.js

@@ -26,6 +26,7 @@ class TypeUtils {
         }
         else if (type instanceof basic_1.StringType
             || type instanceof basic_1.AnyType
+            || type instanceof basic_1.DataType
             || type instanceof basic_1.CharacterType
             || type instanceof basic_1.SimpleType
             || type instanceof cgeneric_type_1.CGenericType

package/build/src/abap/5_syntax/expressions/new_object.js

@@ -109,7 +109,7 @@ class NewObject {
             new method_parameters_1.MethodParameters().checkExporting(parameters, scope, method, filename);
         }
         else if (requiredParameters.length > 0) {
-            throw new Error(`constructor parameter "${requiredParameters[0].getName()}" must be supplied` + name);
+            throw new Error(`constructor parameter "${requiredParameters[0].getName()}" must be supplied, ` + name);
         }
     }
     defaultImportingType(method) {

package/build/src/abap/5_syntax/statements/create_object.js

@@ -49,6 +49,7 @@ class CreateObject {
                 }
                 else if (!(found instanceof basic_1.ObjectReferenceType)
                     && !(found instanceof basic_1.AnyType)
+                    && !(found instanceof basic_1.DataType)
                     && !(found instanceof basic_1.GenericObjectReferenceType)) {
                     throw new Error("Target must be an object reference, " + t.concatTokens());
                 }

package/build/src/abap/5_syntax/statements/get_reference.js

@@ -12,7 +12,11 @@ class GetReference {
         const type = new source_1.Source().runSyntax(s, scope, filename);
         const target = node.findDirectExpression(Expressions.Target);
         const inline = target === null || target === void 0 ? void 0 : target.findDirectExpression(Expressions.InlineData);
+        // todo: error if inline field symbol
         if (inline) {
+            if (type instanceof basic_1.AnyType) {
+                throw new Error("GET REFERENCE generic and inline declaration not possible");
+            }
             new inline_data_1.InlineData().runSyntax(inline, scope, filename, type ? new basic_1.DataReference(type) : undefined);
         }
         else if (target) {

package/build/src/abap/5_syntax/statements/write.js

@@ -11,7 +11,10 @@ const _reference_1 = require("../_reference");
 class Write {
     runSyntax(node, scope, filename) {
         // todo, more
-        const second = node.getChildren()[1];
+        let second = node.getChildren()[1];
+        if (second.get() instanceof Expressions.WriteOffsetLength) {
+            second = node.getChildren()[2];
+        }
         for (const s of node.findAllExpressions(Expressions.Source)) {
             const type = new source_1.Source().runSyntax(s, scope, filename);
             if (s === second

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.105.20";
+        return "2.105.22";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/downport.js

@@ -1260,7 +1260,7 @@ ${indentation}CREATE OBJECT ${uniqueName2} EXPORTING textid = ${uniqueName1}.\n`
         return undefined;
     }
     downportRefSimple(high, lowFile, highSyntax) {
-        var _a;
+        var _a, _b;
         if (!(high.get() instanceof Statements.Move)
             || high.getChildren().length !== 4
             || high.getChildren()[2].getFirstToken().getStr().toUpperCase() !== "REF") {
@@ -1285,7 +1285,20 @@ ENDIF.
 GET REFERENCE OF <${uniqueName}> INTO ${target.concatTokens()}`;
         }
         else {
-            code = `GET REFERENCE OF ${sourceRef.concatTokens()} INTO ${target.concatTokens()}`;
+            const concat = target.concatTokens();
+            code = `GET REFERENCE OF ${sourceRef.concatTokens()} INTO ${concat}`;
+            // workaround for handling generic ANY type,
+            if (concat.toUpperCase().startsWith("DATA(")) {
+                const spag = highSyntax.spaghetti.lookupPosition(high.getFirstToken().getStart(), lowFile.getFilename());
+                if (spag !== undefined) {
+                    const found = spag.findVariable(sourceRef.concatTokens());
+                    const tt = found === null || found === void 0 ? void 0 : found.getType();
+                    if (tt instanceof basic_1.AnyType) {
+                        const tname = (_b = target.findFirstExpression(Expressions.TargetField)) === null || _b === void 0 ? void 0 : _b.concatTokens();
+                        code = `DATA ${tname} TYPE REF TO data.\nGET REFERENCE OF ${sourceRef.concatTokens()} INTO ${tname}`;
+                    }
+                }
+            }
         }
         const start = high.getFirstToken().getStart();
         const end = high.getLastToken().getStart();

package/build/src/rules/keep_single_parameter_on_one_line.js

@@ -126,6 +126,11 @@ class KeepSingleParameterCallsOnOneLine extends _abap_rule_1.ABAPRule {
     }
     isSingleParameter(c) {
         if (c.findDirectExpression(Expressions.Source)) {
+            for (const params of c.findAllExpressions(Expressions.ParameterListS)) {
+                if (params.getChildren().length > 1) {
+                    return false;
+                }
+            }
             return true;
         }
         const list = c.findDirectExpression(Expressions.ParameterListS);

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.105.20",
+    "version": "2.105.22",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -50,12 +50,12 @@
     },
     "homepage": "https://abaplint.org",
     "devDependencies": {
-        "@microsoft/api-extractor": "^7.40.3",
-        "@types/chai": "^4.3.11",
+        "@microsoft/api-extractor": "^7.41.0",
+        "@types/chai": "^4.3.12",
         "@types/mocha": "^10.0.6",
-        "@types/node": "^20.11.19",
+        "@types/node": "^20.11.20",
         "chai": "^4.4.1",
-        "eslint": "^8.56.0",
+        "eslint": "^8.57.0",
         "mocha": "^10.3.0",
         "c8": "^9.1.0",
         "source-map-support": "^0.5.21",
@@ -63,7 +63,7 @@
         "typescript": "^5.3.3"
     },
     "dependencies": {
-        "fast-xml-parser": "^4.3.4",
+        "fast-xml-parser": "^4.3.5",
         "json5": "^2.2.3",
         "vscode-languageserver-types": "^3.17.5"
     }