@abaplint/core 2.105.2 → 2.105.4

package/build/abaplint.d.ts

@@ -4676,6 +4676,29 @@ declare namespace Objects {
         MessagingChannel,
         MIMEObject,
         Namespace,
+        NeptuneAPI,
+        NeptuneApp,
+        NeptuneCustomColor,
+        NeptuneCustomJSHelper,
+        NeptuneDocumentation,
+        NeptuneEnhancement,
+        NeptuneLaunchpadLayout,
+        NeptuneLaunchpad,
+        NeptuneLoginPage,
+        NeptuneMediaLibrary,
+        NeptuneMediaPack,
+        NeptuneMetadata,
+        NeptuneMobileClient,
+        NeptuneOData,
+        NeptunePolicy,
+        NeptuneRFCMapping,
+        NeptuneRichTextTemplate,
+        NeptuneSplashScreen,
+        NeptuneStickyBanner,
+        NeptuneTileGroup,
+        NeptuneTileLayout,
+        NeptuneTile,
+        NeptuneURLAlias,
         NumberRange,
         Oauth2Profile,
         ObjectCharacteristic,
@@ -4703,6 +4726,7 @@ declare namespace Objects {
         SharedMemory,
         SmartForm,
         SmartStyle,
+        StandardTask,
         SwitchAssignmentHierarchy,
         SwitchAssignments,
         TableType,
@@ -4721,30 +4745,7 @@ declare namespace Objects {
         WebDynproApplication,
         WebDynproComponentConfiguration,
         WebDynproComponent,
-        WebMIME,
-        NeptuneMetadata,
-        NeptuneApp,
-        NeptuneAPI,
-        NeptuneLaunchpad,
-        NeptuneTileGroup,
-        NeptuneTile,
-        NeptunePolicy,
-        NeptuneLaunchpadLayout,
-        NeptuneTileLayout,
-        NeptuneEnhancement,
-        NeptuneLoginPage,
-        NeptuneStickyBanner,
-        NeptuneSplashScreen,
-        NeptuneCustomColor,
-        NeptuneRichTextTemplate,
-        NeptuneCustomJSHelper,
-        NeptuneDocumentation,
-        NeptuneRFCMapping,
-        NeptuneMediaLibrary,
-        NeptuneMediaPack,
-        NeptuneURLAlias,
-        NeptuneOData,
-        NeptuneMobileClient
+        WebMIME
     }
 }
 export { Objects }
@@ -5839,6 +5840,15 @@ declare class SQLUpTo extends Expression {
     getRunnable(): IStatementRunnable;
 }
 
+declare class StandardTask extends AbstractObject {
+    getType(): string;
+    getAllowedNaming(): {
+        maxLength: number;
+        allowNamespace: boolean;
+    };
+    getDescription(): string | undefined;
+}
+
 declare class StartOfSelection implements IStatement {
     getMatcher(): IStatementRunnable;
 }

package/build/src/abap/2_statements/statements/delete_memory.js

@@ -8,7 +8,8 @@ class DeleteMemory {
     getMatcher() {
         const memory = (0, combi_1.seq)("MEMORY ID", expressions_1.Source);
         const id = (0, combi_1.seq)("ID", expressions_1.Source);
-        const shared = (0, combi_1.seq)("SHARED MEMORY", expressions_1.Field, "(", expressions_1.Field, ")", id);
+        const client = (0, combi_1.seq)("CLIENT", expressions_1.Source);
+        const shared = (0, combi_1.seq)("SHARED MEMORY", expressions_1.Field, "(", expressions_1.Field, ")", (0, combi_1.optPrio)(client), id);
         const ret = (0, combi_1.seq)("DELETE FROM", (0, combi_1.alt)(memory, shared));
         return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
     }

package/build/src/abap/5_syntax/_type_utils.js

@@ -295,6 +295,9 @@ class TypeUtils {
                 }
                 return true;
             }
+            else if (target instanceof basic_1.CLikeType) {
+                return this.isCharLikeStrict(source);
+            }
             else if (target instanceof basic_1.VoidType || target instanceof basic_1.AnyType) {
                 return true;
             }
@@ -329,6 +332,8 @@ class TypeUtils {
         else if (source instanceof basic_1.ObjectReferenceType) {
             if (target instanceof basic_1.XSequenceType
                 || target instanceof basic_1.IntegerType
+                || target instanceof basic_1.StructureType
+                || target instanceof basic_1.TableType
                 || target instanceof basic_1.XStringType) {
                 return false;
             }

package/build/src/objects/index.js

@@ -99,6 +99,29 @@ __exportStar(require("./message_class"), exports);
 __exportStar(require("./messaging_channel"), exports);
 __exportStar(require("./mime_object"), exports);
 __exportStar(require("./namespace"), exports);
+__exportStar(require("./neptune_api"), exports);
+__exportStar(require("./neptune_app"), exports);
+__exportStar(require("./neptune_custom_color"), exports);
+__exportStar(require("./neptune_custom_js_helper"), exports);
+__exportStar(require("./neptune_documentation"), exports);
+__exportStar(require("./neptune_enhancement"), exports);
+__exportStar(require("./neptune_launchpad_layout"), exports);
+__exportStar(require("./neptune_launchpad"), exports);
+__exportStar(require("./neptune_login_page"), exports);
+__exportStar(require("./neptune_media_library"), exports);
+__exportStar(require("./neptune_media_pack"), exports);
+__exportStar(require("./neptune_metadata"), exports);
+__exportStar(require("./neptune_mobile_client"), exports);
+__exportStar(require("./neptune_odata"), exports);
+__exportStar(require("./neptune_policy"), exports);
+__exportStar(require("./neptune_rfc_mapping"), exports);
+__exportStar(require("./neptune_rich_text_template"), exports);
+__exportStar(require("./neptune_splash_screen"), exports);
+__exportStar(require("./neptune_sticky_banner"), exports);
+__exportStar(require("./neptune_tile_group"), exports);
+__exportStar(require("./neptune_tile_layout"), exports);
+__exportStar(require("./neptune_tile"), exports);
+__exportStar(require("./neptune_url_alias"), exports);
 __exportStar(require("./number_range"), exports);
 __exportStar(require("./oauth2_profile"), exports);
 __exportStar(require("./object_characteristic"), exports);
@@ -123,6 +146,7 @@ __exportStar(require("./service_definition"), exports);
 __exportStar(require("./shared_memory"), exports);
 __exportStar(require("./smart_form"), exports);
 __exportStar(require("./smart_style"), exports);
+__exportStar(require("./standard_task"), exports);
 __exportStar(require("./switch_assignment_hierarchy"), exports);
 __exportStar(require("./switch_assignments"), exports);
 __exportStar(require("./table_type"), exports);
@@ -140,27 +164,4 @@ __exportStar(require("./web_dynpro_application"), exports);
 __exportStar(require("./web_dynpro_component_configuration"), exports);
 __exportStar(require("./web_dynpro_component"), exports);
 __exportStar(require("./web_mime"), exports);
-__exportStar(require("./neptune_metadata"), exports);
-__exportStar(require("./neptune_app"), exports);
-__exportStar(require("./neptune_api"), exports);
-__exportStar(require("./neptune_launchpad"), exports);
-__exportStar(require("./neptune_tile_group"), exports);
-__exportStar(require("./neptune_tile"), exports);
-__exportStar(require("./neptune_policy"), exports);
-__exportStar(require("./neptune_launchpad_layout"), exports);
-__exportStar(require("./neptune_tile_layout"), exports);
-__exportStar(require("./neptune_enhancement"), exports);
-__exportStar(require("./neptune_login_page"), exports);
-__exportStar(require("./neptune_sticky_banner"), exports);
-__exportStar(require("./neptune_splash_screen"), exports);
-__exportStar(require("./neptune_custom_color"), exports);
-__exportStar(require("./neptune_rich_text_template"), exports);
-__exportStar(require("./neptune_custom_js_helper"), exports);
-__exportStar(require("./neptune_documentation"), exports);
-__exportStar(require("./neptune_rfc_mapping"), exports);
-__exportStar(require("./neptune_media_library"), exports);
-__exportStar(require("./neptune_media_pack"), exports);
-__exportStar(require("./neptune_url_alias"), exports);
-__exportStar(require("./neptune_odata"), exports);
-__exportStar(require("./neptune_mobile_client"), exports);
 //# sourceMappingURL=index.js.map

package/build/src/objects/standard_task.js

@@ -0,0 +1,21 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.StandardTask = void 0;
+const _abstract_object_1 = require("./_abstract_object");
+class StandardTask extends _abstract_object_1.AbstractObject {
+    getType() {
+        return "PDTS";
+    }
+    getAllowedNaming() {
+        return {
+            maxLength: 30,
+            allowNamespace: true,
+        };
+    }
+    getDescription() {
+        // todo
+        return undefined;
+    }
+}
+exports.StandardTask = StandardTask;
+//# sourceMappingURL=standard_task.js.map

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.105.2";
+        return "2.105.4";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/avoid_use.js

@@ -51,7 +51,9 @@ STATICS: use CLASS-DATA instead
 
 DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
 
-TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround`,
+TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround
+
+BREAK points`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };
     }

package/build/src/rules/no_prefixes.js

@@ -11,17 +11,17 @@ class NoPrefixesConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
         /** DATA, CLASS-DATA, DATA BEGIN OF, CLASS-DATA BEGIN OF, FINAL(), DATA(), case insensitive regex */
-        this.data = "^[lg]._";
+        this.data = "^[lg].?_";
         /** STATICS, STATICS BEGIN OF, case insensitive regex */
         this.statics = "";
         /** FIELD-SYMBOLS and inline FIELD-SYMBOLS(), case insensitive regex */
-        this.fieldSymbols = "^<l._";
+        this.fieldSymbols = "^<l.?_";
         /** CONSTANTS, CONSTANTS BEGIN OF, case insensitive regex */
         this.constants = "^[lg]c_";
         /** TYPES, ENUM, MESH, case insensitive regex */
         this.types = "^ty_";
         /** importing, exporting, returning and changing parameters, case insensitive regex */
-        this.methodParameters = "^[ierc]._";
+        this.methodParameters = "^[ierc].?_";
         // todo, public localClass: string = "";
         // todo, public localInterface: string = "";
         // todo, public functionModuleParameters: string = "";
@@ -43,6 +43,9 @@ class NoPrefixes extends _abap_rule_1.ABAPRule {
             title: "No Prefixes",
             shortDescription: `Dont use hungarian notation`,
             extendedInformation: `
+Note: not prefixing TYPES will require changing the errorNamespace in the abaplint configuration,
+allowing all types to become voided, abaplint will then provide less precise syntax errors.
+
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-encodings-esp-hungarian-notation-and-prefixes
 
 https://github.com/SAP/styleguides/blob/main/clean-abap/sub-sections/AvoidEncodings.md`,

package/build/src/rules/reduce_procedural_code.js

@@ -6,6 +6,7 @@ const _abap_rule_1 = require("./_abap_rule");
 const _irule_1 = require("./_irule");
 const Statements = require("../abap/2_statements/statements");
 const issue_1 = require("../issue");
+const _statement_1 = require("../abap/2_statements/statements/_statement");
 class ReduceProceduralCodeConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
@@ -25,7 +26,9 @@ class ReduceProceduralCode extends _abap_rule_1.ABAPRule {
             shortDescription: `Checks FORM and FUNCTION-MODULE have few statements`,
             extendedInformation: `Delegate logic to a class method instead of using FORM or FUNCTION-MODULE.
 
-https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-object-orientation-to-procedural-programming`,
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-object-orientation-to-procedural-programming
+
+Comments are not counted as statements.`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
             badExample: `FORM foo.
   DATA lv_bar TYPE i.
@@ -71,6 +74,9 @@ ENDFORM.`,
                 }
                 doCount = undefined;
             }
+            else if (statement.get() instanceof _statement_1.Comment) {
+                continue;
+            }
             else if (doCount !== undefined) {
                 count = count + 1;
             }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.105.2",
+    "version": "2.105.4",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -53,9 +53,9 @@
         "@microsoft/api-extractor": "^7.38.5",
         "@types/chai": "^4.3.11",
         "@types/mocha": "^10.0.6",
-        "@types/node": "^20.10.4",
+        "@types/node": "^20.10.5",
         "chai": "^4.3.10",
-        "eslint": "^8.55.0",
+        "eslint": "^8.56.0",
         "mocha": "^10.2.0",
         "c8": "^8.0.1",
         "source-map-support": "^0.5.21",