@abaplint/core 2.105.1 → 2.105.3

package/build/src/abap/5_syntax/_type_utils.js

@@ -295,6 +295,9 @@ class TypeUtils {
                 }
                 return true;
             }
+            else if (target instanceof basic_1.CLikeType) {
+                return this.isCharLikeStrict(source);
+            }
             else if (target instanceof basic_1.VoidType || target instanceof basic_1.AnyType) {
                 return true;
             }

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.105.1";
+        return "2.105.3";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/avoid_use.js

@@ -51,7 +51,9 @@ STATICS: use CLASS-DATA instead
 
 DESCRIBE TABLE LINES: use lines() instead (quickfix exists)
 
-TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround`,
+TEST-SEAMS: https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#use-test-seams-as-temporary-workaround
+
+BREAK points`,
             tags: [_irule_1.RuleTag.Styleguide, _irule_1.RuleTag.SingleFile],
         };
     }

package/build/src/rules/downport.js

@@ -367,6 +367,10 @@ Make sure to test the downported code, it might not always be completely correct
         if (found) {
             return found;
         }
+        found = this.assignComponent(low, high, lowFile, highSyntax);
+        if (found) {
+            return found;
+        }
         found = this.downportRefSimple(high, lowFile, highSyntax);
         if (found) {
             return found;
@@ -1476,6 +1480,28 @@ LOOP AT ${groupTargetName}tab ${groupTarget}.`;
         const fix = edit_helper_1.EditHelper.replaceRange(lowFile, high.getFirstToken().getStart(), high.getLastToken().getEnd(), code);
         return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Downport, ASSIGN table expr", this.getMetadata().key, this.conf.severity, fix);
     }
+    assignComponent(low, high, lowFile, highSyntax) {
+        if (!(low.get() instanceof _statement_1.Unknown)) {
+            return undefined;
+        }
+        if (!(high.get() instanceof Statements.Assign)) {
+            return undefined;
+        }
+        const assignSource = high.findDirectExpression(Expressions.AssignSource);
+        if (assignSource === undefined || assignSource.getFirstToken().getStr().toUpperCase() !== "COMPONENT") {
+            return undefined;
+        }
+        const componentSource = assignSource.findExpressionAfterToken("COMPONENT");
+        if (componentSource === undefined || componentSource.get() instanceof Expressions.SimpleSource3) {
+            return undefined;
+        }
+        const uniqueName = this.uniqueName(assignSource.getFirstToken().getStart(), lowFile.getFilename(), highSyntax);
+        const code = `DATA(${uniqueName}) = ${componentSource.concatTokens()}.\n`;
+        const fix1 = edit_helper_1.EditHelper.insertAt(lowFile, high.getFirstToken().getStart(), code);
+        const fix2 = edit_helper_1.EditHelper.replaceRange(lowFile, componentSource.getFirstToken().getStart(), componentSource.getLastToken().getEnd(), uniqueName);
+        const fix = edit_helper_1.EditHelper.merge(fix2, fix1);
+        return issue_1.Issue.atToken(lowFile, high.getFirstToken(), "Downport, ASSIGN COMPONENT source", this.getMetadata().key, this.conf.severity, fix);
+    }
     moveWithSimpleValue(low, high, lowFile) {
         if (!(low.get() instanceof _statement_1.Unknown)) {
             return undefined;

package/build/src/rules/no_prefixes.js

@@ -11,17 +11,17 @@ class NoPrefixesConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
         /** DATA, CLASS-DATA, DATA BEGIN OF, CLASS-DATA BEGIN OF, FINAL(), DATA(), case insensitive regex */
-        this.data = "^[lg]._";
+        this.data = "^[lg].?_";
         /** STATICS, STATICS BEGIN OF, case insensitive regex */
         this.statics = "";
         /** FIELD-SYMBOLS and inline FIELD-SYMBOLS(), case insensitive regex */
-        this.fieldSymbols = "^<l._";
+        this.fieldSymbols = "^<l.?_";
         /** CONSTANTS, CONSTANTS BEGIN OF, case insensitive regex */
         this.constants = "^[lg]c_";
         /** TYPES, ENUM, MESH, case insensitive regex */
         this.types = "^ty_";
         /** importing, exporting, returning and changing parameters, case insensitive regex */
-        this.methodParameters = "^[ierc]._";
+        this.methodParameters = "^[ierc].?_";
         // todo, public localClass: string = "";
         // todo, public localInterface: string = "";
         // todo, public functionModuleParameters: string = "";
@@ -43,6 +43,9 @@ class NoPrefixes extends _abap_rule_1.ABAPRule {
             title: "No Prefixes",
             shortDescription: `Dont use hungarian notation`,
             extendedInformation: `
+Note: not prefixing TYPES will require changing the errorNamespace in the abaplint configuration,
+allowing all types to become voided, abaplint will then provide less precise syntax errors.
+
 https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#avoid-encodings-esp-hungarian-notation-and-prefixes
 
 https://github.com/SAP/styleguides/blob/main/clean-abap/sub-sections/AvoidEncodings.md`,

package/build/src/rules/reduce_procedural_code.js

@@ -6,6 +6,7 @@ const _abap_rule_1 = require("./_abap_rule");
 const _irule_1 = require("./_irule");
 const Statements = require("../abap/2_statements/statements");
 const issue_1 = require("../issue");
+const _statement_1 = require("../abap/2_statements/statements/_statement");
 class ReduceProceduralCodeConf extends _basic_rule_config_1.BasicRuleConfig {
     constructor() {
         super(...arguments);
@@ -25,7 +26,9 @@ class ReduceProceduralCode extends _abap_rule_1.ABAPRule {
             shortDescription: `Checks FORM and FUNCTION-MODULE have few statements`,
             extendedInformation: `Delegate logic to a class method instead of using FORM or FUNCTION-MODULE.
 
-https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-object-orientation-to-procedural-programming`,
+https://github.com/SAP/styleguides/blob/main/clean-abap/CleanABAP.md#prefer-object-orientation-to-procedural-programming
+
+Comments are not counted as statements.`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Styleguide],
             badExample: `FORM foo.
   DATA lv_bar TYPE i.
@@ -71,6 +74,9 @@ ENDFORM.`,
                 }
                 doCount = undefined;
             }
+            else if (statement.get() instanceof _statement_1.Comment) {
+                continue;
+            }
             else if (doCount !== undefined) {
                 count = count + 1;
             }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.105.1",
+    "version": "2.105.3",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",