@abaplint/core 2.102.70 → 2.103.1

package/build/abaplint.d.ts

@@ -1719,6 +1719,19 @@ declare class Dynamic extends Expression {
     getRunnable(): IStatementRunnable;
 }
 
+declare type DynproField = {
+    name: string;
+    type: string;
+    length: number;
+};
+
+declare type DynproHeader = {
+    number: string;
+    fields: DynproField[];
+};
+
+declare type DynproList = DynproHeader[];
+
 declare class EcattTestConfiguration extends AbstractObject {
     getType(): string;
     getAllowedNaming(): {
@@ -4423,6 +4436,9 @@ declare namespace Objects {
         Package,
         Parameter,
         PersonalizationObject,
+        DynproField,
+        DynproHeader,
+        DynproList,
         Program,
         ProxyObject,
         PushChannel,
@@ -4728,7 +4744,8 @@ declare class Program extends ABAPObject {
     setDirty(): void;
     isInclude(): boolean;
     isModulePool(): boolean;
-    parseXML(): void;
+    getDynpros(): DynproList;
+    private parseXML;
 }
 
 declare class Program_2 implements IStatement {

package/build/src/abap/types/class_definition.js

@@ -107,13 +107,14 @@ class ClassDefinition extends _identifier_1.Identifier {
         while (sup !== undefined) {
             const cdef = scope.findClassDefinition(sup);
             for (const m of ((_a = cdef === null || cdef === void 0 ? void 0 : cdef.getMethodDefinitions()) === null || _a === void 0 ? void 0 : _a.getAll()) || []) {
+                const name = m.getName().toUpperCase();
                 if (m.getVisibility() === visibility_1.Visibility.Private) {
                     continue;
                 }
-                else if (m.getName().toUpperCase() === "CONSTRUCTOR") {
+                else if (name === "CONSTRUCTOR" || name === "CLASS_CONSTRUCTOR") {
                     continue;
                 }
-                names.add(m.getName().toUpperCase());
+                names.add(name);
             }
             for (const a of (cdef === null || cdef === void 0 ? void 0 : cdef.getAliases().getAll()) || []) {
                 names.add(a.getName().toUpperCase());

package/build/src/objects/program.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.Program = void 0;
 const _abap_object_1 = require("./_abap_object");
+const xml_utils_1 = require("../xml_utils");
 class Program extends _abap_object_1.ABAPObject {
     getType() {
         return "PROG";
@@ -35,14 +36,49 @@ class Program extends _abap_object_1.ABAPObject {
         this.parseXML();
         return this.parsedXML.isModulePool;
     }
+    getDynpros() {
+        this.parseXML();
+        return this.parsedXML.dynpros;
+    }
+    ////////////////////////////
     parseXML() {
-        if (this.parsedXML === undefined) {
-            const file = this.getXMLFile();
+        var _a, _b, _c, _d;
+        if (this.parsedXML !== undefined) {
+            return;
+        }
+        const file = this.getXMLFile();
+        const parsed = this.parseRaw2();
+        if (parsed === undefined) {
             this.parsedXML = {
-                isInclude: file ? file.getRaw().includes("<SUBC>I</SUBC>") : false,
-                isModulePool: file ? file.getRaw().includes("<SUBC>M</SUBC>") : false,
+                isInclude: false,
+                isModulePool: false,
+                dynpros: [],
             };
+            return;
         }
+        const dynpros = [];
+        const xmlDynpros = (_c = (_b = (_a = parsed.abapGit) === null || _a === void 0 ? void 0 : _a["asx:abap"]) === null || _b === void 0 ? void 0 : _b["asx:values"]) === null || _c === void 0 ? void 0 : _c.DYNPROS;
+        if (xmlDynpros !== undefined) {
+            for (const d of (0, xml_utils_1.xmlToArray)(xmlDynpros.item)) {
+                const fields = [];
+                for (const f of (0, xml_utils_1.xmlToArray)((_d = d.FIELDS) === null || _d === void 0 ? void 0 : _d.RPY_DYFATC)) {
+                    fields.push({
+                        name: f.NAME,
+                        type: f.TYPE,
+                        length: f.LENGTH,
+                    });
+                }
+                dynpros.push({
+                    number: d.HEADER.SCREEN,
+                    fields: fields,
+                });
+            }
+        }
+        this.parsedXML = {
+            isInclude: file ? file.getRaw().includes("<SUBC>I</SUBC>") : false,
+            isModulePool: file ? file.getRaw().includes("<SUBC>M</SUBC>") : false,
+            dynpros: dynpros,
+        };
     }
 }
 exports.Program = Program;

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.102.70";
+        return "2.103.1";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/dynpro_checks.js

@@ -0,0 +1,55 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.DynproChecks = exports.DynproChecksConf = void 0;
+const issue_1 = require("../issue");
+const _irule_1 = require("./_irule");
+const _basic_rule_config_1 = require("./_basic_rule_config");
+const objects_1 = require("../objects");
+const position_1 = require("../position");
+class DynproChecksConf extends _basic_rule_config_1.BasicRuleConfig {
+}
+exports.DynproChecksConf = DynproChecksConf;
+class DynproChecks {
+    constructor() {
+        this.conf = new DynproChecksConf();
+    }
+    getMetadata() {
+        return {
+            key: "dynpro_checks",
+            title: "Dynpro Checks",
+            shortDescription: `Various Dynpro checks`,
+            extendedInformation: `* Check length of PUSH elements less than 132`,
+            tags: [_irule_1.RuleTag.Syntax],
+        };
+    }
+    initialize(_reg) {
+        return this;
+    }
+    getConfig() {
+        return this.conf;
+    }
+    setConfig(conf) {
+        this.conf = conf;
+    }
+    run(obj) {
+        const ret = [];
+        if (!(obj instanceof objects_1.Program)) {
+            return [];
+        }
+        const file = obj.getXMLFile();
+        if (file === undefined) {
+            return [];
+        }
+        for (const dynpro of obj.getDynpros()) {
+            for (const field of dynpro.fields) {
+                if (field.type === "PUSH" && field.length > 132) {
+                    const message = `Screen ${dynpro.number}, field ${field.name} LENGTH longer than 132`;
+                    ret.push(issue_1.Issue.atPosition(file, new position_1.Position(1, 1), message, this.getMetadata().key, this.getConfig().severity));
+                }
+            }
+        }
+        return ret;
+    }
+}
+exports.DynproChecks = DynproChecks;
+//# sourceMappingURL=dynpro_checks.js.map

package/build/src/rules/index.js

@@ -53,6 +53,7 @@ __exportStar(require("./definitions_top"), exports);
 __exportStar(require("./description_empty"), exports);
 __exportStar(require("./double_space"), exports);
 __exportStar(require("./downport"), exports);
+__exportStar(require("./dynpro_checks"), exports);
 __exportStar(require("./easy_to_find_messages"), exports);
 __exportStar(require("./empty_line_in_statement"), exports);
 __exportStar(require("./empty_statement"), exports);

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.102.70",
+    "version": "2.103.1",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",