@abaplint/core 2.102.47 → 2.102.49

package/build/abaplint.d.ts

@@ -2001,6 +2001,7 @@ declare class ExpressionNode extends AbstractNode<ExpressionNode | TokenNode> {
     findDirectExpression(type: new () => IStatementRunnable): ExpressionNode | undefined;
     findExpressionAfterToken(text: string): ExpressionNode | undefined;
     findDirectExpressions(type: new () => IStatementRunnable): readonly ExpressionNode[];
+    findDirectExpressionsMulti(type: (new () => IStatementRunnable)[]): ExpressionNode[];
     findDirectTokenByText(text: string): Token | undefined;
     findAllExpressionsRecursive(type: new () => IStatementRunnable): readonly ExpressionNode[];
     findAllExpressions(type: new () => IStatementRunnable): readonly ExpressionNode[];
@@ -2186,6 +2187,7 @@ declare namespace Expressions {
         SQLHaving,
         SQLHints,
         SQLIn,
+        SQLIntoList,
         SQLIntoStructure,
         SQLIntoTable,
         SQLJoin,
@@ -5475,6 +5477,10 @@ declare class SQLIn extends Expression {
     getRunnable(): IStatementRunnable;
 }
 
+declare class SQLIntoList extends Expression {
+    getRunnable(): IStatementRunnable;
+}
+
 declare class SQLIntoStructure extends Expression {
     getRunnable(): IStatementRunnable;
 }

package/build/src/abap/2_statements/expressions/index.js

@@ -191,6 +191,7 @@ __exportStar(require("./sql_group_by"), exports);
 __exportStar(require("./sql_having"), exports);
 __exportStar(require("./sql_hints"), exports);
 __exportStar(require("./sql_in"), exports);
+__exportStar(require("./sql_into_list"), exports);
 __exportStar(require("./sql_into_structure"), exports);
 __exportStar(require("./sql_into_table"), exports);
 __exportStar(require("./sql_join"), exports);

package/build/src/abap/2_statements/expressions/select.js

@@ -11,13 +11,13 @@ const sql_field_name_1 = require("./sql_field_name");
 const sql_up_to_1 = require("./sql_up_to");
 class Select extends combi_1.Expression {
     getRunnable() {
-        const into = (0, combi_1.altPrio)(_1.SQLIntoTable, sql_into_structure_1.SQLIntoStructure);
+        const into = (0, combi_1.altPrio)(_1.SQLIntoTable, sql_into_structure_1.SQLIntoStructure, _1.SQLIntoList);
         const where = (0, combi_1.seq)("WHERE", _1.SQLCond);
         const offset = (0, combi_1.ver)(version_1.Version.v751, (0, combi_1.seq)("OFFSET", _1.SQLSource));
         const bypass = (0, combi_1.str)("BYPASSING BUFFER");
         const fields = (0, combi_1.ver)(version_1.Version.v750, _1.SQLFields);
         const perm = (0, combi_1.per)(_1.SQLFrom, into, _1.SQLForAllEntries, where, _1.SQLOrderBy, sql_up_to_1.SQLUpTo, offset, _1.SQLClient, _1.SQLHaving, bypass, sql_group_by_1.SQLGroupBy, fields, _1.DatabaseConnection);
-        const permSingle = (0, combi_1.per)(_1.SQLFrom, sql_into_structure_1.SQLIntoStructure, where, _1.SQLClient, bypass, fields, _1.DatabaseConnection);
+        const permSingle = (0, combi_1.per)(_1.SQLFrom, (0, combi_1.altPrio)(sql_into_structure_1.SQLIntoStructure, _1.SQLIntoList), where, _1.SQLClient, bypass, fields, _1.DatabaseConnection);
         const paren = (0, combi_1.seq)((0, combi_1.tok)(tokens_1.WParenLeftW), sql_field_name_1.SQLFieldName, (0, combi_1.tok)(tokens_1.WParenRightW));
         const fieldList = (0, combi_1.optPrio)((0, combi_1.altPrio)(_1.SQLFieldList, paren));
         const single = (0, combi_1.seq)("SINGLE", (0, combi_1.optPrio)("FOR UPDATE"), fieldList, permSingle);

package/build/src/abap/2_statements/expressions/select_loop.js

@@ -17,8 +17,9 @@ class SelectLoop extends combi_1.Expression {
         const pack = (0, combi_1.seq)("PACKAGE SIZE", _1.SQLSource);
         const tab = (0, combi_1.seq)(_1.SQLIntoTable, (0, combi_1.alt)(pack, (0, combi_1.seq)(_1.SQLFrom, pack), (0, combi_1.seq)(pack, _1.SQLFrom)));
         const packTab = (0, combi_1.seq)(pack, _1.SQLIntoTable);
-        const perm = (0, combi_1.per)(_1.SQLFrom, where, sql_up_to_1.SQLUpTo, sql_order_by_1.SQLOrderBy, sql_having_1.SQLHaving, _1.SQLClient, bypass, _1.SQLGroupBy, _1.SQLForAllEntries, (0, combi_1.alt)(tab, sql_into_structure_1.SQLIntoStructure, packTab));
-        const strict = (0, combi_1.seq)(_1.SQLFrom, (0, combi_1.ver)(version_1.Version.v750, _1.SQLFields), where, sql_into_structure_1.SQLIntoStructure, sql_up_to_1.SQLUpTo);
+        const into = (0, combi_1.altPrio)(sql_into_structure_1.SQLIntoStructure, _1.SQLIntoList);
+        const perm = (0, combi_1.per)(_1.SQLFrom, where, sql_up_to_1.SQLUpTo, sql_order_by_1.SQLOrderBy, sql_having_1.SQLHaving, _1.SQLClient, bypass, _1.SQLGroupBy, _1.SQLForAllEntries, (0, combi_1.alt)(tab, into, packTab));
+        const strict = (0, combi_1.seq)(_1.SQLFrom, (0, combi_1.ver)(version_1.Version.v750, _1.SQLFields), where, into, sql_up_to_1.SQLUpTo);
         const ret = (0, combi_1.seq)("SELECT", (0, combi_1.altPrio)((0, combi_1.seq)((0, combi_1.optPrio)("DISTINCT"), sql_field_list_loop_1.SQLFieldListLoop, perm), strict), (0, combi_1.optPrio)(sql_hints_1.SQLHints));
         return ret;
     }

package/build/src/abap/2_statements/expressions/sql_into_list.js

@@ -0,0 +1,14 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.SQLIntoList = void 0;
+const combi_1 = require("../combi");
+const _1 = require(".");
+const paren_left_1 = require("../../1_lexer/tokens/paren_left");
+class SQLIntoList extends combi_1.Expression {
+    getRunnable() {
+        const intoList = (0, combi_1.seq)((0, combi_1.altPrio)((0, combi_1.tok)(paren_left_1.WParenLeft), (0, combi_1.tok)(paren_left_1.WParenLeftW)), (0, combi_1.starPrio)((0, combi_1.seq)(_1.SQLTarget, ",")), _1.SQLTarget, ")");
+        return (0, combi_1.seq)("INTO", intoList);
+    }
+}
+exports.SQLIntoList = SQLIntoList;
+//# sourceMappingURL=sql_into_list.js.map

package/build/src/abap/2_statements/expressions/sql_into_structure.js

@@ -3,12 +3,10 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.SQLIntoStructure = void 0;
 const combi_1 = require("../combi");
 const _1 = require(".");
-const paren_left_1 = require("../../1_lexer/tokens/paren_left");
 class SQLIntoStructure extends combi_1.Expression {
     getRunnable() {
-        const intoList = (0, combi_1.seq)((0, combi_1.altPrio)((0, combi_1.tok)(paren_left_1.WParenLeft), (0, combi_1.tok)(paren_left_1.WParenLeftW)), (0, combi_1.starPrio)((0, combi_1.seq)(_1.SQLTarget, ",")), _1.SQLTarget, ")");
         const intoSimple = (0, combi_1.seq)((0, combi_1.optPrio)("CORRESPONDING FIELDS OF"), _1.SQLTarget);
-        return (0, combi_1.seq)("INTO", (0, combi_1.altPrio)(intoList, intoSimple));
+        return (0, combi_1.seq)("INTO", intoSimple);
     }
 }
 exports.SQLIntoStructure = SQLIntoStructure;

package/build/src/abap/2_statements/statements/fetch_next_cursor.js

@@ -8,7 +8,7 @@ const sql_into_structure_1 = require("../expressions/sql_into_structure");
 class FetchNextCursor {
     getMatcher() {
         const size = (0, combi_1.seq)("PACKAGE SIZE", expressions_1.SQLSourceSimple);
-        const ret = (0, combi_1.seq)("FETCH NEXT CURSOR", expressions_1.SQLSourceSimple, (0, combi_1.alt)(sql_into_structure_1.SQLIntoStructure, expressions_1.SQLIntoTable), (0, combi_1.optPrio)(size));
+        const ret = (0, combi_1.seq)("FETCH NEXT CURSOR", expressions_1.SQLSourceSimple, (0, combi_1.alt)(sql_into_structure_1.SQLIntoStructure, expressions_1.SQLIntoTable, expressions_1.SQLIntoList), (0, combi_1.optPrio)(size));
         return (0, combi_1.verNot)(version_1.Version.Cloud, ret);
     }
 }

package/build/src/abap/5_syntax/_type_utils.js

@@ -320,6 +320,11 @@ class TypeUtils {
                 return false;
             }
         }
+        else if (source instanceof basic_1.GenericObjectReferenceType) {
+            if (target instanceof basic_1.ObjectReferenceType) {
+                return false;
+            }
+        }
         else if (source instanceof basic_1.ObjectReferenceType) {
             if (target instanceof basic_1.XSequenceType
                 || target instanceof basic_1.IntegerType

package/build/src/abap/5_syntax/expressions/select.js

@@ -10,6 +10,7 @@ const sql_for_all_entries_1 = require("./sql_for_all_entries");
 const _scope_type_1 = require("../_scope_type");
 const sql_source_1 = require("./sql_source");
 const sql_compare_1 = require("./sql_compare");
+const isSimple = /^\w+$/;
 class Select {
     runSyntax(node, scope, filename, skipImplicitInto = false) {
         var _a, _b;
@@ -22,10 +23,7 @@ class Select {
             throw new Error(`fields missing`);
         }
         this.checkFields(fields, dbSources, scope);
-        for (const inline of node.findAllExpressions(Expressions.InlineData)) {
-            // todo, for now these are voided
-            new inline_data_1.InlineData().runSyntax(inline, scope, filename, this.buildType(fields));
-        }
+        this.handleInto(node, scope, filename, fields, dbSources);
         const fae = node.findDirectExpression(Expressions.SQLForAllEntries);
         if (fae) {
             scope.push(_scope_type_1.ScopeType.OpenSQL, "SELECT", token.getStart(), filename);
@@ -37,6 +35,7 @@ class Select {
         // check implicit into, the target field is implict equal to the table name
         if (skipImplicitInto === false
             && node.findDirectExpression(Expressions.SQLIntoTable) === undefined
+            && node.findDirectExpression(Expressions.SQLIntoList) === undefined
             && node.findDirectExpression(Expressions.SQLIntoStructure) === undefined) {
             const fields = (_a = node.findFirstExpression(Expressions.SQLAggregation)) === null || _a === void 0 ? void 0 : _a.concatTokens();
             const c = new RegExp(/^count\(\s*\*\s*\)$/, "i");
@@ -68,6 +67,54 @@ class Select {
             scope.pop(node.getLastToken().getEnd());
         }
     }
+    handleInto(node, scope, filename, fields, dbSources) {
+        const intoTable = node.findDirectExpression(Expressions.SQLIntoTable);
+        if (intoTable) {
+            const inline = intoTable.findFirstExpression(Expressions.InlineData);
+            if (inline) {
+                new inline_data_1.InlineData().runSyntax(inline, scope, filename, this.buildTableType(fields, dbSources, scope));
+            }
+        }
+        const intoStructure = node.findDirectExpression(Expressions.SQLIntoStructure);
+        if (intoStructure) {
+            for (const inline of intoStructure.findAllExpressions(Expressions.InlineData)) {
+                // todo, for now these are voided
+                new inline_data_1.InlineData().runSyntax(inline, scope, filename, new basic_1.VoidType("SELECT_todo"));
+            }
+        }
+        const intoList = node.findDirectExpression(Expressions.SQLIntoList);
+        if (intoList) {
+            const isDynamic = fields.length === 1 && fields[0].expression.findDirectExpression(Expressions.Dynamic) !== undefined;
+            const targets = intoList.findDirectExpressions(Expressions.SQLTarget);
+            if (targets.length !== fields.length && isDynamic !== true) {
+                throw new Error(`number of fields selected vs list does not match`);
+            }
+            for (let i = 0; i < targets.length; i++) {
+                const target = targets[i];
+                const field = fields[i];
+                const inline = target.findFirstExpression(Expressions.InlineData);
+                if (inline) {
+                    if (isDynamic) {
+                        throw new Error(`dynamic field list, inlining not possible`);
+                    }
+                    if (isSimple.test(field.code) && dbSources.length === 1 && dbSources[0] !== undefined) {
+                        const dbType = dbSources[0].parseType(scope.getRegistry());
+                        let type = new basic_1.VoidType("SELECT_todo");
+                        if (dbType instanceof basic_1.StructureType) {
+                            type = dbType.getComponentByName(field.code);
+                            if (type) {
+                                throw new Error(`handleInto, internal error, should be checked earlier`);
+                            }
+                        }
+                        new inline_data_1.InlineData().runSyntax(inline, scope, filename, type);
+                    }
+                    else {
+                        new inline_data_1.InlineData().runSyntax(inline, scope, filename, new basic_1.VoidType("SELECT_todo"));
+                    }
+                }
+            }
+        }
+    }
     checkFields(fields, dbSources, scope) {
         if (dbSources.length > 1) {
             return;
@@ -84,7 +131,6 @@ class Select {
         if (!(type instanceof basic_1.StructureType)) {
             throw new Error("checkFields, expected structure, " + type.constructor.name);
         }
-        const isSimple = /^\w+$/;
         for (const field of fields) {
             if (field.code === "*") {
                 continue;
@@ -94,21 +140,44 @@ class Select {
             }
         }
     }
-    buildType(_fields) {
+    buildTableType(fields, dbSources, scope) {
+        if (dbSources.length !== 1) {
+            return new basic_1.VoidType("SELECT_todo");
+        }
+        if (dbSources[0] === undefined) {
+            // then its a voided table
+            return new basic_1.VoidType("SELECT_todo");
+        }
+        const dbType = dbSources[0].parseType(scope.getRegistry());
+        if (!(dbType instanceof basic_1.StructureType)) {
+            return new basic_1.VoidType("SELECT_todo");
+        }
+        if (fields.length === 1 && fields[0].code === "*") {
+            return new basic_1.TableType(dbType, { withHeader: false, keyType: basic_1.TableKeyType.default }, undefined);
+        }
+        const allFieldsSimple = fields.every(f => isSimple.test(f.code));
+        if (allFieldsSimple === true) {
+            const components = [];
+            for (const field of fields) {
+                const type = dbType.getComponentByName(field.code);
+                if (type === undefined) {
+                    return new basic_1.VoidType("SELECT_todo");
+                }
+                components.push({ name: field.code, type });
+            }
+            return new basic_1.TableType(new basic_1.StructureType(components), { withHeader: false, keyType: basic_1.TableKeyType.default }, undefined);
+        }
         return new basic_1.VoidType("SELECT_todo");
     }
     findFields(node) {
         var _a;
         let expr = undefined;
         const ret = [];
-        expr = node.findDirectExpression(Expressions.SQLFieldList);
-        if (expr === undefined) {
-            expr = node.findDirectExpression(Expressions.SQLFields);
-        }
+        expr = node.findFirstExpression(Expressions.SQLFieldList);
         if (expr === undefined) {
-            node.findDirectExpression(Expressions.SQLFieldName);
+            expr = node.findDirectExpression(Expressions.SQLFieldListLoop);
         }
-        for (const field of (expr === null || expr === void 0 ? void 0 : expr.findAllExpressions(Expressions.SQLField)) || []) {
+        for (const field of (expr === null || expr === void 0 ? void 0 : expr.findDirectExpressionsMulti([Expressions.SQLField, Expressions.SQLFieldName])) || []) {
             let code = field.concatTokens().toUpperCase();
             const as = ((_a = field.findDirectExpression(Expressions.SQLAsName)) === null || _a === void 0 ? void 0 : _a.concatTokens()) || "";
             if (as !== "") {

package/build/src/abap/nodes/expression_node.js

@@ -153,6 +153,20 @@ class ExpressionNode extends _abstract_node_1.AbstractNode {
         }
         return ret;
     }
+    findDirectExpressionsMulti(type) {
+        const ret = [];
+        for (const child of this.getChildren()) {
+            if (child instanceof ExpressionNode) {
+                for (const t of type) {
+                    if (child.get() instanceof t) {
+                        ret.push(child);
+                        break;
+                    }
+                }
+            }
+        }
+        return ret;
+    }
     findDirectTokenByText(text) {
         for (const child of this.getChildren()) {
             if (child instanceof token_node_1.TokenNode && child.get().getStr().toUpperCase() === text.toUpperCase()) {

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.102.47";
+        return "2.102.49";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/check_subrc.js

@@ -118,6 +118,7 @@ FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
             }
             else if (config.assign === true
                 && statement.get() instanceof Statements.Assign
+                && this.isSimpleAssign(statement) === false
                 && this.isChecked(i, statements) === false) {
                 issues.push(issue_1.Issue.atStatement(file, statement, message, this.getMetadata().key, this.conf.severity));
             }
@@ -131,6 +132,16 @@ FIND statement with MATCH COUNT is considered okay if subrc is not checked`,
         return issues;
     }
     ////////////////
+    isSimpleAssign(statement) {
+        if (statement.getChildren().length === 5) {
+            const source = statement.findDirectExpression(Expressions.AssignSource);
+            if ((source === null || source === void 0 ? void 0 : source.getChildren().length) === 1
+                && source.findDirectExpression(Expressions.Source) !== undefined) {
+                return true;
+            }
+        }
+        return false;
+    }
     isExemptedFind(s) {
         // see https://github.com/abaplint/abaplint/issues/2130
         return s.concatTokens().toUpperCase().includes(" MATCH COUNT ") === true;

package/build/src/rules/many_parentheses.js

@@ -81,7 +81,7 @@ ENDIF.
     }
     ////////////////////
     analyzeInto(file, m) {
-        const into = m.findFirstExpression(Expressions.SQLIntoStructure);
+        const into = m.findFirstExpression(Expressions.SQLIntoList);
         if (into === undefined) {
             return [];
         }

package/build/src/rules/obsolete_statement.js

@@ -209,6 +209,7 @@ ENDIF.`,
             if (this.conf.selectWithoutInto
                 && (sta instanceof Statements.Select || sta instanceof Statements.SelectLoop)
                 && staNode.findFirstExpression(Expressions.SQLIntoStructure) === undefined
+                && staNode.findFirstExpression(Expressions.SQLIntoList) === undefined
                 && staNode.findFirstExpression(Expressions.SQLIntoTable) === undefined) {
                 const concat = (_a = staNode.findFirstExpression(Expressions.SQLFieldList)) === null || _a === void 0 ? void 0 : _a.concatTokens().toUpperCase();
                 if (concat !== "COUNT(*)" && concat !== "COUNT( * )") {

package/build/src/rules/strict_sql.js

@@ -55,6 +55,7 @@ Activates from v750 and up`,
                 const where = expr === null || expr === void 0 ? void 0 : expr.findDirectExpression(Expressions.SQLCond);
                 const order = expr === null || expr === void 0 ? void 0 : expr.findDirectExpression(Expressions.SQLOrderBy);
                 const into = (expr === null || expr === void 0 ? void 0 : expr.findDirectExpression(Expressions.SQLIntoStructure))
+                    || (expr === null || expr === void 0 ? void 0 : expr.findDirectExpression(Expressions.SQLIntoList))
                     || (expr === null || expr === void 0 ? void 0 : expr.findDirectExpression(Expressions.SQLIntoTable));
                 if (into === undefined || where === undefined) {
                     continue;

package/build/src/rules/uncaught_exception.js

@@ -72,7 +72,7 @@ class UncaughtException extends _abap_rule_1.ABAPRule {
         return this.issues;
     }
     traverse(n, file) {
-        var _a;
+        var _a, _b, _c, _d;
         const get = n.get();
         if (get instanceof Structures.ClassDefinition
             || get instanceof Structures.Interface) {
@@ -83,10 +83,16 @@ class UncaughtException extends _abap_rule_1.ABAPRule {
                 // note that TRY-CATCH might be arbitrarily nested
                 const previous = this.sinked ? this.sinked.slice() : undefined;
                 this.addFromTryStructure(n);
-                for (const c of n.getChildren()) {
+                for (const c of ((_a = n.findDirectStructure(Structures.Body)) === null || _a === void 0 ? void 0 : _a.getChildren()) || []) {
                     this.traverse(c, file);
                 }
                 this.sinked = previous;
+                for (const c of ((_b = n.findDirectStructure(Structures.Catch)) === null || _b === void 0 ? void 0 : _b.getChildren()) || []) {
+                    this.traverse(c, file);
+                }
+                for (const c of ((_c = n.findDirectStructure(Structures.Cleanup)) === null || _c === void 0 ? void 0 : _c.getChildren()) || []) {
+                    this.traverse(c, file);
+                }
                 return;
             }
             else {
@@ -116,7 +122,7 @@ class UncaughtException extends _abap_rule_1.ABAPRule {
                 let name = undefined;
                 const concat = n.concatTokens().toUpperCase();
                 if (concat.startsWith("RAISE EXCEPTION TYPE ")) {
-                    name = (_a = n.findFirstExpression(Expressions.ClassName)) === null || _a === void 0 ? void 0 : _a.getFirstToken().getStr().toUpperCase();
+                    name = (_d = n.findFirstExpression(Expressions.ClassName)) === null || _d === void 0 ? void 0 : _d.getFirstToken().getStr().toUpperCase();
                 }
                 this.check(name, n, file);
             }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.102.47",
+    "version": "2.102.49",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -52,9 +52,9 @@
     "devDependencies": {
         "@microsoft/api-extractor": "^7.37.1",
         "@types/chai": "^4.3.6",
-        "@types/mocha": "^10.0.1",
+        "@types/mocha": "^10.0.2",
         "@types/node": "^20.7.0",
-        "chai": "^4.3.8",
+        "chai": "^4.3.9",
         "eslint": "^8.50.0",
         "mocha": "^10.2.0",
         "c8": "^8.0.1",