@abaplint/core 2.102.44 → 2.102.46

package/build/src/abap/5_syntax/_type_utils.js

@@ -305,11 +305,10 @@ class TypeUtils {
             }
         }
         else if (source instanceof basic_1.IntegerType) {
-            if (target instanceof basic_1.StringType
-                || target instanceof basic_1.PackedType) {
+            if (target instanceof basic_1.StringType) {
                 return false;
             }
-            else if (target instanceof basic_1.Integer8Type) {
+            else if (target instanceof basic_1.Integer8Type || target instanceof basic_1.PackedType) {
                 if (((_h = source.getAbstractTypeData()) === null || _h === void 0 ? void 0 : _h.derivedFromConstant) === true) {
                     return true;
                 }

package/build/src/abap/5_syntax/statements/create_data.js

@@ -6,6 +6,9 @@ const target_1 = require("../expressions/target");
 const source_1 = require("../expressions/source");
 const dynamic_1 = require("../expressions/dynamic");
 const basic_types_1 = require("../basic_types");
+const basic_1 = require("../../types/basic");
+const _typed_identifier_1 = require("../../types/_typed_identifier");
+const _reference_1 = require("../_reference");
 class CreateData {
     runSyntax(node, scope, filename) {
         for (const s of node.findDirectExpressions(Expressions.Source)) {
@@ -19,7 +22,23 @@ class CreateData {
         }
         const type = node.findDirectExpression(Expressions.TypeName);
         if (type) {
-            new basic_types_1.BasicTypes(filename, scope).resolveTypeName(type);
+            const found = new basic_types_1.BasicTypes(filename, scope).resolveTypeName(type);
+            if (found instanceof basic_1.UnknownType) {
+                if (node.concatTokens().toUpperCase().includes(" REF TO ")) {
+                    const def = scope.findObjectDefinition(type.concatTokens());
+                    if (def) {
+                        scope.addReference(type.getFirstToken(), def, _reference_1.ReferenceType.TypeReference, filename);
+                    }
+                    else {
+                        const identifier = new _typed_identifier_1.TypedIdentifier(type.getFirstToken(), filename, found);
+                        scope.addReference(type.getFirstToken(), identifier, _reference_1.ReferenceType.TypeReference, filename);
+                    }
+                }
+                else {
+                    const identifier = new _typed_identifier_1.TypedIdentifier(type.getFirstToken(), filename, found);
+                    scope.addReference(type.getFirstToken(), identifier, _reference_1.ReferenceType.TypeReference, filename);
+                }
+            }
         }
     }
 }

package/build/src/registry.js

@@ -65,7 +65,7 @@ class Registry {
     }
     static abaplintVersion() {
         // magic, see build script "version.sh"
-        return "2.102.44";
+        return "2.102.46";
     }
     getDDICReferences() {
         return this.ddicReferences;

package/build/src/rules/definitions_top.js

@@ -4,14 +4,12 @@ exports.DefinitionsTop = exports.DefinitionsTopConf = void 0;
 const issue_1 = require("../issue");
 const _statement_1 = require("../abap/2_statements/statements/_statement");
 const Statements = require("../abap/2_statements/statements");
-const Expressions = require("../abap/2_statements/expressions");
 const Structures = require("../abap/3_structures/structures");
 const _abap_rule_1 = require("./_abap_rule");
 const _basic_rule_config_1 = require("./_basic_rule_config");
 const _irule_1 = require("./_irule");
 const edit_helper_1 = require("../edit_helper");
 const nodes_1 = require("../abap/nodes");
-const version_1 = require("../version");
 class DefinitionsTopConf extends _basic_rule_config_1.BasicRuleConfig {
 }
 exports.DefinitionsTopConf = DefinitionsTopConf;
@@ -30,10 +28,16 @@ class DefinitionsTop extends _abap_rule_1.ABAPRule {
             key: "definitions_top",
             title: "Place definitions in top of routine",
             shortDescription: `Checks that definitions are placed at the beginning of METHODs, FORMs and FUNCTIONs.`,
-            extendedInformation: `If the routine has inline definitions then no issues are reported
-
-https://docs.abapopenchecks.org/checks/17/`,
+            extendedInformation: `https://docs.abapopenchecks.org/checks/17/`,
             tags: [_irule_1.RuleTag.SingleFile, _irule_1.RuleTag.Quickfix],
+            badExample: `FROM foo.
+  WRITE 'hello'.
+  DATA int TYPE i.
+ENDFORM.`,
+            goodExample: `FROM foo.
+  DATA int TYPE i.
+  WRITE 'hello'.
+ENDFORM.`,
         };
     }
     getMessage() {
@@ -62,10 +66,6 @@ https://docs.abapopenchecks.org/checks/17/`,
             this.fixed = false;
             this.mode = DEFINITION;
             this.moveTo = (_a = r.getFirstStatement()) === null || _a === void 0 ? void 0 : _a.getLastToken().getEnd();
-            if (this.reg.getConfig().getVersion() !== version_1.Version.v702
-                && r.findFirstExpression(Expressions.InlineData)) {
-                continue;
-            }
             const found = this.walk(r, file);
             if (found) {
                 issues.push(found);
@@ -126,16 +126,19 @@ https://docs.abapopenchecks.org/checks/17/`,
                 && (get instanceof Statements.Data
                     || get instanceof Statements.Type
                     || get instanceof Statements.Constant
+                    || (get instanceof Statements.Move && c.concatTokens().toUpperCase().startsWith("DATA("))
                     || get instanceof Statements.Static
                     || get instanceof Statements.FieldSymbol)) {
                 if (this.mode === AFTER) {
                     // only one fix per routine, as it reorders a lot
-                    let fix = undefined;
-                    if (this.fixed === false && this.moveTo) {
-                        fix = this.buildFix(file, c, this.moveTo);
-                        this.fixed = true;
+                    if (!(get instanceof Statements.Move && c.concatTokens().toUpperCase().startsWith("DATA("))) {
+                        let fix = undefined;
+                        if (this.fixed === false && this.moveTo) {
+                            fix = this.buildFix(file, c, this.moveTo);
+                            this.fixed = true;
+                        }
+                        return issue_1.Issue.atStatement(file, c, this.getMessage(), this.getMetadata().key, this.conf.severity, fix);
                     }
-                    return issue_1.Issue.atStatement(file, c, this.getMessage(), this.getMetadata().key, this.conf.severity, fix);
                 }
                 else {
                     this.moveTo = c.getLastToken().getEnd();

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@abaplint/core",
-    "version": "2.102.44",
+    "version": "2.102.46",
     "description": "abaplint - Core API",
     "main": "build/src/index.js",
     "typings": "build/abaplint.d.ts",
@@ -53,9 +53,9 @@
         "@microsoft/api-extractor": "^7.37.0",
         "@types/chai": "^4.3.6",
         "@types/mocha": "^10.0.1",
-        "@types/node": "^20.6.2",
+        "@types/node": "^20.6.5",
         "chai": "^4.3.8",
-        "eslint": "^8.49.0",
+        "eslint": "^8.50.0",
         "mocha": "^10.2.0",
         "c8": "^8.0.1",
         "source-map-support": "^0.5.21",
@@ -63,7 +63,7 @@
         "typescript": "^5.2.2"
     },
     "dependencies": {
-        "fast-xml-parser": "^4.2.7",
+        "fast-xml-parser": "^4.3.1",
         "json5": "^2.2.3",
         "vscode-languageserver-types": "^3.17.3"
     }